* handling and use of bulkstats will need to be reflected here as well.
*/
static int
+#if defined(STRUCT_FILE_OPERATIONS_HAS_ITERATE)
+afs_linux_readdir(struct file *fp, struct dir_context *ctx)
+#else
afs_linux_readdir(struct file *fp, void *dirbuf, filldir_t filldir)
+#endif
{
struct vcache *avc = VTOAFS(FILE_INODE(fp));
struct vrequest treq;
* takes an offset in units of blobs, rather than bytes.
*/
code = 0;
+#if defined(STRUCT_FILE_OPERATIONS_HAS_ITERATE)
+ offset = ctx->pos;
+#else
offset = (int) fp->f_pos;
+#endif
while (1) {
dirpos = BlobScan(tdc, offset);
if (!dirpos)
code = afs_dir_GetVerifiedBlob(tdc, dirpos, &entry);
if (code) {
- afs_warn("Corrupt directory (inode %lx, dirpos %d)",
- (unsigned long)&tdc->f.inode, dirpos);
- ReleaseSharedLock(&avc->lock);
- afs_PutDCache(tdc);
+ if (!(avc->f.states & CCorrupt)) {
+ struct cell *tc = afs_GetCellStale(avc->f.fid.Cell, READ_LOCK);
+ afs_warn("Corrupt directory (%d.%d.%d.%d [%s] @%lx, pos %d)",
+ avc->f.fid.Cell, avc->f.fid.Fid.Volume,
+ avc->f.fid.Fid.Vnode, avc->f.fid.Fid.Unique,
+ tc ? tc->cellName : "",
+ (unsigned long)&tdc->f.inode, dirpos);
+ if (tc)
+ afs_PutCell(tc, READ_LOCK);
+ UpgradeSToWLock(&avc->lock, 814);
+ avc->f.states |= CCorrupt;
+ }
code = -ENOENT;
- goto out;
+ goto unlock_out;
}
de = (struct DirEntry *)entry.data;
* holding the GLOCK.
*/
AFS_GUNLOCK();
+#if defined(STRUCT_FILE_OPERATIONS_HAS_ITERATE)
+ /* dir_emit returns a bool - true when it succeeds.
+ * Inverse the result to fit with how we check "code" */
+ code = !dir_emit(ctx, de->name, len, ino, type);
+#else
code = (*filldir) (dirbuf, de->name, len, offset, ino, type);
+#endif
AFS_GLOCK();
}
DRelease(&entry, 0);
/* If filldir didn't fill in the last one this is still pointing to that
* last attempt.
*/
- fp->f_pos = (loff_t) offset;
+ code = 0;
+unlock_out:
+#if defined(STRUCT_FILE_OPERATIONS_HAS_ITERATE)
+ ctx->pos = (loff_t) offset;
+#else
+ fp->f_pos = (loff_t) offset;
+#endif
ReleaseReadLock(&tdc->lock);
afs_PutDCache(tdc);
UpgradeSToWLock(&avc->lock, 813);
avc->dcreaddir = 0;
avc->readdir_pid = 0;
ReleaseSharedLock(&avc->lock);
- code = 0;
out:
afs_PutFakeStat(&fakestat);
struct file_operations afs_dir_fops = {
.read = generic_read_dir,
+#if defined(STRUCT_FILE_OPERATIONS_HAS_ITERATE)
+ .iterate = afs_linux_readdir,
+#else
.readdir = afs_linux_readdir,
+#endif
#ifdef HAVE_UNLOCKED_IOCTL
.unlocked_ioctl = afs_unlocked_xioctl,
#else
#ifdef HAVE_LINUX_GENERIC_FILE_AIO_READ
.aio_read = afs_linux_aio_read,
.aio_write = afs_linux_aio_write,
+ .read = do_sync_read,
+ .write = do_sync_write,
#else
.read = afs_linux_read,
.write = afs_linux_write,
if (iattrp->ia_valid & ATTR_MODE)
vattrp->va_mode = iattrp->ia_mode;
if (iattrp->ia_valid & ATTR_UID)
- vattrp->va_uid = iattrp->ia_uid;
+ vattrp->va_uid = afs_from_kuid(iattrp->ia_uid);
if (iattrp->ia_valid & ATTR_GID)
- vattrp->va_gid = iattrp->ia_gid;
+ vattrp->va_gid = afs_from_kgid(iattrp->ia_gid);
if (iattrp->ia_valid & ATTR_SIZE)
vattrp->va_size = iattrp->ia_size;
if (iattrp->ia_valid & ATTR_ATIME) {
#endif
ip->i_rdev = vp->va_rdev;
ip->i_mode = vp->va_mode;
- ip->i_uid = vp->va_uid;
- ip->i_gid = vp->va_gid;
+ ip->i_uid = afs_make_kuid(vp->va_uid);
+ ip->i_gid = afs_make_kgid(vp->va_gid);
i_size_write(ip, vp->va_size);
ip->i_atime.tv_sec = vp->va_atime.tv_sec;
ip->i_atime.tv_nsec = 0;
return err;
}
+static afs_uint32
+parent_vcache_dv(struct inode *inode, cred_t *credp)
+{
+ int free_cred = 0;
+ struct vcache *pvcp;
+
+ /*
+ * If parent is a mount point and we are using fakestat, we may need
+ * to look at the fake vcache entry instead of what the vfs is giving
+ * us. The fake entry is the one with the useful DataVersion.
+ */
+ pvcp = VTOAFS(inode);
+ if (pvcp->mvstat == 1 && afs_fakestat_enable) {
+ struct vrequest treq;
+ struct afs_fakestat_state fakestate;
+
+ if (!credp) {
+ credp = crref();
+ free_cred = 1;
+ }
+ afs_InitReq(&treq, credp);
+ afs_InitFakeStat(&fakestate);
+ afs_TryEvalFakeStat(&pvcp, &fakestate, &treq);
+ if (free_cred)
+ crfree(credp);
+ afs_PutFakeStat(&fakestate);
+ }
+ return hgetlo(pvcp->f.m.DataVersion);
+}
+
/* Validate a dentry. Return 1 if unchanged, 0 if VFS layer should re-evaluate.
* In kernels 2.2.10 and above, we are passed an additional flags var which
* may have either the LOOKUP_FOLLOW OR LOOKUP_DIRECTORY set in which case
int valid;
struct afs_fakestat_state fakestate;
int locked = 0;
+ int force_drop = 0;
+ afs_uint32 parent_dv;
#ifdef LOOKUP_RCU
/* We don't support RCU path walking */
parent = dget_parent(dp);
pvcp = VTOAFS(parent->d_inode);
- if ((vcp->mvstat == 1) || (vcp->mvstat == 2)) { /* need to lock */
+ if ((vcp->mvstat == 1) || (vcp->mvstat == 2) ||
+ (pvcp->mvstat == 1 && afs_fakestat_enable)) { /* need to lock */
credp = crref();
AFS_GLOCK();
locked = 1;
}
#endif
+ parent_dv = parent_vcache_dv(parent->d_inode, credp);
/* If the parent's DataVersion has changed or the vnode
* is longer valid, we need to do a full lookup. VerifyVCache
* isn't enough since the vnode may have been renamed.
*/
- if ((!locked) && (hgetlo(pvcp->f.m.DataVersion) > dp->d_time || !(vcp->f.states & CStatd)) ) {
+ if ((!locked) && (parent_dv > dp->d_time || !(vcp->f.states & CStatd)) ) {
credp = crref();
AFS_GLOCK();
locked = 1;
}
- if (locked && (hgetlo(pvcp->f.m.DataVersion) > dp->d_time || !(vcp->f.states & CStatd))) {
- afs_lookup(pvcp, (char *)dp->d_name.name, &tvc, credp);
+ if (locked && (parent_dv > dp->d_time || !(vcp->f.states & CStatd))) {
+ int code;
+
+ code = afs_lookup(pvcp, (char *)dp->d_name.name, &tvc, credp);
if (!tvc || tvc != vcp) {
dput(parent);
+ /* Force unhash if name is known not to exist. */
+ if (code == ENOENT)
+ force_drop = 1;
goto bad_dentry;
}
}
vattr2inode(AFSTOV(vcp), &vattr);
- dp->d_time = hgetlo(pvcp->f.m.DataVersion);
+ dp->d_time = parent_dv;
}
/* should we always update the attributes at this point? */
crfree(credp);
if (!valid) {
- shrink_dcache_parent(dp);
- d_drop(dp);
+ /*
+ * If we had a negative lookup for the name we want to forcibly
+ * unhash the dentry.
+ * Otherwise use d_invalidate which will not unhash it if still in use.
+ */
+ if (force_drop) {
+ shrink_dcache_parent(dp);
+ d_drop(dp);
+ } else
+ d_invalidate(dp);
}
+
return valid;
bad_dentry:
#if !defined(STRUCT_SUPER_BLOCK_HAS_S_D_OP)
dp->d_op = &afs_dentry_operations;
#endif
- dp->d_time = hgetlo(VTOAFS(dip)->f.m.DataVersion);
+ dp->d_time = parent_vcache_dv(dip, credp);
d_instantiate(dp, ip);
}
AFS_GUNLOCK();
#if !defined(STRUCT_SUPER_BLOCK_HAS_S_D_OP)
dp->d_op = &afs_dentry_operations;
#endif
- dp->d_time = hgetlo(VTOAFS(dip)->f.m.DataVersion);
+ dp->d_time = parent_vcache_dv(dip, credp);
+
AFS_GUNLOCK();
if (ip && S_ISDIR(ip->i_mode)) {
VATTR_NULL(&vattr);
AFS_GLOCK();
- code = afs_symlink(VTOAFS(dip), (char *)name, &vattr, (char *)target, credp);
+ code = afs_symlink(VTOAFS(dip), (char *)name, &vattr, (char *)target, NULL,
+ credp);
AFS_GUNLOCK();
crfree(credp);
return afs_convert_code(code);
rehash = newdp;
}
-#if defined(D_COUNT_INT)
- spin_lock(&olddp->d_lock);
- if (olddp->d_count > 1) {
- spin_unlock(&olddp->d_lock);
- shrink_dcache_parent(olddp);
- } else
- spin_unlock(&olddp->d_lock);
-#else
- if (atomic_read(&olddp->d_count) > 1)
- shrink_dcache_parent(olddp);
-#endif
+ afs_maybe_shrink_dcache(olddp);
AFS_GLOCK();
code = afs_rename(VTOAFS(oldip), (char *)oldname, VTOAFS(newip), (char *)newname, credp);
ObtainReadLock(&tdc->lock);
if (!hsame(avc->f.m.DataVersion, tdc->f.versionNo) ||
(tdc->dflags & DFFetching)) {
- goto out;
ReleaseReadLock(&tdc->lock);
afs_PutDCache(tdc);
tdc = NULL;
git://git.openafs.org / openafs.git / blobdiff