* output of this program to be valid.
*/
-#include <sys/types.h>
-#include <sys/time.h>
-#include <stdio.h>
-#include <ctype.h>
-#include <string.h>
-#include <errno.h>
-#include <sys/file.h>
-
#include <afsconfig.h>
#include <afs/param.h>
-#include <afs/com_err.h>
-RCSID
- ("$Header$");
+#include <roken.h>
+
+#ifndef _WIN32
+#include <sys/file.h>
+#else
+#define L_SET SEEK_SET
+#endif
+#include <ctype.h>
+#include <afs/com_err.h>
#include <afs/cmd.h> /*Command line parsing */
#include <afs/afsutil.h>
-#include <errno.h>
#include <lock.h>
-#include <netinet/in.h>
#define UBIK_INTERNALS
#include <ubik.h>
#include <rx/xdr.h>
#include <rx/rx.h>
-#include <afs/com_err.h>
+
#include "ptint.h"
#include "ptserver.h"
#include "pterror.h"
+#include "ptprototypes.h"
#define IDHash(x) (abs(x) % HASHSIZE)
#define print_id(x) ( ((flags&DO_SYS)==0 && (x<-32767 || x>97536)) || \
extern char *optarg;
extern int optind;
+extern int pr_noAuth;
+
int restricted = 0;
-int display_entry();
-void add_group();
-void display_groups();
-void display_group();
-void fix_pre();
-char *checkin();
-char *check_core();
-char *id_to_name();
-int CommandProc(struct cmd_syndesc *, void *);
+
+static int display_entry(int);
+static void add_group(long);
+static void display_groups(void);
+static void display_group(int);
+static void fix_pre(struct prentry *);
+static char *id_to_name(int);
+static char *checkin(struct prentry *);
+static char *check_core(int);
+static int CommandProc(struct cmd_syndesc *, void *);
struct hash_entry {
char h_name[PR_MAXNAMELEN];
main(int argc, char **argv)
{
- register struct cmd_syndesc *cs; /*Command line syntax descriptor */
- register afs_int32 code; /*Return code */
+ struct cmd_syndesc *cs; /*Command line syntax descriptor */
+ afs_int32 code; /*Return code */
cs = cmd_CreateSyntax(NULL, CommandProc, NULL,
"access protection database");
}
-int
-CommandProc(register struct cmd_syndesc *a_as, void *arock)
+static int
+CommandProc(struct cmd_syndesc *a_as, void *arock)
{
- register int i;
+ int i;
long code = 0;
- long cc, upos;
+ long upos;
long gpos = 0;
struct prentry uentry, gentry;
struct ubik_hdr *uh;
char *dfile = 0;
- char *pbase = AFSDIR_SERVER_PRDB_FILEPATH;
+ const char *pbase = AFSDIR_SERVER_PRDB_FILEPATH;
char *pfile = NULL;
char pbuffer[1028];
struct cmd_parmdesc *tparm;
if (tparm[0].items) {
wflag++;
+ /* so we are treated as admin and can create "mis"owned
+ groups */
+ pr_noAuth = 1;
}
if (tparm[1].items) {
flags |= DO_USR;
}
if (pfile == NULL) {
- afs_snprintf(pbuffer, sizeof(pbuffer), "%s.DB0", pbase);
+ snprintf(pbuffer, sizeof(pbuffer), "%s.DB0", pbase);
pfile = pbuffer;
}
if ((dbase_fd = open(pfile, (wflag ? O_RDWR : O_RDONLY) | O_CREAT, 0600))
if (wflag) {
struct usr_list *u;
+ int seenGroup = 0, id = 0, flags = 0;
while (fgets(buffer, sizeof(buffer), dfp)) {
- int id, oid, cid, flags, quota, uid;
+ int oid, cid, quota, uid;
char name[PR_MAXNAMELEN], mem[PR_MAXNAMELEN];
if (isspace(*buffer)) {
- sscanf(buffer, "%s %d", mem, &uid);
+ code = sscanf(buffer, "%s %d", mem, &uid);
+ if (code != 2) {
+ fprintf(stderr,
+ "Insuffient data provided for group membership\n");
+ exit(1);
+ }
+
+ if (!seenGroup) {
+ fprintf(stderr,
+ "Group member %s listed outside of group\n",
+ mem);
+ exit(1);
+ }
for (u = usr_head; u; u = u->next)
if (u->uid && u->uid == uid)
fprintf(stderr, "Error while adding %s to %s: %s\n", mem,
name, afs_error_message(code));
} else {
- sscanf(buffer, "%s %d/%d %d %d %d", name, &flags, "a, &id,
- &oid, &cid);
+ code = sscanf(buffer, "%s %d/%d %d %d %d", name, &flags, "a, &id,
+ &oid, &cid);
+ if (code != 6) {
+ fprintf(stderr,
+ "Insufficient data provided for user/group\n");
+ exit(1);
+ }
+
+ seenGroup = 1;
if (FindByID(0, id))
code = PRIDEXIST;
code = CreateEntry(0, name, &id, 1 /*idflag */ ,
flags & PRGRP, oid, cid);
if (code == PRBADNAM) {
- u = (struct usr_list *)malloc(sizeof(struct usr_list));
+ u = malloc(sizeof(struct usr_list));
u->next = usr_head;
u->uid = id;
strcpy(u->name, name);
long newpos;
newpos = display_entry(upos);
if (newpos == upos) {
- fprintf(stderr, "pt_util: hash error in %s chain %d\n",
+ fprintf(stderr, "pt_util: hash error in %s chain %d\n",
nflag ? "name":"id", i);
exit(1);
} else
exit(0);
}
-int
+static int
display_entry(int offset)
{
- register int i;
-
lseek(dbase_fd, offset + HDRSIZE, L_SET);
read(dbase_fd, &pre, sizeof(struct prentry));
return (nflag ? pre.nextName : pre.nextID);
}
-void
+static void
add_group(long id)
{
struct grp_list *g;
- register long i;
+ long i;
i = grp_count++ % 1024;
if (i == 0) {
- g = (struct grp_list *)malloc(sizeof(struct grp_list));
+ g = malloc(sizeof(struct grp_list));
g->next = grp_head;
grp_head = g;
}
g->groups[i] = id;
}
-void
-display_groups()
+static void
+display_groups(void)
{
- register int i, id;
+ int i, id;
struct grp_list *g;
g = grp_head;
}
}
-void
+static void
display_group(int id)
{
- register int i, offset;
+ int i, offset;
int print_grp = 0;
offset = ntohl(prh.idHash[IDHash(id)]);
}
}
-void
+static void
fix_pre(struct prentry *pre)
{
- register int i;
+ int i;
pre->flags = ntohl(pre->flags);
pre->id = ntohl(pre->id);
}
}
-char *
+static char *
id_to_name(int id)
{
- register int offset;
+ int offset;
static struct prentry pre;
char *name;
return 0;
}
-char *
+static char *
checkin(struct prentry *pre)
{
struct hash_entry *he, *last;
- register int id;
+ int id;
id = pre->id;
last = (struct hash_entry *)0;
last = he;
he = he->next;
}
- he = (struct hash_entry *)malloc(sizeof(struct hash_entry));
+ he = malloc(sizeof(struct hash_entry));
if (he == 0) {
fprintf(stderr, "pt_util: No Memory for internal hash table.\n");
exit(1);
return (he->h_name);
}
-char *
-check_core(register int id)
+static char *
+check_core(int id)
{
struct hash_entry *he;
he = hat[IDHash(id)];
git://git.openafs.org / openafs.git / blobdiff