} while (0)
int rxInitDone = 0;
-struct rx_connection *tconn;
-afs_uint32 tserver;
extern struct ubik_client *cstruct;
const char *confdir;
VolumeStats_int(volintInfo *pntr, struct nvldbentry *entry, afs_uint32 server,
afs_int32 part, int voltype)
{
- int totalOK, totalNotOK, totalBusy;
+ int totalOK = 0;
+ int totalNotOK = 0;
+ int totalBusy = 0;
DisplayFormat(pntr, server, part, &totalOK, &totalNotOK, &totalBusy, 0, 1,
1);
transflag = (as->parms[4].items ? ITBusy : ITOffline);
sleeptime = (as->parms[3].items ? atol(as->parms[3].items->data) : 0);
- transdone = (sleeptime ? 0 /*online */ : VTOutOfService);
+ transdone = ((sleeptime || as->parms[4].items) ? 0 /*online */ : VTOutOfService);
if (as->parms[4].items && !as->parms[3].items) {
fprintf(STDERR, "-sleep option must be used with -busy flag\n");
return -1;
struct nvldbentry entry;
afs_int32 vcode;
afs_int32 quota;
+ afs_uint32 tserver;
arovolid = &rovolid;
flags = 0;
if (as->parms[5].items) flags |= RV_OFFLINE;
+ if (as->parms[6].items && as->parms[7].items) {
+ fprintf(STDERR, "vos: cannot specify that a volume be -readwrite and -readonly\n");
+ return EINVAL;
+ }
if (as->parms[6].items) flags |= RV_RDONLY;
+ if (as->parms[7].items) flags |= RV_RWONLY;
code =
afs_uint32 aserver;
afs_int32 apart, vtype, code, err;
int force = 0;
+ int stayUp = 0;
if (as->parms[1].items)
force = 1;
+ if (as->parms[2].items)
+ stayUp = 1;
avolid = vsu_GetVolumeID(as->parms[0].items->data, cstruct, &err);
if (avolid == 0) {
if (err)
return E2BIG;
}
- code = UV_ReleaseVolume(avolid, aserver, apart, force);
+ code = UV_ReleaseVolume(avolid, aserver, apart, force, stayUp);
+
if (code) {
PrintDiagnostics("release", code);
return code;
if (rxConn == 0)
break;
rx_SetConnDeadTime(rxConn, rx_connDeadTime);
- if (rxConn->service)
- rxConn->service->connDeadTime = rx_connDeadTime;
+ if (rx_ServiceOf(rxConn))
+ rx_ServiceOf(rxConn)->connDeadTime = rx_connDeadTime;
}
avolid = vsu_GetVolumeID(as->parms[0].items->data, cstruct, &err);
}
code = UV_ChangeLocation(aserver, apart, avolid);
if (code) {
- PrintDiagnostics("addsite", code);
+ PrintDiagnostics("changeloc", code);
exit(1);
}
MapPartIdIntoName(apart, apartName);
&pntr, &count);
if (code) {
PrintDiagnostics("listvol", code);
- if (pntr)
- free(pntr);
exit(1);
}
if (wantExtendedInfo) {
char part[10];
int flags = 0;
char *volname = 0;
+ afs_uint32 tserver;
tserver = 0;
if (as->parms[0].items) {
{
afs_int32 pnum, code; /* part name */
char part[10];
+ afs_uint32 tserver;
int flags = 0;
avolid = vllist->volumeId[RWVOL];
vcode = ubik_VL_DeleteEntry(cstruct, 0, avolid, RWVOL);
if (vcode) {
- fprintf(STDOUT, "Could not delete VDLB entry for %s\n",
+ fprintf(STDOUT, "Could not delete VLDB entry for %s\n",
vllist->name);
totalFail++;
PrintError("", vcode);
} else {
/* Grow the tarray to keep the extra entries */
parraysize = (centries * sizeof(struct nvldbentry));
- ttarray =
- (struct nvldbentry *)realloc(tarray,
- tarraysize + parraysize);
+ ttarray = realloc(tarray, tarraysize + parraysize);
if (!ttarray) {
fprintf(STDERR,
"Could not allocate enough space for the VLDB entries\n");
afsUUID m_uuid, askuuid;
afs_int32 m_nentries;
- memset(&m_attrs, 0, sizeof(struct ListAddrByAttributes));
- m_attrs.Mask = VLADDR_INDEX;
+ if (as->parms[0].items && as->parms[1].items) {
+ fprintf(STDERR, "vos: Can't use the -uuid and -host flags together\n");
+ exit(-1);
+ }
+ memset(&m_attrs, 0, sizeof(struct ListAddrByAttributes));
memset(&askuuid, 0, sizeof(afsUUID));
if (as->parms[0].items) {
/* -uuid */
}
m_attrs.Mask = VLADDR_UUID;
m_attrs.uuid = askuuid;
- }
- if (as->parms[1].items) {
+ } else if (as->parms[1].items) {
/* -host */
struct hostent *he;
afs_uint32 saddr;
memcpy(&saddr, he->h_addr, 4);
m_attrs.Mask = VLADDR_IPADDR;
m_attrs.ipaddr = ntohl(saddr);
+ } else {
+ /* by index */
+ m_attrs.Mask = VLADDR_INDEX;
}
+
if (as->parms[2].items) {
printuuid = 1;
}
goto out;
}
- m_nentries = 0;
- i = 1;
- while (1) {
- m_attrs.index = i;
-
- xdr_free((xdrproc_t)xdr_bulkaddrs, &m_addrs); /* reset addr list */
- vcode =
- ubik_VL_GetAddrsU(cstruct, UBIK_CALL_NEW, &m_attrs, &m_uuid,
- &m_uniq, &m_nentries, &m_addrs);
-
- if (vcode == VL_NOENT) {
- if (m_attrs.Mask == VLADDR_UUID) {
- fprintf(STDERR, "vos: no entry for UUID '%s' found in VLDB\n",
- as->parms[0].items->data);
- exit(-1);
- } else if (m_attrs.Mask == VLADDR_IPADDR) {
- fprintf(STDERR, "vos: no entry for host '%s' [0x%08x] found in VLDB\n",
- as->parms[1].items->data, m_attrs.ipaddr);
- exit(-1);
- } else {
- i++;
- nentries++;
- continue;
- }
- }
-
- if (vcode == VL_INDEXERANGE) {
- vcode = 0; /* not an error, just means we're done */
- goto out;
- }
-
- if (vcode) {
- fprintf(STDERR, "vos: could not list the server addresses\n");
- PrintError("", vcode);
- goto out;
- }
-
- print_addrs(&m_addrs, &m_uuid, m_nentries, printuuid);
- i++;
+ for (i = 1, m_nentries = 0; nentries; i++) {
+ m_attrs.index = i;
+
+ xdr_free((xdrproc_t)xdr_bulkaddrs, &m_addrs); /* reset addr list */
+ vcode =
+ ubik_VL_GetAddrsU(cstruct, UBIK_CALL_NEW, &m_attrs, &m_uuid,
+ &m_uniq, &m_nentries, &m_addrs);
+ switch (vcode) {
+ case 0: /* success */
+ print_addrs(&m_addrs, &m_uuid, m_nentries, printuuid);
+ nentries--;
+ break;
+
+ case VL_NOENT:
+ if (m_attrs.Mask == VLADDR_UUID) {
+ fprintf(STDERR, "vos: no entry for UUID '%s' found in VLDB\n",
+ as->parms[0].items->data);
+ exit(-1);
+ } else if (m_attrs.Mask == VLADDR_IPADDR) {
+ fprintf(STDERR, "vos: no entry for host '%s' [0x%08x] found in VLDB\n",
+ as->parms[1].items->data, m_attrs.ipaddr);
+ exit(-1);
+ }
+ continue;
+
+ case VL_INDEXERANGE:
+ vcode = 0; /* not an error, just means we're done */
+ goto out;
+
+ default: /* any other error */
+ fprintf(STDERR, "vos: could not list the server addresses\n");
+ PrintError("", vcode);
+ goto out;
+ }
- if ((as->parms[1].items) || (as->parms[0].items) || (i > nentries))
- goto out;
+ /* if -uuid or -host, only list one response */
+ if (as->parms[1].items || as->parms[0].items)
+ break;
}
out:
if (vcode) {
if (vcode == VL_MULTIPADDR) {
fprintf(STDERR, "vos: VL_RegisterAddrs rpc failed; The IP address exists on a different server; repair it\n");
- PrintError("", vcode);
- return vcode;
} else if (vcode == RXGEN_OPCODE) {
fprintf(STDERR, "vlserver doesn't support VL_RegisterAddrs rpc; ignored\n");
- PrintError("", vcode);
- return vcode;
+ } else {
+ fprintf(STDERR, "vos: VL_RegisterAddrs rpc failed\n");
}
+ PrintError("", vcode);
+ return vcode;
}
if (verbose) {
fprintf(STDOUT, "vos: Changed UUID with addresses:\n");
PrintError("", code);
else
fprintf(STDERR, "Unknown volume ID or name '%s'\n",
- as->parms[0].items->data);
+ as->parms[2].items->data);
return -1;
}
if (as->parms[3].items)
fprintf(STDERR,
"Could not fetch the entry for volume %lu from VLDB\n",
(unsigned long)volid);
- PrintError("convertROtoRW", code);
+ PrintError("convertROtoRW ", vcode);
return vcode;
}
rwindex = i;
rwserver = entry.serverNumber[i];
rwpartition = entry.serverPartition[i];
- }
- if (entry.serverFlags[i] & ITSROVOL) {
+ if (roserver)
+ break;
+ } else if ((entry.serverFlags[i] & ITSROVOL) && !roserver) {
same = VLDB_IsSameAddrs(server, entry.serverNumber[i], &code);
if (code) {
fprintf(STDERR,
roindex = i;
roserver = entry.serverNumber[i];
ropartition = entry.serverPartition[i];
- break;
+ if (rwserver)
+ break;
}
}
}
vcode =
ubik_VL_SetLock(cstruct, 0, entry.volumeId[RWVOL], RWVOL,
VLOP_MOVE);
+ if (vcode) {
+ fprintf(STDERR,
+ "Unable to lock volume %lu, code %d\n",
+ (unsigned long)entry.volumeId[RWVOL],vcode);
+ PrintError("", vcode);
+ return -1;
+ }
aconn = UV_Bind(server, AFSCONF_VOLUMEPORT);
code = AFSVolConvertROtoRWvolume(aconn, partition, volid);
if (code) {
"Converting RO volume %lu to RW volume failed with code %d\n",
(unsigned long)volid, code);
PrintError("convertROtoRW ", code);
- return -1;
+ goto error_exit;
}
entry.serverFlags[roindex] = ITSRWVOL;
entry.flags |= RW_EXISTS;
"Warning: volume converted, but vldb update failed with code %d!\n",
code);
}
+
+ error_exit:
vcode = UV_LockRelease(entry.volumeId[RWVOL]);
if (vcode) {
- PrintDiagnostics("unlock", vcode);
+ fprintf(STDERR,
+ "Unable to unlock volume %lu, code %d\n",
+ (unsigned long)entry.volumeId[RWVOL],vcode);
+ PrintError("", vcode);
}
return code;
}
if (rxConn == 0)
break;
rx_SetConnDeadTime(rxConn, rx_connDeadTime);
- if (rxConn->service)
- rxConn->service->connDeadTime = rx_connDeadTime;
+ if (rx_ServiceOf(rxConn))
+ rx_ServiceOf(rxConn)->connDeadTime = rx_connDeadTime;
}
avolid = vsu_GetVolumeID(as->parms[0].items->data, cstruct, &err);
{
char *tcell;
afs_int32 code;
- afs_int32 sauth;
+ int secFlags;
/* Initialize the ubik_client connection */
rx_SetRxDeadTime(90);
- cstruct = (struct ubik_client *)0;
+ cstruct = NULL;
+ secFlags = AFSCONF_SECOPTS_FALLBACK_NULL;
- sauth = 0;
tcell = NULL;
if (as->parms[12].items) /* if -cell specified */
tcell = as->parms[12].items->data;
- if (as->parms[14].items) /* -serverauth specified */
- sauth = 1;
+
+ if (as->parms[13].items)
+ secFlags |= AFSCONF_SECOPTS_NOAUTH;
+
+ if (as->parms[14].items) { /* -localauth specified */
+ secFlags |= AFSCONF_SECOPTS_LOCALAUTH;
+ confdir = AFSDIR_SERVER_ETC_DIRPATH;
+ }
+
if (as->parms[16].items /* -encrypt specified */
#ifdef AFS_NT40_ENV
|| win32_enableCrypt()
#endif /* AFS_NT40_ENV */
)
- vsu_SetCrypt(1);
+ secFlags |= AFSCONF_SECOPTS_ALWAYSENCRYPT;
if (as->parms[18].items) /* -config flag set */
confdir = as->parms[18].items->data;
- if ((code =
- vsu_ClientInit((as->parms[13].items != 0), confdir, tcell, sauth,
- &cstruct, UV_SetSecurity))) {
+ if ((code = vsu_ClientInit(confdir, tcell, secFlags, UV_SetSecurity,
+ &cstruct))) {
fprintf(STDERR, "could not initialize VLDB library (code=%lu) \n",
(unsigned long)code);
exit(1);
"leave clone volume offline");
cmd_AddParm(ts, "-readonly", CMD_FLAG, CMD_OPTIONAL,
"make clone volume read-only, not readwrite");
+ cmd_AddParm(ts, "-readwrite", CMD_FLAG, CMD_OPTIONAL,
+ "make clone volume readwrite, not read-only");
COMMONPARMS;
ts = cmd_CreateSyntax("release", ReleaseVolume, NULL, "release a volume");
cmd_AddParm(ts, "-id", CMD_SINGLE, 0, "volume name or ID");
cmd_AddParm(ts, "-force", CMD_FLAG, CMD_OPTIONAL,
"force a complete release");
+ cmd_AddParm(ts, "-stayonline", CMD_FLAG, CMD_OPTIONAL,
+ "release to cloned temp vol, then clone back to repsite RO");
COMMONPARMS;
ts = cmd_CreateSyntax("dump", DumpVolumeCmd, NULL, "dump a volume");