X-Git-Url: http://git.openafs.org/?p=openafs.git;a=blobdiff_plain;f=CODING;h=fe64431579f40e8b34b758fb26d91d85e68acfd9;hp=b1e12c764c5fa03da16d41d580e614a826103510;hb=00aa9200be86b187c903503e56b2af55639ea2b8;hpb=18511623f2e2bb33e3ebe9f768afed52fd53f9ce

diff --git a/CODING b/CODING
index b1e12c7..fe64431 100644
--- a/CODING
+++ b/CODING
@@ -83,7 +83,39 @@ Suggested compiler flags:
 		(You might not want the -fd, it isn't really useful, just complains about the
 		K&R style functions, but -v gives useful info.)
 
-
+Multiple line comment blocks should begin with only /* on one line and end with
+only */ on one line.
+
+Example:
+
+	/*
+	 * Multiple line comment blocks should be formatted
+	 * like this example.
+	 */
+
+Do not use braces on one-line if and loop statements.
+
+Use:
+
+	if (some_condition)
+	    do_some_action();
+	else
+	    do_something_else();
+
+	while (some_condition)
+	    do_something();
+
+Instead of:
+
+	if (some_condition) {
+	    do_some_action();
+	}
+
+	while (some_condition) {
+	    do_something();
+	}
+
+
 Dependencies required to build OpenAFS from source
 --------------------------------------------------
 The following packages are required to build all of the OpenAFS code
@@ -200,10 +232,11 @@ to reduce the number of warnings in the OpenAFS tree. In an attempt to
 prevent warnings from creeping back in, we now have the ability to break the
 build when new warnings appear.
 
-This is only available for systems with gcc 4.2 or later, and is disabled
-unless the --enable-checking option is supplied to configure. Because we
-can't remove all of the warnings, we permit file by file (and warning by
-warning) disabling of specific warnings. The --enable-checking=all prevents
+This is only available for systems with gcc 4.2 or later or clang 3.2 or
+later, and is disabled unless the --enable-checking option is supplied to
+configure. Because we can't remove all of the warnings, we permit file by
+file (and warning by warning) disabling of specific warnings. The
+--enable-checking=all option prevents
 this, and errors for any file containing a warning.
 
 Disabling warnings
@@ -255,13 +288,12 @@ bucoord/commands.c   : all	     : Ubik_Call
 				     : signed vs unsigned for dates
 butc/tcudbprocs.c    : all	     : ubik_Call
 external/heimdal/hcrypto/validate.c: all: statement with empty body
-kauth/admin_tools.c  : all           : signed vs unsigned for dates
+kauth/admin_tools.c  : strict-proto  : ubik_Call
 kauth/authclient.c   : strict-proto  : ubik_Call nonsense
-libadmin/kas/afs_kasAdmin.c: all     : Ubik_Call nonsense
+libadmin/kas/afs_kasAdmin.c: strict-proto : ubik_Call nonsense
 libadmin/samples/rxstat_query_peer.c : all : util_RPCStatsStateGet types
 libadmin/samples/rxstat_query_process.c : all : util_RPCStatsStateGet types
 libadmin/test/client.c : all         : util_RPCStatsStateGet types
-rxkad/ticket5.c	     : all	     : v5gen.c has set-but-unused variables
 ubik/ubikclient.c    : strict-protos : ubik_Call
 volser/vol-dump.c    : format        : afs_sfsize_t