Do not assume non-valid addrs in addr hash table
authorAndrew Deason <adeason@sinenomine.net>
Tue, 15 Jun 2010 17:19:25 +0000 (12:19 -0500)
committerDerrick Brashear <shadow@dementia.org>
Wed, 16 Jun 2010 02:50:30 +0000 (19:50 -0700)
commit10ada52c26ac3aa13112a91ad201dd3203bb70f8
tree06f5580eb1269fff53f7a108898a0408de10ed55
parent4481a22dc7fa48c7a057f27828da44ab0b4dbf26
Do not assume non-valid addrs in addr hash table

As part of host state verification, we were calling
h_stateVerifyAddrHash to verify that all addresses for a host were in
the address hash table. The problem with this is that interface
addresses that are not marked as 'valid' are intentionally not in the
addr hash table. So, any time there was a non-'valid' interface
address in the host state, we stood a very good chance to fail to
verify the state.

Instead, if we have a non-'valid' address, try to verify that it is
_not_ in the addr hash table (or at least, is not pointing at the host
with the non-'valid' interface addr), since they're not supposed to be
in there.

Change-Id: I02fb0f516fa3ef384471d19bb1b970cfd8aff874
Reviewed-on: http://gerrit.openafs.org/2205
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
src/viced/host.c