Linux: Fix AFS_NORETURN violation with osi_AssertFailK
authorAnders Kaseorg <andersk@mit.edu>
Sat, 6 Nov 2010 07:03:19 +0000 (03:03 -0400)
committerDerrick Brashear <shadow@dementia.org>
Mon, 13 Dec 2010 23:53:01 +0000 (15:53 -0800)
commit1519144f83925d82117f31ce0872f77660f197ee
tree49e985141d08a30bb8c7c23a5b33af63b11bbd67
parentacfc61eca83ecc895e51ae512c1919e7997a560e
Linux: Fix AFS_NORETURN violation with osi_AssertFailK

Commit d86f0c44d3c5910a6b54895484dc0286eac9bc73 changed the
AFS_LINUX26_ENV implementation of osi_AssertFailK so that it returns,
contradicting its AFS_NORETURN prototype, in an effort to make the
following BUG() display the right line number.  To fix this, move the
returning implementation into its only caller, the osi_Assert macro.

This fixes possible compiler misoptimizations due to

rx_kcommon.c:255:1: warning: ‘noreturn’ function does return

Change-Id: Ibbcc630037002ce4659e2e6a36b39d271f9bdc58
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-on: http://gerrit.openafs.org/3276
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
src/rx/rx_kcommon.c
src/rx/rx_prototypes.h