Do not redeclare mutexes for darwin
authorBenjamin Kaduk <kaduk@mit.edu>
Wed, 18 Mar 2015 14:35:33 +0000 (10:35 -0400)
committerJeffrey Altman <jaltman@your-file-system.com>
Sun, 22 Mar 2015 15:23:33 +0000 (11:23 -0400)
commit25373555f838ec7f9a7a1625e66c7d83108a62f2
tree0e71733eaf747d488f57326c61c8520e72bc97fe
parent777870da86e9ed66756e01e858a54e959959482d
Do not redeclare mutexes for darwin

Partially revert commit e2e93aa8920c0b1bfc672a555a59eb4e15dbeaae,
which added local declarations for des_init_mutex, des_random_mutex,
and rxkad_random_mutex to a number of files in libadmin, apparently
to fix the build on macos 10.3.  That OS is long EoL-ed, and
more recent versions of OS X include toolchains that do not
need these extra declarations.  In particular, the extra declarations
can be harmful when these files start to pull in more symbols
from our libraries (e.g., libafscp), since the details of the
linking process can cause that to generate duplicate symbol errors.

There is no longer any need to have local declarations of these
symbols for OS X, so just remove them.

Change-Id: Ie152387b4bd16b470054821fc8ddf852e1a4285c
Reviewed-on: http://gerrit.openafs.org/11798
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
22 files changed:
src/libadmin/samples/cm_client_config.c
src/libadmin/samples/cm_list_cells.c
src/libadmin/samples/cm_local_cell.c
src/libadmin/samples/cm_server_prefs.c
src/libadmin/samples/rxdebug_basic_stats.c
src/libadmin/samples/rxdebug_conns.c
src/libadmin/samples/rxdebug_peers.c
src/libadmin/samples/rxdebug_rx_stats.c
src/libadmin/samples/rxdebug_supported_stats.c
src/libadmin/samples/rxdebug_version.c
src/libadmin/samples/rxstat_clear_peer.c
src/libadmin/samples/rxstat_clear_process.c
src/libadmin/samples/rxstat_disable_peer.c
src/libadmin/samples/rxstat_disable_process.c
src/libadmin/samples/rxstat_enable_peer.c
src/libadmin/samples/rxstat_enable_process.c
src/libadmin/samples/rxstat_get_peer.c
src/libadmin/samples/rxstat_get_process.c
src/libadmin/samples/rxstat_get_version.c
src/libadmin/samples/rxstat_query_peer.c
src/libadmin/samples/rxstat_query_process.c
src/libadmin/test/afscp.c