Rationalise our include paths
authorSimon Wilkinson <sxw@inf.ed.ac.uk>
Fri, 13 Nov 2009 09:50:29 +0000 (09:50 +0000)
committerDerrick Brashear <shadow|account-1000005@unknown>
Tue, 17 Nov 2009 21:12:57 +0000 (13:12 -0800)
commit36524b2ed73a2774ee1f6242208a1395be7736a8
treea2055dd9afd88b3c4d66f42a877e757e9b994d43
parentcb6681c0d189d15fb5ff0d21cf47c9ac223a98c5
Rationalise our include paths

Our include paths are a bit of a mess. Fix these so that they're
more rational, and more in line with normal coding style.

In particular:
   *) Don't include all of the subdirectories of our top level
      include directory. If a file wants afs/file.h, it should
      include that, not "file.h"
   *) Try to avoid including '.' in the search path (although
      objdir builds make this harder)
   *) Don't blindly include other directories from the code tree
      in the search path. If a package wants another packages header,
      then it should get it from the include directory
   *) Use the convention that quoted includes ("") pick up local
      headers. Bracketed includes (<>) pick up ones from the top level
      include dir
   *) In directories which pull in files from multiple packages, don't
      blindly put all of the package directories in the search path.
      Specifically include the file's package directory when required

The big change here is that it's no longer possible to hide a system
include by placing a header of the same name in include/afs. The most
common case where this was happening was for 'assert.h'

Change-Id: I0796fabcf83ffcd74e533624c64e138a160dd632
Reviewed-on: http://gerrit.openafs.org/834
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
72 files changed:
Makefile.in
src/afsmonitor/afsmon-win.c
src/afsmonitor/afsmonitor.c
src/aklog/skipwrap.c
src/audit/Makefile.in
src/bucoord/volstub.c
src/comerr/Makefile.in
src/config/Makefile.config.in
src/config/Makefile.in
src/config/mc.c
src/des/Makefile.in
src/des/cbc_encrypt.c
src/des/cksum.c
src/des/conf.h
src/des/debug_decl.c
src/des/des.c
src/des/des.h
src/des/enc.c
src/des/key_parity.c
src/des/key_sched.c
src/des/main.c
src/des/make_e.c
src/des/make_fp.c
src/des/make_ip.c
src/des/make_keyperm.c
src/des/make_odd.c
src/des/make_p.c
src/des/make_p_table.c
src/des/make_s.c
src/des/make_s_table.c
src/des/misc.c
src/des/new_rnd_key.c
src/des/pcbc_encrypt.c
src/des/quad_cksum.c
src/des/read_pssword.c
src/des/strng_to_key.c
src/des/util.c
src/fsprobe/fsprobe.c
src/fsprobe/fsprobe_test.c
src/kauth/kaaux.c
src/kauth/user.c
src/libadmin/kas/Makefile.in
src/libafsauthent/Makefile.in
src/libafsrpc/Makefile.in
src/rxdebug/rxdebug.c
src/rxkad/Makefile.in
src/rxkad/domestic/crypt_conn.c
src/rxkad/domestic/fcrypt.c
src/rxkad/rxkad.p.h
src/rxkad/v5gen.c
src/scout/scout.c
src/shlibafsrpc/Makefile.in
src/sys/Makefile.in
src/tsalvaged/Makefile.in
src/tsalvaged/salvsync-debug.c
src/tviced/Makefile.in
src/tvolser/Makefile.in
src/ubik/Makefile.in
src/usd/Makefile.in
src/uss/Makefile.in
src/viced/Makefile.in
src/viced/callback.c
src/viced/viced.c
src/vlserver/vldbint.xg
src/vol/nuke.c
src/vol/physio.c
src/vol/volume.c
src/volser/vol-dump.c
src/volser/vol_split.c
src/volser/volmain.c
src/xstat/xstat_cm_test.c
src/xstat/xstat_fs_test.c