libafs: afs_CacheFetchProc can't be called without a dcache pointer
authorGarrett Wollman <wollman@csail.mit.edu>
Tue, 9 Aug 2011 04:28:27 +0000 (00:28 -0400)
committerDerrick Brashear <shadow@dementix.org>
Tue, 31 Jul 2012 12:37:53 +0000 (05:37 -0700)
commit77f258a71dde5bc8f82b5d6f24836cfee4e9bcce
treebd9fbe179a4b4e75c219f1d7add1c3008e8b0747
parent070e90a92175eb91b3709598859fabb0c843d0a9
libafs: afs_CacheFetchProc can't be called without a dcache pointer

An inspection of the only call site suggests that afs_CacheFetchProc()
can't be called with a null dcache pointer, and code further down
in this function dereferences adc unconditionally (assuming
rxfs_fetchInit() doesn't crash first) so remove the conditional
here.

Probably more of these parameters can and should be included in the
AFS_NONNULL.

Change-Id: Ic87517376085b0d5bc7631b5558411259ae986f4
Reviewed-on: http://gerrit.openafs.org/5180
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
src/afs/afs_fetchstore.c
src/afs/afs_prototypes.h