rx-deal-with-missed-keepalives-by-accurately-tracking-call-number-20011110
authorGarry Zacheiss <zacheiss@mit.edu>
Sat, 10 Nov 2001 18:08:40 +0000 (18:08 +0000)
committerDerrick Brashear <shadow@dementia.org>
Sat, 10 Nov 2001 18:08:40 +0000 (18:08 +0000)
commit7a012ce879fdb6193b77e71821b1f9cce89c0fd6
treed22a6af05f74950b124592232faf9775154f3275
parentb9d15d1b49aff5360f0c327ed703433565b00d57
rx-deal-with-missed-keepalives-by-accurately-tracking-call-number-20011110

(as originally discovered by ted@mit.edu)

"This fix deals with the following lose case:
  Client starts a call that, for some reason, takes a long time on the
  server.  While the client waits for the server to finish, client and
  server usually send each other keep alive packets.  If something
  causes those packets to be delayed or dropped, then the client will
  conclude that the call has failed or finished (usually failed), while
  the server is still *busy* doing the call.

  In this circumstance, the client will initiate another call and the
  server will correctly respond that it is busy.  Unfortunately, if the
  callNumber of a received packet doesn't match the callNumber of the
  outstanding call, then the client never sees that the server says it's
  busy.  Instead the server appears as a black hole to the client.

  This fix ensures that the client sees the busy packets when its
  callNumber is reasonably out of sync with the server."
src/rx/rx_packet.c