libafs: Get rx conn ref with afs conn ref
authorAndrew Deason <adeason@sinenomine.net>
Thu, 5 May 2011 16:18:08 +0000 (11:18 -0500)
committerDerrick Brashear <shadow@dementia.org>
Sun, 22 May 2011 15:31:19 +0000 (08:31 -0700)
commit910f3d4cbba4cd78a8e6afa0b32e37ed7f292d18
tree43d75586af78e37976d32695b5ac0277f4531ba7
parent1465946bb6863430bf0efebd024d394549a8775f
libafs: Get rx conn ref with afs conn ref

When we get a reference to an afs_conn with afs_Conn and its variants,
we assume we can use the tc->id rx connection without holding any
locks. However, if tc->forceConnectFS gets set, the tc->id connection
can be destroyed and recreated out from under us. So, to avoid using a
possibly freed rx connection, grab a reference to the rx connection at
the same time as we grab a reference to the afs conn. And also put
back the same reference with afs_PutConn.

Reviewed-on: http://gerrit.openafs.org/4625
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 03f0c656c1734b9be4debdf19b8f10771ff4420a)

Change-Id: I5bef36da0a4337d923a68f1d352b4aad1143395a
Reviewed-on: http://gerrit.openafs.org/4648
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
17 files changed:
src/afs/VNOPS/afs_vnop_create.c
src/afs/VNOPS/afs_vnop_dirops.c
src/afs/VNOPS/afs_vnop_flock.c
src/afs/VNOPS/afs_vnop_link.c
src/afs/VNOPS/afs_vnop_lookup.c
src/afs/VNOPS/afs_vnop_remove.c
src/afs/VNOPS/afs_vnop_rename.c
src/afs/VNOPS/afs_vnop_symlink.c
src/afs/afs_analyze.c
src/afs/afs_conn.c
src/afs/afs_dcache.c
src/afs/afs_pioctl.c
src/afs/afs_prototypes.h
src/afs/afs_segments.c
src/afs/afs_server.c
src/afs/afs_vcache.c
src/afs/afs_volume.c