rxevent: prevent negative rx_connection refCount
rxi_ChallengeEvent is called directly from rxi_ChallengeOn to start the
first challenge; subsequent calls to rxi_ChallengeEvent are from the
event handler. When called as an event, we must putConnection the
reference held by the event. But when called directly for the first
time, the event has not been scheduled yet and so has not taken a
reference on the connection. For this case, we must not putConnection
or the rx_connection refCount will go negative.
One reported symptom of this bug is a fileserver crash with:
'Assertion failed! file rx.c, line 1327.'
Introduced by commit
304d758983b499dc568d6ca57b6e92df24b69de8
('Standardize rx_event usage').
Change-Id: I67122ff84ac9b1b6445ad4005e76e5f8482fd7be
Reviewed-on: https://gerrit.openafs.org/13228
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: BuildBot <buildbot@rampaginggeek.com>