kauth warning reduction
authorMarc Dionne <marc.c.dionne@gmail.com>
Mon, 27 Jul 2009 18:24:15 +0000 (14:24 -0400)
committerJeffrey Altman <jaltman@openafs.org>
Thu, 6 Aug 2009 04:00:46 +0000 (21:00 -0700)
commitc3c8a3e2f912855addc2c430f909bdce912e3670
tree6a490b5b8c0654ffad6290de5e17fa3f209db02b
parent20243612a15b150a3dbb3c9e027c1c79a0e5f200
kauth warning reduction

Warning removal for various functions that manipulates keys and use
several data types interchangeably.
Inline helpers are introduced to convert between the types and are
used when making function calls to target the appropriate type:

des_prototypes.h
cblockptr_to_cblock:  des_cblock *  to des_cblock
charptr_to_cblock:  char *  to des_cblock
charptr_to_cblockptr:  char *  to des_cblock *

rxkad_prototypes.h
ktc_to_cblock:  struct ktc_encryptionKey *  to des_cblock
ktc_to_cblockptr:  struct ktc_encryptionKey *  to des_cblock *

kauth_internal.h
EncryptionKey_to_cblock:  EncryptionKey *  to des_cblock
EncryptionKey_to_ktc:  EncryptionKey *  to struct ktc_encryptionKey *
ktc_to_EncryptionKey:  struct ktc_encryptionKey *  to EncryptionKey *

- parameters are adjusted for tkt_DecodeTicket(5), replacing the char *
key with struct ktc_encryptionKey, to match usage
- the get_key function is changed to have a void * parameter, to match
usage
- rxkad_prototypes.h includes des.h to get the des_cblock definition.
This causes conflicts for a few files where the kerberos headers are
also included - aklog/aklog_main.c and WINNT/afsd/afskfw.c
Use NO_DES_H_INCLUDE in thoses cases to skip the new parts of
rxkad_prototypes.h

Reviewed-on: http://gerrit.openafs.org/234
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
21 files changed:
Makefile.in
src/WINNT/afsd/afskfw.c
src/aklog/aklog_main.c
src/auth/authcon.c
src/bozo/bos_util.c
src/des/des_prototypes.h
src/des/strng_to_key.c
src/kauth/admin_tools.c
src/kauth/authclient.c
src/kauth/client.c
src/kauth/kaprocs.c
src/kauth/kauth_internal.h
src/kauth/kautils.c
src/kauth/kpasswd.c
src/kauth/krb_udp.c
src/kauth/read_passwd.c
src/kauth/rebuild.c
src/kauth/user.c
src/rxkad/rxkad_prototypes.h
src/rxkad/ticket.c
src/rxkad/ticket5.c