budb: Store dumper information correctly
authorSimon Wilkinson <sxw@your-file-system.com>
Sun, 24 Feb 2013 12:53:59 +0000 (12:53 +0000)
committerDerrick Brashear <shadow@your-file-system.com>
Mon, 25 Feb 2013 18:42:33 +0000 (10:42 -0800)
commitdce2d8206ecd35c96e75cc0662432c2a4f9c3d7a
tree487673241edd51802514ade681c48745de3c8c5d
parent2a2cae72d653fbfdada7dddd4b7e5d8aeedea2ee
budb: Store dumper information correctly

Change f498c18a6f7300eb89ca3b9d9b85c4d461fa8474 attempted to fix
a problem with using an inappropriate function to copy the
ktc_principal value 'principal' into the d.dumper structure element.

Originally the code read:
    principal_hton(&principal, &d.dumper)

which copies the 'host' principal principal into the 'net' structure
d.dumper. However, this was changed to
    principal = d.dumper

Which populates 'principal' with whatever garbage is in the d.dumper
structure.

Fix this so that the assignment is done the right way around.

Caught by clang-analyzer

Change-Id: Id9865a36b5a9351d013c695ed301b627ddc4a915
Reviewed-on: http://gerrit.openafs.org/9252
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
src/budb/procs.c