clang-10: ignore fallthrough warning in generated code 75/14275/9
authorCheyenne Wills <cwills@sinenomine.net>
Thu, 23 Jul 2020 21:43:42 +0000 (15:43 -0600)
committerBenjamin Kaduk <kaduk@mit.edu>
Mon, 27 Jul 2020 16:23:15 +0000 (12:23 -0400)
commite5f44f6e9af643cab3a66216dff901e0a4c5eda8
tree6ea0f5160ae1f4b076111a8f5ee1b44f2cb133f2
parent16f1b2f894c28614df0f096be8232b1176e87c70
clang-10: ignore fallthrough warning in generated code

Clang-10 will not recognize '/* fall through */' as an indicator to
turn off the fallthrough warning due to the lack of a 'break' in a case
statement.

Code generated by flex uses the '/* fall through */' comments to turn
off compiler warnings for fallthroughs in case statements.

For code generated by flex, ignore the implicit-fallthrough via pragma
or disable the warning via a compile time flag.

Add new env variable "CFLAGS_NOIMPLICIT_FALLTHROUGH" to selectively
disable the compile check in Makefiles when checking is enabled.

Change-Id: I4c054defda03daa2aeb645ae2271dfa0cb54925f
Reviewed-on: https://gerrit.openafs.org/14275
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
CODING
src/cf/osconf.m4
src/comerr/error_table.y
src/uss/Makefile.in