ubik: do not assign variables in logging argument lists 11/13211/2
authorMichael Meffie <mmeffie@sinenomine.net>
Thu, 14 Jun 2018 19:01:18 +0000 (15:01 -0400)
committerBenjamin Kaduk <kaduk@mit.edu>
Fri, 15 Jun 2018 13:47:59 +0000 (09:47 -0400)
commit472d6b1ee2f7de415e0fa0f8be0636f86956b6fc
treef8907d66f875b6e05615cc9c9bfb0a35d0add063
parente08b9c8d36da3f37efabfb3f94476108a5985d23
ubik: do not assign variables in logging argument lists

Several logging statements in ubik contain an assignment statement
within the logging function call argument list, which would set a
variable as side effect of evaluating the function call arguments.

These embedded assignments are problematic since the logging function
calls have been replaced by ViceLog macros, which avoid the overhead of
a function call depending on logging levels.

Remove the embedded assignments within the logging argument lists so the
variables are always set regardless of the logging level.

Change-Id: Ifc0f32df2d01f9d8105b49e2c56a95758b184449
Reviewed-on: https://gerrit.openafs.org/13211
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Joe Gorse <jhgorse@gmail.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Marcio Brito Barbosa <mbarbosa@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
src/ubik/recovery.c