rx: clear call_queue_lock after removing call from queue 41/13641/4
authorMark Vitale <mvitale@sinenomine.net>
Fri, 15 Mar 2019 03:15:29 +0000 (23:15 -0400)
committerBenjamin Kaduk <kaduk@mit.edu>
Fri, 20 Sep 2019 03:52:15 +0000 (23:52 -0400)
commite87c40f4546ee9c31b2eaad2a24be9fb9a0b25b1
treed34efb419994769a6b8167df0c7b7e3ef7f44542
parent3be5880d1d2a0aef6600047ed43d602949cd5f4d
rx: clear call_queue_lock after removing call from queue

The call_queue_lock is set to either rx_serverPool_lock or
rx_freeCallQueue_lock, depending on whether an rx_call resides in the
rx_incomingCallQueue or the rx_freeCallQueue, respectively.  This value
is used by rxi_ResetCall to lock the appropriate queue before removing a
call.  Therefore, the call_queue_lock should be cleared after a call is
removed from a queue.

This issue has no known external symptoms; however, repairing this is
helpful to developers examining core files.

Repair two instances where the call_queue_lock is not cleared.

Change-Id: Id1d9ac8454c1e07c10766dffb2a2beac7122bf3e
Reviewed-on: https://gerrit.openafs.org/13641
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
src/rx/rx.c