Unix CM: Fix dir buffer leak in afs_readdir
authorSimon Wilkinson <sxw@your-file-system.com>
Thu, 3 Nov 2011 10:10:23 +0000 (10:10 +0000)
committerDerrick Brashear <shadow@dementix.org>
Fri, 4 Nov 2011 22:40:21 +0000 (15:40 -0700)
Resolve a buffer leak in afs_readdir that was visible on all non-Linux
platforms (Linux has an independent readdir implementation)

Change-Id: Ia5106f0e5c57430d3483b6add5b1629ff3fbc7b3
Reviewed-on: http://gerrit.openafs.org/5794
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>

src/afs/VNOPS/afs_vnop_readdir.c

index f0572b9..8316bb9 100644 (file)
@@ -914,6 +914,7 @@ afs_readdir(OSI_VC_DECL(avc), struct uio *auio, afs_ucred_t *acred)
 #endif /* AFS_SGI53_ENV */
        
        DRelease(&oldEntry, 0);
+       oldEntry = nextEntry;
        ode = nde;
        AFS_UIO_SETOFFSET(auio, (afs_int32) ((us + afs_dir_NameBlobs(nde->name)) << 5));
     }