A few if() conditions currently contain redundant syntax, due to typos.
Fix the conditions to actually check different things, according to what
the author probably originally intended. (via cppcheck)
Change-Id: I7e46217e1f84fe65677ada345d227f31f1988fe6
Reviewed-on: https://gerrit.openafs.org/13157
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
count * sizeof(afs_int32));
}
if (!dumps->budb_dumpsList_val
- || !dumps->budb_dumpsList_val)
+ || !flags->budb_dumpsList_val)
ABORT(BUDB_NOMEM);
}
t_handle->afs_token.ticketLen,
t_handle->afs_token.ticket);
if ((t_handle->afs_sc[t_handle->sc_index] == NULL)
- || (t_handle->afs_sc[t_handle->sc_index] == NULL)) {
+ || (t_handle->afs_encrypt_sc[t_handle->sc_index] == NULL)) {
tst = ADMCLIENTTOKENHANDLENOSECURITY;
goto fail_afsclient_TokenGetExisting;
} else {
if (tid) {
etst = AFSVolEndTrans(server, tid, &rcode);
- /* FIXME: this looks like a typo */
- if (etst || etst) {
+ if (etst || rcode) {
if (!tst)
tst = (etst ? etst : rcode);
}