viced-findclient-do-not-return-wrong-client-20060620

In h_FindClient_r it was possible for the wrong client to be returned
and worse for it to be returned without the reference count being
incremented.

diff --git a/src/viced/host.c b/src/viced/host.c
index 0d5447b..2b9e794 100644 (file)
--- a/src/viced/host.c
+++ b/src/viced/host.c
@@ -1646,6 +1646,8 @@ h_FindClient_r(struct rx_connection *tcon)
        H_UNLOCK;
        ObtainWriteLock(&client->lock); /* released at end */
        H_LOCK;
+    } else {
+       client = NULL;
     }
 
     authClass = rx_SecurityClassOf((struct rx_connection *)tcon);