Remove automated casting in rxgen 16/12116/6
authorChas Williams <3chas3@gmail.com>
Mon, 23 Nov 2015 19:19:38 +0000 (14:19 -0500)
committerBenjamin Kaduk <kaduk@mit.edu>
Mon, 21 Mar 2016 03:51:57 +0000 (23:51 -0400)
We should let the compiler warn us when we attempt to convert types that
should not be converted.

Change-Id: Ie9f5f6ab5d5978bbe5e741b1a20bfb4d36fb314c
Reviewed-on: https://gerrit.openafs.org/12116
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: BuildBot <buildbot@rampaginggeek.com>

src/rxgen/rpc_cout.c

index a15b627..3ddb27a 100644 (file)
@@ -221,15 +221,15 @@ print_ifarg_len(char *objname, char *name)
 {
     if (*objname == '&') {
        if (brief_flag) {
-           f_print(fout, "(u_int *)%s.len", objname);
+           f_print(fout, "%s.len", objname);
        } else {
-           f_print(fout, "(u_int *)%s.%s_len", objname, name);
+           f_print(fout, "%s.%s_len", objname, name);
        }
     } else {
        if (brief_flag) {
-           f_print(fout, "(u_int *)&%s->len", objname);
+           f_print(fout, "&%s->len", objname);
        } else {
-           f_print(fout, "(u_int *)&%s->%s_len", objname, name);
+           f_print(fout, "&%s->%s_len", objname, name);
        }
     }
 }