viced: propagate return from CleanupTimedOutCallBacks_r

The fileserver's FiveMinuteCheckLWP periodically calls
CleanupTimedOutCallBacks, and logs an informational messages if the
return code indicates that any callbacks were discarded.

However, since the original IBM code import,  CleanupTimedOutCallBacks
has 1) ignored the return value from CleanupTimedOutCallBacks_r and 2)
unconditionally returned 0.  This makes the informational message
essentially dead code.

Instead, check the code from CleanupTimedOutCallBacks_r and pass it back
to the caller.

Change-Id: I631831c398e43431b79f4a3a0c6f01307ac0c05e
Reviewed-on: https://gerrit.openafs.org/14256
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>

diff --git a/src/viced/callback.c b/src/viced/callback.c
index 980d7e5..0e38a95 100644 (file)
--- a/src/viced/callback.c
+++ b/src/viced/callback.c
@@ -1371,10 +1371,12 @@ BreakLaterCallBacks(void)
 int
 CleanupTimedOutCallBacks(void)
 {
+    int code;
+
     H_LOCK;
-    CleanupTimedOutCallBacks_r();
+    code = CleanupTimedOutCallBacks_r();
     H_UNLOCK;
-    return 0;
+    return code;
 }
 
 int