git://git.openafs.org
/
openafs.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
(parent:
c0876aa
)
viced: incorrect FID audit of BulkStatus and InlineBulkStatus
91/12191/2
author
Mark Vitale
<mvitale@sinenomine.net>
Tue, 16 Feb 2016 19:55:03 +0000 (14:55 -0500)
committer
Benjamin Kaduk
<kaduk@mit.edu>
Wed, 17 Feb 2016 19:06:42 +0000 (14:06 -0500)
The audit code for object AUD_FIDS is off by one - we list the
first FID twice and skip the last FID.
Repair so all FIDs are properly audited.
Change-Id: I99f4687e25031eb26ccd7e07b732217b098005de
Reviewed-on: http://gerrit.openafs.org/12191
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Chas Williams <3chas3@gmail.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
src/audit/audit.c
patch
|
blob
|
history
diff --git
a/src/audit/audit.c
b/src/audit/audit.c
index
6c88c35
..
4701d61
100644
(file)
--- a/
src/audit/audit.c
+++ b/
src/audit/audit.c
@@
-249,9
+249,8
@@
printbuf(int rec, char *audEvent, char *afsName, afs_int32 hostId,
vaFid = vaFids->AFSCBFids_val;
if (vaFid) {
- audit_ops->append_msg("FIDS %u FID %u:%u:%u ", vaFids->AFSCBFids_len, vaFid->Volume,
- vaFid->Vnode, vaFid->Unique);
- for ( i = 1; i < vaFids->AFSCBFids_len; i++, vaFid++ )
+ audit_ops->append_msg("FIDS %u ", vaFids->AFSCBFids_len);
+ for ( i = 1; i <= vaFids->AFSCBFids_len; i++, vaFid++ )
audit_ops->append_msg("FID %u:%u:%u ", vaFid->Volume,
vaFid->Vnode, vaFid->Unique);
} else