audit: remove uneeded strncpy
authorMichael Meffie <mmeffie@sinenomine.net>
Thu, 14 Jul 2011 16:02:21 +0000 (12:02 -0400)
committerDerrick Brashear <shadow@dementia.org>
Sun, 17 Jul 2011 05:01:42 +0000 (22:01 -0700)
In this caller to krb_realms, when no realms names are returned the
number of local realms is correctly set to zero, however the first
local realm buffer is filled with a placeholder string which is
not used.  Remove the uneeded strncpy, which also makes this
section of code consistent with afs_is_foreign_ticket().

This section of code is duplicated by afs_is_foreign_ticket() and
should be consolidated in a subsequent patch.

Change-Id: I48f84934e7321769eebaf80c83b2c100fd026a6a
Reviewed-on: http://gerrit.openafs.org/5020
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Tested-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

src/audit/audit.c

index 3bb5f76..de73c6f 100644 (file)
@@ -456,8 +456,6 @@ osi_auditU(struct rx_call *call, char *audEvent, int errCode, ...)
                                    break;
                            }
 
-                           if (i == 0)
-                               strncpy(local_realms[0], "UNKNOWN.LOCAL.REALM", AFS_REALM_SZ);
                            num_lrealms = i;
                         }