unbalanced-unlock-20050610
authorJeffrey Altman <jaltman@secure-endpoints.com>
Fri, 10 Jun 2005 22:07:05 +0000 (22:07 +0000)
committerJeffrey Altman <jaltman@secure-endpoints.com>
Fri, 10 Jun 2005 22:07:05 +0000 (22:07 +0000)
Addition of __EXPERIMENTAL_CALLBACK_CONN_MOVING if defined left an
unbalanced H_UNLOCK.

Semi-colons after H_LOCK and H_UNLOCK were missing.

src/viced/afsfileprocs.c

index fb3a071..4dab214 100644 (file)
@@ -7249,8 +7249,7 @@ SRXAFS_CallBackRxConnAddr (struct rx_call * acall, afs_int32 *addr)
 #ifndef __EXPERIMENTAL_CALLBACK_CONN_MOVING
     errorCode = 1;
 #else
-
-    H_LOCK
+    H_LOCK;
     tclient = h_FindClient_r(tcon);
     thost = tclient->host;
     
@@ -7283,9 +7282,9 @@ SRXAFS_CallBackRxConnAddr (struct rx_call * acall, afs_int32 *addr)
                             thost->port, 1, sc, 0);
     rx_SetConnDeadTime(conn, 2); 
     rx_SetConnHardDeadTime(conn, AFS_HARDDEADTIME); 
-    H_UNLOCK
+    H_UNLOCK;
     errorCode = RXAFSCB_Probe(conn);
-    H_LOCK
+    H_LOCK;
     if (!errorCode) {
        if ( thost->callback_rxcon )
            rx_DestroyConnection(thost->callback_rxcon);
@@ -7299,10 +7298,10 @@ SRXAFS_CallBackRxConnAddr (struct rx_call * acall, afs_int32 *addr)
     } else {
        rx_DestroyConnection(conn);
     }      
+  Bad_CallBackRxConnAddr:
+    H_UNLOCK;
 #endif
 
- Bad_CallBackRxConnAddr:
-    H_UNLOCK;
     errorCode = CallPostamble(tcon, errorCode);
  Bad_CallBackRxConnAddr1:
     return errorCode;          /* failure */