The conditions in these if statements are always true (or always false).
Remove the check in cmdebug.c, as it is unnecessary, and fix the check
in vlclient.c to actually check for a valid voltype. (via cppcheck)
Change-Id: Ica7dfc9b81fe8bd0f156f6e4e616ed45e205985a
Reviewed-on: https://gerrit.openafs.org/13158
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
if (int32p == 0 || int32p == 1)
PrintLocks(conn, int32p);
- if (int32p >= 0 || int32p <= 4)
- PrintCacheEntries(conn, int32p);
+
+ PrintCacheEntries(conn, int32p);
return 0;
}
sscanf(&(*argp)[0], "%d", &id);
++argp, --nargs;
sscanf(&(*argp)[0], "%d", &voltype);
- if (voltype < 0 && voltype > 2) {
+ if (voltype < 0 || voltype > 2) {
printf("Illegal voltype; must be 0, 1 or 2\n");
continue;
}