uss: signed/unsigned char fallout 75/13475/2
authorBenjamin Kaduk <kaduk@mit.edu>
Sun, 3 Feb 2019 01:48:20 +0000 (19:48 -0600)
committerBenjamin Kaduk <kaduk@mit.edu>
Fri, 1 Mar 2019 14:03:37 +0000 (09:03 -0500)
When char is signed, assigning 255 to a variable of type char changes
the value, which causes clang to emit a warning and fail the
--enable-checking build.

Change-Id: Id02e2526a9a9dd6657dee55b9dc22da03d102d8c
Reviewed-on: https://gerrit.openafs.org/13475
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>

src/uss/uss_kauth.c

index da956bd..11cbe6c 100644 (file)
@@ -641,7 +641,7 @@ uss_kauth_SetFields(char *username, char *expirestring, char *reuse,
        fprintf(stderr, "Zero represents unlimited login attempts.\n");
        fprintf(stderr, "Continuing with limit == 254 for user %s.\n",
                username);
-       misc_auth_bytes[2] = 255;
+       misc_auth_bytes[2] = 0xff;
     } else
        misc_auth_bytes[2] = nfailures + 1;