discon getparentvcache leak fix
authorDerrick Brashear <shadow@dementia.org>
Wed, 4 Aug 2010 13:00:58 +0000 (09:00 -0400)
committerDerrick Brashear <shadow@dementia.org>
Wed, 4 Aug 2010 14:22:22 +0000 (07:22 -0700)
don't leak an unref'd vcache pointer if we are returning an error
(EAGAIN). thanks to Simon Wilkinson for catching this.

Change-Id: I40c5aa0fd50e1f2c76b09ba073a7109bca706d8c
Reviewed-on: http://gerrit.openafs.org/2511
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

src/afs/afs_disconnected.c

index db244bf..46a665c 100644 (file)
@@ -531,8 +531,10 @@ afs_GetParentVCache(struct vcache *avc, int deleted, struct VenusFid *afid,
     }
 
 end:
-    if (code && *adp)
+    if (code && *adp) {
        afs_PutVCache(*adp);
+       *adp = NULL;
+    }
     return code;
 }