Remove weekly bosserver restarts

Change the default so new installations of the bosserver have
no weekly restarts. Update the manpage and XML documentation to
reflect this change.

FIXES 126138

Change-Id: Ic22b750a602f6d2a22be881f5e1b04cd4fa132ae
Reviewed-on: http://gerrit.openafs.org/1097
Reviewed-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

diff --git a/doc/man-pages/pod8/bos_setrestart.pod b/doc/man-pages/pod8/bos_setrestart.pod
index 27c18e9..216cd91 100644 (file)
--- a/doc/man-pages/pod8/bos_setrestart.pod
+++ b/doc/man-pages/pod8/bos_setrestart.pod
@@ -27,11 +27,11 @@ by the B<-server> argument performs two types of restarts:
 
 =item *
 
-A I<general restart>. By default, once per week the BOS Server restarts
-itself and then any AFS process marked with the C<Run> status flag in the
+A I<general restart>. The BOS Server will restart itself,
+and then any AFS process marked with the C<Run> status flag in the
 F<BosConfig> file (equivalent in effect to issuing the B<bos restart>
-command with the B<-bosserver> flag). The default setting is 4:00
-a.m. each Sunday morning.
+command with the B<-bosserver> flag) at this time each week. By default,
+in a new bos installation, general restarts are disabled.
 
 =item *
 

diff --git a/doc/xml/AdminGuide/auagd007.xml b/doc/xml/AdminGuide/auagd007.xml
index 1bb7d90..77b9f59 100644 (file)
--- a/doc/xml/AdminGuide/auagd007.xml
+++ b/doc/xml/AdminGuide/auagd007.xml
@@ -1992,15 +1992,15 @@ user receives an AFS token when
       Reboot file server machines as infrequently as possible. For instructions, see <link linkend="HDRWQ139">Rebooting a Server
       Machine</link>.</para>
 
-      <para>By default, the BOS Server on each file server machine stops and immediately restarts all AFS server processes on the
-      machine (including itself) once a week, at 4:00 a.m. on Sunday. This reduces the potential for the core leaks that can develop
-      as any process runs for an extended time.</para>
-
-      <para>The BOS Server also checks each morning at 5:00 a.m. for any newly installed binary files in the <emphasis
+      <para>The BOS Server checks each morning at 5:00 a.m. for any newly installed binary files in the <emphasis
       role="bold">/usr/afs/bin</emphasis> directory. It compares the timestamp on each binary file to the time at which the
       corresponding process last restarted. If the timestamp on the binary is later, the BOS Server restarts the corresponding
       process to start using it.</para>
 
+      <para>The BOS server also supports performing a weekly restart of all AFS server processes, including itself. This functionality
+      is disabled on new installs, but historically it was set to 4:00am on Sunday. Administrators may find that installations predating
+      OpenAFS 1.6.0 have weekly restarts enabled.</para>
+
       <para>The default times are in the early morning hours when the outage that results from restarting a process is likely to
       disturb the fewest number of people. You can display the restart times for each machine with the <emphasis role="bold">bos
       getrestart</emphasis> command, and set them with the <emphasis role="bold">bos setrestart</emphasis> command. The latter

diff --git a/doc/xml/AdminGuide/auagd008.xml b/doc/xml/AdminGuide/auagd008.xml
index 0e1c10c..4ce35df 100644 (file)
--- a/doc/xml/AdminGuide/auagd008.xml
+++ b/doc/xml/AdminGuide/auagd008.xml
@@ -5708,4 +5708,4 @@
       </orderedlist>
     </sect2>
   </sect1>
-</chapter>
\ No newline at end of file
+</chapter>

diff --git a/doc/xml/AdminGuide/auagd009.xml b/doc/xml/AdminGuide/auagd009.xml
index 00b3613..13d9869 100644 (file)
--- a/doc/xml/AdminGuide/auagd009.xml
+++ b/doc/xml/AdminGuide/auagd009.xml
@@ -2614,12 +2614,14 @@
       <secondary>setting</secondary>
     </indexterm>
 
-    <para>The BOS Server by default restarts once a week, and the new instance restarts all processes marked with status flag
+    <para>The BOS Server by default has general restarts disabled. If you wish, it may be configured so that it
+    restarts once a week, and the new instance restarts all processes marked with status flag
     <computeroutput>Run</computeroutput> in the local <emphasis role="bold">/usr/afs/local/BosConfig</emphasis> file (this is
     equivalent to issuing the <emphasis role="bold">bos restart</emphasis> command with the <emphasis
-    role="bold">-bosserver</emphasis> flag). The default restart time is Sunday at 4:00 a.m. The weekly restart is designed to
-    minimize core leaks, which can develop as a process continues to allocate virtual memory but does not free it again. When the
-    memory is completely exhausted, the machine can no longer function correctly.</para>
+    role="bold">-bosserver</emphasis> flag). Historically, the default restart time was Sunday at 4:00 a.m - sites which have
+    been upgraded from earlier versions of OpenAFS may find that this value is still present. The weekly restart was designed to
+    minimize core leaks, which can develop as a process continues to allocate virtual memory but does not free it again. It is
+    believed that these leaks have been fixed in OpenAFS.</pare>
 
     <para>The BOS Server also by default checks once a day for any newly installed binary files. If it finds that the modification
     time stamp on a process's binary file in the <emphasis role="bold">/usr/afs/bin</emphasis> directory is more recent than the
@@ -3036,4 +3038,4 @@
       </orderedlist>
     </sect2>
   </sect1>
-</chapter>
\ No newline at end of file
+</chapter>

diff --git a/src/bozo/bosserver.c b/src/bozo/bosserver.c
index 49bc39b..6dc5e93 100644 (file)
--- a/src/bozo/bosserver.c
+++ b/src/bozo/bosserver.c
@@ -301,11 +301,13 @@ ReadBozoFile(char *aname)
        }
     }
 
-    /* setup default times we want to do restarts */
-    bozo_nextRestartKT.mask = KTIME_HOUR | KTIME_MIN | KTIME_DAY;
-    bozo_nextRestartKT.hour = 4;       /* 4 am */
+    /* don't do server restarts by default */
+    bozo_nextRestartKT.mask = KTIME_NEVER;
+    bozo_nextRestartKT.hour = 0;
     bozo_nextRestartKT.min = 0;
-    bozo_nextRestartKT.day = 0;        /* Sunday */
+    bozo_nextRestartKT.day = 0;
+
+    /* restart processes at 5am if their binaries have changed */
     bozo_nextDayKT.mask = KTIME_HOUR | KTIME_MIN;
     bozo_nextDayKT.hour = 5;
     bozo_nextDayKT.min = 0;