Windows: GetInfoTip really set return to NULL
authorJeffrey Altman <jaltman@your-file-system.com>
Fri, 2 Dec 2011 23:49:23 +0000 (18:49 -0500)
committerJeffrey Altman <jaltman@secure-endpoints.com>
Fri, 2 Dec 2011 23:54:48 +0000 (15:54 -0800)
When we are not returning an info-tip string from the shell
extension the string output parameter must be set to NULL.

Change-Id: I63cd9bbe078edd01e62d4b0c810a513dfbf205ae
Reviewed-on: http://gerrit.openafs.org/6183
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>

src/WINNT/client_exp/shell_ext.cpp

index fab7d6b..2f916f8 100644 (file)
@@ -805,14 +805,14 @@ STDMETHODIMP CShellExt::XToolTipExt::GetInfoTip(DWORD dwFlags, LPWSTR *ppwszTip)
 
     if ((_tcslen(pThis->m_szFile) == 0)||(!IsPathInAfs(pThis->m_szFile)))
     {
-        ppwszTip=NULL;
+        *ppwszTip=NULL;
         return S_OK;
     }
     bool bIsSymlink = !!IsSymlink(pThis->m_szFile);
     bool bIsMountpoint = !!IsMountPoint(pThis->m_szFile);
     if ((!bIsSymlink) && (!bIsMountpoint))
     {
-       ppwszTip=NULL;
+       *ppwszTip=NULL;
        return S_OK;
     }
     USES_CONVERSION;