FBSD: in reclaim, print the failed vnode
authorBen Kaduk <kaduk@mit.edu>
Wed, 30 Jun 2010 04:29:41 +0000 (00:29 -0400)
committerDerrick Brashear <shadow@dementia.org>
Wed, 30 Jun 2010 12:16:48 +0000 (05:16 -0700)
If we fail to flush a vnode, in addition to printing a diagnostic
message, also print information about the vnode; fs getfid can
frequently confirm which vnode(s) are problematic, which may be
useful in debugging the failure.

Change-Id: Ia6e93f436f9dcd2d634c46856ede5effbf79e9cb
Reviewed-on: http://gerrit.openafs.org/2296
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

src/afs/FBSD/osi_vnodeops.c

index cfa59ff..8d88aef 100644 (file)
@@ -1438,8 +1438,10 @@ afs_vop_reclaim(struct vop_reclaim_args *ap)
      * XXX Pretend it worked, to prevent panic on shutdown
      * Garrett, please fix - Jim Rees
      */
-    if (code)
-       printf("afs_vop_reclaim: afs_FlushVCache failed code %d\n", code);
+    if (code) {
+       printf("afs_vop_reclaim: afs_FlushVCache failed code %d vnode\n", code);
+       VOP_PRINT(vp);
+    }
 
     /* basically, it must not fail */
     vnode_destroy_vobject(vp);