DEVEL15-shutdown-vcache-avoid-null-deref-20090324
authorDerrick Brashear <shadow@dementia.org>
Tue, 24 Mar 2009 22:40:14 +0000 (22:40 +0000)
committerDerrick Brashear <shadow@dementia.org>
Tue, 24 Mar 2009 22:40:14 +0000 (22:40 +0000)
LICENSE IPL10

avoid potential null pointer deref at shutdown

(cherry picked from commit 4162ff9d4d733afc788b3c002adc57aac78a3282)

src/afs/afs_vcache.c

index e0f7e0c..593d7fc 100644 (file)
@@ -3286,7 +3286,7 @@ shutdown_vcache(void)
      */
 
     {
-       register struct afs_q *tq, *uq;
+       register struct afs_q *tq, *uq = NULL;
        register struct vcache *tvc;
        for (tq = VLRU.prev; tq != &VLRU; tq = uq) {
            tvc = QTOV(tq);
@@ -3341,7 +3341,8 @@ shutdown_vcache(void)
                    tvc->linkData = 0;
                }
 
-               afs_FreeAllAxs(&(tvc->Access));
+               if (tvc->Access)
+                   afs_FreeAllAxs(&(tvc->Access));
            }
            afs_vhashT[i] = 0;
        }