DeleteVolume should check ITSROVOL as a bit
authorNathaniel Wesley Filardo <nwfilardo@gmail.com>
Wed, 3 Dec 2014 07:06:35 +0000 (02:06 -0500)
committerJeffrey Altman <jaltman@your-file-system.com>
Thu, 4 Dec 2014 23:41:24 +0000 (18:41 -0500)
Other bits may be asserted even if this is a RO vol.

Change-Id: Iff5256db25502b61b161ec068bd9d2a389f796c7
Reviewed-on: http://gerrit.openafs.org/11617
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>

src/volser/vos.c

index a7299ab..719c954 100644 (file)
@@ -2172,7 +2172,7 @@ DeleteVolume(struct cmd_syndesc *as, void *arock)
        } else if ((volid == entry.volumeId[ROVOL])
                   && (entry.flags & RO_EXISTS)) {
            for (idx = -1, j = 0; j < entry.nServers; j++) {
-               if (entry.serverFlags[j] != ITSROVOL)
+               if (!(entry.serverFlags[j] & ITSROVOL))
                    continue;
 
                if (((server == 0) || (server == entry.serverNumber[j]))