From: Simon Wilkinson <sxw@your-file-system.com>
Date: Wed, 23 Nov 2011 16:30:55 +0000 (+0000)
Subject: Unix CM: Fix PutVolume in afs_BlackListOnce
X-Git-Tag: openafs-stable-1_8_0pre1~3017
X-Git-Url: http://git.openafs.org/?p=openafs.git;a=commitdiff_plain;h=2373547a86c12f72261072971b8d47e6b7cdd4e6

Unix CM: Fix PutVolume in afs_BlackListOnce

It isn't safe to keep accessing a structure once we have Put our
reference to it.

Change-Id: I6f23a054c3ccde21aa17e07d06dd3c6e7761c098
Reviewed-on: http://gerrit.openafs.org/6117
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
---

diff --git a/src/afs/afs_analyze.c b/src/afs/afs_analyze.c
index a59b416..6bec02d 100644
--- a/src/afs/afs_analyze.c
+++ b/src/afs/afs_analyze.c
@@ -258,13 +258,13 @@ afs_BlackListOnce(struct vrequest *areq, struct VenusFid *afid,
 		    areq->skipserver[i] = 1;
 		}
 	    }
-	    afs_PutVolume(tvp, READ_LOCK);
 	    for (i = 0; i < AFS_MAXHOSTS; i++) {
 	        if (tvp->serverHost[i] && areq->skipserver[i] == 0) {
 		    serversleft = 1;
 		    break;
 		}
 	    }
+	    afs_PutVolume(tvp, READ_LOCK);
 	    return serversleft;
 	}
     }