From: Simon Wilkinson <sxw@inf.ed.ac.uk>
Date: Tue, 15 Jun 2010 17:08:50 +0000 (+0100)
Subject: libcmd: Don't store values that we don't need
X-Git-Tag: openafs-devel-1_7_1~241
X-Git-Url: http://git.openafs.org/?p=openafs.git;a=commitdiff_plain;h=e3d9821a8b34f919de9a01fa0023a691487e763f

libcmd: Don't store values that we don't need

Don't store the results from cmd_CreateSyntax unless we actually
need to use them for something.

Caught by clang-analyzer

Change-Id: I581dcc00a886245a8d117f78c74590111c75e3b0
Reviewed-on: http://gerrit.openafs.org/5077
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
---

diff --git a/src/cmd/cmd.c b/src/cmd/cmd.c
index d67a816..1ead1ca 100644
--- a/src/cmd/cmd.c
+++ b/src/cmd/cmd.c
@@ -771,16 +771,17 @@ initSyntax(void)
 	ts = cmd_CreateSyntax("apropos", AproposProc, NULL,
 			      "search by help text");
 	cmd_AddParm(ts, "-topic", CMD_SINGLE, CMD_REQUIRED, "help string");
-	ts = cmd_CreateSyntax("version", VersionProc, NULL,
-			      (char *)CMD_HIDDEN);
-	ts = cmd_CreateSyntax("-version", VersionProc, NULL,
-			      (char *)CMD_HIDDEN);
-	ts = cmd_CreateSyntax("-help", HelpProc, NULL,
-			      (char *)CMD_HIDDEN);
-	ts = cmd_CreateSyntax("--version", VersionProc, NULL,
-		              (char *)CMD_HIDDEN);
-	ts = cmd_CreateSyntax("--help", HelpProc, NULL,
-			      (char *)CMD_HIDDEN);
+
+	cmd_CreateSyntax("version", VersionProc, NULL,
+			 (char *)CMD_HIDDEN);
+	cmd_CreateSyntax("-version", VersionProc, NULL,
+			 (char *)CMD_HIDDEN);
+	cmd_CreateSyntax("-help", HelpProc, NULL,
+			 (char *)CMD_HIDDEN);
+	cmd_CreateSyntax("--version", VersionProc, NULL,
+		         (char *)CMD_HIDDEN);
+	cmd_CreateSyntax("--help", HelpProc, NULL,
+			 (char *)CMD_HIDDEN);
     }
 }