openafs.git
14 years agoDEVEL15-windows-xml-release-notes-version-20090525
Jeffrey Altman [Tue, 26 May 2009 03:20:24 +0000]
DEVEL15-windows-xml-release-notes-version-20090525

LICENSE MIT

autogenerate version info.

fix chapter title.

(cherry picked from commit 582688f1be17611d2926a4a7281d55bc7ccaa611)

14 years agoDEVEL15-windows-top-makefile-20090525
Jeffrey Altman [Tue, 26 May 2009 01:54:25 +0000]
DEVEL15-windows-top-makefile-20090525

LICENSE MIT

add rules for building documentation sources

add option for including cygwin libs in wix installer

(cherry picked from commit 2f7046eff6599d9a66a7f31bb6f33b7f88646db5)

14 years agoDEVEL15-windows-doc-man-dependency-20090525
Jeffrey Altman [Tue, 26 May 2009 00:54:06 +0000]
DEVEL15-windows-doc-man-dependency-20090525

LICENSE IPL10

html\index.html not index.html

(cherry picked from commit 4a523957feabf7f5d9f36b7a05c79fd6eccf426e)

14 years agoDEVEL15-windows-cellservdb-lookup-20090525
Jeffrey Altman [Mon, 25 May 2009 23:06:37 +0000]
DEVEL15-windows-cellservdb-lookup-20090525

LICENSE MIT

Add a new Registry distribution method for CellServDB info.

The CellServDB registry schema is as follows:

 HKLM\SOFTWARE\OpenAFS\Client\CellServDB\[cellname]\
   "LinkedCell"    REG_SZ "[cellname]"
   "Description"   REG_SZ "[comment]"
   "ForceDNS"      DWORD  {0,1}

 HKLM\SOFTWARE\OpenAFS\Client\CellServDB\[cellname]\[servername]\
   "HostName"      REG_SZ "[hostname]"
   "IPv4Address"   REG_SZ "[address]"
   "IPv6Address"   REG_SZ "[address]"   <future>
   "Comment"       REG_SZ "[comment]"
   "Rank"          DWORD  "0..65535"
   "Clone"         DWORD  "{0,1}"       <future - server only>
   "vlserver"      DWORD  "7003"        <future>
   "ptserver"      DWORD  ...           <future>

 ForceDNS is implied non-zero if there are no [servername]
 keys under the [cellname] key.  Otherwise, ForceDNS is zero.
 If [servername] keys are specified and none of them evaluate
 to a valid server configuration, the return code is success.
 This prevents failover to the CellServDB file or DNS.

Registry distributed info takes precedence over the CellServDB file.

Registry support has been added to both the Windows specific cm_config
interface and the auth/cellconfig interface utilized by aklog, the
services, and the vast majority of support commands.

Enhance the DNS lookup for Cell vlserver info to support ranking info
which is used with _vlserver._udp SRV record lookups when AFSDB records
are not present.  Priorities become ranks.

(cherry picked from commit 22a932c40a3ecabae8110db21572a4cae2ba1fae)

14 years agoDEVEL15-windows-libafsconf-20090525
Jeffrey Altman [Mon, 25 May 2009 22:31:21 +0000]
DEVEL15-windows-libafsconf-20090525

LICENSE MIT

libafsconf.dll has been present since OpenAFS 1.0.  However,
for some unknown reason the components that it consists of
(cm_dns.obj, cm_config.obj, cm_nls.obj) have been staticly
linked into exes and dlls all over the code base.  This commit
removes all of the static references and replaces them with
libafsconf.lib.

libafsconf.dll is also moved from Client\Program to Common
because it is now linked to by server and utility components.

(cherry picked from commit c8ccb887882bc4affef02a8193e9b1ed01f885f5)

14 years agoDEVEL15-windows-doc-man-makefile-20090525
Jeffrey Altman [Mon, 25 May 2009 21:00:26 +0000]
DEVEL15-windows-doc-man-makefile-20090525

LICENSE IPL10

Add a proper dependency list so that the man-pages are not
rebuilt when no changes have occurred.

(cherry picked from commit d8410b56c895830d609846aec56d61dfd2efb897)

14 years agoDEVEL15-windows-make-version-20090525
Jeffrey Altman [Mon, 25 May 2009 20:57:53 +0000]
DEVEL15-windows-make-version-20090525

LICENSE IPL10

remove space before "KEEP".  older versions of nmake.exe do not like it.

(cherry picked from commit 20460e1391d87bdedbf1b84e233ffd5b926b5df8)

14 years agoDEVEL15-windows-btree-flush-race-20090522
Jeffrey Altman [Fri, 22 May 2009 17:01:21 +0000]
DEVEL15-windows-btree-flush-race-20090522

LICENSE MIT
FIXES 124787

A flush operation on a directory will result in the btree being destroyed.
This can race with on-going operations.  Make sure that the dirlock is held
if the btree is destroyed.  Otherwise, just invalidate the btree version
number.

====================
This delta was composed from multiple commits as part of the CVS->Git migration.
The checkin message with each commit was inconsistent.
The following are the additional commit messages.
====================
LICENSE MIT
FIXES 124787

correct sandbox leakage

(cherry picked from commit a31fd7f70f0049a180e5b02202941d3b1266c1f8)

14 years agoDEVEL15-background-fsync-consistency-issues-20090522
Derrick Brashear [Fri, 22 May 2009 17:00:35 +0000]
DEVEL15-background-fsync-consistency-issues-20090522

LICENSE IPL10
FIXES 124359

avoid either reopening closed vnodes and leaving cached descriptors around,
or discarding a reference we're not holding; instead, sync changes when the
fd is closed, and note such has been done; otherwise, no changes from older
code.

(cherry picked from commit 12e85227c5dbfdb1258718ee3360bffacc4f96ac)

14 years agoDEVEL15-windows-install-wix-vs2008-20090521
Asanka Herath [Thu, 21 May 2009 19:08:34 +0000]
DEVEL15-windows-install-wix-vs2008-20090521

LICENSE MIT

add merge modules for VS2008 RunTime Libraries

(cherry picked from commit 556597af26150041e3b44ec2769ec6c962ab06db)

14 years agoDEVEL15-windows-install-wix-doc-xml-20090521
Jeffrey Altman [Thu, 21 May 2009 19:06:21 +0000]
DEVEL15-windows-install-wix-doc-xml-20090521

LICENSE MIT

replace static html documentation with auto-generated
html help files from doc/xml/... when building en_US
locale.

(cherry picked from commit 32ddb143388bb5d6bbcc1f3afc5860f0566de81c)

14 years agoDEVEL15-doc-xml-version-generation-20090521
Jeffrey Altman [Thu, 21 May 2009 18:52:13 +0000]
DEVEL15-doc-xml-version-generation-20090521

LICENSE MIT

Replace version info in the DocBook files with a new ENTITY "version"
associated with a local "version.xml" file which contain a <revision>
tag for the current release.

The version.xml file should be autogenerated by the Makefile system.

(cherry picked from commit e4b36071ef35b73fb68db6c054e811ba7e6b65e0)

14 years agoDEVEL15-config-mkvers-xml-20090521
Jeffrey Altman [Thu, 21 May 2009 18:26:03 +0000]
DEVEL15-config-mkvers-xml-20090521

LICENSE IPL10

Add a -x option to mkvers.c to permit generation of XML entities containing
a revision tag and <revremark> tags for each delta

Add autogeneration of version.xml to Windows Makefiles

(cherry picked from commit da5794d9caa47e96679c197610bd8ea2a682c338)

14 years agoDEVEL15-windows-install-nsis-20090521
Jeffrey Altman [Thu, 21 May 2009 14:34:17 +0000]
DEVEL15-windows-install-nsis-20090521

LICENSE MIT

Remove old documentation and start menu links before installing
new versions.

No longer install versions from src/WINNT/doc/install/... tree

Install versions from doc/xml/...  Use CHM files when available.

Construct new Start Menu/Program/OpenAFS/Documentation/ menu with
links to individual documents instead of using an index.html
top level link.

(cherry picked from commit 278f8a18305b376e1c764bb38dc0e69ba5b246e5)

14 years agoDEVEL15-windows-make-cygwin-libs-20090520
Asanka Herath [Thu, 21 May 2009 04:26:12 +0000]
DEVEL15-windows-make-cygwin-libs-20090520

LICENSE MIT

added libosi.a and libafsconf.a

(cherry picked from commit 716c81782eae719b43b3b90464b821b398a0f9a6)

14 years agoDEVEL15-windows-make-cygwin-libs-20090519
Asanka Herath [Wed, 20 May 2009 06:03:51 +0000]
DEVEL15-windows-make-cygwin-libs-20090519

LICENSE MIT

Unless NOCYGWIN is defined create cygwin .a import libraries
for each OpenAFS DLL that is constructed.

(cherry picked from commit 4e9bd3bd0ec5977609fd75d681fcc6dbd24a8c6f)

14 years agoDEVEL15-doc-xml-windows-20090519
Jeffrey Altman [Wed, 20 May 2009 05:54:14 +0000]
DEVEL15-doc-xml-windows-20090519

LICENSE IPL10

remove references to xml files no longer in the repository

(cherry picked from commit 85a10ffc9385240818ff9a968f308ac31ee03348)

14 years agoDEVEL15-krb-conf-manpage-path-fix-20090519
Derrick Brashear [Tue, 19 May 2009 19:40:20 +0000]
DEVEL15-krb-conf-manpage-path-fix-20090519

LICENSE IPL10

fix path to krb.conf, per IRC discussion

(cherry picked from commit 6cc155e8da8f505443f43a312a522a64c52515e8)

14 years agoDEVEL15-doc-xml-build-20090518
Russ Allbery [Tue, 19 May 2009 04:59:45 +0000]
DEVEL15-doc-xml-build-20090518

LICENSE MIT

Standardize the UNIX Makefiles for all of the DocBook guides.  Remove the
rest of the generated files and switch to xsltproc and dblatex for the
document generation in all cases.  Fix a few DocBook errors by removing
the contents of the <index> tag and removing the unknown <pubsnumber> tag
in the <revision> field.

(cherry picked from commit 7b56f2ebfc8c2e1695e007798833ad2053e08113)

14 years agoDEVEL15-doc-quick-start-unix-build-20090518
Russ Allbery [Tue, 19 May 2009 04:29:39 +0000]
DEVEL15-doc-quick-start-unix-build-20090518

LICENSE MIT

Use dblatex to build PDF documentation instead of docbook2html and xsltproc
to build HTML instead of docbook2html.  Remove all the index generation
logic, since dblatex and xsltproc handle that automatically.  Remove the
contents of the <index> tag in the source, since neither program requires
there be anything in there.

Remove the style sheets and configuration that were used for docbook2*.

(cherry picked from commit 74585aa5003cfb42103ac8d6059137eebd2005e0)

14 years agoDEVEL15-windows-wix-new-man-pages-20090518
Jeffrey Altman [Tue, 19 May 2009 03:36:33 +0000]
DEVEL15-windows-wix-new-man-pages-20090518

LICENSE MIT
FIXES 124800

pod1/compile_et.pod
pod1/copyauth.pod
pod1/fs_cscpolicy.pod
pod1/fs_getfid.pod
pod1/fs_memdump.pod
pod1/fs_monitor.pod
pod1/fs_rxstatproc.pod
pod1/fs_setcbaddr.pod
pod1/fs_trace.pod
pod8/rmtsysd.pod
pod8/vsys.pod

(cherry picked from commit 8f2a8edb2aec01226d18feae71643e856bbd6470)

14 years agoDEVEL15-man-page-syntax-errors-20090518
Russ Allbery [Tue, 19 May 2009 00:57:08 +0000]
DEVEL15-man-page-syntax-errors-20090518

LICENSE BSD

Fix some man page syntax errors that snuck into the recent round of
updates.

(cherry picked from commit 9ad6c37ccfec016df9e845972ae626a1da19dfbf)

14 years agoDEVEL15-man-page-krb-varients-20090518
Steven Jenkins [Tue, 19 May 2009 00:38:15 +0000]
DEVEL15-man-page-krb-varients-20090518

FIXES 124799
LICENSE IPL10

Install symlinks for the *.krb versions of klog, pagsh, and tokens to the
non-krb versions and add information about the *.krb versions to the
non-krb man pages.

(cherry picked from commit 798ffe54af1f5798bf07947439fc62946bc2f07e)

14 years agoDEVEL15-man-page-cellservdb-updates-20090518
Steven Jenkins [Tue, 19 May 2009 00:35:55 +0000]
DEVEL15-man-page-cellservdb-updates-20090518

FIXES 124794
LICENSE IPL10

Note in CellServDB man page that it's also used to populate root.afs for
a -dynroot client.  Also document the dynamic lookup of database servers
with -afsdb and provide some more information about when CellServDB has to
contain the cell and when it doesn't.

Mark the backup server as optional, and indicate that the authentication
server is deprecated and CellServDB isn't required for authentication if
Kerberos v5 and aklog are used.

(cherry picked from commit 6df60468130977744fea0499fba2351ef74175d8)

14 years agoDEVEL15-man-page-vsys-20090518
Steven Jenkins [Tue, 19 May 2009 00:35:32 +0000]
DEVEL15-man-page-vsys-20090518

LICENSE BSD
FIXES 124793

Add man page for vsys.

(cherry picked from commit 1df9282985949b38313f05640d9afd05948f45c4)

14 years agoDEVEL15-man-page-rmtsysd-20090518
Steven Jenkins [Tue, 19 May 2009 00:34:56 +0000]
DEVEL15-man-page-rmtsysd-20090518

LICENSE IPL10
FIXES 124792

New man page for rmtsysd.

(cherry picked from commit 921774594faead45f9432af218c5f9f394a03204)

14 years agoDEVEL15-man-page-restorevol-20090518
Steven Jenkins [Tue, 19 May 2009 00:34:06 +0000]
DEVEL15-man-page-restorevol-20090518

LICENSE IPL10
FIXES 124791

Add man page for restorevol.

(cherry picked from commit 97b0d230145c4c5f58ef785b11bf2d201ded2d26)

14 years agoDEVEL15-man-page-fs-monitor-20090518
Steven Jenkins [Tue, 19 May 2009 00:33:43 +0000]
DEVEL15-man-page-fs-monitor-20090518

LICENSE IPL10
FIXES 124790

Add man page for fs monitor.

(cherry picked from commit 01ba5ab1ed24d14c1068d5dac951cbea1befba10)

14 years agoDEVEL15-man-page-copyauth-20090518
Steven Jenkins [Tue, 19 May 2009 00:33:25 +0000]
DEVEL15-man-page-copyauth-20090518

FIXES 124789
LICENSE IPL10

Add man page for copyauth.

(cherry picked from commit a7a80efd577d9f2a9573fe35c12ca30b59e2f375)

14 years agoDEVEL15-man-page-compile-et-20090518
Steven Jenkins [Tue, 19 May 2009 00:33:01 +0000]
DEVEL15-man-page-compile-et-20090518

LICENSE IPL10
FIXES 124788

Add man page for compile_et.

(cherry picked from commit 16ec87e0b382bc8bca14ec6a70987f54899eea7f)

14 years agoDEVEL15-man-page-yet-more-fs-commands-20090517
Mike Robinson [Mon, 18 May 2009 04:40:54 +0000]
DEVEL15-man-page-yet-more-fs-commands-20090517

LICENSE IPL10
FIXES 109189

Add new man pages for fs rxstatproc, fs setcbaddr, and fs trace.  Also
updates the links from fs to its subsidiary man pages and fixes the
fs rxstatpeer man page a bit to mirror fs rxstatproc.

(cherry picked from commit faf518ace7c8c0ec9c3269afd267afd276d69cd4)

14 years agoDEVEL15-man-page-more-fs-commands-20090517
Steven Jenkins [Mon, 18 May 2009 04:40:26 +0000]
DEVEL15-man-page-more-fs-commands-20090517

LICENSE IPL10
FIXES 124756

Add man pages for fs cscpolicy, fs getfid, and fs memdump.

(cherry picked from commit 32c93cf55210809de92e81428bff784b07a58d44)

14 years agoDEVEL15-man-pod-fileserver-20090515
Simon Wilkinson [Fri, 15 May 2009 14:30:18 +0000]
DEVEL15-man-pod-fileserver-20090515

LICENSE IPL10
FIXES 124778

-L sets the max number of threads

(cherry picked from commit d5c2efa499fdef6811e40e79a041a43761b3d208)

14 years agoDEVEL15-printf-format-macros-20090515
Jeffrey Altman [Fri, 15 May 2009 13:30:18 +0000]
DEVEL15-printf-format-macros-20090515

LICENSE IPL10
FIXES 124776

The Windows format macro for AFS_INT64_FMT was wrong.
It is "I64" not "l64".

Also added macros for AFS_SIZET_FMT.  Although not currently
in use.  size_t varies in size on Windows just like pointers.

(cherry picked from commit b41d124409589e2890dea60963db4dc158f4d19c)

14 years agoDEVEL15-vol-split-no-nearinode-hint-for-namei-20090514
Derrick Brashear [Thu, 14 May 2009 21:50:53 +0000]
DEVEL15-vol-split-no-nearinode-hint-for-namei-20090514

LICENSE IPL10

nearinode hint makes no sense when you're not using inode fileserver

(cherry picked from commit 1f07c903055c54fb7f0a584e88cfc1c289a161c6)

14 years agoDEVEL15-doc-xml-release-notes-windows-20090514
Jeffrey Altman [Thu, 14 May 2009 18:49:25 +0000]
DEVEL15-doc-xml-release-notes-windows-20090514

LICENSE MIT

Initial take at converting the OpenAFS for Windows Release Notes
to DocBook.

Website style HTML and HtmlHelp (.chm) output is generated.

Formatting of Registry Value descriptions could be improved.

There is no indexing at present.

(cherry picked from commit fb985eefcea791ae16610c210f1ca5408b8ed62f)

14 years agoDEVEL15-cfileopen-cleanup-20090514
Derrick Brashear [Thu, 14 May 2009 05:05:42 +0000]
DEVEL15-cfileopen-cleanup-20090514

LICENSE IPL10

make disconnected work again. also, use static_inline macro consistently

(cherry picked from commit 8a2fcaa8f45c36a80c574a7e903e71041bbd53cc)

14 years agoDEVEL15-doc-xml-20090513
Jeffrey Altman [Thu, 14 May 2009 03:29:07 +0000]
DEVEL15-doc-xml-20090513

LICENSE IPL10
FIXES 124760

Remove generated HTML from the respository

Update XML to support autogeneration of Index files via XSLT

Add graphics referenced by generated HTML output

Add top level index.html used by the docs.openafs.org web site.

Add NTMakefile for AdminGuide, QuickStartUnix, and UserGuide
that utilizes XSLT to generate Windows HTMLHelp (.CHM) and
website appropriate HTML output.

In AdminGuide and UserGuide, relabel the documentation as OpenAFS
instead of IBM AFS.  Create a new revision entry for the OpenAFS
docs.

Incorporate updates to QuickStartUnix Appendix A

RCS file: /cvs/openafs/doc/xml/UserGuide/Attic/a3632.html,v
Working file: doc/xml/UserGuide/a3632.html
head: 1.2
branch:
locks: strict
access list:
keyword substitution: kv
total revisions: 6; selected revisions: 0
description:

RCS file: /cvs/openafs/doc/xml/UserGuide/Attic/a3812.html,v
Working file: doc/xml/UserGuide/a3812.html
head: 1.2
branch:
locks: strict
access list:
keyword substitution: kv
total revisions: 6; selected revisions: 0
description:

RCS file: /cvs/openafs/doc/xml/UserGuide/Attic/book1.html,v
Working file: doc/xml/UserGuide/book1.html
head: 1.2
branch:
locks: strict
access list:
keyword substitution: kv
total revisions: 6; selected revisions: 0
description:

RCS file: /cvs/openafs/doc/xml/UserGuide/Attic/c1095.html,v
Working file: doc/xml/UserGuide/c1095.html
head: 1.2
branch:
locks: strict
access list:
keyword substitution: kv
total revisions: 6; selected revisions: 0
description:

RCS file: /cvs/openafs/doc/xml/UserGuide/Attic/c113.html,v
Working file: doc/xml/UserGuide/c113.html
head: 1.2
branch:
locks: strict
access list:
keyword substitution: kv
total revisions: 6; selected revisions: 0
description:

RCS file: /cvs/openafs/doc/xml/UserGuide/Attic/c1444.html,v
Working file: doc/xml/UserGuide/c1444.html
head: 1.2
branch:
locks: strict
access list:
keyword substitution: kv
total revisions: 6; selected revisions: 0
description:

RCS file: /cvs/openafs/doc/xml/UserGuide/Attic/c2454.html,v
Working file: doc/xml/UserGuide/c2454.html
head: 1.2
branch:
locks: strict
access list:
keyword substitution: kv
total revisions: 6; selected revisions: 0
description:

RCS file: /cvs/openafs/doc/xml/UserGuide/Attic/c3402.html,v
Working file: doc/xml/UserGuide/c3402.html
head: 1.2
branch:
locks: strict
access list:
keyword substitution: kv
total revisions: 6; selected revisions: 0
description:

RCS file: /cvs/openafs/doc/xml/UserGuide/Attic/c569.html,v
Working file: doc/xml/UserGuide/c569.html
head: 1.2
branch:
locks: strict
access list:
keyword substitution: kv
total revisions: 6; selected revisions: 0
description:

RCS file: /cvs/openafs/doc/xml/UserGuide/Attic/f24.html,v
Working file: doc/xml/UserGuide/f24.html
head: 1.2
branch:
locks: strict
access list:
keyword substitution: kv
total revisions: 6; selected revisions: 0
description:

RCS file: /cvs/openafs/doc/xml/UserGuide/Attic/g4153.html,v
Working file: doc/xml/UserGuide/g4153.html
head: 1.2
branch:
locks: strict
access list:
keyword substitution: kv
total revisions: 6; selected revisions: 0
description:

RCS file: /cvs/openafs/doc/xml/UserGuide/Attic/i4608.html,v
Working file: doc/xml/UserGuide/i4608.html
head: 1.2
branch:
locks: strict
access list:
keyword substitution: kv
total revisions: 6; selected revisions: 0
description:

====================
This delta was composed from multiple commits as part of the CVS->Git migration.
The checkin message with each commit was inconsistent.
The following are the additional commit messages.
====================
LICENSE IPL10
FIXES 124760

Remove generated HTML from the respository

Update XML to support autogeneration of Index files via XSLT

Add graphics referenced by generated HTML output

Add top level index.html used by the docs.openafs.org web site.

Add NTMakefile for AdminGuide, QuickStartUnix, and UserGuide
that utilizes XSLT to generate Windows HTMLHelp (.CHM) and
website appropriate HTML output.

In AdminGuide and UserGuide, relabel the documentation as OpenAFS
instead of IBM AFS.  Create a new revision entry for the OpenAFS
docs.

Incorporate updates to QuickStartUnix Appendix A

(cherry picked from commit 9e8e080a5c1281dfa6109700cacd13cd1c44f5ef)

14 years agoDEVEL15-ukernel-use-fsblkcnt-20090513
Derrick Brashear [Wed, 13 May 2009 22:35:08 +0000]
DEVEL15-ukernel-use-fsblkcnt-20090513

LICENSE IPL10
FIXES 124681

blkcnt_t doesn't exist on fbsd, macos 10.3, and isn't really the right type.
this is the right type, but also can be missing. test appropriately.

(cherry picked from commit 070f02923cfa4e01ccb754928cdd4d02bec48720)

14 years agoDEVEL15-mmap-antirecursion-port-to-head-20090513
Marc Dionne [Wed, 13 May 2009 21:41:36 +0000]
DEVEL15-mmap-antirecursion-port-to-head-20090513

LICENSE IPL10
FIXES 124770

deal correctly with the structure reorg which took place

(cherry picked from commit 2c0bf1c881f34554472982df2b74c50c4eeb7dcd)

14 years agoDEVEL15-pts-encrypt-option-20090512
Derrick Brashear [Tue, 12 May 2009 20:40:32 +0000]
DEVEL15-pts-encrypt-option-20090512

LICENSE IPL10
FIXES 124681

add -encrypt flag to pts generic options, allowing the wire to be
encrypted if desired and the user's authenticated. document same.

(cherry picked from commit 6ba44802ea6cf722c22a4784cbbad70ed6f5d60a)

14 years agoDEVEL15-linux-mmap-antirecursion-fix-20090512
Felix Frank [Tue, 12 May 2009 18:56:40 +0000]
DEVEL15-linux-mmap-antirecursion-fix-20090512

LICENSE IPL10
FIXES 124627

fix the mmap anti-recursion protection to set and mask CPageWrite appropriately
and with the correct lock protection. this leaves us with an issue to handle
when the mmap'd file is larger (possibly considerably larger) than the
cache

(cherry picked from commit 5e0e1ea2540d0cb7d7274350eb1fadfd41733ea4)

14 years agoDEVEL15-freebsd-kauth-sig-t-20090512
Matt Benjamin [Tue, 12 May 2009 18:19:09 +0000]
DEVEL15-freebsd-kauth-sig-t-20090512

LICENSE IPL10
FIXES 124569

define the old signal type as sig_t on freebsd (e.g. everywhere we prototype as
sig_t)

(cherry picked from commit 3b6bf1a05730b6383d1cef4516b94a63e802521b)

14 years agoDEVEL15-rxdebug-print-values-unsigned-20090512
Rainer Toebbicke [Tue, 12 May 2009 18:12:30 +0000]
DEVEL15-rxdebug-print-values-unsigned-20090512

LICENSE IPL10
FIXES 124563

for the values which are unsigned, use %u, not %d

(cherry picked from commit b967654434f4d24b50dbc96e0296d2c632f76ea3)

14 years agoDEVEL15-redhat-use-postinit-in-initscript-20090512
Anders Kaseorg [Tue, 12 May 2009 17:58:37 +0000]
DEVEL15-redhat-use-postinit-in-initscript-20090512

LICENSE IPL10
FIXES 124552

if a postinit script is defined, use it

(cherry picked from commit eb9fff14c7be1b15369c6d1a44426c1c7c82c92e)

14 years agoDEVEL15-memcache-write-on-laststore-20090512
Felix Frank [Tue, 12 May 2009 17:42:37 +0000]
DEVEL15-memcache-write-on-laststore-20090512

LICENSE IPL10
FIXES 124671

write back dirty pages on last store for memcache, lest we end up
unintentionally discarding the changes.

(cherry picked from commit 214ce7c8b488e90301e9f604b6ecc625b7000e62)

14 years agoDEVEL15-tests-generate-dirpath-in-makefile-20090512
Steven Jenkins [Tue, 12 May 2009 17:23:04 +0000]
DEVEL15-tests-generate-dirpath-in-makefile-20090512

LICENSE IPL10
FIXES 124715

fix rmcell to not have hardcoded paths; instead, generate a dirpath shell
script from makefile and use that

(cherry picked from commit c6adb0d2f32f8e8f3974b8ea3049601bf01d6877)

14 years agoDEVEL15-tests-no-dirpath-infile-20090512
Steven Jenkins [Tue, 12 May 2009 14:06:24 +0000]
DEVEL15-tests-no-dirpath-infile-20090512

LICENSE IPL10
FIXES 124716

Dirpath.pm.in is no longer needed

(cherry picked from commit c39f38d8c6703a9d1b9967a1bf0901db35e19267)

14 years agoDEVEL15-openbsd-44-45-20090512
Matt Benjamin [Tue, 12 May 2009 14:02:58 +0000]
DEVEL15-openbsd-44-45-20090512

LICENSE IPL10
FIXES 124719

add missing osi_free backend, missing param file, modify soreceive for 4.5

(cherry picked from commit 4b9283a30db0c3aee943c94573b412f24894d366)

14 years agoDEVEL15-windows-dcache-store-data-20090511
Jeffrey Altman [Mon, 11 May 2009 17:22:35 +0000]
DEVEL15-windows-dcache-store-data-20090511

LICENSE MIT

The windows dcache module synchronizes store data operations in
order to prevent multiple simultaneous store data operations against
the same file at the same time by multiple threads.  This is performed
using cm_SyncOp(CM_SCACHESYNC_STOREDATA_EXCL).  However, cm_SetupStoreBIOD()
was being processed prior to the synchronization.  As a result a dirty
buffer could be added to two BIOD lists resulting in the same buffer
contents being written to the file server twice.

This patch moves the cm_SetupStoreBIOD() into the synchronization region.
It also adds a new 'locked' parameter to cm_ReleaseBIOD() that indicates
whether or not the cm_scache_t object is locked when called.  This
permits fewer lock state changes to be used in several cases.

(cherry picked from commit 947213da0ee6a0d805f0fc5eaeec0202d0bbffa4)

14 years agoDEVEL15-xml-docbook-documentation-first-pass-20060915
Chas Williams [Mon, 11 May 2009 16:12:58 +0000]
DEVEL15-xml-docbook-documentation-first-pass-20060915

needs more massaging to make it fit the tree, but, get it here first

(cherry picked from commit 52557c982e1ed65c694c5c1387ac2b385356438d)

14 years agoDEVEL15-linux26-defer-cred-changing-20090511
Simon Wilkinson [Mon, 11 May 2009 15:55:02 +0000]
DEVEL15-linux26-defer-cred-changing-20090511

LICENSE IPL10
FIXES 124737

Newer Linux kernels differentiate between the real and effective
credentials of a process, and prevent a process's credentials from being
change when the effective credentials have been set to a different value.
When AFS notices a keyring PAG exists but no group-based PAG does, the
attempt to rectify this, if done in a VFS call (which changes effective creds)
triggers this issue. We defer the change to the groups to avoid it.

(cherry picked from commit 7d530b9080f6dd4d7f7e4555ed6ce855ff81bcaa)

14 years agoDEVEL15-windows-hard-and-idle-dead-timeouts-20090511
Jeffrey Altman [Mon, 11 May 2009 15:16:32 +0000]
DEVEL15-windows-hard-and-idle-dead-timeouts-20090511

LICENSE MIT

Fix conditional test that assigns value to idleDeadTimeout

Modify event log message to indicate timeout could be either a
hard or an idle timeout.

As described in the source comments, do not retry on a hard or
idle timeout.

(cherry picked from commit f5a97a145e09a16a9b2d3ab485f33f520235b7e9)

14 years agoDEVEL15-windows-fs-getfid-20090511
Jeffrey Altman [Mon, 11 May 2009 15:04:52 +0000]
DEVEL15-windows-fs-getfid-20090511

LICENSE MIT

Implement "fs getfid +<path> [-literal]" on Windows.
Same as the first line of output as "fs examine ...".

(cherry picked from commit 5520747790b599bc10013dc78efb81b5d50a3f52)

14 years agoDEVEL15-linux-fh-based-cache-20090511
Marc Dionne [Mon, 11 May 2009 14:40:23 +0000]
DEVEL15-linux-fh-based-cache-20090511

LICENSE IPL10
FIXES 123620

rework previous fh-based cache support. now allows use of
arbitrarily large file handles, and build correctly for UKERNEL.

we now just use this if there's no iget, instead of providing a configure
switch.

because this relies on the somewhat invasive patch from 124184 it is not
currently pulled up to 1.4.x

(cherry picked from commit 326ffcc108e1db32fa2071b66ac9dbf2321ae71d)

14 years agoDEVEL15-abstract-cache-inode-ops-20090511
Simon Wilkinson [Mon, 11 May 2009 14:28:04 +0000]
DEVEL15-abstract-cache-inode-ops-20090511

LICENSE IPL10
FIXES 124184

previous versions had abstract functions for linux (use_fh) and osx/solaris
(cache_vnode_path) cache file access, which was contributing to code bloat

switch to a union for disk/memory cache objects, and provide functions to
convert these into something appropriate for each system

(cherry picked from commit 8747236d54742c1c2fb8788c1f6aee4e657b3e89)

14 years agoDEVEL15-windows-fs-path-in-afs-20090507
Jeffrey Altman [Thu, 7 May 2009 16:03:07 +0000]
DEVEL15-windows-fs-path-in-afs-20090507

LICENSE MIT

Switch the PathInAfs test to use VIOCGETFID instead of VIOC_GET_CELL_NAME
so that the literal option can be used.

(cherry picked from commit fd0f1f49f27b5f92547a0d15e23efd3b2e46376d)

14 years agoDEVEL15-windows-shellext-path-in-afs-20090507
Jeffrey Altman [Thu, 7 May 2009 15:53:25 +0000]
DEVEL15-windows-shellext-path-in-afs-20090507

LICENSE MIT
FIXES 124742

Change the PathInAfs test to use VIOCGETFID instead of VIOC_GET_CELL_NAME.
VIOCGETFID permits a literal test of the specified object.   This is needed
for testing the validity of a symlink to a msdfs: or non-existent path.
Otherwise, the AFS Shell Extension context menu will not be displayed.

(cherry picked from commit 621719905806a5883be5a17ca1af0d1929b874e3)

14 years agoDEVEL15-man-pages-allow-dots-consistent-20090505
Derrick Brashear [Tue, 5 May 2009 13:30:34 +0000]
DEVEL15-man-pages-allow-dots-consistent-20090505

LICENSE IPL10

make all server man pages list -allow-dotted-principals (rather than
-allow-dotted-principal)

(cherry picked from commit c8ac7d1c499150b3f82a6566e9bbdb7478ddd469)

14 years agoDEVEL15-dafs-vol-offline-20090428
Mike Meffie [Tue, 28 Apr 2009 15:37:51 +0000]
DEVEL15-dafs-vol-offline-20090428

LICENSE IPL10
FIXES 124582

fix a logic error in the dafs vos offline support

(cherry picked from commit 5958aa0c4b0a9279a918cda1f37cb7e6c5666d44)

14 years agoDEVEL15-windows-smb-disable-loopback-check-20090427
Jeffrey Altman [Tue, 28 Apr 2009 00:37:26 +0000]
DEVEL15-windows-smb-disable-loopback-check-20090427

LICENSE MIT

Now that BackConnectionHostNames can be set each time the smb listener
threads are stopped and restarted, we need to make sure that we do not
clear the DisableLoopbackCheck value if it was set during the same
service session because BackConnectionHostName value changes only take
effect on a reboot.

(cherry picked from commit c4006edf4022e4f80cda5afd427d43997299c890)

14 years agoDEVEL15-rename-residency-from-mrafs-to-osd-20090427
Steven Jenkins [Tue, 28 Apr 2009 00:04:29 +0000]
DEVEL15-rename-residency-from-mrafs-to-osd-20090427

LICENSE IPL10
FIXES 124130

rename mrafs commands into their equivalent osd versions; structures etc are the
 same.

(cherry picked from commit 8655541d1eb6ea7d935f50d9256e12bf90db5045)

14 years agoDEVEL15-vos-reveal-hidden-cmds-20090427
Jeffrey Altman [Mon, 27 Apr 2009 21:18:12 +0000]
DEVEL15-vos-reveal-hidden-cmds-20090427

LICENSE IPL10

vos hides "online", "offline", "delentry -noexecute", and "addsite -valid".
All of these are currently documented in the man pages without warning.
Reveal them.

(cherry picked from commit 4836fd1e374c30b5e3be72e73b3dbd21c0c98548)

14 years agoDEVEL15-dprintf-rename-20090427
Simon Wilkinson [Mon, 27 Apr 2009 20:17:25 +0000]
DEVEL15-dprintf-rename-20090427

LICENSE IPL10
FIXES 124657

make dprintf be afs_dprintf to fix for fedora 11 and probably others

(cherry picked from commit 2f5ac61b0a8775c58536ee954f2208ab88d0b225)

14 years agoDEVEL15-netinfo-fake-address-text-20090427
Jason Edgecombe [Mon, 27 Apr 2009 19:37:34 +0000]
DEVEL15-netinfo-fake-address-text-20090427

LICENSE IPL10
FIXES 124699

explain fake address support for NetInfo files

(cherry picked from commit 758366c26a0d1b2e97449ab858e15da8cc0d73f0)

14 years agoDEVEL15-dragonfly-bsd-userland-20090427
Matt Benjamin [Mon, 27 Apr 2009 19:31:52 +0000]
DEVEL15-dragonfly-bsd-userland-20090427

LICENSE IPL10
FIXES 124702

add support for dragonflyBSD's userland

(cherry picked from commit 25f13f38064bf38ed89332b38c53c740475db87d)

15 years agoDEVEL15-linux-2-6-30-support-for-head-20090407
Marc Dionne [Tue, 7 Apr 2009 17:16:59 +0000]
DEVEL15-linux-2-6-30-support-for-head-20090407

LICENSE IPL10
FIXES 124592

make proc dir entry owner field only be initialized when it exists

(cherry picked from commit aea52af634dd20c1cff1a6347ac24770ae727328)

15 years agoDEVEL15-windows-smb-registry-config-20090407
Jeffrey Altman [Tue, 7 Apr 2009 15:05:44 +0000]
DEVEL15-windows-smb-registry-config-20090407

LICENSE MIT

Move configureBackConnectionHostNames() to smb_StartListeners()
so that when the NetbiosName changes while the service is running
the new values can be set.

Add configureExtendedSMBSessionTimeouts() which configures new
SMB functionality added in a Win2003 post-SP2 hot fix.

(cherry picked from commit b4b61821081d809bb3a737f9e23964f4f99b3c58)

15 years agoDEVEL15-linux-avoid-returning-invalid-pointers-on-error-20090402 openafs-devel-1_5_59
Simon Wilkinson [Tue, 7 Apr 2009 13:25:52 +0000]
DEVEL15-linux-avoid-returning-invalid-pointers-on-error-20090402

LICENSE IPL10
FIXES 124580

avoid returning a positive error as it will look like a pointer.

15 years agoDEVEL15-openafs-1-5-59-20090406
Derrick Brashear [Mon, 6 Apr 2009 23:57:09 +0000]
DEVEL15-openafs-1-5-59-20090406

LICENSE IPL10

make 1.5.59

15 years agoDEVEL15-avoid-buffer-overflow-on-rx-fixed-size-array-return-20090402
Simon Wilkinson [Mon, 6 Apr 2009 23:53:02 +0000]
DEVEL15-avoid-buffer-overflow-on-rx-fixed-size-array-return-20090402

LICENSE IPL10
FIXES 124579

avoid potentially writing beyond allocated memory if a return is larger than expected

(cherry picked from commit 62bca1123fb471ca1eec58b448fd39f7f797638a)

15 years agoDEVEL15-linux-avoid-returning-invalid-pointers-on-error-20090402
Simon Wilkinson [Mon, 6 Apr 2009 23:50:32 +0000]
DEVEL15-linux-avoid-returning-invalid-pointers-on-error-20090402

LICENSE IPL10
FIXES 124580

avoid returning a positive error as it will look like a pointer.

15 years agoDEVEL15-windows-pioctl-subst-unc-20090407
Jeffrey Altman [Mon, 6 Apr 2009 22:47:59 +0000]
DEVEL15-windows-pioctl-subst-unc-20090407

LICENSE MIT

Add code to support determining if a drive substitution refers to
a UNC path.

(cherry picked from commit 9a0b3da255032f177dfedb650c7a0b65cff24fba)

15 years agoDEVEL15-windows-smb-trace-20090406
Jeffrey Altman [Mon, 6 Apr 2009 18:25:16 +0000]
DEVEL15-windows-smb-trace-20090406

LICENSE MIT

include the correct function name in a
trace message

(cherry picked from commit aad7a2c5858a94672db6c23f508e404e236e4142)

15 years agoDEVEL15-windows-release-notes-20090406
Jeffrey Altman [Mon, 6 Apr 2009 18:20:52 +0000]
DEVEL15-windows-release-notes-20090406

LICENSE MIT

1.5.59

15 years agoDEVEL15-windows-version-20090406
Jeffrey Altman [Mon, 6 Apr 2009 18:17:32 +0000]
DEVEL15-windows-version-20090406

LICENSE MIT

1.5.59 == 1.5.5900.0

15 years agoDEVEL15-windows-notes-20090406
Jeffrey Altman [Mon, 6 Apr 2009 18:15:12 +0000]
DEVEL15-windows-notes-20090406

LICENSE MIT

1.5.59

15 years agoDEVEL15-windows-test-torture-stack-overflow-20090405
Jeffrey Altman [Sun, 5 Apr 2009 13:54:40 +0000]
DEVEL15-windows-test-torture-stack-overflow-20090405

LICENSE MIT

avoid stack overflow.

(cherry picked from commit ac199c845e6771c627dfb5e7efc0cdd8c5356df9)

15 years agoDEVEL15-windows-tests-torture-20090405
Jeffrey Altman [Sun, 5 Apr 2009 06:25:20 +0000]
DEVEL15-windows-tests-torture-20090405

LICENSE MIT

replace the VOLSTAT online test with the PATH_AVAILABILITY
online test.  We do not care of the volume is offline on the file
server if the cache manager has current data to serve.

(cherry picked from commit 59945d1cb5f14baf9ab0008990079e1dde9a796d)

15 years agoDEVEL15-windows-smb-error-map-20090404
Jeffrey Altman [Sat, 4 Apr 2009 21:16:36 +0000]
DEVEL15-windows-smb-error-map-20090404

LICENSE MIT

For CM_ERROR_BADSHARENAME return BAD_NETWORK_PATH instead
of BAD_NETWORK_NAME.  The latter refers to the server name
and the former to the share name.   Returning BAD_NETWORK_NAME
will causes the smb redirector to break its connection to \\AFS.

For CM_ERROR_ALLOFFLINE and CM_ERROR_ALLDOWN return PATH_NOT_FOUND
instead of BAD_NETWORK_PATH.  We don't want the smb redirector
to tear down all open files just because some volume in the path
is inaccessible at the moment.

(cherry picked from commit ffe04f710b41120f1bbd843c73ee2d95bc179d9c)

15 years agoDEVEL15-linux-key-alloc-no-pointer-arith-20090404
Simon Wilkinson [Sat, 4 Apr 2009 17:44:02 +0000]
DEVEL15-linux-key-alloc-no-pointer-arith-20090404

LICENSE IPL10

make the key_alloc configure test work

(cherry picked from commit 4ecaeaac97a48c36df3866f1f71eb8a95c8f6e51)

15 years agoDEVEL15-windows-afsd-no-more-ods-20090402
Jeffrey Altman [Fri, 3 Apr 2009 03:57:13 +0000]
DEVEL15-windows-afsd-no-more-ods-20090402

LICENSE MIT

Any use of OutputDebugString() in production can result in serious
delays in the execution of the thread that issues the call.  Remove
the last of the unprotected calls within afsd_service.

(cherry picked from commit f6b4902daeb731eb01de44464476cb0a3edb26b1)

15 years agoDEVEL15-windows-rx-xmit-20090402
Jeffrey Altman [Thu, 2 Apr 2009 08:45:00 +0000]
DEVEL15-windows-rx-xmit-20090402

LICENSE IPL10

permit compilation with Windows SDK v6.0/6.1 which hides
previously exposed XP symbols unless _WINNT_WIN32 is at
least 0x0501

(cherry picked from commit fc408da993e753d33336ab408167383a75ed97f0)

15 years agoDEVEL15-windows-src-makefile-two-20090402
Jeffrey Altman [Thu, 2 Apr 2009 08:41:50 +0000]
DEVEL15-windows-src-makefile-two-20090402

LICENSE MIT

get the i386 case right

(cherry picked from commit 0700567eef0c52b1b8892454b72c5123fe0514b1)

15 years agoDEVEL15-windows-src-makefile-20090402
Jeffrey Altman [Thu, 2 Apr 2009 06:06:54 +0000]
DEVEL15-windows-src-makefile-20090402

LICENSE MIT

remove extraneous echo command output

do not attempt to build NSIS target on non-x86 platforms
since support is not implemented

(cherry picked from commit 27aedf7a2cfb04f49b6b8f3c9cabc3d6cdb91c78)

15 years agoDEVEL15-windows-config-clean-20090402
Jeffrey Altman [Thu, 2 Apr 2009 06:04:57 +0000]
DEVEL15-windows-config-clean-20090402

LICENSE MIT

permit "nmake -f ntmakefile clean" to complete on a
clean source tree.

(cherry picked from commit 8673c0de48140b8cd148bf3ea47094968ffbda8b)

15 years agoDEVEL15-windows-install-loopback-20090401
Asanka Herath [Wed, 1 Apr 2009 23:56:29 +0000]
DEVEL15-windows-install-loopback-20090401

LICENSE MIT

Define INCLUDE variable and reorder binary link order
to ensure compatibility with latest WDK/SDK combinations.

(cherry picked from commit d86247619136d3080eb6be08fd8c077bc2afc68b)

15 years agoDEVEL15-windows-talocale-20090401
Jeffrey Altman [Wed, 1 Apr 2009 18:36:39 +0000]
DEVEL15-windows-talocale-20090401

LICENSE MIT

perform proper casting to avoid a warning

(cherry picked from commit d8a8bfb5c3b49980135b9da26082fa668640ec0f)

15 years agoDEVEL15-windows-afsd-smb-logging-20090401
Jeffrey Altman [Wed, 1 Apr 2009 18:30:37 +0000]
DEVEL15-windows-afsd-smb-logging-20090401

LICENSE MIT

Add more info about the smb request to the log entry
that is written to afsd_init.log if the request took
longer than 45 seconds to complete.

(cherry picked from commit 520fef4278bd43073782e1c75f67900f96fa6ddf)

15 years agoDEVEL15-windows-afsd-priority-class-20090401
Jeffrey Altman [Wed, 1 Apr 2009 18:29:24 +0000]
DEVEL15-windows-afsd-priority-class-20090401

LICENSE MIT

Change the default priority class for afsd_service.exe to High.
This matches the priority class assigned to other system processes
that generate requests to afsd_service.exe.

Permit the ..\TransarcAFSDaemon\Parameters "PriorityClass"
registry value to be used to change the default.

(cherry picked from commit 37f582326c1c5d5363a988f7038af0b62d0fb3ea)

15 years agoDEVEL15-windows-afsd-xdr-free-20090401
Jeffrey Altman [Wed, 1 Apr 2009 17:39:08 +0000]
DEVEL15-windows-afsd-xdr-free-20090401

LICENSE MIT

make use of xdr_free() to release memory allocated within afsrpc.dll.
this prevents crashes when the library is built with a different
runtime library version than the application.

fix signed/unsigned warnings in the same code snippet

(cherry picked from commit 3d81394f9106b187c28e35328676e11b662025c6)

15 years agoDEVEL15-xdr-free-20090401
Jeffrey Altman [Wed, 1 Apr 2009 17:38:13 +0000]
DEVEL15-xdr-free-20090401

LICENSE MIT

add xdr_free() and export it from afsrpc.dll.  This permits applications
to free memory allocated within the xdr routines with the same run time
library memory management routines as was used to allocate it.

This is necessary on Windows to prevent memory corruption.

VL_GetAddrsU() is an example where a xdr array is allocated in the
library and must be freed by the application.

(cherry picked from commit d7749751df230d919188546106b61bd2dbb8974c)

15 years agoDEVEL15-dynamic-vcache-no-printf-20090331
Derrick Brashear [Tue, 31 Mar 2009 13:41:37 +0000]
DEVEL15-dynamic-vcache-no-printf-20090331

LICENSE IPL10

no printf in 1.4.9

(cherry picked from commit 84871adb4bb3f8d1d50127255da75629e2167977)

15 years agoDEVEL15-linux-2630-maybe-20090331
Marc Dionne [Tue, 31 Mar 2009 13:16:30 +0000]
DEVEL15-linux-2630-maybe-20090331

LICENSE IPL10
FIXES 124560

hopefully support 2.6.30 when it's released

(cherry picked from commit d0a166bdffce2d2498cab54cc458d9489d05c299)

15 years agoDEVEL15-windows-version-20090329
Jeffrey Altman [Sun, 29 Mar 2009 18:16:07 +0000]
DEVEL15-windows-version-20090329

LICENSE MIT

1.5.58

15 years agoDEVEL15-windows-release-notes-20090329
Jeffrey Altman [Sun, 29 Mar 2009 18:13:04 +0000]
DEVEL15-windows-release-notes-20090329

LICENSE MIT

1.5.58

15 years agoDEVEL15-windows-notes-20090329
Jeffrey Altman [Sun, 29 Mar 2009 18:09:10 +0000]
DEVEL15-windows-notes-20090329

LICENSE MIT

1.5.58

15 years agoDEVEL15-windows-afsd-log-smb-mid-20090328
Jeffrey Altman [Sat, 28 Mar 2009 23:26:17 +0000]
DEVEL15-windows-afsd-log-smb-mid-20090328

LICENSE MIT

For each SMB transation log the 'mid' field of the smb packet.
The 'mid' field can be used as a reference against the mrxsmb request
logging for debugging purposes.

(cherry picked from commit 07c187c84384635413e6353dc9913a8826f25bb5)

15 years agoDEVEL15-windows-remove-reset-all-vcs-event-20090328
Jeffrey Altman [Sat, 28 Mar 2009 23:17:44 +0000]
DEVEL15-windows-remove-reset-all-vcs-event-20090328

LICENSE MIT

remove the smb reset all VCs message.  duplicates the
reportSessionStartups functionality.

(cherry picked from commit 4bc36a697fffe78cc0ec93cb9cf98772aeadfcb6)

15 years agoDEVEL15-windows-afsd-symlink-20090327
Jeffrey Altman [Fri, 27 Mar 2009 17:58:19 +0000]
DEVEL15-windows-afsd-symlink-20090327

LICENSE MIT

Increase max symlink limit to 64 and remove the repeated fid
recursion test.  Breaks too many things.

(cherry picked from commit 27609fe288eb20f30e1f17a709a07468a74372eb)