openafs.git
8 years agoviced: AFSDisk, AFSFetchVolumeStatus Int31 PartSize openafs-stable-1_4_12_1
Jeffrey Altman [Tue, 3 Apr 2012 02:35:41 +0000]
viced: AFSDisk, AFSFetchVolumeStatus Int31 PartSize

The AFSDisk and AFSFetchVolumeStatus structures use signed
32-bit integers for representation partition size and
available blocks.  RoundInt64ToInt31() should be used instead
of RoundInt64ToInt32() when assigning their values.

(cherry picked from commit e8f6dfac59fe042a04a9ac5eb3c37356cb3a22a3)
Reviewed-on: http://gerrit.openafs.org/7022
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>

Change-Id: I81f2f120c0080b1d680fa362372e54dd3af1f3f6
Reviewed-on: http://gerrit.openafs.org/7025
Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>

8 years agoopenafs 1.4.15
Derrick Brashear [Sun, 27 Nov 2011 15:32:24 +0000]
openafs 1.4.15

make 1.4.15 release

Change-Id: I6968c67cdafd3c18b5a213c28a7f8e9f49ee3d04
Reviewed-on: http://gerrit.openafs.org/6125
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>

8 years agoafs: Remove afs1_readdir
Andrew Deason [Thu, 29 Sep 2011 17:04:07 +0000]
afs: Remove afs1_readdir

The function afs1_readdir is not referenced anywhere. Remove it, as it
currently causes compilation errors (a typo with the
origOffset/orginOffset variable name).

This is a 1.6/1.4-only change. afs1_readdir was removed on master as a
part of commit 0284e65f97861e888d95576f22a93cd681813c39.

Reviewed-on: http://gerrit.openafs.org/5522
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit 1cf667e0df61651538bef9b7b89f1ec98acfe6c3)

Change-Id: I5fdc6617dcee40d3860dc9e419dbf4c7143c65e8
Reviewed-on: http://gerrit.openafs.org/5781
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>

8 years agodir: Protect against circular hash chains
Simon Wilkinson [Fri, 15 Apr 2011 18:40:45 +0000]
dir: Protect against circular hash chains

The dir package didn't protect against circular hash chains when
performing directory lookups. A corrupt directory could therefore
cause a client or a fileserver to go into an endless loop if that
directory contained a loop in its hash chain pointers.

Fix this by exiting the lookup if the hash chain has more elements
than the total number of entries in a directory. This maximum number
of entries is taken as being (number of entries per page) * (max
number of pages), which is considerably more than the real maximum
value.

Reviewed-on: http://gerrit.openafs.org/5618
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit 796581621861264a8cfb978cd749546de73825f1)

Change-Id: If812ee59b143ca62d1a539e6428febce9915fcc5
Reviewed-on: http://gerrit.openafs.org/5747
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>

8 years agolibafs/dir: Verify directory pathnames
Simon Wilkinson [Sat, 16 Jul 2011 22:30:59 +0000]
libafs/dir: Verify directory pathnames

Provide a new routine, GetVerifiedBlob() which will ensure that the
pathname contained within a directory blob is correctly terminated
before returning it to the caller. For the purposes of this function,
correct termination is defined as having a terminating \0 character
within the same directory page as the blob itself.

Reviewed-on: http://gerrit.openafs.org/5617
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit 988e51520429195955921bb53a71974a0cdff0a8)

Change-Id: Ifb17d22a79b0b05a7dc209a8686b05225a4aefb0
Reviewed-on: http://gerrit.openafs.org/5746
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>

9 years agomake 1.4.14.1
Derrick Brashear [Tue, 3 May 2011 12:49:14 +0000]
make 1.4.14.1

update configure version strings for 1.4.14.1. note that macos kext
can be of form XXXX.YY[.ZZ[(d|a|b|fc)NNN]] where d dev, a alpha,
b beta, f final candidate so we have no way to represent 1.4.14.1.
switch to 1.4.15 dev 1 for macos.

Change-Id: I955a54fd44a411989b5eea2521f82909621f14cd
Reviewed-on: http://gerrit.openafs.org/4619
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

9 years agoSOLARIS: Perform daemon syscalls as kernel threads
Andrew Deason [Mon, 2 May 2011 22:23:23 +0000]
SOLARIS: Perform daemon syscalls as kernel threads

Add AFS_SUN5_ENV to the list of platforms where AFS_DAEMONOP_ENV is
defined. Implement the necessary functionality so we spawn kernel
threads when a daemon syscall is called. Remove the rxk_Listener
wrapper, since it will be called in a separate thread via the
afs_DaemonOp interface.

Reviewed-on: http://gerrit.openafs.org/4189
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit e261238470ed28ee7c1068d914de171b34033e09)

Change-Id: Ic6e116673caf8cfaf5c894a5ab9d9383bdaa3b0f
Reviewed-on: http://gerrit.openafs.org/4610
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

9 years agolibafs: Consolidate afs_DaemonOp code
Andrew Deason [Tue, 8 Mar 2011 21:37:17 +0000]
libafs: Consolidate afs_DaemonOp code

Create the AFS_DAEMONOP_ENV define to simplify the logic of when we
perform afs_DaemonOp-y code paths. Also create the daemonOp_common
function, to perform common pre-fork operations that are common
between platforms.

Reviewed-on: http://gerrit.openafs.org/4188
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 6143bb27d20380e689346b4e66c077e5d4cd6061)

Change-Id: Id44385334e8dd0485f6250c9e4c2a8d7337cf211
Reviewed-on: http://gerrit.openafs.org/4609
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

9 years agolibafs: Indent afs_call.c ifdef maze
Andrew Deason [Tue, 8 Mar 2011 20:59:44 +0000]
libafs: Indent afs_call.c ifdef maze

Reviewed-on: http://gerrit.openafs.org/4187
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 05241a59a1ce88d2f25d75127124971c55e1f677)

Change-Id: Ied0c7273fe02d56eb01571682721ead58f02f2b0
Reviewed-on: http://gerrit.openafs.org/4608
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

9 years agoFix cherry-pick of “linux: 2.6.38: New d_op handling”
Anders Kaseorg [Sun, 1 May 2011 03:35:02 +0000]
Fix cherry-pick of “linux: 2.6.38: New d_op handling”

Conflicts in this cherry-pick (http://gerrit.openafs.org/4041) were
resolved incorrectly.  The correct resolution of
"""
 <<<<<<< HEAD
 ||||||| parent of 0d95e6b... linux: 2.6.38: New d_op handling
 #if defined(AFS_LINUX26_ENV)
 =======

 #if defined(STRUCT_SUPER_BLOCK_HAS_S_D_OP)
     sb->s_d_op = &afs_dentry_operations;
 #endif

 #if defined(AFS_LINUX26_ENV)
 >>>>>>> 0d95e6b... linux: 2.6.38: New d_op handling
"""
is
"""

 #if defined(STRUCT_SUPER_BLOCK_HAS_S_D_OP)
     sb->s_d_op = &afs_dentry_operations;
 #endif

"""
and not
"""

 #if defined(STRUCT_SUPER_BLOCK_HAS_S_D_OP)
     sb->s_d_op = &afs_dentry_operations;
 #endif

 #if defined(AFS_LINUX26_ENV)
"""

As usual, it’s impossible to tell the difference in the default
conflict style, so I urge everyone reading this to run

git config --global merge.conflictstyle diff3

Change-Id: I09fb77b2f1d80beda7b81fa1f40f663117dae920
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-on: http://gerrit.openafs.org/4596
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>

9 years agoSolaris: stop NetIfPoller on shutdown
Andrew Deason [Wed, 12 May 2010 18:59:06 +0000]
Solaris: stop NetIfPoller on shutdown

The NetIfPoller code that is enabled on AFS_SUN510_ENV never gets
shutdown properly. The current code looks as if it was intended for
NetIfPoller to recognize the appropriate termState and just return,
but we never wait for it, and so we can complete the shutdown sequence
without NetIfPoller ever knowing that we are shutting down. This can
cause the machine to panic, as we keep attempting to run NetIfPoller
even after libafs has been unloaded.

Since NetIfPoller is fired by default every 30 seconds, we probably do
not want to wait for it to fire during shutdown. Instead, just destroy
the necessary timeout and task queue, which will wait for NetIfPoller
to complete if running, and will just prevent it from running in the
future otherwise.

Reviewed-on: http://gerrit.openafs.org/1957
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 9562721b89a2a7a7f32a165762d7fba8540006a9)

Change-Id: Ida24a406958cdafa54bdda954c34a05ef4e7e459
Reviewed-on: http://gerrit.openafs.org/3589
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-on: http://gerrit.openafs.org/4045
Tested-by: Derrick Brashear <shadow@dementia.org>

9 years agoLinux: 2.6.38: dentry->d_count is not an atomic
Marc Dionne [Thu, 3 Feb 2011 02:55:27 +0000]
Linux: 2.6.38: dentry->d_count is not an atomic

d_count is now an int protected by the dentry's d_lock.
Take the lock when we use it, instead of using an atomic_*
function.

Reviewed-on: http://gerrit.openafs.org/3883
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 281f5bf5fbb0a546edcce62ef4e097ae9bbdbf73)

Change-Id: Id6b17d9cfe18d348a66df02f6b309fc53b00da86
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-on: http://gerrit.openafs.org/3999
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Russ Allbery <rra@stanford.edu>
Reviewed-on: http://gerrit.openafs.org/4044
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

9 years agoLinux: 2.6.38: deal with dcache_lock removal
Marc Dionne [Sat, 29 Jan 2011 01:59:17 +0000]
Linux: 2.6.38: deal with dcache_lock removal

dcache_lock is gone in 2.6.38, and some of the vfs locking rules
have changed.

Of interest for openafs:
- inode->i_lock protects the d_alias list
- dentry->d_lock protects d_unhashed()

Add a new configure test for dcache_lock, and replace its use by
the appropriate new lock(s).

Reviewed-on: http://gerrit.openafs.org/3771
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 2eca7aef7b2940e4ef5f9901ce28481af6edb6dd)

Change-Id: Ie405bb1e40cca4ba83bca3e051e2ab54b8850ac6
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-on: http://gerrit.openafs.org/3998
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Russ Allbery <rra@stanford.edu>
Reviewed-on: http://gerrit.openafs.org/4043
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

9 years agolinux: 2.6.38: Make d_revalidate RCU-walk aware
Marc Dionne [Tue, 25 Jan 2011 23:18:56 +0000]
linux: 2.6.38: Make d_revalidate RCU-walk aware

Signal to the vfs that we don't support path RCU walk in
d_revalidate.  It will call back in non-RCU mode.

Reviewed-on: http://gerrit.openafs.org/3759
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 52556d50298e4a636f07e9a3cf0b6557c882c82d)

Change-Id: Id346ca87a1a064ab7d66140156cb8eb48a888566
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-on: http://gerrit.openafs.org/3995
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Russ Allbery <rra@stanford.edu>
Reviewed-on: http://gerrit.openafs.org/4042
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

9 years agolinux: 2.6.38: New d_op handling
Marc Dionne [Tue, 25 Jan 2011 22:17:21 +0000]
linux: 2.6.38: New d_op handling

In 2.6.38, the super block structure has a new field to hold the
default dentry ops.  The vfs will automatically set it for new
dentries in most cases.

Set s_d_op to our set of operations, and omit setting the dentry
ops where the vfs will already do it (and where new locking rules
prohibit it).

Reviewed-on: http://gerrit.openafs.org/3758
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 08bb83d95027bb3ac68834d12b72bdc647fa24a9)

Change-Id: Ia808d6bcd119f3999a1805b1d31678f5a3ba3d55
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-on: http://gerrit.openafs.org/3994
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Russ Allbery <rra@stanford.edu>
Reviewed-on: http://gerrit.openafs.org/4041
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

9 years agoLinux: 2.6.38: Adjust for permission inode operation changes
Marc Dionne [Sat, 29 Jan 2011 00:41:32 +0000]
Linux: 2.6.38: Adjust for permission inode operation changes

The permission i_op has a new signature with a flags argument, and
must now deal with RCU path walking.
- Fix existing configure test for this i_op, it succeeds when it
shouldn't
- Add a new configure test for the new signature
- Make our permission i_op "RCU-walk aware" - return ECHILD if
called in that mode

Reviewed-on: http://gerrit.openafs.org/3770
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 5bcc0ea735ea519298c98b46c66bf1326cdee5e4)

Change-Id: I38db16f0f62500f46fad9c92d045ccfa6cfe1c38
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-on: http://gerrit.openafs.org/3997
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Russ Allbery <rra@stanford.edu>
Reviewed-on: http://gerrit.openafs.org/4040
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

9 years agoLinux: allow compile flags to be passed to AC_CHECK_LINUX_BUILD
Marc Dionne [Sat, 29 Jan 2011 00:03:39 +0000]
Linux: allow compile flags to be passed to AC_CHECK_LINUX_BUILD

Some linux autoconf tests require particular compile flags such as
-Werror.  Add a parameter to the AC_CHECK_LINUX_BUILD macro that
lets the caller pass in any needed special flags.

Reviewed-on: http://gerrit.openafs.org/3769
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit ca38c9546e323b59189670b80740510fb9ec5269)

Change-Id: If4daa7b1202e30046d22bda5eca6b191130945ea
[andersk@mit.edu: Remove modifications of existing tests]
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-on: http://gerrit.openafs.org/3996
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Russ Allbery <rra@stanford.edu>
Reviewed-on: http://gerrit.openafs.org/4039
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

9 years agoLinux: Add general autoconf macro for Linux kernel
Simon Wilkinson [Tue, 27 Apr 2010 16:41:22 +0000]
Linux: Add general autoconf macro for Linux kernel

Add AC_CHECK_LINUX_BUILD() to do a standardised Linux build, which
takes a "checking" message, the autoconf variable to use to cache
the results, headers and code to run, preprocessor variable to
define, and a description of that variable.

Reviewed-on: http://gerrit.openafs.org/1854
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit a89d6b029d059d01b8bbfc18b9ee6e3f5a964b85)

Change-Id: I75c5efbf69b54e0f0b1aedcb157992e13c6a8aa7
[andersk@mit.edu: Remove reimplementation of existing check macros]
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-on: http://gerrit.openafs.org/3993
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Russ Allbery <rra@stanford.edu>
Reviewed-on: http://gerrit.openafs.org/4038
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

9 years agoLinux: Add autoconf macro for structure checks
Simon Wilkinson [Tue, 27 Apr 2010 12:02:20 +0000]
Linux: Add autoconf macro for structure checks

Add a new autoconf macro for doing structure element checks.

Reviewed-on: http://gerrit.openafs.org/1853
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 02f2c7cb3734d44dc90b77d631909373daefacd3)

Change-Id: Id7768128e058805baf8d44f2610f3345b25ac973
[andersk@mit.edu: Remove modifications of existing structure checks]
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-on: http://gerrit.openafs.org/3992
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Russ Allbery <rra@stanford.edu>
Reviewed-on: http://gerrit.openafs.org/4037
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

9 years agoSolaris: Don't access lbolt directly
Simon Wilkinson [Tue, 22 Dec 2009 21:46:43 +0000]
Solaris: Don't access lbolt directly

Recent changes in OpenSolaris have removed the 'lbolt' variable.
However, the ddi_get_lbolt accessor (which has been present since
Solaris 10) can be used to get access to the same value. So, use it.

Reviewed-on: http://gerrit.openafs.org/1022
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 2c0a9ab3c361ade9218c2f458d86165de8eadc76)

Change-Id: Id02601f081bc2cd6e42358422a175c842041ad08
Reviewed-on: http://gerrit.openafs.org/4032
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-on: http://gerrit.openafs.org/4036
Tested-by: Derrick Brashear <shadow@dementia.org>

9 years agoRemoved kpasswd from openafs-file-list
Jonathan Billings [Wed, 30 Jun 2010 19:09:39 +0000]
Removed kpasswd from openafs-file-list

The executable %{_bindir}/kpasswd was included in the
the 'openafs' base package.

This change removes the kpasswd executable from the base package.  It
is still built and is installed in the 'openafs-kpasswd' package.  I
believe this was the original intent of the 'openafs-kpasswd' package.

Reviewed-on: http://gerrit.openafs.org/2305
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit b54c7ceefe884b57db76c929940afdfee86472e8)

Change-Id: I9153aedd35551382101a6e9d7ed4e1e54382d442
Reviewed-on: http://gerrit.openafs.org/3753
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jonathan Billings <jsbillin@umich.edu>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-on: http://gerrit.openafs.org/4035
Tested-by: Derrick Brashear <shadow@dementia.org>

9 years agoopenafs 1.4.14 openafs-stable-1_4_14
Derrick Brashear [Fri, 17 Dec 2010 14:36:04 +0000]
openafs 1.4.14

perhaps 14 is luckier than 13. sigh.

Change-Id: I07d7308cf31f0706e37494d6e421df55126c595b
Reviewed-on: http://gerrit.openafs.org/3540
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

9 years agoLinux: use DEFINE_MUTEX for afs_linux_alloc_sem on newer kernels
Alejandro R. Sedeño [Fri, 5 Nov 2010 21:24:43 +0000]
Linux: use DEFINE_MUTEX for afs_linux_alloc_sem on newer kernels

DECLARE_MUTEX is gone as of 2.6.37; afs_global_lock switches from
DECLARE_MUTEX to DEFINE_MUTEX at 2.6.16, so do the same here.

(cherry picked from commit f9409fcdffa594aff9530038a5ac81a2495da3b6)
Signed-off-by: Alejandro R. Sedeño <asedeno@mit.edu>
Reviewed-on: http://gerrit.openafs.org/3273
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

Change-Id: I3d72f56db7ebaf40f1cdcdbf9f73783cb9d71676
Reviewed-on: http://gerrit.openafs.org/3539
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

9 years agoLINUX: Use correct type of error in flock code openafs-stable-1_4_13
Simon Wilkinson [Wed, 11 Aug 2010 16:25:36 +0000]
LINUX: Use correct type of error in flock code

The flock code gets a kernel error code from afs_posix_lock_file()
but then passes this error code through afs_convert_code (which sees
that it is already negative, and returns EIO). Instead, we should just
return afs_posix_lock_file()'s code direct to our caller.

Reviewed-on: http://gerrit.openafs.org/2534
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 5abe706a7e237d3872db3638d947a14c935370d5)
Change-Id: I8e12c9804cc81c8c88f820f55abd4ce863525c9a
Reviewed-on: http://gerrit.openafs.org/3533

9 years agoupdate ticket5 from heimdal
Derrick Brashear [Wed, 30 Jun 2010 19:35:38 +0000]
update ticket5 from heimdal

includes updated instructions for updating.
note that gen_glue.c in lib/asn1 has a bug which omits
a needed newline in the "const struct units * asn1_%s_units(void);",
line.

FIXES 127554

Reviewed-on: http://gerrit.openafs.org/2306
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 582878a75858a341f674f833609f08b6d3bf839a)

Change-Id: I8a7eefb19d353469376a799614005245aeb91b1f
Reviewed-on: http://gerrit.openafs.org/3522
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

9 years agomake openafs 1.4.13
Derrick Brashear [Tue, 14 Dec 2010 17:54:05 +0000]
make openafs 1.4.13

update versions for openafs 1.4.13

Change-Id: Ifdaa32de6896afc9efa9b05da10182a737ce1f0e
Reviewed-on: http://gerrit.openafs.org/3531
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

9 years agoLinux: define llseek operations
Marc Dionne [Fri, 5 Nov 2010 21:30:02 +0000]
Linux: define llseek operations

With kernel 2.6.37 it is now mandatory to define the llseek operation
for files and directories.  If these are not defined, no_llseek is
called, and any attempt to seek returns ESPIPE.

Most file systems use generic_file_llseek, but it seems safer to use
default_llseek which is what the vfs used to call for us by default.
In 2.6.37 these two functions are actually functionally identical.

Reviewed-on: http://gerrit.openafs.org/3292
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: BuildBot <buildbot@rampaginggeek.com>

(cherry-picked from commit fb6b22cf77039962f22f462ee602f0e4a8153817)

Reviewed-on: http://gerrit.openafs.org/3512
Tested-by: Marc Dionne <marc.c.dionne@gmail.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit d0e31ec418555354ac30516269a9748ee01fc36f)
Change-Id: If90a5ac65a9ccd1d1301884065e9583ad25f5af4
Reviewed-on: http://gerrit.openafs.org/3527

9 years agoCellServDB update 13 Dec 2010
GCO Public CellServDB [Mon, 13 Dec 2010 16:02:18 +0000]
CellServDB update 13 Dec 2010

Reviewed-on: http://gerrit.openafs.org/3505
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Change-Id: I6c27922b7877041d5f74751aa06fad469d5e92cd
Reviewed-on: http://gerrit.openafs.org/3526
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

9 years agoLinux: fix statfs configure test
Marc Dionne [Wed, 13 Oct 2010 23:11:25 +0000]
Linux: fix statfs configure test

The change to the statfs configure test that was made for 2.6.36
broke the test for older kernels.  The new test is based on a call,
and that will generate a warning but not an error when the arguments
don't match the prototype.

Take another tack, and revert to the old style test, but with the
simple_statfs function instead of vfs_statfs.

Reviewed-on: http://gerrit.openafs.org/2975
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
(cherry picked from commit 59927e20052c3f075e0269e46691bc94c3974f86)

Change-Id: Iaee4e3d62ce95c33539ba57c19ddc916b097deb2
Reviewed-on: http://gerrit.openafs.org/3521
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

9 years agoLinux: 2.6.35 - fsync no longer takes a dentry
Marc Dionne [Fri, 28 May 2010 21:48:12 +0000]
Linux: 2.6.35 - fsync no longer takes a dentry

In 2.6.35, the fsync file operations drops the dentry argument.
Add a configure test and cope.

Reviewed-on: http://gerrit.openafs.org/2064
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Tested-by: Derrick Brashear <shadow@dementia.org>

(cherry-picked from commit 4d89ce0a89e9b9e2709e6f6d730f245b5bce744b)

Reviewed-on: http://gerrit.openafs.org/2549
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 58bffd741cdc917f164f19b4621aa2567e6a5b3e)
Change-Id: Ibeb609a57003fc863568e4fc619db9746aa9462f
Reviewed-on: http://gerrit.openafs.org/3520
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>

9 years agoLinux: adapt to truncate sequence changes
Marc Dionne [Wed, 11 Aug 2010 22:20:59 +0000]
Linux: adapt to truncate sequence changes

As part of changes to the truncate sequence, inode_setattr() no
longer exists, and all filesystems have to define the setattr op
so we can assume that it is not NULL.

Introduce a compat inline function afs_inode_setattr that hides
the tests and the different versions from the main code.

Note that the existing test for the inode_setattr() return type
will fail, but the value is no longer used in that case.

This is required for 2.6.36

Reviewed-on: http://gerrit.openafs.org/2543
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

(cherry-picked from commit eaf3378f537935f6b9843886b43d)

Reviewed-on: http://gerrit.openafs.org/2550
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 58e56d080b8d19117b60f04ecb37af0c6dcafc1a)

Change-Id: I4cfdd191c60d7672c80aa3b3789e52c3e5e87666
Reviewed-on: http://gerrit.openafs.org/3519
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

9 years agoLinux: use %pI4 if NIPQUAD is not available
Marc Dionne [Wed, 11 Aug 2010 21:18:32 +0000]
Linux: use %pI4 if NIPQUAD is not available

The definition of NIPQUAD has been removed from the kernel headers
in the mainline kernel.  Replace it by using the %pI4 format
specifier which takes the IP address as a single argument.

There should be no change in the output.

This fix is required for 2.6.36.

Reviewed-on: http://gerrit.openafs.org/2542
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

(cherry-picked from commit d4018b2673e6532543984838290ffb891b970fea)

Reviewed-on: http://gerrit.openafs.org/2551
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit e2e8881db7757ccac5ce3d5fc5603c40c5b47a43)
Change-Id: I1bbe4f8f24f18d29fb6af98fc6e6f4707def547f
Reviewed-on: http://gerrit.openafs.org/3518
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>

9 years agoLinux: switch to evict_inode
Marc Dionne [Wed, 11 Aug 2010 22:55:29 +0000]
Linux: switch to evict_inode

In 2.6.36, the delete_inode and clear_inode inode operations
are replaced by evict_inode.
Rename our current clear_inode to evict_inode, and add a few
things that were previously handled by the generic delete_inode.

This is required for 2.6.36.

Reviewed-on: http://gerrit.openafs.org/2544
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

(cherry-picked from commit fb01fbd7cd2d396df8a4605eaad9febc52ef3b61)

Reviewed-on: http://gerrit.openafs.org/2552
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit e05b5937201ec313d2c8fa863f4dacec87ab687d)
Change-Id: I42a22dbea4f880f5c8bb1cd0904f1711b3a48292
Reviewed-on: http://gerrit.openafs.org/3517
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>

9 years agoLinux: Rework statfs super block operations configure test
Marc Dionne [Wed, 11 Aug 2010 23:28:53 +0000]
Linux: Rework statfs super block operations configure test

The configure test to detect if the statfs super block operation
needs a dentry argument is based on vfs_statfs, and assumes that
its signature matches the one of the operation.  In 2.6.36 this is
no longer true and the test fails.

Rework the test to actually test the operation we're interested in.

This change is required for 2.6.36.

Reviewed-on: http://gerrit.openafs.org/2545
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

(cherry-picked from commit 08552ad8a94f7cc5908aabe8385711e09a6418e4)

Reviewed-on: http://gerrit.openafs.org/2553
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit b8b708fc416aa281fe1d1ce1d498cc381c81679c)
Change-Id: Ib40de2018ecec5e3c82d8fa829364c31d29526b4
Reviewed-on: http://gerrit.openafs.org/3516
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>

9 years agoLinux: RedHat packaging updates for RHEL6
Simon Wilkinson [Thu, 22 Apr 2010 16:56:25 +0000]
Linux: RedHat packaging updates for RHEL6

Update our bundled spec file and related tools so they can be used
to build OpenAFS on the RHEL6 beta.

- Make kmodtool recognise el6 as having "modern" kernel naming
  conventions
- Replace %{PACKAGE_VERSION} (which seems to have disappeared)
  with the standard %{version} macro

Thanks to billings and phalenor on IRC for their testing efforts.

Reviewed-on: http://gerrit.openafs.org/1806
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 0d0e7699c9f789214205fe6837cded1a4c95f9c0)

Reviewed-on: http://gerrit.openafs.org/2638
Tested-by: Andrew Deason <adeason@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 41040638e23be43e260f79a4694df528244ef38b)
Change-Id: Ia2d1d1c377d7df0a4e7bdd22ac5f86c7253ffa66
Reviewed-on: http://gerrit.openafs.org/3515
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>

9 years agoRedHat: Find krb5-config in /usr/bin
Andrew Deason [Wed, 1 Sep 2010 16:18:56 +0000]
RedHat: Find krb5-config in /usr/bin

In RHEL6, krb5-config is no longer in /usr/kerberos/bin/, but is in
just /usr/bin/. So, try to use /usr/bin/krb5-config if we cannot find
/usr/kerberos/bin/krb5-config and krb5config was not specified.

This is a 1.4-only change, as the 'configure' on more modern branches
should have the ability to find krb5-config automatically.

Reviewed-on: http://gerrit.openafs.org/2646
Tested-by: Andrew Deason <adeason@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit c2eba9d57adc79b05165fc8aebaf751ea89282f5)
Change-Id: I46c6f0e3d7c2ce427eacfbb82366a7da3156d9bd
Reviewed-on: http://gerrit.openafs.org/3514
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>

10 years agomake openafs 1.4.12.1 openafs-stable-1_4_12_1
Derrick Brashear [Mon, 24 May 2010 18:45:16 +0000]
make openafs 1.4.12.1

update configure scripts with new version number

Change-Id: I3d75cdd481369aaaaaa3de343c70360a6e20847a

10 years agoMove non-executable stack assembly code to end of file
Russ Allbery [Mon, 22 Mar 2010 19:42:48 +0000]
Move non-executable stack assembly code to end of file

The non-executable stack annotation used for Linux works by adding
an additional section to the generated object.  The annotation added
in 9bfd03d723a9cf17673f40513a7adde1d503bcbc was added to the beginning
of each assembly file.  This caused build failures on Linux s390
because the remainder of the assembly code was then put in that
section, which was discarded during linking.

Add the annotation to the end of each assembly file instead, following
the instructions at:

    http://www.gentoo.org/proj/en/hardened/gnu-stack.xml

Change-Id: I5bd2d8d0ac31932b59757dcec0a942c459d61cac
Reviewed-on: http://gerrit.openafs.org/1615
Tested-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 9dbe48ac2d14742d2acefb9cb4138b810a1a128e)

10 years agofix other oldtvix typo
Derrick Brashear [Mon, 26 Apr 2010 04:21:30 +0000]
fix other oldtvix typo

i failed to push this to commit 0dac8f93af5262472bc5bdf94dbb605a24da59d0,
and so, well, here's the real fix. sorry.

Change-Id: I6799ecb207f246ac3e4c48b1de55268d2fba4d23
Reviewed-on: http://gerrit.openafs.org/1837
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

(cherry-picked from commit 51c1eb362da866e28a9fb9a6f5d9d412aac7e8c2)

Change-Id: If42f31b47d50aecb147fa82040a6c3ab48f7a7ce
Reviewed-on: http://gerrit.openafs.org/2009
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

10 years agoInitialize oldvtix
Marc Dionne [Thu, 22 Apr 2010 21:22:37 +0000]
Initialize oldvtix

Initialize the variable to avoid compiler complaints that it
could be used uninitialized.  Use a sentinel value and issue
a warning if we try to use the variable and we haven't set
it to a useful value.

Change-Id: I037be2ad8e0b55d06b50aafdeca5012764640f16
Reviewed-on: http://gerrit.openafs.org/1810
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

(cherry-picked from commit 0dac8f93af5262472bc5bdf94dbb605a24da59d0)

Change-Id: I3311ad5a73e21f7fb44f9dcf0cda251bae96eb0f
Reviewed-on: http://gerrit.openafs.org/2008
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

10 years agoRecover from afs_GetVolSlot errors
Andrew Deason [Wed, 21 Apr 2010 17:41:21 +0000]
Recover from afs_GetVolSlot errors

afs_GetVolSlot can panic in a few different ways, such as failing to
read from or write to VolumeInfo. Instead of panic'ing, return an
error to the application. Adjust callers to deal with getting a NULL
volume returned.

Based on a patch by Mike Meffie.

Change-Id: Ibb301fed795ee9ee5906b8e7973945a06218b8f1
Reviewed-on: http://gerrit.openafs.org/1801
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

(cherry-picked from commit 80f05473428969ff71d1791cda8cb09d30223724)

Change-Id: Ie89034cb0fcc8f92868f338996d62edfe150b1b2
Reviewed-on: http://gerrit.openafs.org/2004
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

10 years agoLinux: replace invalidate_inode_pages
Marc Dionne [Fri, 5 Mar 2010 22:54:42 +0000]
Linux: replace invalidate_inode_pages

This helper has been deprecated for a while, and gets removed
with 2.6.34.
Replace it with invalidate_remote_inode, which has been around for
all of 2.6's life, according to Chaskiel in RT #124377.

Change-Id: I8658b454e1c997c041f654ba55d06f713ea25459
Reviewed-on: http://gerrit.openafs.org/1523
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 80481fb14ea9301b0f6b3503d07ecaef39aef0d8)
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-on: http://gerrit.openafs.org/1988

10 years agomacos 32 bit platform user address transform
Derrick Brashear [Fri, 2 Apr 2010 05:29:22 +0000]
macos 32 bit platform user address transform

make the ioctl32 translator work as expected, e.g., create
proper user addresses.

Change-Id: Ia690dee5f9978d679e942a9954f2123df4a96bc2
Reviewed-on: http://gerrit.openafs.org/1687
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit ec74299c7c0f6e705e6ba2329001b92f9941868e)

10 years agoremove fc_test from normal build openafs-stable-1_4_12
Derrick Brashear [Mon, 8 Mar 2010 17:27:28 +0000]
remove fc_test from normal build

1.5 deals with this differently. for now, don't build fc_test (rx needs
libsys so it can deal with network config from userspace; the sys/rxkad
dependancies are circular if so. so, no)

Change-Id: I4936fd610d9346aa78665664e76a2023783d6654
Reviewed-on: http://gerrit.openafs.org/1536
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

10 years agoopenafs 1.4.12
Derrick Brashear [Mon, 8 Mar 2010 16:46:41 +0000]
openafs 1.4.12

make 1.4.12 changes for versioning

Change-Id: I528ab7b9f6de85eed4e3fb053e7dc7cc7d0986fc
Reviewed-on: http://gerrit.openafs.org/1535
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

10 years agoBegin support for OpenBSD 4.7
Antoine Verheijen [Wed, 3 Mar 2010 18:57:29 +0000]
Begin support for OpenBSD 4.7

Add config param header and sysname number for OpenBSD 4.7 (currently
in beta).

Change-Id: I6537bd352becd9a8c3937e95f79911c8bc08bcfb
Reviewed-on: http://gerrit.openafs.org/1533
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 7aca59c2f6c8097fbc0cafab18fe4cdfe28e89c2)
Change-Id: I8cc317cf6cf64e72323da0efcb402a43802df9a8
Reviewed-on: http://gerrit.openafs.org/1510

10 years agoOpenBSD: eliminate use of VREF() macro
Antoine Verheijen [Sun, 7 Mar 2010 19:50:06 +0000]
OpenBSD: eliminate use of VREF() macro

OpenBSD 4.7 (currently in beta) removes the (dummy) VREF() macro from the
system header files. For at least as far back as OpenBSD 3.6, all this
macro does is expand to a call to a system routine by the same name in
lower case. This patch therefore replaces the single OpenBSD use of
VREF() with a direct call to the routine to which it expanded.

Change-Id: I44888ed1ba7ba8e7150202798def10bed2ab3158
Reviewed-on: http://gerrit.openafs.org/1532
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit a31bbd3123dd7bd5c0f73c1bcd89548d489930a8)
Change-Id: I442d5e9cfa9bd7f5886692c0afcbb3d220d0ca5b
Reviewed-on: http://gerrit.openafs.org/1509

10 years agodarwin afshelper fix startup check
Derrick Brashear [Thu, 4 Mar 2010 19:16:04 +0000]
darwin afshelper fix startup check

make the launchd check run as root without whining about passwords
repeatedly

Change-Id: Ib4bac7c9ddf1837a8e86bf17a8a66b6ba1247272
Reviewed-on: http://gerrit.openafs.org/1511
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 08aec0182a888f38fa50ca4e1dbd9ed83e022a2a)
Reviewed-on: http://gerrit.openafs.org/1516

10 years agocorrect cred mgmt typo
Derrick Brashear [Fri, 5 Mar 2010 01:27:15 +0000]
correct cred mgmt typo

crfree is not crfee

Change-Id: I28de28f8b93220a694272898ef02185e749e8d49
Reviewed-on: http://gerrit.openafs.org/1515
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

10 years agoremove the force.. comments
Derrick Brashear [Wed, 3 Mar 2010 16:25:18 +0000]
remove the force.. comments

we're not c++; don't use c++ comments.

Change-Id: I4bb68c61bacefe41c6fd367fd6f0dadb0bc64886
Reviewed-on: http://gerrit.openafs.org/1508
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

10 years agoLinux: bdi doesn't always have a name
Simon Wilkinson [Thu, 18 Feb 2010 23:09:40 +0000]
Linux: bdi doesn't always have a name

The 'name' element of the backing_dev_info structure is new in
2.6.32 - add yet another configure test, and #ifdef to protect our
setting of it.

Change-Id: I0a3e411e571e05771619381bf621d299482c695b
Reviewed-on: http://gerrit.openafs.org/1341
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit a9951410e1cb1a713f9d26a24d6b3cf485f94ac6)
Reviewed-on: http://gerrit.openafs.org/1498
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>

10 years agolinux bdi allocate memory
Derrick Brashear [Tue, 16 Feb 2010 18:10:09 +0000]
linux bdi allocate memory

allocate bdi with osi_Alloc (and free with osi_Free)
seems to fix an oops

FIXES 126514

Change-Id: I667391710c5fd2b6712117471247f1cd7c20aa9b
Reviewed-on: http://gerrit.openafs.org/1332
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 8f1e1199a2ef65ac0c5f00dcb30aeb8114c95551)
Reviewed-on: http://gerrit.openafs.org/1497

10 years agoOSXPreferencePane
Claudio Bisegni [Mon, 1 Mar 2010 19:41:48 +0000]
OSXPreferencePane
checkAfsStatusForStartup method modification for search /afs volume for determinate if afs is on has been transfered into checkAfsStatus. checkAfsStatusForStartup method is used to check when afs start axitn system startup. Anyway these are only workaround we must use osx api or afs api to make this job.

Change-Id: If9be5a91418eccc0c58a69b566af140d619d3057
Reviewed-on: http://gerrit.openafs.org/1492
Reviewed-by: Claudio Bisegni <Claudio.Bisegni@lnf.infn.it>
Tested-by: Claudio Bisegni <Claudio.Bisegni@lnf.infn.it>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit b7b51cb22c56cb7304a9d6c9c9b12eaaa470db49)
Reviewed-on: http://gerrit.openafs.org/1494

10 years agomacos prefs pane more reliable running indicator
Derrick Brashear [Sun, 28 Feb 2010 01:09:42 +0000]
macos prefs pane more reliable running indicator

instead of grepping ps output, look for AFS in df output. not
happy with this either but it's way more reliable.

Change-Id: I73ff53bc1cc24c9484011a870546b6334ff66b49
Reviewed-on: http://gerrit.openafs.org/1410
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit f0ce809181d19e865817200dab4fb8370bceeb59)
Reviewed-on: http://gerrit.openafs.org/1493

10 years agomacos prefs pane krb5 auth setup
Derrick Brashear [Sat, 27 Feb 2010 22:48:19 +0000]
macos prefs pane krb5 auth setup

when we configure krb5-at-login, don't inadvertantly reorder the list.
replace inline.

FIXES 126628

Change-Id: I23de38dadeae6a01d6f97d84e7bb6d9e75e99510
Reviewed-on: http://gerrit.openafs.org/1408
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-on: http://gerrit.openafs.org/1409

10 years agoadd libsys.a to rxkad Makefile
Chaz Chandler [Thu, 25 Feb 2010 22:54:18 +0000]
add libsys.a to rxkad Makefile

IRIX needs libsys for afs_syscall, added to fc_test_LIBS to avoid
compilation error

Change-Id: Ic6db560c5a03af871663216a47e3898b94e776f3
Reviewed-on: http://gerrit.openafs.org/1400
Reviewed-by: Chaz Chandler
Tested-by: Chaz Chandler
Reviewed-by: Derrick Brashear <shadow@dementia.org>

10 years agoFix (p)install of compile_et (addendum)
Antoine Verheijen [Thu, 25 Feb 2010 08:54:30 +0000]
Fix (p)install of compile_et (addendum)

A prior update (ChangeID: Ie6af2d3fd9c5166dd2d884c22d287c180b24fab1)
stops compile_et from being (p)installed into a separate directory.
Unfortunately, there's a second rule in the Makefile exhibiting the
same behaviour that was missed (the decision of which rule is used is
determined by whether a 'make install' or 'make dest' is requested).
This patch fixes the second ruleset as well.

Change-Id: I0e94d5cf0bb4e46a24fba6e77aa6baff2118f78b
Reviewed-on: http://gerrit.openafs.org/1397
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

10 years agomake openafs 1.4.12pre4 openafs-stable-1_4_12pre4
Derrick Brashear [Thu, 25 Feb 2010 04:42:07 +0000]
make openafs 1.4.12pre4

make version strings for 1.4.12pre4

Change-Id: Ie81809c622ed0b59d67b3e58e07b60b4f5a41ff4
Reviewed-on: http://gerrit.openafs.org/1394
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

10 years agoremove dropbox attribute leak fix
Derrick Brashear [Wed, 24 Feb 2010 16:20:51 +0000]
remove dropbox attribute leak fix

change 6ec18461649d3e4f44b2476f886bcc480c456500, avoid leaking stat info,
appears to have side effects on at least macos, crashing the system
coreservicesd. revoke the change until the exact behavior we want is
better understood.

(cherry picked from commit 142883cae8de203822c8be4f975e691b57be2834)

Change-Id: Id3a03e7b3982abb3947c9b3d1baa46c828169cdb
Reviewed-on: http://gerrit.openafs.org/1389
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

10 years agoLinux: Fix conversion of whole-file locks
Anders Kaseorg [Sun, 21 Feb 2010 01:28:42 +0000]
Linux: Fix conversion of whole-file locks

An overflow bug in commit 49b7bbdd3b45df694fadbef48f9ed99d9bfe07b9
caused whole-file locks to be treated as byte-range locks, which fail
to be propagated to other machines.

Fix this by setting l_len = 0 for locks that range to the end of the
file.

FIXES 126561

Change-Id: Ie2dc9d04f33559c73b3b86b64152c549b785f8ad
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-on: http://gerrit.openafs.org/1352
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit d3abbebcb0651c5d2c7a3094270fd4f86bea3c1e)
Reviewed-on: http://gerrit.openafs.org/1372

10 years agoLinux: autoconf.h is moving in 2.6.33
Anders Kaseorg [Sat, 20 Feb 2010 18:36:22 +0000]
Linux: autoconf.h is moving in 2.6.33

In 2.6.33, <linux/autoconf.h> is moving to <generated/autoconf.h>.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Change-Id: Ib97031728b89cf8e17581f3c425216ae4b5538ec
Reviewed-on: http://gerrit.openafs.org/1351
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Tested-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 91e50aa81bdeecbdf351088b3b5510fe3c8e848e)
Reviewed-on: http://gerrit.openafs.org/1375
Tested-by: Derrick Brashear <shadow@dementia.org>

10 years agoLinux: Use kbuild to check for UML
Anders Kaseorg [Sat, 20 Feb 2010 18:28:59 +0000]
Linux: Use kbuild to check for UML

<linux/autoconf.h> is automatically included by kbuild; you aren’t
supposed to include it directly.  That breaks in 2.6.33 because
<linux/autoconf.h> is moving to <generated/autoconf.h>.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Change-Id: I56c90dfe90ef72408620793fcd4e927ea3d8f468
Reviewed-on: http://gerrit.openafs.org/1350
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 660c7a3952f36fc892e12aa6b11eda3295b1416d)
Reviewed-on: http://gerrit.openafs.org/1374

10 years agoCheck for HOSTDELETED before h_Hold_r
Andrew Deason [Fri, 12 Feb 2010 23:44:31 +0000]
Check for HOSTDELETED before h_Hold_r

A few places h_Hold_r a host and later drop and reacquire H_LOCK without
checking if the hostFlags contains HOSTDELETED. This can cause a race
with h_TossStuff_r where we later reference a host that is about to be
freed or already has been freed.

Add checks for HOSTDELETED in these places, and skip over the deleted
hosts.

FIXES 126454

Reviewed-on: http://gerrit.openafs.org/1305
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit b8c3c6add90ea3face9a16ff04a1024be3d8f32d)

Change-Id: I9e67465b3dac6db8626fee03823ed63a680beaad
Reviewed-on: http://gerrit.openafs.org/1366
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

10 years agoCorrect the h_Enumerate_r hostList safety check
Andrew Deason [Fri, 12 Feb 2010 22:30:44 +0000]
Correct the h_Enumerate_r hostList safety check

Ide1e5aca7c2c4a4af3f62bc07821db694f2f9999 added safety checks for a few
traversals through hostList, including the traversal in h_Enumerate_r.
Unfortunately, h_Enumerate_r may not hold H_LOCK over its entire
traversal (h_Release_r can drop and reacquire it), so the value of
hostCount is not guaranteed to stay the same.

A host may be deleted during the loop, or right near the end, decreasing
hostCount to below our current running 'count' of hosts, triggering the
panic unnecessarily. So instead, remember the value of hostCount.

Reviewed-on: http://gerrit.openafs.org/1304
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 4dfbbd34ce66c09593a0b1a88831ec0f36848fe8)

Change-Id: I8e39d3bbe16e96a1d3f56e3b19d5f30c3810f6bc
Reviewed-on: http://gerrit.openafs.org/1365
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

10 years agoanalyze warning fix
Derrick Brashear [Mon, 22 Feb 2010 18:58:58 +0000]
analyze warning fix

initialize variable. warnings caught this in the other compiler

Change-Id: Iae2ae5c1aefe29603bbf5d9952f65b0119f4db9b
Reviewed-on: http://gerrit.openafs.org/1363
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 1e731a22ae954900af036d1ade014a07418ae4ea)
Reviewed-on: http://gerrit.openafs.org/1364

10 years agoanalyze paranoia
Derrick Brashear [Mon, 22 Feb 2010 17:15:15 +0000]
analyze paranoia

don't pass a null pointer to FindVolume in case one shows up

Change-Id: I76258d8f8ca18c536e3faa776df3e06005fe2bc2
Reviewed-on: http://gerrit.openafs.org/1360
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 48908e2a932420fe67fe1065d55f7e458b5cd1c2)
Reviewed-on: http://gerrit.openafs.org/1361

10 years agoidledead client dont interrupt writes
Derrick Brashear [Sun, 21 Feb 2010 22:15:26 +0000]
idledead client dont interrupt writes

allowing failover is nonsensical, there's nothing to fail to. keep trying to
write. if we want to change this, we need to handle it better than just this.

Change-Id: Ibed4c63182f44ed9e659895e4868b4192d004688
Reviewed-on: http://gerrit.openafs.org/1355
Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 01f42cad663cc860e451f694f973ca46f03289ff)
Reviewed-on: http://gerrit.openafs.org/1359

10 years agoLinux: Remove unused LINUX_KERNEL_SELINUX test
Anders Kaseorg [Sat, 20 Feb 2010 19:47:45 +0000]
Linux: Remove unused LINUX_KERNEL_SELINUX test

This test needs <linux/autoconf.h>, which has moved in 2.6.33.  It is
also unused (it was removed in master by commit
35d5b6c4e101c92e2c242bb75029db24eb1aa7d7).

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Change-Id: I7876fed2ed2b0395cdf29c71edfdad1089c88cce
Reviewed-on: http://gerrit.openafs.org/1354
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

10 years agomake openafs 1.4.12pre3 openafs-stable-1_4_12pre3
Derrick Brashear [Thu, 11 Feb 2010 05:18:47 +0000]
make openafs 1.4.12pre3

make version strings for 1.4.12pre3

Change-Id: I6873dc6717176318fabc3344cddb804bb1b4a499
Reviewed-on: http://gerrit.openafs.org/1293
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

10 years agoLinux: Use current_creds() if stashed creds fail
Simon Wilkinson [Tue, 9 Feb 2010 19:53:40 +0000]
Linux: Use current_creds() if stashed creds fail

If we can't use our stashed credentials (because SELinux hates us,
most likely), then fall back to trying the processes current credentials
instead of just oopsing.

Change-Id: Ib3676ff66f8400e86cccb97fb207a5f094ceb4ad
Reviewed-on: http://gerrit.openafs.org/1283
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit bcdb5220e2db2bf0cd22c6316682046425048d87)
Reviewed-on: http://gerrit.openafs.org/1289

10 years agoafs_TruncateAllSegments() make sure correct afs_size_t comparison is
Rainer Toebbicke [Mon, 8 Feb 2010 14:18:04 +0000]
afs_TruncateAllSegments() make sure correct afs_size_t comparison is
used when selecting dcache entries for truncation

Insure that afs_TruncateAllSegments() uses the correct [64-bit]
comparison when deciding whether to truncate chunks:
alen - AFS_CHUNKTOBASE(tdc->f.chunk) for a file > 2GB would fail
to be recognised negative with an "afs_int32 newSize", even with
alen = 0 and big tdc->f.chunk.

Change-Id: Id77109fb8238234dae725bd876f70ea0fbd403fc
Change-Id: If0120e21a52316e536d03241c83e8f0d36614c13
Reviewed-on: http://gerrit.openafs.org/1252
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 3913aa55eed10f9d6316910ef950f5c3242e20d7)
Reviewed-on: http://gerrit.openafs.org/1282

10 years agoOpenBSD: don't use AFS_GLOBAL_SUNLOCK on single processor system
Antoine Verheijen [Mon, 8 Feb 2010 21:57:51 +0000]
OpenBSD: don't use AFS_GLOBAL_SUNLOCK on single processor system

Put back the header directives that only turns on AFS_GLOBAL_SUNLOCK
when compiling for multiprocessors system. When enabled on a single
processor OpenBSD system, it is possible to put the entire system
into a lengthy (minutes) lock state when performing multiple AFS
activities. The system behaves MUCH better when AFS_GLOBAL_SUNLOCK
is not set (no problems encopuntered). This whole locking mechanism
needs a bit more examination on OpenBSD before this is useful in
single processor mode.

Change-Id: I19813b78ad8d705b4f043ccb3a38c83e278972e9
Reviewed-on: http://gerrit.openafs.org/1276
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 6219c84243706ed46b922c2e037cceab2684d645)
Change-Id: I9891c469aae9de3ca1b7a334d3f54757c97ddc5f
Reviewed-on: http://gerrit.openafs.org/1257

10 years agoOpenBSD: allow for more graceful shutdown
Antoine Verheijen [Mon, 8 Feb 2010 22:33:38 +0000]
OpenBSD: allow for more graceful shutdown

A shutdown or unmount of AFS on OpenBSD will invariably result in a kernel
panic. This is because the afs_unmount() routine does not (can not?) force
vnode releases if the vnode is still busy. However, it continues on
nonetheless and dies a horrible death a little later.

This update causes a return from afs_unmount() with EBUSY if all the vnodes
weren't released. This results in error messages on shutdown but the overall
process continues more reliably and reboots, for example, work.

There is likely a better solution to this but at least this is no worse than
a system crash and it doesn't require console (or power button) intervention
so it should do until I have the chance to explore further.

Change-Id: Ia70f83bda748ea3d0b81b341a292e83121446567
Reviewed-on: http://gerrit.openafs.org/1275
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 5f39ae64bafe1e2073ff419fe62c2d5a86fc98f5)
Change-Id: I5b74a5b80c6e33ae49ac4f23fb6b3b5d7002b28a
Reviewed-on: http://gerrit.openafs.org/1260

10 years agoOpenBSD: fix lookup of network interfaces
Antoine Verheijen [Mon, 8 Feb 2010 22:23:03 +0000]
OpenBSD: fix lookup of network interfaces

Starting with OpenBSD 4.2, the interface list returned by sysctl using
NET_RT_IFLIST contains multiple versions of the data. This really
messes up the rx_getAllAddr_internal() routine that returns a list of
valid interfaces for the system (to the point where none are returned).

This change adds a routine that cleans up the data returned by sysctl
so it returns only a single (the most current) version of the data.
That stops afsd (among others) from being cranky when it starts up.

Change-Id: Ief1df0d2c3eb241c45b439a785ddb67d3afe992c
Reviewed-on: http://gerrit.openafs.org/1274
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit d06bc699f2e3848da8ce9a7fa20ac99db630bd1b)
Change-Id: I3c1f0b96b579784c6702ade34e33a3348fe82885
Reviewed-on: http://gerrit.openafs.org/1259

10 years agoOpenBSD: move AFS memory type offet
Antoine Verheijen [Mon, 8 Feb 2010 22:07:09 +0000]
OpenBSD: move AFS memory type offet

The internal malloc memory types for IPv6 (M_IP6OPT, ...) conflict
with the type numbers used to designate AFS memory (M_AFSFID, etc.).
This change moves the AFS memory type to a new number that does not
conflict. This is not a serious issue but can create real confusion
when trying to debug or track memory issues, among other things.

Change-Id: Icccaa7c06443cab008013414cb3c2ab4ea08889e
Reviewed-on: http://gerrit.openafs.org/1271
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 03ac7bd100d93f2f47b5e3724c61e3d93a9eca56)
Change-Id: I518850e0a4ac4e527f5cedba6cdc83daeafb6ddd
Reviewed-on: http://gerrit.openafs.org/1258

10 years agoFix segmentation fault in vsu_GetVolumeID
Antoine Verheijen [Mon, 8 Feb 2010 23:01:46 +0000]
Fix segmentation fault in vsu_GetVolumeID

When determining the volume type of a volume, vsu_GetVolumeID() checks
to see if the volume name ends in '.backup' or '.readonly' by backing
up the appropriate number of characters from the end of the name. It
does not, however, check to see if it skips past the beginning of the
volume name. This can result in a segmentation fault (which it has for
me on many occasions during a vos release) depending on where memory
is allocated or how/if memory is protected.

This patch corrects this behaviour by checking the volume name string
length prior to doing the string comparison.

Change-Id: Ia27fcac76b86ae2707663caa6bff365a4e8dd0da
Reviewed-on: http://gerrit.openafs.org/1269
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 4221d7acc8595a052dbc5fbb4366050c00d6ef37)
Reviewed-on: http://gerrit.openafs.org/1270

10 years agoAdd support for OpenBSD 4.6
Antoine Verheijen [Mon, 8 Feb 2010 22:45:25 +0000]
Add support for OpenBSD 4.6

Add config param header and sysname number for OpenBSD 4.6.

As well, add an additional parameter to a call to ifa_ifwithnet()
when looking up the MTU for an interface to indicate that the call
should use the default routing table. With the advent of OpenBSD
4.6, the system has started to make provisions for multiple routing
tables which included a change to the calling sequence for this
routine.

Change-Id: Ia616400094ed36bc6f0e37f86d3b7448d5bd32c2
(cherry picked from commit ab17ebef16a04180b2ede8c8ed07cd9c1871ae42)
Reviewed-on: http://gerrit.openafs.org/1261
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

10 years agoOpenBSD: allow code optimization to be turned off
Antoine Verheijen [Mon, 8 Feb 2010 21:44:55 +0000]
OpenBSD: allow code optimization to be turned off

Code optimization can not be turned of using the configuration script
(--disable-optimize, etc.) because the compiler directive is associated
with the wrong makefile variable. This fixes it.

Change-Id: I55759054fdad9677d9576e582df6829c4c508331
Reviewed-on: http://gerrit.openafs.org/1256
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

10 years agomacos package allow backrev
Derrick Brashear [Sun, 7 Feb 2010 00:48:44 +0000]
macos package allow backrev

in order to go back versions, tell the install not to enforce
"no backrev"

Change-Id: Ifb4bee86344560d63c9b8ab3cd789f25ed8629b8
Reviewed-on: http://gerrit.openafs.org/1249
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 80a1130612a68d14e1beda90013bd90d5523aa25)
Reviewed-on: http://gerrit.openafs.org/1250

10 years agofakestat should preclude afsdb lookups too
Derrick Brashear [Thu, 4 Feb 2010 00:01:28 +0000]
fakestat should preclude afsdb lookups too

macos tries to look up ._foo stuff. correctly identify those (mvstat 2, not
1) and also use tryEvalOnly to preclude AFSDB lookups

Change-Id: I490fe98d695c4d230210bc4e4645ea20cd4d8fa2
Reviewed-on: http://gerrit.openafs.org/1228
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 682db4d64d550af86dc5a09786e050c6a98ffb0c)
Reviewed-on: http://gerrit.openafs.org/1232

10 years agomacos prefs pane spelling
Derrick Brashear [Thu, 4 Feb 2010 02:46:06 +0000]
macos prefs pane spelling

fix spelling of link to the usual unix spelling

Change-Id: Id8464a22c049200526c6ffe471ea6dc6d4b0ed9a
Reviewed-on: http://gerrit.openafs.org/1230
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 0e8beecff3bffc0aa6f10d342cd4d100412ca29f)
Reviewed-on: http://gerrit.openafs.org/1231

10 years agono debian packaging in 1.4.x
Derrick Brashear [Tue, 2 Feb 2010 18:38:49 +0000]
no debian packaging in 1.4.x

don't try to build this here. slipped in from 1.5 pullup

Change-Id: Ie8702e4ba0af1c67542330d4d798dad2e2ec2b68
Reviewed-on: http://gerrit.openafs.org/1216
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

10 years agoAdd a set of strings for the InstallationCheck
Simon Wilkinson [Tue, 2 Feb 2010 15:59:12 +0000]
Add a set of strings for the InstallationCheck

InstallationCheck needs a strings dictionary to turn its errors
into human readable content. Add such a dictionary, and use the
correct product name and version for each Mac OS X release.

FIXES 126322

Change-Id: I8401a1163ea078e690152215c20db6970969ee04
Reviewed-on: http://gerrit.openafs.org/1208
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 7533adaf34ef76324b971a211bcbf3fba5b40627)
Reviewed-on: http://gerrit.openafs.org/1215

10 years agocreate debugging kext package for MacOS
Derrick Brashear [Sun, 17 Jan 2010 06:10:28 +0000]
create debugging kext package for MacOS

this creates and installs a debugging kext package for macos. it also
always installs the decode-panic script (which can be used even without
the debug kext)

Change-Id: Iff03de66cd3df2690f03333e6629d21660364cd1
Reviewed-on: http://gerrit.openafs.org/1120
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit cc47e765912e1a5dedddb6ef00ca8b8c8d567f0e)
Reviewed-on: http://gerrit.openafs.org/1214

10 years agoDon't echo from the InstallationCheck script
Simon Wilkinson [Tue, 2 Feb 2010 15:47:02 +0000]
Don't echo from the InstallationCheck script

Return codes from InstallationCheck are turned into errors by
the GUI - don't echo them out to stdout as well.

Change-Id: Iee9c1ff4687ea42ab8c18566493a8a92b6d51fed
Reviewed-on: http://gerrit.openafs.org/1206
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit c0724584680562330347026ee9ec72f74066bc51)
Reviewed-on: http://gerrit.openafs.org/1207

10 years agoafs_vnop_attrs: syntax error in conditional expression
Marc Dionne [Thu, 21 Jan 2010 22:53:42 +0000]
afs_vnop_attrs: syntax error in conditional expression

Add a missing && in a 2-line condition.
Not sure how this could have compiled successfully on the affected
platforms.

Change-Id: I2e8b791c6d8cd09795be1ef52c078ebfa5a3e53b
Reviewed-on: http://gerrit.openafs.org/1140
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit ddc64898e7b3a26e6514be63ef01672fe67cb851)
Reviewed-on: http://gerrit.openafs.org/1197

10 years agocall afs_osi_suser correctly in PNewUuid
Jeffrey Hutzelman [Mon, 1 Feb 2010 21:59:14 +0000]
call afs_osi_suser correctly in PNewUuid

we were using the wrong level of indirection on acred. fixed.

Change-Id: I00ab1a97b42717adc2d9d26e885b91c44103ab1d
Reviewed-on: http://gerrit.openafs.org/1190
Reviewed-by: Jeffrey Hutzelman <jhutz@cmu.edu>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit a97fffc08a02ad8583c7f7b50d41fe07c93520b8)
Reviewed-on: http://gerrit.openafs.org/1193

10 years agomake 1.4.12 rc2 openafs-stable-1_4_12pre2
Derrick Brashear [Mon, 1 Feb 2010 05:01:05 +0000]
make 1.4.12 rc2

push version strings for 1.4.12 pre2

Change-Id: I4ea9de19cc52c531d3ec9f4ec130449467f3e87d
Reviewed-on: http://gerrit.openafs.org/1186
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

10 years agorx idledeadtime don't track window wait
Derrick Brashear [Sat, 30 Jan 2010 18:54:20 +0000]
rx idledeadtime don't track window wait

if we're in writer mode and waiting for more window, don't consider it idle.

Change-Id: Id1e80f297929eef363ffe88bfe181b74bb331515
Reviewed-on: http://gerrit.openafs.org/1182
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit d52213fcc5dae5095d660e1861f77e90c07bb2ab)
Reviewed-on: http://gerrit.openafs.org/1183

10 years agolinux mmap anti-deadlock should issue error rather than write returns
Derrick Brashear [Thu, 21 Jan 2010 21:28:33 +0000]
linux mmap anti-deadlock should issue error rather than write returns

we are careful to issue errors negative everywhere but here. do so
here also

Change-Id: I2322ffbaf16c91161d0d7aa980d50f56b83ac0a2
Reviewed-on: http://gerrit.openafs.org/1137
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

10 years agoEnable weak enctypes for klog.krb5 if supported by Kerberos
Russ Allbery [Fri, 22 Jan 2010 18:59:14 +0000]
Enable weak enctypes for klog.krb5 if supported by Kerberos

The same as cb4b62a40352ccebae3a299f4327fa70fc7a0c5c, but for klog.krb5.

Current versions of both MIT Kerberos and Heimdal disable DES enctypes
by default, but DES enctypes are still required for AFS service tickets.
Probe for either krb5_allow_weak_crypto() (MIT Kerberos 1.8) or
krb5_enctype_enable() (Heimdal) and, if found, call them to enable DES
enctypes.  If neither is found, assume that the Kerberos libraries are
old enough that DES is enabled by default.

Change-Id: I99c93621c847f6edcc485207f5b6b99b2370b347
Reviewed-on: http://gerrit.openafs.org/1144
Tested-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit f02ab3339d01bca414fe705f3a990a1db146f29b)
Reviewed-on: http://gerrit.openafs.org/1148
Tested-by: Derrick Brashear <shadow@dementia.org>

10 years agoEnable weak enctypes for aklog if supported by Kerberos
Russ Allbery [Fri, 22 Jan 2010 19:04:10 +0000]
Enable weak enctypes for aklog if supported by Kerberos

Current versions of both MIT Kerberos and Heimdal disable DES enctypes
by default, but DES enctypes are still required for AFS service tickets.
Probe for either krb5_allow_weak_crypto() (MIT Kerberos 1.8) or
krb5_enctype_enable() (Heimdal) and, if found, call them to enable DES
enctypes.  If neither is found, assume that the Kerberos libraries are
old enough that DES is enabled by default.

Change-Id: Ib5231bb7c2fe88f4c424628394ed08122d5710a1
Reviewed-on: http://gerrit.openafs.org/1141
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit cb4b62a40352ccebae3a299f4327fa70fc7a0c5c)
Reviewed-on: http://gerrit.openafs.org/1145
Tested-by: Russ Allbery <rra@stanford.edu>

10 years agoDon't double free call structure
Simon Wilkinson [Sat, 16 Jan 2010 15:52:58 +0000]
Don't double free call structure

If the rx_Read() of the number of bytes in the FetchData64 response
fails, then it sets code, and disposes of the call structure. However,
the length safety check that was added in
c7b92a3018044f7aca4d9a77644e5c06ef64d1e9 executes regardless of whether
code is set, and the call has already been freed. So we end up calling
rx_Error with a NULL call structure, and panic.

(pulled up from 806423be3c55f3de91c2b836d2088eeb0f4e4665)

Change-Id: Ia1ee4ab9c794db9337e4eb7b5b5980c8a57cef0b
Reviewed-on: http://gerrit.openafs.org/1113
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

10 years agoSpec file changes
Simon Wilkinson [Thu, 14 Jan 2010 20:03:28 +0000]
Spec file changes

RedHat spec file changes so that the current tree will build into
RPMS.

Change-Id: Id7fa677e2ff8fac3ce0fee876b1274bc65e944fb
Reviewed-on: http://gerrit.openafs.org/1102
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

10 years agoDon't install compile_et into its own directory
Simon Wilkinson [Thu, 14 Jan 2010 16:57:15 +0000]
Don't install compile_et into its own directory

When pinstall sees that the basenames of its two arguments differ,
it assumes that its installing into a path, and creates the missing
directory. This meant that we got /usr/bin/afs_compile_et/compile_et
which wasn't the desired result.

Change-Id: Ie6af2d3fd9c5166dd2d884c22d287c180b24fab1
Reviewed-on: http://gerrit.openafs.org/1099
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

10 years agoLinux: kmem_cache_create fix and cleanup
Marc Dionne [Fri, 9 Oct 2009 01:53:03 +0000]
Linux: kmem_cache_create fix and cleanup

Fix the kmem_cache constructor function to match the current
expected prototype, and cleanup related code.  This has been wrong
for a while, but since we were just passing extra parameters the
only effect was to generate a warning.

- Add a new configure test to detect the new constructor function
signature
- Define the older versions of the constructor in osi_compat.h,
making them call the current version
- Move a few compatibility #defines to osi_compat.h

(cherry picked from 3abc87a5a94f0d5eaca702c7bd66fbe35ce7b896)
Reviewed-on: http://gerrit.openafs.org/657
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

Change-Id: I3570a3268d35ac73409b96816ba5112f809f6645
Reviewed-on: http://gerrit.openafs.org/994
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

10 years agomake 1.4.12rc1 openafs-stable-1_4_12pre1
Derrick Brashear [Tue, 12 Jan 2010 17:37:52 +0000]
make 1.4.12rc1

mark the first 1.4.12 release candidate

Change-Id: Ief73a61978469f142c0305246fa8224b8a842f58
Reviewed-on: http://gerrit.openafs.org/1091
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

10 years agolinux kernel lacks uintptr
Derrick Brashear [Mon, 4 Jan 2010 22:57:30 +0000]
linux kernel lacks uintptr

sadly only recent kernels include uintptr_t. change the cast to use unsigned
long

Change-Id: Ib69f7aa0f2d316c5ea8bdc960b15ee0f89f96250
Reviewed-on: http://gerrit.openafs.org/1059
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 165571947be770645900bb8d55ba7b6a3c58f8fd)
Reviewed-on: http://gerrit.openafs.org/1081

10 years agoavoid leaking stat info
Derrick Brashear [Thu, 17 Dec 2009 20:33:42 +0000]
avoid leaking stat info

if a file is already CStatd we just copy out the information without doing
access checks. add an access check.

Reviewed-on: http://gerrit.openafs.org/995
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 6ec18461649d3e4f44b2476f886bcc480c456500)

Change-Id: I4a66c9e4229da464592c1dad94854261e5daa30d
Reviewed-on: http://gerrit.openafs.org/1076
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

10 years agoviced host always hash on add
Derrick Brashear [Thu, 31 Dec 2009 12:50:56 +0000]
viced host always hash on add

currently the openafs 1.4 code doesn't always add a host/port pair to the
hash when an interface address is being added. make the code match what exists
on the head

Change-Id: Ibf56a397b936abd1b0646c63c5dda88a59819538
Reviewed-on: http://gerrit.openafs.org/1053
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Alistair Ferguson <alistair.ferguson@mac.com>
Tested-by: Alistair Ferguson <alistair.ferguson@mac.com>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Tested-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>