From 1a42219e63b2e511c8940d1993d886a80a34b78c Mon Sep 17 00:00:00 2001 From: Christof Hanke Date: Tue, 24 Sep 2013 11:01:08 +0200 Subject: [PATCH 1/1] vos: complain if no fields are passed to vos "setfields". It might be a misleading if it exists sucessfully when clearly invoked wrongly. Change-Id: Ic92f4e17fde0a0dfc182f9713350800c72fa165e Reviewed-on: http://gerrit.openafs.org/10271 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk Reviewed-by: Derrick Brashear --- src/volser/vos.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/volser/vos.c b/src/volser/vos.c index b0368d4..4e1a743 100644 --- a/src/volser/vos.c +++ b/src/volser/vos.c @@ -1714,6 +1714,7 @@ SetFields(struct cmd_syndesc *as, void *arock) afs_uint32 aserver; afs_int32 apart; int previdx = -1; + int have_field = 0; volid = vsu_GetVolumeID(as->parms[0].items->data, cstruct, &err); /* -id */ if (volid == 0) { @@ -1747,6 +1748,7 @@ SetFields(struct cmd_syndesc *as, void *arock) if (as->parms[1].items) { /* -max */ + have_field = 1; code = util_GetHumanInt32(as->parms[1].items->data, &info.maxquota); if (code) { fprintf(STDERR, "invalid quota value\n"); @@ -1755,12 +1757,18 @@ SetFields(struct cmd_syndesc *as, void *arock) } if (as->parms[2].items) { /* -clearuse */ + have_field = 1; info.dayUse = 0; } if (as->parms[3].items) { /* -clearVolUpCounter */ + have_field = 1; info.spare2 = 0; } + if (!have_field) { + fprintf(STDERR,"Nothing to set.\n"); + return (1); + } code = UV_SetVolumeInfo(aserver, apart, volid, &info); if (code) fprintf(STDERR, -- 1.9.4