From 3e8529b6efec4625a4c67e6779fc8367291461a0 Mon Sep 17 00:00:00 2001 From: Mark Vitale Date: Wed, 18 May 2016 00:36:12 -0400 Subject: [PATCH] salvager: fix error message for invalid volumeid If the specified volumeid is invalid (e.g. volume name was specified instead of volume number), the error is reported via Log(). However, commit 24fed351fd13b38bfaf9f278c914a47782dbf670 moved the log opening logic from before this check to after it, effectively making this Log() call a no-op. Instead, use fprintf to issue the error message. Change-Id: I488bc93b178c7973e48d7c9ef4e7ecde9ba62696 Reviewed-on: https://gerrit.openafs.org/12288 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk --- src/vol/salvager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vol/salvager.c b/src/vol/salvager.c index 3bc9351..297ea3d 100644 --- a/src/vol/salvager.c +++ b/src/vol/salvager.c @@ -200,7 +200,7 @@ handleit(struct cmd_syndesc *as, void *arock) seenvol = 1; vid_l = strtoul(ti->data, &end, 10); if (vid_l >= MAX_AFS_UINT32 || vid_l == ULONG_MAX || *end != '\0') { - Log("salvage: invalid volume id specified; salvage aborted\n"); + fprintf(stderr, "salvage: invalid volume id specified; salvage aborted\n"); Exit(1); } vid = (VolumeId)vid_l; -- 1.9.4