From 4caadf71f556f789bcdd2bcc80b9642630329421 Mon Sep 17 00:00:00 2001 From: Mark Vitale Date: Sun, 5 Apr 2020 17:10:42 -0400 Subject: [PATCH 1/1] afs: remove stats dead code afs_GetCMSTats, afs_AddToMean, and macro AFS_MEANCNT have been dead code since the original IBM code import. Remove them from the tree. No functional change is incurred by this commit. Change-Id: Icd6aeff7896d69a4d334531b5e0c632d807457ce Reviewed-on: https://gerrit.openafs.org/14196 Reviewed-by: Benjamin Kaduk Reviewed-by: Andrew Deason Tested-by: BuildBot --- src/afs/afs_prototypes.h | 4 ---- src/afs/afs_stat.c | 16 ---------------- src/afs/afs_stats.h | 7 ++----- 3 files changed, 2 insertions(+), 25 deletions(-) diff --git a/src/afs/afs_prototypes.h b/src/afs/afs_prototypes.h index 3cf4394..79eea6d 100644 --- a/src/afs/afs_prototypes.h +++ b/src/afs/afs_prototypes.h @@ -910,10 +910,6 @@ extern struct afs_stats_CMPerf afs_stats_cmperf; extern struct afs_stats_CMFullPerf afs_stats_cmfullperf; extern afs_int32 afs_stats_XferSumBytes[AFS_STATS_NUM_FS_XFER_OPS]; extern void afs_InitStats(void); -extern void afs_GetCMStat(char **ptr, unsigned *size); -#ifndef AFS_NOSTATS -extern void afs_AddToMean(struct afs_MeanStats *oldMean, afs_int32 newValue); -#endif /* afs_syscall.c */ #ifdef AFS_DARWIN100_ENV diff --git a/src/afs/afs_stat.c b/src/afs/afs_stat.c index 81873ee..7145001 100644 --- a/src/afs/afs_stat.c +++ b/src/afs/afs_stat.c @@ -72,19 +72,3 @@ afs_InitStats(void) xferP->minBytes = 999999999; } } - -void -afs_GetCMStat(char **ptr, unsigned *size) -{ -#ifndef AFS_NOSTATS - AFS_STATCNT(afs_GetCMStat); - *ptr = (char *)&afs_cmstats; - *size = sizeof(afs_cmstats); -#endif /* AFS_NOSTATS */ -} - -void -afs_AddToMean(struct afs_MeanStats *oldMean, afs_int32 newValue) -{ - AFS_STATCNT(afs_AddToMean); -} diff --git a/src/afs/afs_stats.h b/src/afs/afs_stats.h index bf383c8..2562a62 100644 --- a/src/afs/afs_stats.h +++ b/src/afs/afs_stats.h @@ -523,8 +523,8 @@ struct afs_MeanStats { AFS_CS(HaveCallBacksFrom) /* afs_resource.c */ \ AFS_CS(ServerDown) /* afs_resource.c */ \ AFS_CS(afs_CheckServers) /* afs_resource.c */ \ - AFS_CS(afs_AddToMean) /* afs_stat.c */ \ - AFS_CS(afs_GetCMStat) /* afs_stat.c */ \ + AFS_CS(afs_AddToMean) /* UNUSED */ \ + AFS_CS(afs_GetCMStat) /* UNUSED */ \ AFS_CS(afs_getpage) /* afs_sun_subr.c */ \ AFS_CS(afs_putpage) /* afs_sun_subr.c */ \ AFS_CS(afs_nfsrdwr) /* afs_sun_subr.c */ \ @@ -1186,9 +1186,6 @@ struct afs_stats_CMFullPerf { */ #define AFS_STATCNT(arg) ((afs_cmstats.callInfo.C_ ## arg)++) -#define AFS_MEANCNT(arg, value) \ - (afs_AddToMean(((afs_cmstats.meanInfo).(arg)),value)) - #endif /* AFS_NOSTATS */ -- 1.9.4