From 66b74e78ba5fea6a8236dcd3b8b46e1dfa6a0ac7 Mon Sep 17 00:00:00 2001 From: Benjamin Kaduk Date: Mon, 27 Nov 2017 22:07:53 -0600 Subject: [PATCH] rx: fix call refcount leak in error case The recent event handling normalization in commit 304d758983b499dc568d6ca57b6e92df24b69de8 had event handlers switch to dropping their reference on the associated connection/call just before return. An early return case was missed in the conversion, leading to a refcount leak in an error case. Change-Id: Ie3d0bc9474fdbc09be9c753f4d0192c8cca68351 Reviewed-on: https://gerrit.openafs.org/12781 Tested-by: BuildBot Reviewed-by: Michael Meffie Reviewed-by: Benjamin Kaduk --- src/rx/rx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/rx/rx.c b/src/rx/rx.c index ce9adcb..9dc2e2b 100644 --- a/src/rx/rx.c +++ b/src/rx/rx.c @@ -6463,6 +6463,7 @@ rxi_KeepAliveEvent(struct rxevent *event, void *arg1, void *dummy, if (rxi_CheckCall(call, 0)) { MUTEX_EXIT(&call->lock); + CALL_RELE(call, RX_CALL_REFCOUNT_ALIVE); return; } -- 1.9.4