From 7c15e6efe62fb3fe1970c56331df09b257abf6d9 Mon Sep 17 00:00:00 2001 From: Benjamin Kaduk Date: Sat, 2 Feb 2019 19:48:20 -0600 Subject: [PATCH] uss: signed/unsigned char fallout When char is signed, assigning 255 to a variable of type char changes the value, which causes clang to emit a warning and fail the --enable-checking build. Change-Id: Id02e2526a9a9dd6657dee55b9dc22da03d102d8c Reviewed-on: https://gerrit.openafs.org/13475 Tested-by: BuildBot Reviewed-by: Cheyenne Wills Reviewed-by: Michael Meffie Reviewed-by: Benjamin Kaduk --- src/uss/uss_kauth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/uss/uss_kauth.c b/src/uss/uss_kauth.c index da956bd..11cbe6c 100644 --- a/src/uss/uss_kauth.c +++ b/src/uss/uss_kauth.c @@ -641,7 +641,7 @@ uss_kauth_SetFields(char *username, char *expirestring, char *reuse, fprintf(stderr, "Zero represents unlimited login attempts.\n"); fprintf(stderr, "Continuing with limit == 254 for user %s.\n", username); - misc_auth_bytes[2] = 255; + misc_auth_bytes[2] = 0xff; } else misc_auth_bytes[2] = nfailures + 1; -- 1.9.4