From bf17a719e3443502e2b4bdb7f6b9d2f0c1e39510 Mon Sep 17 00:00:00 2001 From: Mark Vitale Date: Tue, 10 May 2016 22:51:38 -0400 Subject: [PATCH 1/1] salvageserver: segfault in DoSalvageVolume A typo in the recent logging changes for salvageserver ad455347bc99d1bd499535995958b5f77c2388ff caused a bad address to be passed to memset. Correctly memset the log options as intended. Change-Id: Ifef46defcc6da56df4e58f8ed9029717a77c0b39 Reviewed-on: https://gerrit.openafs.org/12282 Reviewed-by: Benjamin Kaduk Tested-by: BuildBot --- src/vol/salvaged.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vol/salvaged.c b/src/vol/salvaged.c index 6e4c87a..f513ce3 100644 --- a/src/vol/salvaged.c +++ b/src/vol/salvaged.c @@ -621,7 +621,7 @@ DoSalvageVolume(struct SalvageQueueNode * node, int slot) * another thread may have held the lock when fork was * called! */ - memset(&memset, 0, sizeof(logopts)); + memset(&logopts, 0, sizeof(logopts)); logopts.lopt_dest = logDest_file; logopts.lopt_rotateStyle = logRotate_none; if (asprintf(&filename, "%s.%d", -- 1.9.4