From e61ab9353e99d3298815296abf6b02c50ebe3df0 Mon Sep 17 00:00:00 2001 From: Michael Meffie Date: Wed, 1 Jul 2020 21:50:09 -0400 Subject: [PATCH] redhat: Add make to the dkms-openafs pre-requirements If `make` is not installed before dkms-openafs, the OpenAFS kernel module is not built during the dkms-openafs package installation. The failure happens in the "checking if linux kernel module build works" configure step, which invokes `make` to check the linux buildsystem. configure fails when `make` is not available, and gives the unhelpful suggestion (in this case) of configuring with --disable-kernel module. Running the configure.log in the dkms build directory shows: configure:7739: checking if linux kernel module build works make -C /lib/modules/4.18.0-193.6.3.el8_2.x86_64/build M=/var/lib/dkms/openafs/... ./configure: line 7771: make: command not found configure: failed using Makefile: Avoid this build failure by adding `make` to the list of dkms-openafs package pre-requirements. Change-Id: I98b3508341eea1df4fa7b6f43e88add1bda9ee2c Reviewed-on: https://gerrit.openafs.org/14266 Tested-by: BuildBot Reviewed-by: Cheyenne Wills Reviewed-by: Benjamin Kaduk --- src/packaging/RedHat/openafs.spec.in | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/packaging/RedHat/openafs.spec.in b/src/packaging/RedHat/openafs.spec.in index 8601b1d..5c54e2e 100644 --- a/src/packaging/RedHat/openafs.spec.in +++ b/src/packaging/RedHat/openafs.spec.in @@ -229,8 +229,7 @@ Summary: DKMS-ready kernel source for AFS distributed filesystem Group: Development/Kernel Provides: openafs-kernel = %{version} Provides: %{name}-kmod = %{version} -Requires(pre): dkms -Requires(pre): flex +Requires(pre): dkms, make, flex Requires(post): dkms Requires: %{name}-kmod-common = %{version} -- 1.9.4