From ebaefc5a06fb3b559ce3649676197d0a989efbde Mon Sep 17 00:00:00 2001 From: Andrew Deason Date: Sat, 25 Apr 2020 18:21:10 -0500 Subject: [PATCH] tests: Give more leeway in rx/event-t Currently, the rx/event-t tests schedule a bunch of events up to 3 seconds in the future, and then we sleep for 3 seconds to give them a chance to run. Since we're cutting it so close, this can rarely result in a few events not being run (observed occasionally on FreeBSD 12.1, where we failed to run about 3 events out of 10000). To avoid this, just sleep for 4 seconds instead of 3. Also print out a little more info regarding the number of fired/cancelled events, so we can see the event count when it's wrong. Change-Id: I6269bea2c245aeed00c129ff638423d0fa81ad23 Reviewed-on: https://gerrit.openafs.org/14160 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk --- tests/rx/event-t.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/rx/event-t.c b/tests/rx/event-t.c index 9c2b8e1..008cadb 100644 --- a/tests/rx/event-t.c +++ b/tests/rx/event-t.c @@ -179,7 +179,7 @@ main(void) ok(1, "Added %d events", NUMEVENTS); - sleep(3); + sleep(4); fired = 0; cancelled = 0; @@ -193,7 +193,9 @@ main(void) fail = 1; } ok(!fail, "Didn't fire any cancelled events"); - ok(fired+cancelled == NUMEVENTS, + diag("fired %d/%d events", fired, NUMEVENTS); + diag("cancelled %d/%d events", cancelled, NUMEVENTS); + is_int(NUMEVENTS, fired+cancelled, "Number of fired and cancelled events sum to correct total"); return 0; -- 1.9.4