2 * Copyright 2000, International Business Machines Corporation and others.
5 * This software has been released under the terms of the IBM Public
6 * License. For details, see the LICENSE file in the top-level source
7 * directory or online at http://www.openafs.org/dl/license10.html
10 #include <afsconfig.h>
11 #include <afs/param.h>
18 #include <afs/afsutil.h>
19 #include <afs/cellconfig.h>
21 #define UBIK_INTERNALS
26 * This module is responsible for determining when the system has
27 * recovered to the point that it can handle new transactions. It
28 * replays logs, polls to determine the current dbase after a crash,
29 * and distributes the new database to the others.
31 * The sync site associates a version number with each database. It
32 * broadcasts the version associated with its current dbase in every
33 * one of its beacon messages. When the sync site send a dbase to a
34 * server, it also sends the db's version. A non-sync site server can
35 * tell if it has the right dbase version by simply comparing the
36 * version from the beacon message \p uvote_dbVersion with the version
37 * associated with the database \p ubik_dbase->version. The sync site
38 * itself simply has one counter to keep track of all of this (again
39 * \p ubik_dbase->version).
41 * sync site: routine called when the sync site loses its quorum; this
42 * procedure is called "up" from the beacon package. It resyncs the
43 * dbase and nudges the recovery daemon to try to propagate out the
44 * changes. It also resets the recovery daemon's state, since
45 * recovery must potentially find a new dbase to propagate out. This
46 * routine should not do anything with variables used by non-sync site
51 * if this flag is set, then ubik will use only the primary address
52 * (the address specified in the CellServDB) to contact other
53 * ubik servers. Ubik recovery will not try opening connections
54 * to the alternate interface addresses.
56 int ubikPrimaryAddrOnly;
59 urecovery_ResetState(void)
62 #if !defined(AFS_PTHREAD_ENV)
63 /* No corresponding LWP_WaitProcess found anywhere for this -- klm */
64 LWP_NoYieldSignal(&urecovery_state);
72 * routine called when a non-sync site server goes down; restarts recovery
73 * process to send missing server the new db when it comes back up for
74 * non-sync site servers.
76 * \note This routine should not do anything with variables used by non-sync site servers.
79 urecovery_LostServer(struct ubik_server *ts)
81 ubeacon_ReinitServer(ts);
82 #if !defined(AFS_PTHREAD_ENV)
83 /* No corresponding LWP_WaitProcess found anywhere for this -- klm */
84 LWP_NoYieldSignal(&urecovery_state);
90 * return true iff we have a current database (called by both sync
91 * sites and non-sync sites) How do we determine this? If we're the
92 * sync site, we wait until recovery has finished fetching and
93 * re-labelling its dbase (it may still be trying to propagate it out
94 * to everyone else; that's THEIR problem). If we're not the sync
95 * site, then we must have a dbase labelled with the right version,
96 * and we must have a currently-good sync site.
99 urecovery_AllBetter(struct ubik_dbase *adbase, int areadAny)
103 ubik_dprint_25("allbetter checking\n");
108 if (ubik_dbase->version.epoch > 1)
109 rcode = 1; /* Happy with any good version of database */
112 /* Check if we're sync site and we've got the right data */
113 else if (ubeacon_AmSyncSite() && (urecovery_state & UBIK_RECHAVEDB)) {
117 /* next, check if we're aux site, and we've ever been sent the
118 * right data (note that if a dbase update fails, we won't think
119 * that the sync site is still the sync site, 'cause it won't talk
120 * to us until a timeout period has gone by. When we recover, we
121 * leave this clear until we get a new dbase */
122 else if ((uvote_GetSyncSite() && uvote_eq_dbVersion(ubik_dbase->version))) { /* && order is important */
126 ubik_dprint_25("allbetter: returning %d\n", rcode);
131 * \brief abort all transactions on this database
134 urecovery_AbortAll(struct ubik_dbase *adbase)
136 struct ubik_trans *tt;
137 for (tt = adbase->activeTrans; tt; tt = tt->next) {
144 * \brief this routine aborts the current remote transaction, if any, if the tid is wrong
147 urecovery_CheckTid(struct ubik_tid *atid, int abortalways)
149 if (ubik_currentTrans) {
150 /* there is remote write trans, see if we match, see if this
151 * is a new transaction */
152 if (atid->epoch != ubik_currentTrans->tid.epoch
153 || atid->counter > ubik_currentTrans->tid.counter || abortalways) {
154 /* don't match, abort it */
155 /* If the thread is not waiting for lock - ok to end it */
156 if (ubik_currentTrans->locktype != LOCKWAIT) {
157 udisk_end(ubik_currentTrans);
159 ubik_currentTrans = (struct ubik_trans *)0;
168 * log format is defined here, and implicitly in disk.c
170 * 4 byte opcode, followed by parameters, each 4 bytes long. All integers
171 * are in logged in network standard byte order, in case we want to move logs
172 * from machine-to-machine someday.
174 * Begin transaction: opcode \n
175 * Commit transaction: opcode, version (8 bytes) \n
176 * Truncate file: opcode, file number, length \n
177 * Abort transaction: opcode \n
178 * Write data: opcode, file, position, length, <length> data bytes \n
180 * A very simple routine, it just replays the log. Note that this is a new-value only log, which
181 * implies that no uncommitted data is written to the dbase: one writes data to the log, including
182 * the commit record, then we allow data to be written through to the dbase. In our particular
183 * implementation, once a transaction is done, we write out the pages to the database, so that
184 * our buffer package doesn't have to know about stable and uncommitted data in the memory buffers:
185 * any changed data while there is an uncommitted write transaction can be zapped during an
186 * abort and the remaining dbase on the disk is exactly the right dbase, without having to read
190 ReplayLog(struct ubik_dbase *adbase)
193 afs_int32 code, tpos;
195 afs_int32 len, thisSize, tfile, filePos;
197 afs_int32 syncFile = -1;
198 afs_int32 data[1024];
200 /* read the lock twice, once to see whether we have a transaction to deal
201 * with that committed, (theoretically, we should support more than one
202 * trans in the log at once, but not yet), and once replaying the
206 /* for now, assume that all ops in log pertain to one transaction; see if there's a commit */
209 (*adbase->read) (adbase, LOGFILE, (char *)&opcode, tpos,
211 if (code != sizeof(afs_int32))
213 opcode = ntohl(opcode);
214 if (opcode == LOGNEW) {
215 /* handle begin trans */
216 tpos += sizeof(afs_int32);
217 } else if (opcode == LOGABORT)
219 else if (opcode == LOGEND) {
222 } else if (opcode == LOGTRUNCATE) {
225 (*adbase->read) (adbase, LOGFILE, (char *)buffer, tpos,
226 2 * sizeof(afs_int32));
227 if (code != 2 * sizeof(afs_int32))
228 break; /* premature eof or io error */
229 tpos += 2 * sizeof(afs_int32);
230 } else if (opcode == LOGDATA) {
233 (*adbase->read) (adbase, LOGFILE, (char *)buffer, tpos,
234 3 * sizeof(afs_int32));
235 if (code != 3 * sizeof(afs_int32))
237 /* otherwise, skip over the data bytes, too */
238 tpos += ntohl(buffer[2]) + 3 * sizeof(afs_int32);
240 ubik_print("corrupt log opcode (%d) at position %d\n", opcode,
242 break; /* corrupt log! */
246 /* actually do the replay; log should go all the way through the commit record, since
247 * we just read it above. */
253 (*adbase->read) (adbase, LOGFILE, (char *)&opcode, tpos,
255 if (code != sizeof(afs_int32))
257 opcode = ntohl(opcode);
258 if (opcode == LOGNEW) {
259 /* handle begin trans */
260 tpos += sizeof(afs_int32);
261 } else if (opcode == LOGABORT)
262 panic("log abort\n");
263 else if (opcode == LOGEND) {
264 struct ubik_version version;
267 (*adbase->read) (adbase, LOGFILE, (char *)buffer, tpos,
268 2 * sizeof(afs_int32));
269 if (code != 2 * sizeof(afs_int32))
271 version.epoch = ntohl(buffer[0]);
272 version.counter = ntohl(buffer[1]);
273 code = (*adbase->setlabel) (adbase, 0, &version);
276 ubik_print("Successfully replayed log for interrupted "
277 "transaction; db version is now %ld.%ld\n",
278 (long) version.epoch, (long) version.counter);
280 break; /* all done now */
281 } else if (opcode == LOGTRUNCATE) {
284 (*adbase->read) (adbase, LOGFILE, (char *)buffer, tpos,
285 2 * sizeof(afs_int32));
286 if (code != 2 * sizeof(afs_int32))
287 break; /* premature eof or io error */
288 tpos += 2 * sizeof(afs_int32);
290 (*adbase->truncate) (adbase, ntohl(buffer[0]),
294 } else if (opcode == LOGDATA) {
297 (*adbase->read) (adbase, LOGFILE, (char *)buffer, tpos,
298 3 * sizeof(afs_int32));
299 if (code != 3 * sizeof(afs_int32))
301 tpos += 3 * sizeof(afs_int32);
302 /* otherwise, skip over the data bytes, too */
303 len = ntohl(buffer[2]); /* total number of bytes to copy */
304 filePos = ntohl(buffer[1]);
305 tfile = ntohl(buffer[0]);
306 /* try to minimize file syncs */
307 if (syncFile != tfile) {
309 code = (*adbase->sync) (adbase, syncFile);
317 thisSize = (len > sizeof(data) ? sizeof(data) : len);
318 /* copy sizeof(data) buffer bytes at a time */
320 (*adbase->read) (adbase, LOGFILE, (char *)data, tpos,
322 if (code != thisSize)
325 (*adbase->write) (adbase, tfile, (char *)data, filePos,
327 if (code != thisSize)
334 ubik_print("corrupt log opcode (%d) at position %d\n",
336 break; /* corrupt log! */
341 code = (*adbase->sync) (adbase, syncFile);
345 ubik_print("Log read error on pass 2\n");
350 /* now truncate the log, we're done with it */
351 code = (*adbase->truncate) (adbase, LOGFILE, 0);
356 * Called at initialization to figure out version of the dbase we really have.
358 * This routine is called after replaying the log; it reads the restored labels.
361 InitializeDB(struct ubik_dbase *adbase)
365 code = (*adbase->getlabel) (adbase, 0, &adbase->version);
367 /* try setting the label to a new value */
369 adbase->version.epoch = 1; /* value for newly-initialized db */
370 adbase->version.counter = 1;
371 code = (*adbase->setlabel) (adbase, 0, &adbase->version);
373 /* failed, try to set it back */
374 adbase->version.epoch = 0;
375 adbase->version.counter = 0;
376 (*adbase->setlabel) (adbase, 0, &adbase->version);
378 #ifdef AFS_PTHREAD_ENV
379 CV_BROADCAST(&adbase->version_cond);
381 LWP_NoYieldSignal(&adbase->version);
389 * \brief initialize the local ubik_dbase
391 * We replay the logs and then read the resulting file to figure out what version we've really got.
394 urecovery_Initialize(struct ubik_dbase *adbase)
398 code = ReplayLog(adbase);
401 code = InitializeDB(adbase);
406 * \brief Main interaction loop for the recovery manager
408 * The recovery light-weight process only runs when you're the
409 * synchronization site. It performs the following tasks, if and only
410 * if the prerequisite tasks have been performed successfully (it
411 * keeps track of which ones have been performed in its bit map,
412 * \p urecovery_state).
414 * First, it is responsible for probing that all servers are up. This
415 * is the only operation that must be performed even if this is not
416 * yet the sync site, since otherwise this site may not notice that
417 * enough other machines are running to even elect this guy to be the
420 * After that, the recovery process does nothing until the beacon and
421 * voting modules manage to get this site elected sync site.
423 * After becoming sync site, recovery first attempts to find the best
424 * database available in the network (it must do this in order to
425 * ensure finding the latest committed data). After finding the right
426 * database, it must fetch this dbase to the sync site.
428 * After fetching the dbase, it relabels it with a new version number,
429 * to ensure that everyone recognizes this dbase as the most recent
432 * One the dbase has been relabelled, this machine can start handling
433 * requests. However, the recovery module still has one more task:
434 * propagating the dbase out to everyone who is up in the network.
437 urecovery_Interact(void *dummy)
439 afs_int32 code, tcode;
440 struct ubik_server *bestServer = NULL;
441 struct ubik_server *ts;
442 int dbok, doingRPC, now;
443 afs_int32 lastProbeTime;
444 /* if we're the sync site, the best db version we've found yet */
445 static struct ubik_version bestDBVersion;
446 struct ubik_version tversion;
448 int length, tlen, offset, file, nbytes;
449 struct rx_call *rxcall;
451 struct ubik_stat ubikstat;
452 struct in_addr inAddr;
458 /* otherwise, begin interaction */
462 /* Run through this loop every 4 seconds */
465 #ifdef AFS_PTHREAD_ENV
466 select(0, 0, 0, 0, &tv);
468 IOMGR_Select(0, 0, 0, 0, &tv);
471 ubik_dprint("recovery running in state %x\n", urecovery_state);
473 /* Every 30 seconds, check all the down servers and mark them
474 * as up if they respond. When a server comes up or found to
475 * not be current, then re-find the the best database and
478 if ((now = FT_ApproxTime()) > 30 + lastProbeTime) {
480 #ifdef AFS_PTHREAD_ENV
484 for (ts = ubik_servers, doingRPC = 0; ts; ts = ts->next) {
493 urecovery_state &= ~UBIK_RECFOUNDDB;
495 } else if (!ts->currentDB) {
496 urecovery_state &= ~UBIK_RECFOUNDDB;
501 #ifdef AFS_PTHREAD_ENV
506 now = FT_ApproxTime();
510 /* Mark whether we are the sync site */
511 if (!ubeacon_AmSyncSite()) {
512 urecovery_state &= ~UBIK_RECSYNCSITE;
514 continue; /* nothing to do */
516 urecovery_state |= UBIK_RECSYNCSITE;
518 /* If a server has just come up or if we have not found the
519 * most current database, then go find the most current db.
521 if (!(urecovery_state & UBIK_RECFOUNDDB)) {
522 bestServer = (struct ubik_server *)0;
523 bestDBVersion.epoch = 0;
524 bestDBVersion.counter = 0;
525 for (ts = ubik_servers; ts; ts = ts->next) {
529 continue; /* don't bother with these guys */
535 code = DISK_GetVersion(ts->disk_rxcid, &ts->version);
538 /* perhaps this is the best version */
539 if (vcmp(ts->version, bestDBVersion) > 0) {
540 /* new best version */
541 bestDBVersion = ts->version;
546 /* take into consideration our version. Remember if we,
547 * the sync site, have the best version. Also note that
548 * we may need to send the best version out.
550 if (vcmp(ubik_dbase->version, bestDBVersion) >= 0) {
551 bestDBVersion = ubik_dbase->version;
552 bestServer = (struct ubik_server *)0;
553 urecovery_state |= UBIK_RECHAVEDB;
555 /* Clear the flag only when we know we have to retrieve
556 * the db. Because urecovery_AllBetter() looks at it.
558 urecovery_state &= ~UBIK_RECHAVEDB;
560 urecovery_state |= UBIK_RECFOUNDDB;
561 urecovery_state &= ~UBIK_RECSENTDB;
563 if (!(urecovery_state & UBIK_RECFOUNDDB)) {
565 continue; /* not ready */
568 /* If we, the sync site, do not have the best db version, then
569 * go and get it from the server that does.
571 if ((urecovery_state & UBIK_RECHAVEDB) || !bestServer) {
572 urecovery_state |= UBIK_RECHAVEDB;
574 /* we don't have the best version; we should fetch it. */
575 urecovery_AbortAll(ubik_dbase);
577 /* Rx code to do the Bulk fetch */
581 rxcall = rx_NewCall(bestServer->disk_rxcid);
583 ubik_print("Ubik: Synchronize database with server %s\n",
584 afs_inet_ntoa_r(bestServer->addr[0], hoststr));
587 code = StartDISK_GetFile(rxcall, file);
589 ubik_dprint("StartDiskGetFile failed=%d\n", code);
592 nbytes = rx_Read(rxcall, (char *)&length, sizeof(afs_int32));
593 length = ntohl(length);
594 if (nbytes != sizeof(afs_int32)) {
595 ubik_dprint("Rx-read length error=%d\n", code = BULK_ERROR);
600 /* give invalid label during file transit */
603 code = (*ubik_dbase->setlabel) (ubik_dbase, file, &tversion);
606 ubik_dprint("setlabel io error=%d\n", code);
609 snprintf(pbuffer, sizeof(pbuffer), "%s.DB%s%d.TMP",
610 ubik_dbase->pathName, (file<0)?"SYS":"",
611 (file<0)?-file:file);
612 fd = open(pbuffer, O_CREAT | O_RDWR | O_TRUNC, 0600);
617 code = lseek(fd, HDRSIZE, 0);
618 if (code != HDRSIZE) {
625 tlen = (length > sizeof(tbuffer) ? sizeof(tbuffer) : length);
626 #ifndef AFS_PTHREAD_ENV
630 nbytes = rx_Read(rxcall, tbuffer, tlen);
631 if (nbytes != tlen) {
632 ubik_dprint("Rx-read bulk error=%d\n", code = BULK_ERROR);
637 nbytes = write(fd, tbuffer, tlen);
639 if (nbytes != tlen) {
650 code = EndDISK_GetFile(rxcall, &tversion);
652 tcode = rx_EndCall(rxcall, code);
656 /* we got a new file, set up its header */
657 urecovery_state |= UBIK_RECHAVEDB;
659 memcpy(&ubik_dbase->version, &tversion,
660 sizeof(struct ubik_version));
661 snprintf(tbuffer, sizeof(tbuffer), "%s.DB%s%d",
662 ubik_dbase->pathName, (file<0)?"SYS":"",
663 (file<0)?-file:file);
665 snprintf(pbuffer, sizeof(pbuffer), "%s.DB%s%d.OLD",
666 ubik_dbase->pathName, (file<0)?"SYS":"",
667 (file<0)?-file:file);
668 code = unlink(pbuffer);
670 code = rename(tbuffer, pbuffer);
671 snprintf(pbuffer, sizeof(pbuffer), "%s.DB%s%d.TMP",
672 ubik_dbase->pathName, (file<0)?"SYS":"",
673 (file<0)?-file:file);
676 code = rename(pbuffer, tbuffer);
678 (*ubik_dbase->open) (ubik_dbase, file);
679 /* after data is good, sync disk with correct label */
681 (*ubik_dbase->setlabel) (ubik_dbase, 0,
682 &ubik_dbase->version);
686 snprintf(pbuffer, sizeof(pbuffer), "%s.DB%s%d.OLD",
687 ubik_dbase->pathName, (file<0)?"SYS":"",
688 (file<0)?-file:file);
695 * We will effectively invalidate the old data forever now.
696 * Unclear if we *should* but we do.
699 ubik_dbase->version.epoch = 0;
700 ubik_dbase->version.counter = 0;
702 ubik_print("Ubik: Synchronize database failed (error = %d)\n",
705 ubik_print("Ubik: Synchronize database completed\n");
706 urecovery_state |= UBIK_RECHAVEDB;
708 udisk_Invalidate(ubik_dbase, 0); /* data has changed */
709 #ifdef AFS_PTHREAD_ENV
710 CV_BROADCAST(&ubik_dbase->version_cond);
712 LWP_NoYieldSignal(&ubik_dbase->version);
716 if (!(urecovery_state & UBIK_RECHAVEDB)) {
718 continue; /* not ready */
721 /* If the database was newly initialized, then when we establish quorum, write
722 * a new label. This allows urecovery_AllBetter() to allow access for reads.
723 * Setting it to 2 also allows another site to come along with a newer
724 * database and overwrite this one.
726 if (ubik_dbase->version.epoch == 1) {
727 urecovery_AbortAll(ubik_dbase);
729 version_globals.ubik_epochTime = 2;
730 ubik_dbase->version.epoch = version_globals.ubik_epochTime;
731 ubik_dbase->version.counter = 1;
733 (*ubik_dbase->setlabel) (ubik_dbase, 0, &ubik_dbase->version);
735 udisk_Invalidate(ubik_dbase, 0); /* data may have changed */
736 #ifdef AFS_PTHREAD_ENV
737 CV_BROADCAST(&ubik_dbase->version_cond);
739 LWP_NoYieldSignal(&ubik_dbase->version);
743 /* Check the other sites and send the database to them if they
744 * do not have the current db.
746 if (!(urecovery_state & UBIK_RECSENTDB)) {
747 /* now propagate out new version to everyone else */
748 dbok = 1; /* start off assuming they all worked */
751 * Check if a write transaction is in progress. We can't send the
752 * db when a write is in progress here because the db would be
753 * obsolete as soon as it goes there. Also, ops after the begin
754 * trans would reach the recepient and wouldn't find a transaction
755 * pending there. Frankly, I don't think it's possible to get past
756 * the write-lock above if there is a write transaction in progress,
757 * but then, it won't hurt to check, will it?
759 if (ubik_dbase->flags & DBWRITING) {
764 while ((ubik_dbase->flags & DBWRITING) && (safety < 500)) {
766 /* sleep for a little while */
767 #ifdef AFS_PTHREAD_ENV
768 select(0, 0, 0, 0, &tv);
770 IOMGR_Select(0, 0, 0, 0, &tv);
778 for (ts = ubik_servers; ts; ts = ts->next) {
780 inAddr.s_addr = ts->addr[0];
785 ubik_dprint("recovery cannot send version to %s\n",
786 afs_inet_ntoa_r(inAddr.s_addr, hoststr));
791 ubik_dprint("recovery sending version to %s\n",
792 afs_inet_ntoa_r(inAddr.s_addr, hoststr));
793 if (vcmp(ts->version, ubik_dbase->version) != 0) {
794 ubik_dprint("recovery stating local database\n");
796 /* Rx code to do the Bulk Store */
797 code = (*ubik_dbase->stat) (ubik_dbase, 0, &ubikstat);
799 length = ubikstat.size;
802 rxcall = rx_NewCall(ts->disk_rxcid);
805 StartDISK_SendFile(rxcall, file, length,
806 &ubik_dbase->version);
808 ubik_dprint("StartDiskSendFile failed=%d\n",
815 sizeof(tbuffer) ? sizeof(tbuffer) : length);
817 (*ubik_dbase->read) (ubik_dbase, file,
818 tbuffer, offset, tlen);
819 if (nbytes != tlen) {
820 ubik_dprint("Local disk read error=%d\n",
824 nbytes = rx_Write(rxcall, tbuffer, tlen);
825 if (nbytes != tlen) {
826 ubik_dprint("Rx-write bulk error=%d\n", code =
833 code = EndDISK_SendFile(rxcall);
835 code = rx_EndCall(rxcall, code);
838 /* we set a new file, process its header */
839 ts->version = ubik_dbase->version;
844 /* mark file up to date */
849 urecovery_state |= UBIK_RECSENTDB;
857 * \brief send a Probe to all the network address of this server
859 * \return 0 if success, else return 1
862 DoProbe(struct ubik_server *server)
864 struct rx_connection *conns[UBIK_MAX_INTERFACE_ADDR];
865 struct rx_connection *connSuccess = 0;
866 int i, j, success_i = -1;
872 for (i = 0; (addr = server->addr[i]) && (i < UBIK_MAX_INTERFACE_ADDR);
875 rx_NewConnection(addr, ubik_callPortal, DISK_SERVICE_ID,
876 addr_globals.ubikSecClass, addr_globals.ubikSecIndex);
878 /* user requirement to use only the primary interface */
879 if (ubikPrimaryAddrOnly) {
885 osi_Assert(i); /* at least one interface address for this server */
887 #ifdef AFS_PTHREAD_ENV
893 if (!multi_error) { /* first success */
900 #ifdef AFS_PTHREAD_ENV
904 if (success_i >= 0) {
906 addr = server->addr[success_i]; /* successful interface addr */
908 if (server->disk_rxcid) /* destroy existing conn */
909 rx_DestroyConnection(server->disk_rxcid);
910 if (server->vote_rxcid)
911 rx_DestroyConnection(server->vote_rxcid);
913 /* make new connections */
914 server->disk_rxcid = conns[success_i];
915 server->vote_rxcid = rx_NewConnection(addr, ubik_callPortal,
916 VOTE_SERVICE_ID, addr_globals.ubikSecClass,
917 addr_globals.ubikSecIndex);
919 connSuccess = conns[success_i];
920 strcpy(buffer, afs_inet_ntoa_r(server->addr[0], hoststr));
922 ubik_print("ubik:server %s is back up: will be contacted through %s\n",
923 buffer, afs_inet_ntoa_r(addr, hoststr));
927 /* Destroy all connections except the one on which we succeeded */
928 for (j = 0; j < i; j++)
929 if (conns[j] != connSuccess)
930 rx_DestroyConnection(conns[j]);
933 ubik_dprint("ubik:server %s still down\n",
934 afs_inet_ntoa_r(server->addr[0], hoststr));
937 return 0; /* success */
939 return 1; /* failure */