}
}
-/* called with cm_scacheLock write-locked; recycles an existing scp.
- *
- * this function ignores all of the locking hierarchy.
- */
+/* called with cm_scacheLock and scp write-locked */
+void cm_ResetSCacheDirectory(cm_scache_t *scp, afs_int32 dirlock)
+{
+#ifdef USE_BPLUS
+ /* destroy directory Bplus Tree */
+ if (scp->dirBplus) {
+ LARGE_INTEGER start, end;
+
+ if (!dirlock && !lock_TryWrite(&scp->dirlock)) {
+ /*
+ * We are not holding the dirlock and obtaining it
+ * requires that we drop the scp->rw. As a result
+ * we will leave the dirBplus tree intact but
+ * invalidate the version number so that whatever
+ * operation is currently active can safely complete
+ * but the contents will be ignored on the next
+ * directory operation.
+ */
+ scp->dirDataVersion = CM_SCACHE_VERSION_BAD;
+ return;
+ }
+
+ QueryPerformanceCounter(&start);
+ bplus_free_tree++;
+ freeBtree(scp->dirBplus);
+ scp->dirBplus = NULL;
+ scp->dirDataVersion = CM_SCACHE_VERSION_BAD;
+ QueryPerformanceCounter(&end);
+
+ if (!dirlock)
+ lock_ReleaseWrite(&scp->dirlock);
+
+ bplus_free_time += (end.QuadPart - start.QuadPart);
+ }
+#endif
+}
+
+/* called with cm_scacheLock and scp write-locked; recycles an existing scp. */
long cm_RecycleSCache(cm_scache_t *scp, afs_int32 flags)
{
if (scp->refCount != 0) {
return -1;
}
- lock_ObtainWrite(&scp->rw);
cm_RemoveSCacheFromHashTable(scp);
- lock_ReleaseWrite(&scp->rw);
#if 0
if (flags & CM_SCACHE_RECYCLEFLAG_DESTROY_BUFFERS) {
bufp->dirty_length = 0;
bufp->flags |= CM_BUF_ERROR;
bufp->error = VNOVNODE;
- bufp->dataVersion = -1; /* bad */
+ bufp->dataVersion = CM_BUF_VERSION_BAD; /* bad */
bufp->dirtyCounter++;
if (bufp->flags & CM_BUF_WAITING) {
osi_Log2(afsd_logp, "CM RecycleSCache Waking [scp 0x%x] bufp 0x%x", scp, bufp);
bufp->dirty_length = 0;
bufp->flags |= CM_BUF_ERROR;
bufp->error = VNOVNODE;
- bufp->dataVersion = -1; /* bad */
+ bufp->dataVersion = CM_BUF_VERSION_BAD; /* bad */
bufp->dirtyCounter++;
if (bufp->flags & CM_BUF_WAITING) {
osi_Log2(afsd_logp, "CM RecycleSCache Waking [scp 0x%x] bufp 0x%x", scp, bufp);
| CM_SCACHEFLAG_OUTOFSPACE
| CM_SCACHEFLAG_EACCESS);
scp->serverModTime = 0;
- scp->dataVersion = 0;
- scp->bufDataVersionLow = 0;
+ scp->dataVersion = CM_SCACHE_VERSION_BAD;
+ scp->bufDataVersionLow = CM_SCACHE_VERSION_BAD;
scp->bulkStatProgress = hzero;
scp->waitCount = 0;
scp->waitQueueT = NULL;
scp->serverLock = (-1);
scp->exclusiveLocks = 0;
scp->sharedLocks = 0;
- scp->lockDataVersion = -1;
+ scp->lockDataVersion = CM_SCACHE_VERSION_BAD;
/* not locked, but there can be no references to this guy
* while we hold the global refcount lock.
*/
cm_FreeAllACLEnts(scp);
-#ifdef USE_BPLUS
- /* destroy directory Bplus Tree */
- if (scp->dirBplus) {
- LARGE_INTEGER start, end;
- QueryPerformanceCounter(&start);
- bplus_free_tree++;
- freeBtree(scp->dirBplus);
- scp->dirBplus = NULL;
- QueryPerformanceCounter(&end);
-
- bplus_free_time += (end.QuadPart - start.QuadPart);
- }
-#endif
+ cm_ResetSCacheDirectory(scp, 0);
return 0;
}
-/* called with cm_scacheLock write-locked; find a vnode to recycle.
+/*
+ * called with cm_scacheLock write-locked; find a vnode to recycle.
* Can allocate a new one if desperate, or if below quota (cm_data.maxSCaches).
+ * returns scp->mx held.
*/
cm_scache_t *cm_GetNewSCache(void)
{
if (scp->refCount == 0) {
if (scp->flags & CM_SCACHEFLAG_DELETED) {
+ if (!lock_TryWrite(&scp->rw))
+ continue;
+
osi_Log1(afsd_logp, "GetNewSCache attempting to recycle deleted scp 0x%x", scp);
if (!cm_RecycleSCache(scp, CM_SCACHE_RECYCLEFLAG_DESTROY_BUFFERS)) {
/* and we're done */
return scp;
}
+ lock_ReleaseWrite(&scp->rw);
osi_Log1(afsd_logp, "GetNewSCache recycled failed scp 0x%x", scp);
} else if (!(scp->flags & CM_SCACHEFLAG_INHASH)) {
+ if (!lock_TryWrite(&scp->rw))
+ continue;
+
/* we found an entry, so return it */
/* now remove from the LRU queue and put it back at the
* head of the LRU queue.
* we must not recycle the scp. */
if (scp->refCount == 0 && scp->bufReadsp == NULL && scp->bufWritesp == NULL) {
if (!buf_DirtyBuffersExist(&scp->fid)) {
+ if (!lock_TryWrite(&scp->rw))
+ continue;
+
if (!cm_RecycleSCache(scp, 0)) {
/* we found an entry, so return it */
/* now remove from the LRU queue and put it back at the
/* and we're done */
return scp;
}
+ lock_ReleaseWrite(&scp->rw);
} else {
osi_Log1(afsd_logp,"GetNewSCache dirty buffers exist scp 0x%x", scp);
}
"invalid cm_scache_t address");
memset(scp, 0, sizeof(cm_scache_t));
scp->magic = CM_SCACHE_MAGIC;
- lock_InitializeRWLock(&scp->rw, "cm_scache_t rw");
- lock_InitializeRWLock(&scp->bufCreateLock, "cm_scache_t bufCreateLock");
+ lock_InitializeRWLock(&scp->rw, "cm_scache_t rw", LOCK_HIERARCHY_SCACHE);
+ osi_assertx(lock_TryWrite(&scp->rw), "cm_scache_t rw held after allocation");
+ lock_InitializeRWLock(&scp->bufCreateLock, "cm_scache_t bufCreateLock", LOCK_HIERARCHY_SCACHE_BUFCREATE);
#ifdef USE_BPLUS
- lock_InitializeRWLock(&scp->dirlock, "cm_scache_t dirlock");
+ lock_InitializeRWLock(&scp->dirlock, "cm_scache_t dirlock", LOCK_HIERARCHY_SCACHE_DIRLOCK);
#endif
scp->serverLock = -1;
cm_data.fakeSCache.linkCount = 1;
cm_data.fakeSCache.refCount = 1;
}
- lock_InitializeRWLock(&cm_data.fakeSCache.rw, "cm_scache_t rw");
+ lock_InitializeRWLock(&cm_data.fakeSCache.rw, "cm_scache_t rw", LOCK_HIERARCHY_SCACHE);
}
long
for ( scp = cm_data.allSCachesp; scp;
scp = scp->allNextp ) {
if (scp->randomACLp) {
+ lock_ReleaseWrite(&cm_scacheLock);
lock_ObtainWrite(&scp->rw);
+ lock_ObtainWrite(&cm_scacheLock);
cm_FreeAllACLEnts(scp);
lock_ReleaseWrite(&scp->rw);
}
if (scp->dirBplus)
freeBtree(scp->dirBplus);
scp->dirBplus = NULL;
- scp->dirDataVersion = -1;
+ scp->dirDataVersion = CM_SCACHE_VERSION_BAD;
lock_FinalizeRWLock(&scp->dirlock);
#endif
lock_FinalizeRWLock(&scp->rw);
static osi_once_t once;
if (osi_Once(&once)) {
- lock_InitializeRWLock(&cm_scacheLock, "cm_scacheLock");
+ lock_InitializeRWLock(&cm_scacheLock, "cm_scacheLock", LOCK_HIERARCHY_SCACHE_GLOBAL);
if ( newFile ) {
memset(cm_data.scacheHashTablep, 0, sizeof(cm_scache_t *) * cm_data.scacheHashTableSize);
cm_data.allSCachesp = NULL;
for ( scp = cm_data.allSCachesp; scp;
scp = scp->allNextp ) {
- lock_InitializeRWLock(&scp->rw, "cm_scache_t rw");
- lock_InitializeRWLock(&scp->bufCreateLock, "cm_scache_t bufCreateLock");
+ lock_InitializeRWLock(&scp->rw, "cm_scache_t rw", LOCK_HIERARCHY_SCACHE);
+ lock_InitializeRWLock(&scp->bufCreateLock, "cm_scache_t bufCreateLock", LOCK_HIERARCHY_SCACHE_BUFCREATE);
#ifdef USE_BPLUS
- lock_InitializeRWLock(&scp->dirlock, "cm_scache_t dirlock");
+ lock_InitializeRWLock(&scp->dirlock, "cm_scache_t dirlock", LOCK_HIERARCHY_SCACHE_DIRLOCK);
#endif
scp->cbServerp = NULL;
scp->cbExpires = 0;
scp->waitCount = 0;
#ifdef USE_BPLUS
scp->dirBplus = NULL;
- scp->dirDataVersion = -1;
+ scp->dirDataVersion = CM_SCACHE_VERSION_BAD;
#endif
scp->waitQueueT = NULL;
scp->flags &= ~CM_SCACHEFLAG_WAITING;
for (scp=cm_data.scacheHashTablep[hash]; scp; scp=scp->nextp) {
if (cm_FidCmp(fidp, &scp->fid) == 0) {
#ifdef DEBUG_REFCOUNT
- afsi_log("%s:%d cm_GetSCache (1) outScpp 0x%p ref %d", file, line, scp, scp->refCount);
- osi_Log1(afsd_logp,"cm_GetSCache (1) outScpp 0x%p", scp);
+ afsi_log("%s:%d cm_GetSCache (1) scp 0x%p ref %d", file, line, scp, scp->refCount);
+ osi_Log1(afsd_logp,"cm_GetSCache (1) scp 0x%p", scp);
#endif
#ifdef AFS_FREELANCE_CLIENT
if (cm_freelanceEnabled && special &&
}
if (cm_freelanceEnabled && special) {
- char mp[MOUNTPOINTLEN] = "";
- afs_uint32 fileType;
-
lock_ReleaseWrite(&cm_scacheLock);
osi_Log0(afsd_logp,"cm_GetSCache Freelance and special");
cm_reInitLocalMountPoints(); // start reinit
}
- lock_ObtainMutex(&cm_Freelance_Lock);
- if (fidp->vnode >= 2 && fidp->vnode - 2 < cm_noLocalMountPoints) {
- strncpy(mp,(cm_localMountPoints+fidp->vnode-2)->mountPointStringp, MOUNTPOINTLEN);
- mp[MOUNTPOINTLEN-1] = '\0';
- if ( !strnicmp(mp, "msdfs:", strlen("msdfs:")) )
- fileType = CM_SCACHETYPE_DFSLINK;
- else
- fileType = (cm_localMountPoints+fidp->vnode-2)->fileType;
- } else {
- fileType = CM_SCACHETYPE_INVALID;
-
- }
- lock_ReleaseMutex(&cm_Freelance_Lock);
lock_ObtainWrite(&cm_scacheLock);
- if (scp == NULL)
- scp = cm_GetNewSCache();
- if (scp == NULL) {
- osi_Log0(afsd_logp,"cm_GetSCache unable to obtain *new* scache entry");
+ if (scp == NULL) {
+ scp = cm_GetNewSCache(); /* returns scp->rw held */
+ if (scp == NULL) {
+ osi_Log0(afsd_logp,"cm_GetSCache unable to obtain *new* scache entry");
+ lock_ReleaseWrite(&cm_scacheLock);
+ return CM_ERROR_WOULDBLOCK;
+ }
+ } else {
lock_ReleaseWrite(&cm_scacheLock);
- return CM_ERROR_WOULDBLOCK;
- }
-
-#if not_too_dangerous
- /* dropping the cm_scacheLock allows more than one thread
- * to obtain the same cm_scache_t from the LRU list. Since
- * the refCount is known to be zero at this point we have to
- * assume that no one else is using the one this is returned.
- */
- lock_ReleaseWrite(&cm_scacheLock);
- lock_ObtainWrite(&scp->rw);
- lock_ObtainWrite(&cm_scacheLock);
-#endif
+ lock_ObtainWrite(&scp->rw);
+ lock_ObtainWrite(&cm_scacheLock);
+ }
scp->fid = *fidp;
scp->dotdotFid.cell=AFS_FAKE_ROOT_CELL_ID;
scp->dotdotFid.volume=AFS_FAKE_ROOT_VOL_ID;
}
scp->refCount = 1;
osi_Log1(afsd_logp,"cm_GetSCache (freelance) sets refCount to 1 scp 0x%x", scp);
- scp->fileType = fileType;
- scp->length.LowPart = (DWORD)strlen(mp)+4;
+
+ /* must be called after the scp->fid is set */
+ cm_FreelanceFetchMountPointString(scp);
+ cm_FreelanceFetchFileType(scp);
+
+ scp->length.LowPart = (DWORD)strlen(scp->mountPointStringp)+4;
scp->length.HighPart = 0;
- strncpy(scp->mountPointStringp,mp,MOUNTPOINTLEN);
scp->owner=0x0;
scp->unixModeBits=0777;
scp->clientModTime=FakeFreelanceModTime;
scp->dataVersion=cm_data.fakeDirVersion;
scp->bufDataVersionLow=cm_data.fakeDirVersion;
scp->lockDataVersion=-1; /* no lock yet */
-#if not_too_dangerous
- lock_ReleaseWrite(&scp->rw);
-#endif
- *outScpp = scp;
+ lock_ReleaseWrite(&scp->rw);
lock_ReleaseWrite(&cm_scacheLock);
+ *outScpp = scp;
#ifdef DEBUG_REFCOUNT
- afsi_log("%s:%d cm_GetSCache (2) outScpp 0x%p ref %d", file, line, scp, scp->refCount);
- osi_Log1(afsd_logp,"cm_GetSCache (2) outScpp 0x%p", scp);
+ afsi_log("%s:%d cm_GetSCache (2) scp 0x%p ref %d", file, line, scp, scp->refCount);
+ osi_Log1(afsd_logp,"cm_GetSCache (2) scp 0x%p", scp);
#endif
return 0;
}
for (scp=cm_data.scacheHashTablep[hash]; scp; scp=scp->nextp) {
if (cm_FidCmp(fidp, &scp->fid) == 0) {
#ifdef DEBUG_REFCOUNT
- afsi_log("%s:%d cm_GetSCache (3) outScpp 0x%p ref %d", file, line, scp, scp->refCount);
- osi_Log1(afsd_logp,"cm_GetSCache (3) outScpp 0x%p", scp);
+ afsi_log("%s:%d cm_GetSCache (3) scp 0x%p ref %d", file, line, scp, scp->refCount);
+ osi_Log1(afsd_logp,"cm_GetSCache (3) scp 0x%p", scp);
#endif
cm_HoldSCacheNoLock(scp);
cm_AdjustScacheLRU(scp);
}
/* now, if we don't have the fid, recycle something */
- scp = cm_GetNewSCache();
+ scp = cm_GetNewSCache(); /* returns scp->rw held */
if (scp == NULL) {
osi_Log0(afsd_logp,"cm_GetNewSCache unable to obtain *new* scache entry");
lock_ReleaseWrite(&cm_scacheLock);
cm_PutVolume(volp);
return CM_ERROR_WOULDBLOCK;
}
- osi_Log2(afsd_logp,"cm_GetNewSCache returns scp 0x%x flags 0x%x", scp, scp->flags);
+#ifdef DEBUG_REFCOUNT
+ afsi_log("%s:%d cm_GetNewSCache returns scp 0x%p flags 0x%x", file, line, scp, scp->flags);
+#endif
+ osi_Log2(afsd_logp,"cm_GetNewSCache returns scp 0x%p flags 0x%x", scp, scp->flags);
osi_assertx(!(scp->flags & CM_SCACHEFLAG_INHASH), "CM_SCACHEFLAG_INHASH set");
-#if not_too_dangerous
- /* dropping the cm_scacheLock allows more than one thread
- * to obtain the same cm_scache_t from the LRU list. Since
- * the refCount is known to be zero at this point we have to
- * assume that no one else is using the one this is returned.
- */
- lock_ReleaseWrite(&cm_scacheLock);
- lock_ObtainWrite(&scp->rw);
- lock_ObtainWrite(&cm_scacheLock);
-#endif
scp->fid = *fidp;
if (!cm_freelanceEnabled || !isRoot) {
/* if this scache entry represents a volume root then we need
scp->nextp = cm_data.scacheHashTablep[hash];
cm_data.scacheHashTablep[hash] = scp;
scp->flags |= CM_SCACHEFLAG_INHASH;
- scp->refCount = 1;
- osi_Log1(afsd_logp,"cm_GetSCache sets refCount to 1 scp 0x%x", scp);
-#if not_too_dangerous
lock_ReleaseWrite(&scp->rw);
+ scp->refCount = 1;
+#ifdef DEBUG_REFCOUNT
+ afsi_log("%s:%d cm_GetSCache sets refCount to 1 scp 0x%x", file, line, scp);
#endif
+ osi_Log1(afsd_logp,"cm_GetSCache sets refCount to 1 scp 0x%x", scp);
/* XXX - The following fields in the cm_scache are
* uninitialized:
* parentVnode
* parentUnique
*/
- lock_ReleaseWrite(&cm_scacheLock);
/* now we have a held scache entry; just return it */
*outScpp = scp;
#ifdef DEBUG_REFCOUNT
- afsi_log("%s:%d cm_GetSCache (4) outScpp 0x%p ref %d", file, line, scp, scp->refCount);
- osi_Log1(afsd_logp,"cm_GetSCache (4) outScpp 0x%p", scp);
+ afsi_log("%s:%d cm_GetSCache (4) scp 0x%p ref %d", file, line, scp, scp->refCount);
+ osi_Log1(afsd_logp,"cm_GetSCache (4) scp 0x%p", scp);
#endif
+ lock_ReleaseWrite(&cm_scacheLock);
return 0;
}
afs_uint32 sleep_buf_cmflags = 0;
afs_uint32 sleep_scp_bufs = 0;
int wakeupCycle;
- int getAccessRights = 1;
lock_AssertWrite(&scp->rw);
if ((rights & (PRSFS_WRITE|PRSFS_DELETE)) && (scp->flags & CM_SCACHEFLAG_RO))
return CM_ERROR_READONLY;
- if (cm_HaveAccessRights(scp, userp, rights, &outRights) || !getAccessRights) {
+ if (cm_HaveAccessRights(scp, userp, rights, &outRights)) {
if (~outRights & rights)
return CM_ERROR_NOACCESS;
}
}
if (code)
return code;
- getAccessRights = 0; /* do not repeat */
continue;
}
}
void cm_MergeStatus(cm_scache_t *dscp,
cm_scache_t *scp, AFSFetchStatus *statusp,
AFSVolSync *volsyncp,
- cm_user_t *userp, afs_uint32 flags)
+ cm_user_t *userp, cm_req_t *reqp, afs_uint32 flags)
{
afs_uint64 dataVersion;
scp->group = 0;
scp->unixModeBits = 0;
scp->anyAccess = 0;
- scp->dataVersion = 0;
- scp->bufDataVersionLow = 0;
+ scp->dataVersion = CM_SCACHE_VERSION_BAD;
+ scp->bufDataVersionLow = CM_SCACHE_VERSION_BAD;
if (dscp) {
scp->parentVnode = dscp->fid.vnode;
dataVersion <<= 32;
dataVersion |= statusp->DataVersion;
- if (!(flags & CM_MERGEFLAG_FORCE) && dataVersion < scp->dataVersion) {
+ if (!(flags & CM_MERGEFLAG_FORCE) &&
+ dataVersion < scp->dataVersion &&
+ scp->dataVersion != CM_SCACHE_VERSION_BAD) {
struct cm_cell *cellp;
cellp = cm_FindCellByID(scp->fid.cell, 0);
if (scp->cbServerp) {
struct cm_volume *volp = NULL;
-
cm_FindVolumeByID(cellp, scp->fid.volume, userp,
- (cm_req_t *) NULL, CM_GETVOL_FLAG_CREATE, &volp);
+ reqp, CM_GETVOL_FLAG_CREATE, &volp);
osi_Log2(afsd_logp, "old data from server %x volume %s",
scp->cbServerp->addr.sin_addr.s_addr,
volp ? volp->namep : "(unknown)");
scp->cbServerp = NULL;
}
scp->cbExpires = 0;
- scp->flags &= ~CM_SCACHEFLAG_CALLBACK;
+ scp->flags &= ~(CM_SCACHEFLAG_CALLBACK | CM_SCACHEFLAG_LOCAL);
cm_dnlcPurgedp(scp);
cm_dnlcPurgevp(scp);
cm_FreeAllACLEnts(scp);
#endif
{
afs_int32 refCount;
- long lockstate;
osi_assertx(scp != NULL, "null cm_scache_t");
lock_AssertAny(&cm_scacheLock);
- lockstate = lock_GetRWLockState(&cm_scacheLock);
refCount = InterlockedDecrement(&scp->refCount);
#ifdef DEBUG_REFCOUNT
if (refCount < 0)
if (refCount == 0 && (scp->flags & CM_SCACHEFLAG_DELETED)) {
int deleted = 0;
+ long lockstate;
+
+ lockstate = lock_GetRWLockState(&cm_scacheLock);
if (lockstate != OSI_RWLOCK_WRITEHELD)
- lock_ConvertRToW(&cm_scacheLock);
+ lock_ReleaseRead(&cm_scacheLock);
+ else
+ lock_ReleaseWrite(&cm_scacheLock);
+
lock_ObtainWrite(&scp->rw);
if (scp->flags & CM_SCACHEFLAG_DELETED)
deleted = 1;
- lock_ReleaseWrite(&scp->rw);
- if (refCount == 0 && deleted)
+
+ if (refCount == 0 && deleted) {
+ lock_ObtainWrite(&cm_scacheLock);
cm_RecycleSCache(scp, 0);
- if (lockstate != OSI_RWLOCK_WRITEHELD)
- lock_ConvertWToR(&cm_scacheLock);
+ if (lockstate != OSI_RWLOCK_WRITEHELD)
+ lock_ConvertWToR(&cm_scacheLock);
+ } else {
+ if (lockstate != OSI_RWLOCK_WRITEHELD)
+ lock_ObtainRead(&cm_scacheLock);
+ else
+ lock_ObtainWrite(&cm_scacheLock);
+ }
+ lock_ReleaseWrite(&scp->rw);
}
}
osi_Log2(afsd_logp,"cm_ReleaseSCache scp 0x%p ref %d",scp, refCount);
afsi_log("%s:%d cm_ReleaseSCache scp 0x%p ref %d", file, line, scp, refCount);
#endif
+ lock_ReleaseRead(&cm_scacheLock);
if (scp->flags & CM_SCACHEFLAG_DELETED) {
int deleted = 0;
lock_ObtainWrite(&scp->rw);
if (scp->flags & CM_SCACHEFLAG_DELETED)
deleted = 1;
- lock_ReleaseWrite(&scp->rw);
if (deleted) {
- lock_ConvertRToW(&cm_scacheLock);
+ lock_ObtainWrite(&cm_scacheLock);
cm_RecycleSCache(scp, 0);
- lock_ConvertWToR(&cm_scacheLock);
+ lock_ReleaseWrite(&cm_scacheLock);
}
+ lock_ReleaseWrite(&scp->rw);
}
-
- lock_ReleaseRead(&cm_scacheLock);
}
/* just look for the scp entry to get filetype */
git://git.openafs.org / openafs.git / blobdiff