csc_policy_logon_updates-20040503
[openafs.git] / src / WINNT / afsd / smb3.c
index a41d5c7..44acc8d 100644 (file)
@@ -40,21 +40,21 @@ smb_tran2Packet_t *smb_tran2AssemblyQueuep;
 cm_user_t *smb_GetTran2User(smb_vc_t *vcp, smb_tran2Packet_t *inp)
 {
        smb_user_t *uidp;
-        cm_user_t *up = NULL;
+    cm_user_t *up = NULL;
         
-        uidp = smb_FindUID(vcp, inp->uid, 0);
-        if (!uidp) return NULL;
+    uidp = smb_FindUID(vcp, inp->uid, 0);
+    if (!uidp) return NULL;
         
        lock_ObtainMutex(&uidp->mx);
-        if (uidp->unp) {
-          up = uidp->unp->userp;
-          cm_HoldUser(up);
-        }
+    if (uidp->unp) {
+        up = uidp->unp->userp;
+        cm_HoldUser(up);
+    }
        lock_ReleaseMutex(&uidp->mx);
 
-        smb_ReleaseUID(uidp);
-        
-        return up;
+    smb_ReleaseUID(uidp);
+
+    return up;
 }
 
 /*
@@ -89,21 +89,22 @@ unsigned long smb_ExtAttributes(cm_scache_t *scp)
 
 int smb_V3IsStarMask(char *maskp)
 {
-        char tc;
+    char tc;
 
        while (tc = *maskp++)
-         if (tc == '?' || tc == '*') return 1;
+        if (tc == '?' || tc == '*') 
+            return 1;
        return 0;
 }
 
 unsigned char *smb_ParseString(unsigned char *inp, char **chainpp)
 {
-        if (chainpp) {
+    if (chainpp) {
                /* skip over null-terminated string */
                *chainpp = inp + strlen(inp) + 1;
-        }
-        return inp;
-}
+    }
+    return inp;
+}   
 
 long smb_ReceiveV3SessionSetupX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
 {
@@ -150,7 +151,7 @@ long smb_ReceiveV3SessionSetupX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *
         userp = unp->userp;
         newUid = (unsigned short)uidp->userID;  /* For some reason these are different types!*/
                osi_LogEvent("AFS smb_ReceiveV3SessionSetupX",NULL,"FindUserByName:Lana[%d],lsn[%d],userid[%d],name[%s]",vcp->lana,vcp->lsn,newUid,usern);
-               osi_Log3(afsd_logp,"smb_ReceiveV3SessionSetupX FindUserByName:Lana[%d],lsn[%d],userid[%d]",vcp->lana,vcp->lsn,newUid);
+               osi_Log3(smb_logp,"smb_ReceiveV3SessionSetupX FindUserByName:Lana[%d],lsn[%d],userid[%d]",vcp->lana,vcp->lsn,newUid);
         smb_ReleaseUID(uidp);
     }
     else {
@@ -160,7 +161,7 @@ long smb_ReceiveV3SessionSetupX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *
         /* Create a new UID and cm_user_t structure */
         userp = unp->userp;
         if (!userp)
-          userp = cm_NewUser();
+            userp = cm_NewUser();
         lock_ObtainMutex(&vcp->mx);
         if (!vcp->uidCounter)
             vcp->uidCounter++; /* handle unlikely wraparounds */
@@ -176,7 +177,7 @@ long smb_ReceiveV3SessionSetupX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *
         lock_ObtainMutex(&uidp->mx);
         uidp->unp = unp;
                osi_LogEvent("AFS smb_ReceiveV3SessionSetupX",NULL,"MakeNewUser:VCP[%x],Lana[%d],lsn[%d],userid[%d],TicketKTCName[%s]",(int)vcp,vcp->lana,vcp->lsn,newUid,usern);
-               osi_Log4(afsd_logp,"smb_ReceiveV3SessionSetupX MakeNewUser:VCP[%x],Lana[%d],lsn[%d],userid[%d]",vcp,vcp->lana,vcp->lsn,newUid);
+               osi_Log4(smb_logp,"smb_ReceiveV3SessionSetupX MakeNewUser:VCP[%x],Lana[%d],lsn[%d],userid[%d]",vcp,vcp->lana,vcp->lsn,newUid);
         lock_ReleaseMutex(&uidp->mx);
         smb_ReleaseUID(uidp);
     }
@@ -186,8 +187,8 @@ long smb_ReceiveV3SessionSetupX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *
     /* Also to the next chained message */
     ((smb_t *)inp)->uid = newUid;
 
-    osi_Log3(afsd_logp, "SMB3 session setup name %s creating ID %d%s",
-             osi_LogSaveString(afsd_logp, usern), newUid, osi_LogSaveString(afsd_logp, s1));
+    osi_Log3(smb_logp, "SMB3 session setup name %s creating ID %d%s",
+             osi_LogSaveString(smb_logp, usern), newUid, osi_LogSaveString(smb_logp, s1));
     smb_SetSMBParm(outp, 2, 0);
     smb_SetSMBDataLength(outp, 0);
     return 0;
@@ -211,10 +212,10 @@ long smb_ReceiveV3UserLogoffX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *ou
                if (s2 == NULL) s2 = " ";
                if (s1 == NULL) {s1 = s2; s2 = " ";}
 
-               osi_Log4(afsd_logp, "SMB3 user logoffX uid %d name %s%s%s",
-                        uidp->userID,
-                        osi_LogSaveString(afsd_logp,
-                 (uidp->unp) ? uidp->unp->name: " "), s1, s2);
+               osi_Log4(smb_logp, "SMB3 user logoffX uid %d name %s%s%s",
+                  uidp->userID,
+                  osi_LogSaveString(smb_logp,
+                                    (uidp->unp) ? uidp->unp->name: " "), s1, s2);
 
                lock_ObtainMutex(&uidp->mx);
                uidp->flags |= SMB_USERFLAG_DELETE;
@@ -222,49 +223,51 @@ long smb_ReceiveV3UserLogoffX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *ou
                 * it doesn't get deleted right away
                 * because the vcp points to it
                 */
-                lock_ReleaseMutex(&uidp->mx);
-        }
-       else
-               osi_Log0(afsd_logp, "SMB3 user logoffX");
+        lock_ReleaseMutex(&uidp->mx);
+    }
+       else    
+               osi_Log0(smb_logp, "SMB3 user logoffX");
 
-        smb_SetSMBDataLength(outp, 0);
-        return 0;
+    smb_SetSMBDataLength(outp, 0);
+    return 0;
 }
 
+#define SMB_SUPPORT_SEARCH_BITS        0x0001
+
 long smb_ReceiveV3TreeConnectX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
 {
-        smb_tid_t *tidp;
-        unsigned short newTid;
-        char shareName[256];
+    smb_tid_t *tidp;
+    unsigned short newTid;
+    char shareName[256];
        char *sharePath;
        int shareFound;
-        char *tp;
-        char *pathp;
-        char *passwordp;
+    char *tp;
+    char *pathp;
+    char *passwordp;
        char *servicep;
-        cm_user_t *userp;
+    cm_user_t *userp;
         
-       osi_Log0(afsd_logp, "SMB3 receive tree connect");
+       osi_Log0(smb_logp, "SMB3 receive tree connect");
 
        /* parse input parameters */
        tp = smb_GetSMBData(inp, NULL);
-        passwordp = smb_ParseString(tp, &tp);
+    passwordp = smb_ParseString(tp, &tp);
        pathp = smb_ParseString(tp, &tp);
        servicep = smb_ParseString(tp, &tp);
 
        tp = strrchr(pathp, '\\');
-        if (!tp) {
-                return CM_ERROR_BADSMB;
-        }
-        strcpy(shareName, tp+1);
+    if (!tp) {
+        return CM_ERROR_BADSMB;
+    }
+    strcpy(shareName, tp+1);
 
        if (strcmp(servicep, "IPC") == 0 || strcmp(shareName, "IPC$") == 0)
                return CM_ERROR_NOIPC;
 
-        userp = smb_GetUser(vcp, inp);
+    userp = smb_GetUser(vcp, inp);
 
        lock_ObtainMutex(&vcp->mx);
-        newTid = vcp->tidCounter++;
+    newTid = vcp->tidCounter++;
        lock_ReleaseMutex(&vcp->mx);
         
        tidp = smb_FindTID(vcp, newTid, SMB_FLAG_CREATE);
@@ -273,39 +276,42 @@ long smb_ReceiveV3TreeConnectX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *o
                smb_ReleaseTID(tidp);
                return CM_ERROR_BADSHARENAME;
        }
-        lock_ObtainMutex(&tidp->mx);
-        tidp->userp = userp;
+    lock_ObtainMutex(&tidp->mx);
+    tidp->userp = userp;
        tidp->pathname = sharePath;
-        lock_ReleaseMutex(&tidp->mx);
-        smb_ReleaseTID(tidp);
+    lock_ReleaseMutex(&tidp->mx);
+    smb_ReleaseTID(tidp);
 
        if (vcp->flags & SMB_VCFLAG_USENT)
-               smb_SetSMBParm(outp, 2, 0);     /* OptionalSupport bits */
+    {
+        int policy = smb_FindShareCSCPolicy(shareName);
+        smb_SetSMBParm(outp, 2, SMB_SUPPORT_SEARCH_BITS | (policy << 2));
+    }
 
        ((smb_t *)outp)->tid = newTid;
        ((smb_t *)inp)->tid = newTid;
        tp = smb_GetSMBData(outp, NULL);
-        *tp++ = 'A';
-        *tp++ = ':';
-        *tp++ = 0;
-        smb_SetSMBDataLength(outp, 3);
-        
-        osi_Log1(afsd_logp, "SMB3 tree connect created ID %d", newTid);
-        return 0;
+    *tp++ = 'A';
+    *tp++ = ':';
+    *tp++ = 0;
+    smb_SetSMBDataLength(outp, 3);
+
+    osi_Log1(smb_logp, "SMB3 tree connect created ID %d", newTid);
+    return 0;
 }
 
 /* must be called with global tran lock held */
 smb_tran2Packet_t *smb_FindTran2Packet(smb_vc_t *vcp, smb_packet_t *inp)
 {
        smb_tran2Packet_t *tp;
-        smb_t *smbp;
+    smb_t *smbp;
         
-        smbp = (smb_t *) inp->data;
+    smbp = (smb_t *) inp->data;
        for(tp = smb_tran2AssemblyQueuep; tp; tp = (smb_tran2Packet_t *) osi_QNext(&tp->q)) {
                if (tp->vcp == vcp && tp->mid == smbp->mid && tp->tid == smbp->tid)
-                       return tp;
-        }
-        return NULL;
+            return tp;
+    }
+    return NULL;
 }
 
 smb_tran2Packet_t *smb_NewTran2Packet(smb_vc_t *vcp, smb_packet_t *inp,
@@ -347,18 +353,18 @@ smb_tran2Packet_t *smb_GetTran2ResponsePacket(smb_vc_t *vcp,
        unsigned short dataAlign;
         
        tp = malloc(sizeof(*tp));
-        memset(tp, 0, sizeof(*tp));
-        tp->vcp = NULL;
-        tp->curData = tp->curParms = 0;
-        tp->totalData = totalData;
-        tp->totalParms = totalParms;
+    memset(tp, 0, sizeof(*tp));
+    tp->vcp = NULL;
+    tp->curData = tp->curParms = 0;
+    tp->totalData = totalData;
+    tp->totalParms = totalParms;
        tp->oldTotalParms = totalParms;
-        tp->tid = inp->tid;
-        tp->mid = inp->mid;
-        tp->uid = inp->uid;
-        tp->pid = inp->pid;
+    tp->tid = inp->tid;
+    tp->mid = inp->mid;
+    tp->uid = inp->uid;
+    tp->pid = inp->pid;
        tp->res[0] = inp->res[0];
-        tp->opcode = inp->opcode;
+    tp->opcode = inp->opcode;
 
        /*
         * We calculate where the parameters and data will start.
@@ -375,7 +381,7 @@ smb_tran2Packet_t *smb_GetTran2ResponsePacket(smb_vc_t *vcp,
        dataOffset += dataAlign;
        tp->datap = outp->data + dataOffset;
 
-        return tp;
+    return tp;
 }
 
 /* free a tran2 packet; must be called with smb_globalLock held */
@@ -397,29 +403,29 @@ void smb_FreeTran2Packet(smb_tran2Packet_t *t2p)
 void smb_SendTran2Error(smb_vc_t *vcp, smb_tran2Packet_t *t2p,
        smb_packet_t *tp, long code)
 {
-        smb_t *smbp;
-        unsigned short errCode;
-        unsigned char errClass;
+    smb_t *smbp;
+    unsigned short errCode;
+    unsigned char errClass;
        unsigned long NTStatus;
 
-        if (vcp->flags & SMB_VCFLAG_STATUS32)
+    if (vcp->flags & SMB_VCFLAG_STATUS32)
                smb_MapNTError(code, &NTStatus);
        else
                smb_MapCoreError(code, vcp, &errCode, &errClass);
 
-        smb_FormatResponsePacket(vcp, NULL, tp);
-        smbp = (smb_t *) tp;
-        
+    smb_FormatResponsePacket(vcp, NULL, tp);
+    smbp = (smb_t *) tp;
+
        /* We can handle long names */
        if (vcp->flags & SMB_VCFLAG_USENT)
                smbp->flg2 |= 0x40;     /* IS_LONG_NAME */
         
-        /* now copy important fields from the tran 2 packet */
-        smbp->com = 0x32;              /* tran 2 response */
-        smbp->tid = t2p->tid;
-        smbp->mid = t2p->mid;
-        smbp->pid = t2p->pid;
-        smbp->uid = t2p->uid;
+    /* now copy important fields from the tran 2 packet */
+    smbp->com = 0x32;          /* tran 2 response */
+    smbp->tid = t2p->tid;
+    smbp->mid = t2p->mid;
+    smbp->pid = t2p->pid;
+    smbp->uid = t2p->uid;
        smbp->res[0] = t2p->res[0];
        if (vcp->flags & SMB_VCFLAG_STATUS32) {
                smbp->rcls = (unsigned char) (NTStatus & 0xff);
@@ -429,83 +435,83 @@ void smb_SendTran2Error(smb_vc_t *vcp, smb_tran2Packet_t *t2p,
                smbp->flg2 |= 0x4000;
        }
        else {
-               smbp->rcls = errClass;
+        smbp->rcls = errClass;
                smbp->errLow = (unsigned char) (errCode & 0xff);
                smbp->errHigh = (unsigned char) ((errCode >> 8) & 0xff);
        }
         
-        /* send packet */
-        smb_SendPacket(vcp, tp);
+    /* send packet */
+    smb_SendPacket(vcp, tp);
 }        
 
 void smb_SendTran2Packet(smb_vc_t *vcp, smb_tran2Packet_t *t2p, smb_packet_t *tp)
 {
-        smb_t *smbp;
-        unsigned short parmOffset;
+    smb_t *smbp;
+    unsigned short parmOffset;
        unsigned short dataOffset;
        unsigned short totalLength;
        unsigned short dataAlign;
-        char *datap;
+    char *datap;
         
-        smb_FormatResponsePacket(vcp, NULL, tp);
-        smbp = (smb_t *) tp;
+    smb_FormatResponsePacket(vcp, NULL, tp);
+    smbp = (smb_t *) tp;
 
        /* We can handle long names */
        if (vcp->flags & SMB_VCFLAG_USENT)
                smbp->flg2 |= 0x40;     /* IS_LONG_NAME */
-        
-        /* now copy important fields from the tran 2 packet */
-        smbp->com = 0x32;              /* tran 2 response */
-        smbp->tid = t2p->tid;
-        smbp->mid = t2p->mid;
-        smbp->pid = t2p->pid;
-        smbp->uid = t2p->uid;
+
+    /* now copy important fields from the tran 2 packet */
+    smbp->com = 0x32;          /* tran 2 response */
+    smbp->tid = t2p->tid;
+    smbp->mid = t2p->mid;
+    smbp->pid = t2p->pid;
+    smbp->uid = t2p->uid;
        smbp->res[0] = t2p->res[0];
 
-        totalLength = 1 + t2p->totalData + t2p->totalParms;
+    totalLength = 1 + t2p->totalData + t2p->totalParms;
 
-        /* now add the core parameters (tran2 info) to the packet */
-        smb_SetSMBParm(tp, 0, t2p->totalParms);        /* parm bytes */
-        smb_SetSMBParm(tp, 1, t2p->totalData); /* data bytes */
-        smb_SetSMBParm(tp, 2, 0);              /* reserved */
-        smb_SetSMBParm(tp, 3, t2p->totalParms);        /* parm bytes in this packet */
+    /* now add the core parameters (tran2 info) to the packet */
+    smb_SetSMBParm(tp, 0, t2p->totalParms);    /* parm bytes */
+    smb_SetSMBParm(tp, 1, t2p->totalData);     /* data bytes */
+    smb_SetSMBParm(tp, 2, 0);          /* reserved */
+    smb_SetSMBParm(tp, 3, t2p->totalParms);    /* parm bytes in this packet */
        parmOffset = 10*2 + 35;                 /* parm offset in packet */
        parmOffset++;                           /* round to even */
-        smb_SetSMBParm(tp, 4, parmOffset);     /* 11 parm words plus *
-                                                * hdr, bcc and wct */
-        smb_SetSMBParm(tp, 5, 0);              /* parm displacement */
-        smb_SetSMBParm(tp, 6, t2p->totalData); /* data in this packet */
+    smb_SetSMBParm(tp, 4, parmOffset); /* 11 parm words plus *
+    * hdr, bcc and wct */
+    smb_SetSMBParm(tp, 5, 0);          /* parm displacement */
+    smb_SetSMBParm(tp, 6, t2p->totalData);     /* data in this packet */
        dataOffset = parmOffset + t2p->oldTotalParms;
        dataAlign = dataOffset & 2;             /* quad-align */
        dataOffset += dataAlign;
-        smb_SetSMBParm(tp, 7, dataOffset);     /* offset of data */
-        smb_SetSMBParm(tp, 8, 0);              /* data displacement */
-        smb_SetSMBParm(tp, 9, 0);              /* low: setup word count *
-                                                * high: resvd */
-        
-        datap = smb_GetSMBData(tp, NULL);
+    smb_SetSMBParm(tp, 7, dataOffset); /* offset of data */
+    smb_SetSMBParm(tp, 8, 0);          /* data displacement */
+    smb_SetSMBParm(tp, 9, 0);          /* low: setup word count *
+    * high: resvd */
+
+    datap = smb_GetSMBData(tp, NULL);
        *datap++ = 0;                           /* we rounded to even */
 
        totalLength += dataAlign;
-        smb_SetSMBDataLength(tp, totalLength);
+    smb_SetSMBDataLength(tp, totalLength);
         
-        /* next, send the datagram */
-        smb_SendPacket(vcp, tp);
-}
+    /* next, send the datagram */
+    smb_SendPacket(vcp, tp);
+}   
 
 long smb_ReceiveV3Tran2A(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
 {
-        smb_tran2Packet_t *asp;
-        int totalParms;
-        int totalData;
-        int parmDisp;
-        int dataDisp;
-        int parmOffset;
-        int dataOffset;
-        int parmCount;
-        int dataCount;
-        int firstPacket;
-        long code;
+    smb_tran2Packet_t *asp;
+    int totalParms;
+    int totalData;
+    int parmDisp;
+    int dataDisp;
+    int parmOffset;
+    int dataOffset;
+    int parmCount;
+    int dataCount;
+    int firstPacket;
+    long code = 0;
 
        /* We sometimes see 0 word count.  What to do? */
        if (*inp->wctp == 0) {
@@ -513,7 +519,7 @@ long smb_ReceiveV3Tran2A(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
                HANDLE h;
                char *ptbuf[1];
 
-               osi_Log0(afsd_logp, "TRANSACTION2 word count = 0"); 
+               osi_Log0(smb_logp, "TRANSACTION2 word count = 0"); 
 
                h = RegisterEventSource(NULL, AFS_DAEMON_EVENT_NAME);
                ptbuf[0] = "Transaction2 word count = 0";
@@ -521,51 +527,51 @@ long smb_ReceiveV3Tran2A(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
                            1, inp->ncb_length, ptbuf, inp);
                DeregisterEventSource(h);
 #else /* DJGPP */
-               osi_Log0(afsd_logp, "TRANSACTION2 word count = 0"); 
+               osi_Log0(smb_logp, "TRANSACTION2 word count = 0"); 
 #endif /* !DJGPP */
 
-                smb_SetSMBDataLength(outp, 0);
-                smb_SendPacket(vcp, outp);
+        smb_SetSMBDataLength(outp, 0);
+        smb_SendPacket(vcp, outp);
                return 0;
        }
 
-        totalParms = smb_GetSMBParm(inp, 0);
-        totalData = smb_GetSMBParm(inp, 1);
+    totalParms = smb_GetSMBParm(inp, 0);
+    totalData = smb_GetSMBParm(inp, 1);
         
-        firstPacket = (inp->inCom == 0x32);
+    firstPacket = (inp->inCom == 0x32);
         
        /* find the packet we're reassembling */
        lock_ObtainWrite(&smb_globalLock);
-        asp = smb_FindTran2Packet(vcp, inp);
-        if (!asp) {
-               asp = smb_NewTran2Packet(vcp, inp, totalParms, totalData);
+    asp = smb_FindTran2Packet(vcp, inp);
+    if (!asp) {
+        asp = smb_NewTran2Packet(vcp, inp, totalParms, totalData);
        }
-        lock_ReleaseWrite(&smb_globalLock);
+    lock_ReleaseWrite(&smb_globalLock);
         
-        /* now merge in this latest packet; start by looking up offsets */
+    /* now merge in this latest packet; start by looking up offsets */
        if (firstPacket) {
                parmDisp = dataDisp = 0;
-                parmOffset = smb_GetSMBParm(inp, 10);
-                dataOffset = smb_GetSMBParm(inp, 12);
-                parmCount = smb_GetSMBParm(inp, 9);
-                dataCount = smb_GetSMBParm(inp, 11);
+        parmOffset = smb_GetSMBParm(inp, 10);
+        dataOffset = smb_GetSMBParm(inp, 12);
+        parmCount = smb_GetSMBParm(inp, 9);
+        dataCount = smb_GetSMBParm(inp, 11);
                asp->maxReturnParms = smb_GetSMBParm(inp, 2);
-                asp->maxReturnData = smb_GetSMBParm(inp, 3);
+        asp->maxReturnData = smb_GetSMBParm(inp, 3);
 
-               osi_Log3(afsd_logp, "SMB3 received T2 init packet total data %d, cur data %d, max return data %d",
-                       totalData, dataCount, asp->maxReturnData);
-        }
-        else {
-               parmDisp = smb_GetSMBParm(inp, 4);
-               parmOffset = smb_GetSMBParm(inp, 3);
-               dataDisp = smb_GetSMBParm(inp, 7);
-               dataOffset = smb_GetSMBParm(inp, 6);
-               parmCount = smb_GetSMBParm(inp, 2);
-               dataCount = smb_GetSMBParm(inp, 5);
-                
-                osi_Log2(afsd_logp, "SMB3 received T2 aux packet parms %d, data %d",
-                       parmCount, dataCount);
-       }
+               osi_Log3(smb_logp, "SMB3 received T2 init packet total data %d, cur data %d, max return data %d",
+                 totalData, dataCount, asp->maxReturnData);
+    }
+    else {
+        parmDisp = smb_GetSMBParm(inp, 4);
+        parmOffset = smb_GetSMBParm(inp, 3);
+        dataDisp = smb_GetSMBParm(inp, 7);
+        dataOffset = smb_GetSMBParm(inp, 6);
+        parmCount = smb_GetSMBParm(inp, 2);
+        dataCount = smb_GetSMBParm(inp, 5);
+
+        osi_Log2(smb_logp, "SMB3 received T2 aux packet parms %d, data %d",
+                 parmCount, dataCount);
+    }   
 
     /* now copy the parms and data */
     if ( parmCount != 0 )
@@ -576,50 +582,50 @@ long smb_ReceiveV3Tran2A(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
         memcpy(asp->datap + dataDisp, inp->data + dataOffset, dataCount);
     }
 
-        /* account for new bytes */
-        asp->curData += dataCount;
-        asp->curParms += parmCount;
-        
-        /* finally, if we're done, remove the packet from the queue and dispatch it */
-        if (asp->totalData <= asp->curData && asp->totalParms <= asp->curParms) {
+    /* account for new bytes */
+    asp->curData += dataCount;
+    asp->curParms += parmCount;
+
+    /* finally, if we're done, remove the packet from the queue and dispatch it */
+    if (asp->totalData <= asp->curData && asp->totalParms <= asp->curParms) {
                /* we've received it all */
-                lock_ObtainWrite(&smb_globalLock);
+        lock_ObtainWrite(&smb_globalLock);
                osi_QRemove((osi_queue_t **) &smb_tran2AssemblyQueuep, &asp->q);
-                lock_ReleaseWrite(&smb_globalLock);
-                
-            /* now dispatch it */
-            if ( asp->opcode >= 0 && asp->opcode < 20 && smb_tran2DispatchTable[asp->opcode].procp) {
-                osi_LogEvent("AFS-Dispatch-2[%s]",myCrt_2Dispatch(asp->opcode),"vcp[%x] lana[%d] lsn[%d]",(int)vcp,vcp->lana,vcp->lsn);
-                osi_Log4(afsd_logp,"AFS Server - Dispatch-2 %s vcp[%x] lana[%d] lsn[%d]",myCrt_2Dispatch(asp->opcode),vcp,vcp->lana,vcp->lsn);
-                code = (*smb_tran2DispatchTable[asp->opcode].procp)(vcp, asp, outp);
-            }
-            else {
-                osi_LogEvent("AFS-Dispatch-2 [invalid]", NULL, "op[%x] vcp[%x] lana[%d] lsn[%d]", asp->opcode, vcp, vcp->lana, vcp->lsn);
-                osi_Log4(afsd_logp,"AFS Server - Dispatch-2 [INVALID] op[%x] vcp[%x] lana[%d] lsn[%d]", asp->opcode, vcp, vcp->lana, vcp->lsn);
-                code = CM_ERROR_BADOP;
-            }
+        lock_ReleaseWrite(&smb_globalLock);
+
+        /* now dispatch it */
+        if ( asp->opcode >= 0 && asp->opcode < 20 && smb_tran2DispatchTable[asp->opcode].procp) {
+            osi_LogEvent("AFS-Dispatch-2[%s]",myCrt_2Dispatch(asp->opcode),"vcp[%x] lana[%d] lsn[%d]",(int)vcp,vcp->lana,vcp->lsn);
+            osi_Log4(smb_logp,"AFS Server - Dispatch-2 %s vcp[%x] lana[%d] lsn[%d]",myCrt_2Dispatch(asp->opcode),vcp,vcp->lana,vcp->lsn);
+            code = (*smb_tran2DispatchTable[asp->opcode].procp)(vcp, asp, outp);
+        }
+        else {
+            osi_LogEvent("AFS-Dispatch-2 [invalid]", NULL, "op[%x] vcp[%x] lana[%d] lsn[%d]", asp->opcode, vcp, vcp->lana, vcp->lsn);
+            osi_Log4(smb_logp,"AFS Server - Dispatch-2 [INVALID] op[%x] vcp[%x] lana[%d] lsn[%d]", asp->opcode, vcp, vcp->lana, vcp->lsn);
+            code = CM_ERROR_BADOP;
+        }
 
                /* if an error is returned, we're supposed to send an error packet,
-                 * otherwise the dispatched function already did the data sending.
-                * We give dispatched proc the responsibility since it knows how much
-                 * space to allocate.
-                 */
-                if (code != 0) {
-                        smb_SendTran2Error(vcp, asp, outp, code);
-                }
+         * otherwise the dispatched function already did the data sending.
+         * We give dispatched proc the responsibility since it knows how much
+         * space to allocate.
+         */
+        if (code != 0) {
+            smb_SendTran2Error(vcp, asp, outp, code);
+        }
 
                /* free the input tran 2 packet */
                lock_ObtainWrite(&smb_globalLock);
-                smb_FreeTran2Packet(asp);
+        smb_FreeTran2Packet(asp);
                lock_ReleaseWrite(&smb_globalLock);
-        }
-        else if (firstPacket) {
+    }
+    else if (firstPacket) {
                /* the first packet in a multi-packet request, we need to send an
-                 * ack to get more data.
-                 */
-                smb_SetSMBDataLength(outp, 0);
-                smb_SendPacket(vcp, outp);
-        }
+         * ack to get more data.
+         */
+        smb_SetSMBDataLength(outp, 0);
+        smb_SendPacket(vcp, outp);
+    }
 
        return 0;
 }
@@ -628,7 +634,7 @@ long smb_ReceiveTran2Open(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t *op)
 {
        char *pathp;
     smb_tran2Packet_t *outp;
-    long code;
+    long code = 0;
        cm_space_t *spacep;
     int excl;
     cm_user_t *userp;
@@ -733,7 +739,7 @@ long smb_ReceiveTran2Open(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t *op)
        userp = smb_GetTran2User(vcp, p);
     /* In the off chance that userp is NULL, we log and abandon */
     if(!userp) {
-        osi_Log1(afsd_logp, "ReceiveTran2Open user [%d] not resolvable", p->uid);
+        osi_Log1(smb_logp, "ReceiveTran2Open user [%d] not resolvable", p->uid);
         smb_FreeTran2Packet(outp);
         return CM_ERROR_BADSMB;
     }
@@ -923,23 +929,23 @@ long smb_ReceiveTran2Open(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t *op)
 
 long smb_ReceiveTran2FindFirst(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t *outp)
 {
-        return CM_ERROR_BADOP;
+    return CM_ERROR_BADOP;
 }
 
 long smb_ReceiveTran2FindNext(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t *outp)
 {
-        return CM_ERROR_BADOP;
+    return CM_ERROR_BADOP;
 }
 
 long smb_ReceiveTran2QFSInfo(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t *op)
 {
        smb_tran2Packet_t *outp;
-        smb_tran2QFSInfo_t qi;
+    smb_tran2QFSInfo_t qi;
        int responseSize;
        osi_hyper_t temp;
        static char FSname[6] = {'A', 0, 'F', 0, 'S', 0};
         
-       osi_Log1(afsd_logp, "T2 QFSInfo type 0x%x", p->parmsp[0]);
+       osi_Log1(smb_logp, "T2 QFSInfo type 0x%x", p->parmsp[0]);
 
        switch (p->parmsp[0]) {
        case 1: responseSize = sizeof(qi.u.allocInfo); break;
@@ -951,18 +957,18 @@ long smb_ReceiveTran2QFSInfo(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t *
        default: return CM_ERROR_INVAL;
        }
 
-        outp = smb_GetTran2ResponsePacket(vcp, p, op, 0, responseSize);
+    outp = smb_GetTran2ResponsePacket(vcp, p, op, 0, responseSize);
        switch (p->parmsp[0]) {
        case 1:
                /* alloc info */
-                qi.u.allocInfo.FSID = 0;
-                qi.u.allocInfo.sectorsPerAllocUnit = 1;
-                qi.u.allocInfo.totalAllocUnits = 0x7fffffff;
-                qi.u.allocInfo.availAllocUnits = 0x3fffffff;
-                qi.u.allocInfo.bytesPerSector = 1024;
+        qi.u.allocInfo.FSID = 0;
+        qi.u.allocInfo.sectorsPerAllocUnit = 1;
+        qi.u.allocInfo.totalAllocUnits = 0x7fffffff;
+        qi.u.allocInfo.availAllocUnits = 0x3fffffff;
+        qi.u.allocInfo.bytesPerSector = 1024;
                break;
 
-        case 2:
+    case 2:
                /* volume info */
         qi.u.volumeInfo.vsn = 1234;
         qi.u.volumeInfo.vnCount = 4;
@@ -1011,23 +1017,23 @@ long smb_ReceiveTran2QFSInfo(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t *
                qi.u.FSattributeInfo.FSnameLength = 6;
                memcpy(qi.u.FSattributeInfo.FSname, FSname, 6);
                break;
-        }
+    }
         
        /* copy out return data, and set corresponding sizes */
        outp->totalParms = 0;
-        outp->totalData = responseSize;
-        memcpy(outp->datap, &qi, responseSize);
+    outp->totalData = responseSize;
+    memcpy(outp->datap, &qi, responseSize);
 
        /* send and free the packets */
        smb_SendTran2Packet(vcp, outp, op);
-        smb_FreeTran2Packet(outp);
+    smb_FreeTran2Packet(outp);
 
-        return 0;
+    return 0;
 }
 
 long smb_ReceiveTran2SetFSInfo(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t *outp)
 {
-        return CM_ERROR_BADOP;
+    return CM_ERROR_BADOP;
 }
 
 struct smb_ShortNameRock {
@@ -1065,14 +1071,14 @@ long cm_GetShortName(char *pathp, cm_user_t *userp, cm_req_t *reqp,
        cm_space_t *spacep;
        cm_scache_t *dscp;
        int caseFold = CM_FLAG_FOLLOW | CM_FLAG_CASEFOLD;
-       long code;
+       long code = 0;
        osi_hyper_t thyper;
 
        spacep = cm_GetSpace();
        smb_StripLastComponent(spacep->data, &lastNamep, pathp);
 
        code = cm_NameI(cm_rootSCachep, spacep->data, caseFold, userp, tidPathp,
-                       reqp, &dscp);
+                     reqp, &dscp);
        cm_FreeSpace(spacep);
        if (code) return code;
 
@@ -1084,7 +1090,7 @@ long cm_GetShortName(char *pathp, cm_user_t *userp, cm_req_t *reqp,
        rock.vnode = vnode;
        rock.maskp = lastNamep;
        code = cm_ApplyDir(dscp, cm_GetShortNameProc, &rock, &thyper, userp,
-                          reqp, NULL);
+                        reqp, NULL);
 
        cm_ReleaseSCache(dscp);
 
@@ -1100,19 +1106,19 @@ long cm_GetShortName(char *pathp, cm_user_t *userp, cm_req_t *reqp,
 long smb_ReceiveTran2QPathInfo(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t *opx)
 {
        smb_tran2Packet_t *outp;
-        unsigned long dosTime;
+    unsigned long dosTime;
        FILETIME ft;
-        unsigned short infoLevel;
-        int nbytesRequired;
-        unsigned short attributes;
+    unsigned short infoLevel;
+    int nbytesRequired;
+    unsigned short attributes;
        unsigned long extAttributes;
        char shortName[13];
        unsigned int len;
-        cm_user_t *userp;
+    cm_user_t *userp;
        cm_space_t *spacep;
-        cm_scache_t *scp, *dscp;
-        long code;
-        char *op;
+    cm_scache_t *scp, *dscp;
+    long code = 0;
+    char *op;
        char *tidPathp;
        char *lastComp;
        cm_req_t req;
@@ -1120,23 +1126,23 @@ long smb_ReceiveTran2QPathInfo(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t
        cm_InitReq(&req);
 
        infoLevel = p->parmsp[0];
-        if (infoLevel == 6) nbytesRequired = 0;
-        else if (infoLevel == 1) nbytesRequired = 22;
-        else if (infoLevel == 2) nbytesRequired = 26;
+    if (infoLevel == 6) nbytesRequired = 0;
+    else if (infoLevel == 1) nbytesRequired = 22;
+    else if (infoLevel == 2) nbytesRequired = 26;
        else if (infoLevel == 0x101) nbytesRequired = 40;
        else if (infoLevel == 0x102) nbytesRequired = 24;
        else if (infoLevel == 0x103) nbytesRequired = 4;
        else if (infoLevel == 0x108) nbytesRequired = 30;
-        else {
-               osi_Log2(afsd_logp, "Bad Tran2 op 0x%x infolevel 0x%x",
-                        p->opcode, infoLevel);
+    else {
+               osi_Log2(smb_logp, "Bad Tran2 op 0x%x infolevel 0x%x",
+                  p->opcode, infoLevel);
                smb_SendTran2Error(vcp, p, opx, CM_ERROR_INVAL);
-                return 0;
-        }
-       osi_Log2(afsd_logp, "T2 QPathInfo type 0x%x path %s", infoLevel,
-                osi_LogSaveString(afsd_logp, (char *)(&p->parmsp[3])));
+        return 0;
+    }
+       osi_Log2(smb_logp, "T2 QPathInfo type 0x%x path %s", infoLevel,
+             osi_LogSaveString(smb_logp, (char *)(&p->parmsp[3])));
 
-        outp = smb_GetTran2ResponsePacket(vcp, p, opx, 2, nbytesRequired);
+    outp = smb_GetTran2ResponsePacket(vcp, p, opx, 2, nbytesRequired);
 
        if (infoLevel > 0x100)
                outp->totalParms = 2;
@@ -1144,22 +1150,22 @@ long smb_ReceiveTran2QPathInfo(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t
                outp->totalParms = 0;
         outp->totalData = nbytesRequired;
         
-        /* now, if we're at infoLevel 6, we're only being asked to check
-         * the syntax, so we just OK things now.  In particular, we're *not*
-         * being asked to verify anything about the state of any parent dirs.
-         */
+    /* now, if we're at infoLevel 6, we're only being asked to check
+     * the syntax, so we just OK things now.  In particular, we're *not*
+     * being asked to verify anything about the state of any parent dirs.
+     */
        if (infoLevel == 6) {
                smb_SendTran2Packet(vcp, outp, opx);
-                smb_FreeTran2Packet(outp);
+        smb_FreeTran2Packet(outp);
                return 0;
-        }
+    }
         
-        userp = smb_GetTran2User(vcp, p);
-        if(!userp) {
-               osi_Log1(afsd_logp, "ReceiveTran2QPathInfo unable to resolve user [%d]", p->uid);
-               smb_FreeTran2Packet(outp);
-               return CM_ERROR_BADSMB;
-        }
+    userp = smb_GetTran2User(vcp, p);
+    if(!userp) {
+        osi_Log1(smb_logp, "ReceiveTran2QPathInfo unable to resolve user [%d]", p->uid);
+        smb_FreeTran2Packet(outp);
+        return CM_ERROR_BADSMB;
+    }
 
        tidPathp = smb_GetTIDPath(vcp, p->tid);
 
@@ -1215,30 +1221,30 @@ long smb_ReceiveTran2QPathInfo(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t
        }
 
        /* now do namei and stat, and copy out the info */
-        code = cm_NameI(cm_rootSCachep, (char *)(&p->parmsp[3]),
-               CM_FLAG_FOLLOW | CM_FLAG_CASEFOLD, userp, tidPathp, &req, &scp);
+    code = cm_NameI(cm_rootSCachep, (char *)(&p->parmsp[3]),
+                    CM_FLAG_FOLLOW | CM_FLAG_CASEFOLD, userp, tidPathp, &req, &scp);
 
        if (code) {
                cm_ReleaseUser(userp);
-                smb_SendTran2Error(vcp, p, opx, code);
-                smb_FreeTran2Packet(outp);
-                return 0;
-        }
+        smb_SendTran2Error(vcp, p, opx, code);
+        smb_FreeTran2Packet(outp);
+        return 0;
+    }
 
-        lock_ObtainMutex(&scp->mx);
+    lock_ObtainMutex(&scp->mx);
         code = cm_SyncOp(scp, NULL, userp, &req, 0,
-               CM_SCACHESYNC_NEEDCALLBACK | CM_SCACHESYNC_GETSTATUS);
+                         CM_SCACHESYNC_NEEDCALLBACK | CM_SCACHESYNC_GETSTATUS);
        if (code) goto done;
         
-        /* now we have the status in the cache entry, and everything is locked.
+    /* now we have the status in the cache entry, and everything is locked.
         * Marshall the output data.
-         */
+     */
        op = outp->datap;
        /* for info level 108, figure out short name */
        if (infoLevel == 0x108) {
                code = cm_GetShortName((char *)(&p->parmsp[3]), userp, &req,
-                                       tidPathp, scp->fid.vnode, shortName,
-                                       (size_t *) &len);
+                                tidPathp, scp->fid.vnode, shortName,
+                                (size_t *) &len);
                if (code) {
                        goto done;
                }
@@ -1252,11 +1258,11 @@ long smb_ReceiveTran2QPathInfo(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t
        }
        if (infoLevel == 1 || infoLevel == 2) {
                smb_SearchTimeFromUnixTime(&dosTime, scp->clientModTime);
-               *((u_long *)op) = dosTime; op += 4;     /* creation time */
-               *((u_long *)op) = dosTime; op += 4;     /* access time */
-               *((u_long *)op) = dosTime; op += 4;     /* write time */
-               *((u_long *)op) = scp->length.LowPart; op += 4; /* length */
-               *((u_long *)op) = scp->length.LowPart; op += 4; /* alloc size */
+        *((u_long *)op) = dosTime; op += 4;    /* creation time */
+        *((u_long *)op) = dosTime; op += 4;    /* access time */
+        *((u_long *)op) = dosTime; op += 4;    /* write time */
+        *((u_long *)op) = scp->length.LowPart; op += 4;        /* length */
+        *((u_long *)op) = scp->length.LowPart; op += 4;        /* alloc size */
                attributes = smb_Attributes(scp);
                *((u_short *)op) = attributes; op += 2; /* attributes */
        }
@@ -1290,20 +1296,22 @@ long smb_ReceiveTran2QPathInfo(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t
         
 
        /* send and free the packets */
-done:
+  done:
        lock_ReleaseMutex(&scp->mx);
-        cm_ReleaseSCache(scp);
-        cm_ReleaseUser(userp);
-       if (code == 0) smb_SendTran2Packet(vcp, outp, opx);
-        else smb_SendTran2Error(vcp, p, opx, code);
-        smb_FreeTran2Packet(outp);
+    cm_ReleaseSCache(scp);
+    cm_ReleaseUser(userp);
+       if (code == 0) 
+        smb_SendTran2Packet(vcp, outp, opx);
+    else 
+        smb_SendTran2Error(vcp, p, opx, code);
+    smb_FreeTran2Packet(outp);
 
-        return 0;
+    return 0;
 }
 
 long smb_ReceiveTran2SetPathInfo(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t *outp)
 {
-        return CM_ERROR_BADOP;
+    return CM_ERROR_BADOP;
 }
 
 long smb_ReceiveTran2QFileInfo(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t *opx)
@@ -1318,7 +1326,7 @@ long smb_ReceiveTran2QFileInfo(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t
     smb_fid_t *fidp;
        cm_scache_t *scp;
        char *op;
-       long code;
+       long code = 0;
        cm_req_t req;
 
        cm_InitReq(&req);
@@ -1337,13 +1345,13 @@ long smb_ReceiveTran2QFileInfo(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t
        else if (infoLevel == 0x103) nbytesRequired = 4;
        else if (infoLevel == 0x104) nbytesRequired = 6;
        else {
-               osi_Log2(afsd_logp, "Bad Tran2 op 0x%x infolevel 0x%x",
+               osi_Log2(smb_logp, "Bad Tran2 op 0x%x infolevel 0x%x",
                  p->opcode, infoLevel);
                smb_SendTran2Error(vcp, p, opx, CM_ERROR_INVAL);
         smb_ReleaseFID(fidp);
                return 0;
        }
-       osi_Log2(afsd_logp, "T2 QFileInfo type 0x%x fid %d", infoLevel, fid);
+       osi_Log2(smb_logp, "T2 QFileInfo type 0x%x fid %d", infoLevel, fid);
 
        outp = smb_GetTran2ResponsePacket(vcp, p, opx, 2, nbytesRequired);
 
@@ -1355,7 +1363,7 @@ long smb_ReceiveTran2QFileInfo(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t
 
        userp = smb_GetTran2User(vcp, p);
     if(!userp) {
-       osi_Log1(afsd_logp, "ReceiveTran2QFileInfo unable to resolve user [%d]", p->uid);
+       osi_Log1(smb_logp, "ReceiveTran2QFileInfo unable to resolve user [%d]", p->uid);
        code = CM_ERROR_BADSMB;
        goto done;
     }
@@ -1407,7 +1415,7 @@ long smb_ReceiveTran2QFileInfo(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t
        }
 
        /* send and free the packets */
-done:
+  done:
        lock_ReleaseMutex(&scp->mx);
        cm_ReleaseUser(userp);
        smb_ReleaseFID(fidp);
@@ -1420,7 +1428,7 @@ done:
 
 long smb_ReceiveTran2SetFileInfo(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t *op)
 {
-       long code;
+       long code = 0;
        unsigned short fid;
        smb_fid_t *fidp;
        unsigned short infoLevel;
@@ -1441,7 +1449,7 @@ long smb_ReceiveTran2SetFileInfo(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet
 
        infoLevel = p->parmsp[1];
        if (infoLevel > 0x104 || infoLevel < 0x101) {
-               osi_Log2(afsd_logp, "Bad Tran2 op 0x%x infolevel 0x%x",
+               osi_Log2(smb_logp, "Bad Tran2 op 0x%x infolevel 0x%x",
                         p->opcode, infoLevel);
                smb_SendTran2Error(vcp, p, op, CM_ERROR_INVAL);
         smb_ReleaseFID(fidp);
@@ -1460,7 +1468,7 @@ long smb_ReceiveTran2SetFileInfo(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet
                return 0;
        }
 
-       osi_Log1(afsd_logp, "T2 SFileInfo type 0x%x", infoLevel);
+       osi_Log1(smb_logp, "T2 SFileInfo type 0x%x", infoLevel);
 
        outp = smb_GetTran2ResponsePacket(vcp, p, op, 2, 0);
 
@@ -1469,7 +1477,7 @@ long smb_ReceiveTran2SetFileInfo(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet
 
        userp = smb_GetTran2User(vcp, p);
     if(!userp) {
-       osi_Log1(afsd_logp,"ReceiveTran2SetFileInfo unable to resolve user [%d]", p->uid);
+       osi_Log1(smb_logp,"ReceiveTran2SetFileInfo unable to resolve user [%d]", p->uid);
        code = CM_ERROR_BADSMB;
        goto done;
     }
@@ -1553,7 +1561,7 @@ long smb_ReceiveTran2SetFileInfo(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet
                        fidp->flags &= ~SMB_FID_DELONCLOSE;
                }
        }
-done:
+  done:
        cm_ReleaseUser(userp);
        smb_ReleaseFID(fidp);
        if (code == 0) smb_SendTran2Packet(vcp, outp, op);
@@ -1565,75 +1573,74 @@ done:
 
 long smb_ReceiveTran2FSCTL(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t *outp)
 {
-        return CM_ERROR_BADOP;
+    return CM_ERROR_BADOP;
 }
 
 long smb_ReceiveTran2IOCTL(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t *outp)
 {
-        return CM_ERROR_BADOP;
+    return CM_ERROR_BADOP;
 }
 
 long smb_ReceiveTran2FindNotifyFirst(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t *outp)
 {
-        return CM_ERROR_BADOP;
+    return CM_ERROR_BADOP;
 }
 
 long smb_ReceiveTran2FindNotifyNext(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t *outp)
 {
-        return CM_ERROR_BADOP;
+    return CM_ERROR_BADOP;
 }
 
 long smb_ReceiveTran2MKDir(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t *outp)
 {
-        return CM_ERROR_BADOP;
+    return CM_ERROR_BADOP;
 }
 
 long smb_ApplyV3DirListPatches(cm_scache_t *dscp,
        smb_dirListPatch_t **dirPatchespp, int infoLevel, cm_user_t *userp,
        cm_req_t *reqp)
 {
-       long code;
-        cm_scache_t *scp;
-        cm_scache_t *targetScp;                        /* target if scp is a symlink */
-        char *dptr;
-        long dosTime;
+       long code = 0;
+    cm_scache_t *scp;
+    cm_scache_t *targetScp;                    /* target if scp is a symlink */
+    char *dptr;
+    long dosTime;
        FILETIME ft;
-        int shortTemp;
-        unsigned short attr;
+    int shortTemp;
+    unsigned short attr;
        unsigned long lattr;
-        smb_dirListPatch_t *patchp;
-        smb_dirListPatch_t *npatchp;
+    smb_dirListPatch_t *patchp;
+    smb_dirListPatch_t *npatchp;
         
-        for(patchp = *dirPatchespp; patchp; patchp =
-               (smb_dirListPatch_t *) osi_QNext(&patchp->q)) {
+    for(patchp = *dirPatchespp; patchp; patchp =
+         (smb_dirListPatch_t *) osi_QNext(&patchp->q)) {
                code = cm_GetSCache(&patchp->fid, &scp, userp, reqp);
-                if (code) continue;
-                lock_ObtainMutex(&scp->mx);
-                code = cm_SyncOp(scp, NULL, userp, reqp, 0,
-                       CM_SCACHESYNC_NEEDCALLBACK | CM_SCACHESYNC_GETSTATUS);
-               if (code) {
+        if (code) continue;
+        lock_ObtainMutex(&scp->mx);
+        code = cm_SyncOp(scp, NULL, userp, reqp, 0,
+                          CM_SCACHESYNC_NEEDCALLBACK | CM_SCACHESYNC_GETSTATUS);
+               if (code) { 
                        lock_ReleaseMutex(&scp->mx);
                        cm_ReleaseSCache(scp);
                        continue;
-                }
+        }
                 
-                /* now watch for a symlink */
-                if (scp->fileType == CM_SCACHETYPE_SYMLINK) {
+        /* now watch for a symlink */
+        if (scp->fileType == CM_SCACHETYPE_SYMLINK) {
                        lock_ReleaseMutex(&scp->mx);
-                        code = cm_EvaluateSymLink(dscp, scp, &targetScp, userp,
-                                                 reqp);
-                        if (code == 0) {
+            code = cm_EvaluateSymLink(dscp, scp, &targetScp, userp, reqp);
+            if (code == 0) {
                                /* we have a more accurate file to use (the
                                 * target of the symbolic link).  Otherwise,
                                 * we'll just use the symlink anyway.
-                                 */
-                               osi_Log2(afsd_logp, "symlink vp %x to vp %x",
-                                        scp, targetScp);
+                 */
+                               osi_Log2(smb_logp, "symlink vp %x to vp %x",
+                         scp, targetScp);
                                cm_ReleaseSCache(scp);
-                                scp = targetScp;
-                        }
-                        lock_ObtainMutex(&scp->mx);
-                }
+                scp = targetScp;
+            }
+            lock_ObtainMutex(&scp->mx);
+        }
 
                dptr = patchp->dptr;
 
@@ -1722,20 +1729,20 @@ long smb_ApplyV3DirListPatches(cm_scache_t *dscp,
                        *dptr++ = (attr >> 8) & 0xff;
                }
 
-                lock_ReleaseMutex(&scp->mx);
-                cm_ReleaseSCache(scp);
+        lock_ReleaseMutex(&scp->mx);
+        cm_ReleaseSCache(scp);
        }
         
-        /* now free the patches */
-        for(patchp = *dirPatchespp; patchp; patchp = npatchp) {
+    /* now free the patches */
+    for(patchp = *dirPatchespp; patchp; patchp = npatchp) {
                npatchp = (smb_dirListPatch_t *) osi_QNext(&patchp->q);
-                free(patchp);
+        free(patchp);
        }
         
-        /* and mark the list as empty */
-        *dirPatchespp = NULL;
+    /* and mark the list as empty */
+    *dirPatchespp = NULL;
 
-        return code;
+    return code;
 }
 
 /* do a case-folding search of the star name mask with the name in namep.
@@ -1744,13 +1751,15 @@ long smb_ApplyV3DirListPatches(cm_scache_t *dscp,
 int smb_V3MatchMask(char *namep, char *maskp, int flags)
 {
        unsigned char tcp1, tcp2;       /* Pattern characters */
-        unsigned char tcn1;            /* Name characters */
-       int sawDot = 0, sawStar = 0;
+    unsigned char tcn1;                /* Name characters */
+       int sawDot = 0, sawStar = 0, req8dot3 = 0;
        char *starNamep, *starMaskp;
        static char nullCharp[] = {0};
 
        /* make sure we only match 8.3 names, if requested */
-       if ((flags & CM_FLAG_8DOT3) && !cm_Is8Dot3(namep)) return 0;
+    req8dot3 = (flags & CM_FLAG_8DOT3);
+       if (req8dot3 && !cm_Is8Dot3(namep)) 
+        return 0;
 
        /* loop */
        while (1) {
@@ -1807,8 +1816,8 @@ int smb_V3MatchMask(char *namep, char *maskp, int flags)
                        tcp2 = *maskp++;
                        if (tcp2 == 0)
                                return 1;
-                       else if (tcp2 == '.' || tcp2 == '"') {
-                               while (tcn1 != '.' && tcn1 != 0)
+                       else if ((req8dot3 && tcp2 == '.') || tcp2 == '"') {
+                               while (req8dot3 && tcn1 != '.' && tcn1 != 0)
                                        tcn1 = *++namep;
                                if (tcn1 == 0) {
                                        if (sawDot)
@@ -1834,12 +1843,12 @@ int smb_V3MatchMask(char *namep, char *maskp, int flags)
                                        tcp2 = *maskp++;
 
                                /* skip over characters that don't match tcp2 */
-                               while (tcn1 != '.' && tcn1 != 0
+                               while (req8dot3 && tcn1 != '.' && tcn1 != 0
                                        && cm_foldUpper[tcn1] != cm_foldUpper[tcp2])
                                        tcn1 = *++namep;
 
                                /* No match */
-                               if (tcn1 == '.' || tcn1 == 0)
+                               if ((req8dot3 && tcn1 == '.') || tcn1 == 0)
                                        return 0;
 
                                /* Remember where we are */
@@ -1874,131 +1883,132 @@ int smb_V3MatchMask(char *namep, char *maskp, int flags)
 long smb_ReceiveTran2SearchDir(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t *opx)
 {
        int attribute;
-        long nextCookie;
-        char *tp;
-        long code;
-        char *pathp;
-        cm_dirEntry_t *dep;
-        int maxCount;
-        smb_dirListPatch_t *dirListPatchesp;
-        smb_dirListPatch_t *curPatchp;
-        cm_buf_t *bufferp;
-        long temp;
-        long orbytes;                  /* # of bytes in this output record */
-        long ohbytes;                  /* # of bytes, except file name */
-        long onbytes;                  /* # of bytes in name, incl. term. null */
-        osi_hyper_t dirLength;
-        osi_hyper_t bufferOffset;
-        osi_hyper_t curOffset;
-        osi_hyper_t thyper;
-        smb_dirSearch_t *dsp;
-        cm_scache_t *scp;
-        long entryInDir;
-        long entryInBuffer;
+    long nextCookie;
+    char *tp;
+    long code = 0;
+    char *pathp;
+    cm_dirEntry_t *dep;
+    int maxCount;
+    smb_dirListPatch_t *dirListPatchesp;
+    smb_dirListPatch_t *curPatchp;
+    cm_buf_t *bufferp;
+    long temp;
+    long orbytes;                      /* # of bytes in this output record */
+    long ohbytes;                      /* # of bytes, except file name */
+    long onbytes;                      /* # of bytes in name, incl. term. null */
+    osi_hyper_t dirLength;
+    osi_hyper_t bufferOffset;
+    osi_hyper_t curOffset;
+    osi_hyper_t thyper;
+    smb_dirSearch_t *dsp;
+    cm_scache_t *scp;
+    long entryInDir;
+    long entryInBuffer;
        cm_pageHeader_t *pageHeaderp;
-        cm_user_t *userp = NULL;
-        int slotInPage;
-        int returnedNames;
-        long nextEntryCookie;
-        int numDirChunks;              /* # of 32 byte dir chunks in this entry */
-        char *op;                      /* output data ptr */
+    cm_user_t *userp = NULL;
+    int slotInPage;
+    int returnedNames;
+    long nextEntryCookie;
+    int numDirChunks;          /* # of 32 byte dir chunks in this entry */
+    char *op;                  /* output data ptr */
        char *origOp;                   /* original value of op */
-        cm_space_t *spacep;            /* for pathname buffer */
-        long maxReturnData;            /* max # of return data */
-        long maxReturnParms;           /* max # of return parms */
-        long bytesInBuffer;            /* # data bytes in the output buffer */
-        int starPattern;
-        char *maskp;                   /* mask part of path */
-        int infoLevel;
-        int searchFlags;
-        int eos;
-        smb_tran2Packet_t *outp;       /* response packet */
+    cm_space_t *spacep;                /* for pathname buffer */
+    long maxReturnData;                /* max # of return data */
+    long maxReturnParms;               /* max # of return parms */
+    long bytesInBuffer;                /* # data bytes in the output buffer */
+    int starPattern;
+    char *maskp;                       /* mask part of path */
+    int infoLevel;
+    int searchFlags;
+    int eos;
+    smb_tran2Packet_t *outp;   /* response packet */
        char *tidPathp;
        int align;
        char shortName[13];             /* 8.3 name if needed */
        int NeedShortName;
        char *shortNameEnd;
-        int fileType;
-        cm_fid_t fid;
-        
-        cm_req_t req;
+    int fileType;
+    cm_fid_t fid;
+
+    cm_req_t req;
 
        cm_InitReq(&req);
 
        eos = 0;
        if (p->opcode == 1) {
                /* find first; obtain basic parameters from request */
-                attribute = p->parmsp[0];
-                maxCount = p->parmsp[1];
-                infoLevel = p->parmsp[3];
-                searchFlags = p->parmsp[2];
-                dsp = smb_NewDirSearch(1);
-                dsp->attribute = attribute;
-                pathp = ((char *) p->parmsp) + 12;     /* points to path */
-                nextCookie = 0;
-                maskp = strrchr(pathp, '\\');
-                if (maskp == NULL) maskp = pathp;
+        attribute = p->parmsp[0];
+        maxCount = p->parmsp[1];
+        infoLevel = p->parmsp[3];
+        searchFlags = p->parmsp[2];
+        dsp = smb_NewDirSearch(1);
+        dsp->attribute = attribute;
+        pathp = ((char *) p->parmsp) + 12;     /* points to path */
+        nextCookie = 0;
+        maskp = strrchr(pathp, '\\');
+        if (maskp == NULL) maskp = pathp;
                else maskp++;   /* skip over backslash */
-                strcpy(dsp->mask, maskp);      /* and save mask */
+        strcpy(dsp->mask, maskp);      /* and save mask */
                /* track if this is likely to match a lot of entries */
-               starPattern = smb_V3IsStarMask(maskp);
+        starPattern = smb_V3IsStarMask(maskp);
         }
-        else {
+    else {
                osi_assert(p->opcode == 2);
-                /* find next; obtain basic parameters from request or open dir file */
-                dsp = smb_FindDirSearch(p->parmsp[0]);
-                if (!dsp) return CM_ERROR_BADFD;
-                attribute = dsp->attribute;
-                maxCount = p->parmsp[1];
-                infoLevel = p->parmsp[2];
-                searchFlags = p->parmsp[5];
-                pathp = NULL;
-                nextCookie = p->parmsp[3] | (p->parmsp[4] << 16);
-                maskp = dsp->mask;
+        /* find next; obtain basic parameters from request or open dir file */
+        dsp = smb_FindDirSearch(p->parmsp[0]);
+        if (!dsp) return CM_ERROR_BADFD;
+        attribute = dsp->attribute;
+        maxCount = p->parmsp[1];
+        infoLevel = p->parmsp[2];
+        searchFlags = p->parmsp[5];
+        pathp = NULL;
+        nextCookie = p->parmsp[3] | (p->parmsp[4] << 16);
+        maskp = dsp->mask;
                starPattern = 1;        /* assume, since required a Find Next */
-        }
+    }
 
-       osi_Log4(afsd_logp,
-                "T2 search dir attr 0x%x, info level %d, max count %d, flags 0x%x",
-                attribute, infoLevel, maxCount, searchFlags);
+       osi_Log4(smb_logp,
+              "T2 search dir attr 0x%x, info level %d, max count %d, flags 0x%x",
+              attribute, infoLevel, maxCount, searchFlags);
 
-       osi_Log2(afsd_logp, "...T2 search op %d, nextCookie 0x%x",
-                p->opcode, nextCookie);
+       osi_Log2(smb_logp, "...T2 search op %d, nextCookie 0x%x",
+              p->opcode, nextCookie);
 
        if (infoLevel >= 0x101)
                searchFlags &= ~4;      /* no resume keys */
 
-        dirListPatchesp = NULL;
+    dirListPatchesp = NULL;
 
        maxReturnData = p->maxReturnData;
-        if (p->opcode == 1)    /* find first */
-               maxReturnParms = 10;    /* bytes */
-       else
-               maxReturnParms = 8;     /* bytes */
+    if (p->opcode == 1)        /* find first */
+        maxReturnParms = 10;   /* bytes */
+       else    
+        maxReturnParms = 8;    /* bytes */
 
 #ifndef CM_CONFIG_MULTITRAN2RESPONSES
-        if (maxReturnData > 6000) maxReturnData = 6000;
+    if (maxReturnData > 6000) 
+        maxReturnData = 6000;
 #endif /* CM_CONFIG_MULTITRAN2RESPONSES */
 
        outp = smb_GetTran2ResponsePacket(vcp, p, opx, maxReturnParms,
-                                         maxReturnData);
+                                      maxReturnData);
 
-        osi_Log1(afsd_logp, "T2 receive search dir %s",
-                       osi_LogSaveString(afsd_logp, pathp));
+    osi_Log1(smb_logp, "T2 receive search dir %s",
+             osi_LogSaveString(smb_logp, pathp));
         
-        /* bail out if request looks bad */
+    /* bail out if request looks bad */
     if (p->opcode == 1 && !pathp) {
         smb_ReleaseDirSearch(dsp);
         smb_FreeTran2Packet(outp);
         return CM_ERROR_BADSMB;
     }
         
-       osi_Log2(afsd_logp, "T2 dir search cookie 0x%x, connection %d",
-               nextCookie, dsp->cookie);
+       osi_Log2(smb_logp, "T2 dir search cookie 0x%x, connection %d",
+             nextCookie, dsp->cookie);
 
        userp = smb_GetTran2User(vcp, p);
     if (!userp) {
-       osi_Log1(afsd_logp, "T2 dir search unable to resolve user [%d]", p->uid);
+       osi_Log1(smb_logp, "T2 dir search unable to resolve user [%d]", p->uid);
        smb_ReleaseDirSearch(dsp);
        smb_FreeTran2Packet(outp);
        return CM_ERROR_BADSMB;
@@ -2008,144 +2018,143 @@ long smb_ReceiveTran2SearchDir(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t
        lock_ObtainMutex(&dsp->mx);
        if (dsp->scp) {
                scp = dsp->scp;
-                cm_HoldSCache(scp);
-                code = 0;
-        }
-        else {
+        cm_HoldSCache(scp);
+        code = 0;
+    }
+    else {
                spacep = cm_GetSpace();
-               smb_StripLastComponent(spacep->data, NULL, pathp);
-                lock_ReleaseMutex(&dsp->mx);
+        smb_StripLastComponent(spacep->data, NULL, pathp);
+        lock_ReleaseMutex(&dsp->mx);
 
                tidPathp = smb_GetTIDPath(vcp, p->tid);
-               code = cm_NameI(cm_rootSCachep, spacep->data,
-                               CM_FLAG_FOLLOW | CM_FLAG_CASEFOLD,
-                               userp, tidPathp, &req, &scp);
-               cm_FreeSpace(spacep);
+        code = cm_NameI(cm_rootSCachep, spacep->data,
+                        CM_FLAG_FOLLOW | CM_FLAG_CASEFOLD,
+                        userp, tidPathp, &req, &scp);
+        cm_FreeSpace(spacep);
 
-                lock_ObtainMutex(&dsp->mx);
+        lock_ObtainMutex(&dsp->mx);
                if (code == 0) {
-                       if (dsp->scp != 0) cm_ReleaseSCache(dsp->scp);
+            if (dsp->scp != 0) cm_ReleaseSCache(dsp->scp);
                        dsp->scp = scp;
                        /* we need one hold for the entry we just stored into,
-                         * and one for our own processing.  When we're done
+             * and one for our own processing.  When we're done
                         * with this function, we'll drop the one for our own
                         * processing.  We held it once from the namei call,
                         * and so we do another hold now.
-                         */
-                        cm_HoldSCache(scp);
+             */
+            cm_HoldSCache(scp);
                        lock_ObtainMutex(&scp->mx);
                        if ((scp->flags & CM_SCACHEFLAG_BULKSTATTING) == 0
                            && LargeIntegerGreaterOrEqualToZero(scp->bulkStatProgress)) {
-                               scp->flags |= CM_SCACHEFLAG_BULKSTATTING;
+                scp->flags |= CM_SCACHEFLAG_BULKSTATTING;
                                dsp->flags |= SMB_DIRSEARCH_BULKST;
                        }
                        lock_ReleaseMutex(&scp->mx);
-                }
         }
+    }
        lock_ReleaseMutex(&dsp->mx);
-        if (code) {
+    if (code) {
                cm_ReleaseUser(userp);
-                smb_FreeTran2Packet(outp);
+        smb_FreeTran2Packet(outp);
                smb_DeleteDirSearch(dsp);
                smb_ReleaseDirSearch(dsp);
-                return code;
+        return code;
         }
 
-        /* get the directory size */
+    /* get the directory size */
        lock_ObtainMutex(&scp->mx);
-        code = cm_SyncOp(scp, NULL, userp, &req, 0,
-               CM_SCACHESYNC_NEEDCALLBACK | CM_SCACHESYNC_GETSTATUS);
+    code = cm_SyncOp(scp, NULL, userp, &req, 0,
+                     CM_SCACHESYNC_NEEDCALLBACK | CM_SCACHESYNC_GETSTATUS);
        if (code) {
                lock_ReleaseMutex(&scp->mx);
-                cm_ReleaseSCache(scp);
-                cm_ReleaseUser(userp);
-                smb_FreeTran2Packet(outp);
+        cm_ReleaseSCache(scp);
+        cm_ReleaseUser(userp);
+        smb_FreeTran2Packet(outp);
                smb_DeleteDirSearch(dsp);
                smb_ReleaseDirSearch(dsp);
-                return code;
-        }
-        
-        dirLength = scp->length;
-        bufferp = NULL;
-        bufferOffset.LowPart = bufferOffset.HighPart = 0;
-        curOffset.HighPart = 0;
-        curOffset.LowPart = nextCookie;
+        return code;
+    }
+
+    dirLength = scp->length;
+    bufferp = NULL;
+    bufferOffset.LowPart = bufferOffset.HighPart = 0;
+    curOffset.HighPart = 0;
+    curOffset.LowPart = nextCookie;
        origOp = outp->datap;
 
-        code = 0;
-        returnedNames = 0;
-        bytesInBuffer = 0;
-        while (1) {
+    code = 0;
+    returnedNames = 0;
+    bytesInBuffer = 0;
+    while (1) {
                op = origOp;
                if (searchFlags & 4)
                        /* skip over resume key */
                        op += 4;
 
                /* make sure that curOffset.LowPart doesn't point to the first
-                 * 32 bytes in the 2nd through last dir page, and that it doesn't
-                 * point at the first 13 32-byte chunks in the first dir page,
-                 * since those are dir and page headers, and don't contain useful
-                 * information.
-                 */
+         * 32 bytes in the 2nd through last dir page, and that it doesn't
+         * point at the first 13 32-byte chunks in the first dir page,
+         * since those are dir and page headers, and don't contain useful
+         * information.
+         */
                temp = curOffset.LowPart & (2048-1);
-                if (curOffset.HighPart == 0 && curOffset.LowPart < 2048) {
+        if (curOffset.HighPart == 0 && curOffset.LowPart < 2048) {
                        /* we're in the first page */
-                       if (temp < 13*32) temp = 13*32;
+            if (temp < 13*32) temp = 13*32;
                }
                else {
                        /* we're in a later dir page */
-                        if (temp < 32) temp = 32;
-                }
+            if (temp < 32) temp = 32;
+        }
                
-                /* make sure the low order 5 bits are zero */
-                temp &= ~(32-1);
+        /* make sure the low order 5 bits are zero */
+        temp &= ~(32-1);
                 
-                /* now put temp bits back ito curOffset.LowPart */
-                curOffset.LowPart &= ~(2048-1);
-                curOffset.LowPart |= temp;
+        /* now put temp bits back ito curOffset.LowPart */
+        curOffset.LowPart &= ~(2048-1);
+        curOffset.LowPart |= temp;
+
+        /* check if we've passed the dir's EOF */
+        if (LargeIntegerGreaterThanOrEqualTo(curOffset, dirLength)) {
+            eos = 1;
+            break;
+        }
 
-            /* check if we've passed the dir's EOF */
-            if (LargeIntegerGreaterThanOrEqualTo(curOffset, dirLength)) {
-                eos = 1;
-                break;
-            }
+        /* check if we've returned all the names that will fit in the
+         * response packet; we check return count as well as the number
+         * of bytes requested.  We check the # of bytes after we find
+         * the dir entry, since we'll need to check its size.
+         */
+        if (returnedNames >= maxCount) {
+            break;
+        }
 
-            /* check if we've returned all the names that will fit in the
-             * response packet; we check return count as well as the number
-             * of bytes requested.  We check the # of bytes after we find
-             * the dir entry, since we'll need to check its size.
-             */
-            if (returnedNames >= maxCount) {
-                break;
-            }
-                
-            /* see if we can use the bufferp we have now; compute in which
-             * page the current offset would be, and check whether that's
-             * the offset of the buffer we have.  If not, get the buffer.
-             */
-            thyper.HighPart = curOffset.HighPart;
-            thyper.LowPart = curOffset.LowPart & ~(buf_bufferSize-1);
-            if (!bufferp || !LargeIntegerEqualTo(thyper, bufferOffset)) {
+        /* see if we can use the bufferp we have now; compute in which
+         * page the current offset would be, and check whether that's
+         * the offset of the buffer we have.  If not, get the buffer.
+         */
+        thyper.HighPart = curOffset.HighPart;
+        thyper.LowPart = curOffset.LowPart & ~(buf_bufferSize-1);
+        if (!bufferp || !LargeIntegerEqualTo(thyper, bufferOffset)) {
                        /* wrong buffer */
-                if (bufferp) {
-                    buf_Release(bufferp);
-                    bufferp = NULL;
-                       }   
+            if (bufferp) {
+                buf_Release(bufferp);
+                bufferp = NULL;
+                       }       
                        lock_ReleaseMutex(&scp->mx);
                        lock_ObtainRead(&scp->bufCreateLock);
-                        code = buf_Get(scp, &thyper, &bufferp);
+            code = buf_Get(scp, &thyper, &bufferp);
                        lock_ReleaseRead(&scp->bufCreateLock);
 
                        /* now, if we're doing a star match, do bulk fetching
                         * of all of the status info for files in the dir.
-                         */
-                        if (starPattern) {
+             */
+            if (starPattern) {
                                smb_ApplyV3DirListPatches(scp, &dirListPatchesp,
-                                                         infoLevel, userp,
-                                                         &req);
+                                          infoLevel, userp,
+                                          &req);
                                if ((dsp->flags & SMB_DIRSEARCH_BULKST)
-                                   && LargeIntegerGreaterThanOrEqualTo(
-                                               thyper, scp->bulkStatProgress)) {
+                    && LargeIntegerGreaterThanOrEqualTo(thyper, scp->bulkStatProgress)) {
                                        /* Don't bulk stat if risking timeout */
                                        int now = GetCurrentTime();
                                        if (now - req.startTime > 5000) {
@@ -2153,79 +2162,77 @@ long smb_ReceiveTran2SearchDir(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t
                                                scp->flags &= ~CM_SCACHEFLAG_BULKSTATTING;
                                                dsp->flags &= ~SMB_DIRSEARCH_BULKST;
                                        } else
-                                               cm_TryBulkStat(scp, &thyper,
-                                                              userp, &req);
+                        cm_TryBulkStat(scp, &thyper, userp, &req);
                                }
                        }
 
-                        lock_ObtainMutex(&scp->mx);
-                        if (code) break;
-                        bufferOffset = thyper;
+            lock_ObtainMutex(&scp->mx);
+            if (code) break;
+            bufferOffset = thyper;
 
-                        /* now get the data in the cache */
-                        while (1) {
+            /* now get the data in the cache */
+            while (1) {
                                code = cm_SyncOp(scp, bufferp, userp, &req,
-                                       PRSFS_LOOKUP,
-                                       CM_SCACHESYNC_NEEDCALLBACK
-                                       | CM_SCACHESYNC_READ);
+                                 PRSFS_LOOKUP,
+                                 CM_SCACHESYNC_NEEDCALLBACK
+                                 | CM_SCACHESYNC_READ);
                                if (code) break;
                                 
-                                if (cm_HaveBuffer(scp, bufferp, 0)) break;
-                                
-                                /* otherwise, load the buffer and try again */
-                                code = cm_GetBuffer(scp, bufferp, NULL, userp,
-                                                   &req);
-                                if (code) break;
-                        }
-                        if (code) {
+                if (cm_HaveBuffer(scp, bufferp, 0)) break;
+
+                /* otherwise, load the buffer and try again */
+                code = cm_GetBuffer(scp, bufferp, NULL, userp,
+                                    &req);
+                if (code) break;
+            }
+            if (code) {
                                buf_Release(bufferp);
-                                bufferp = NULL;
-                               break;
+                bufferp = NULL;
+                break;
                        }
-                }      /* if (wrong buffer) ... */
+        }      /* if (wrong buffer) ... */
                 
-                /* now we have the buffer containing the entry we're interested
-                * in; copy it out if it represents a non-deleted entry.
-                 */
+        /* now we have the buffer containing the entry we're interested
+         * in; copy it out if it represents a non-deleted entry.
+         */
                entryInDir = curOffset.LowPart & (2048-1);
-                entryInBuffer = curOffset.LowPart & (buf_bufferSize - 1);
+        entryInBuffer = curOffset.LowPart & (buf_bufferSize - 1);
 
                /* page header will help tell us which entries are free.  Page
                 * header can change more often than once per buffer, since
                 * AFS 3 dir page size may be less than (but not more than)
                 * a buffer package buffer.
-                 */
+         */
                /* only look intra-buffer */
                temp = curOffset.LowPart & (buf_bufferSize - 1);
-                temp &= ~(2048 - 1);   /* turn off intra-page bits */
+        temp &= ~(2048 - 1);   /* turn off intra-page bits */
                pageHeaderp = (cm_pageHeader_t *) (bufferp->datap + temp);
 
                /* now determine which entry we're looking at in the page.
                 * If it is free (there's a free bitmap at the start of the
                 * dir), we should skip these 32 bytes.
-                 */
-                slotInPage = (entryInDir & 0x7e0) >> 5;
-                if (!(pageHeaderp->freeBitmap[slotInPage>>3]
-                       & (1 << (slotInPage & 0x7)))) {
+         */
+        slotInPage = (entryInDir & 0x7e0) >> 5;
+        if (!(pageHeaderp->freeBitmap[slotInPage>>3]
+               & (1 << (slotInPage & 0x7)))) {
                        /* this entry is free */
-                        numDirChunks = 1;      /* only skip this guy */
-                        goto nextEntry;
-                }
+            numDirChunks = 1;  /* only skip this guy */
+            goto nextEntry;
+        }
 
                tp = bufferp->datap + entryInBuffer;
-                dep = (cm_dirEntry_t *) tp;    /* now points to AFS3 dir entry */
+        dep = (cm_dirEntry_t *) tp;    /* now points to AFS3 dir entry */
 
-                /* while we're here, compute the next entry's location, too,
+        /* while we're here, compute the next entry's location, too,
                 * since we'll need it when writing out the cookie into the dir
                 * listing stream.
-                 *
-                 * XXXX Probably should do more sanity checking.
-                 */
+         *
+         * XXXX Probably should do more sanity checking.
+         */
                numDirChunks = cm_NameEntries(dep->name, &onbytes);
                
-                /* compute offset of cookie representing next entry */
-                nextEntryCookie = curOffset.LowPart
-                                   + (CM_DIR_CHUNKSIZE * numDirChunks);
+        /* compute offset of cookie representing next entry */
+        nextEntryCookie = curOffset.LowPart + (CM_DIR_CHUNKSIZE * numDirChunks);
 
                /* Need 8.3 name? */
                NeedShortName = 0;
@@ -2236,32 +2243,31 @@ long smb_ReceiveTran2SearchDir(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t
                        NeedShortName = 1;
                }
 
-                if (dep->fid.vnode != 0
-                   && (smb_V3MatchMask(dep->name, maskp, CM_FLAG_CASEFOLD)
-                       || (NeedShortName
-                           && smb_V3MatchMask(shortName, maskp,
-                                               CM_FLAG_CASEFOLD)))) {
-
-                        /* Eliminate entries that don't match requested
-                           attributes */
-                    if (smb_hideDotFiles && !(dsp->attribute & SMB_ATTR_HIDDEN) && 
-                        smb_IsDotFile(dep->name))
-                        goto nextEntry; /* no hidden files */
+        if (dep->fid.vnode != 0
+             && (smb_V3MatchMask(dep->name, maskp, CM_FLAG_CASEFOLD)
+                 || (NeedShortName
+                      && smb_V3MatchMask(shortName, maskp,
+                                          CM_FLAG_CASEFOLD)))) {
+
+            /* Eliminate entries that don't match requested attributes */
+            if (smb_hideDotFiles && !(dsp->attribute & SMB_ATTR_HIDDEN) && 
+                 smb_IsDotFile(dep->name))
+                goto nextEntry; /* no hidden files */
                     
-                    if (!(dsp->attribute & SMB_ATTR_DIRECTORY))  /* no directories */
-                    {
-                            /* We have already done the cm_TryBulkStat above */
-                            fid.cell = scp->fid.cell;
-                            fid.volume = scp->fid.volume;
-                            fid.vnode = ntohl(dep->fid.vnode);
-                            fid.unique = ntohl(dep->fid.unique);
-                            fileType = cm_FindFileType(&fid);
-                            /*osi_Log2(afsd_logp, "smb_ReceiveTran2SearchDir: file %s "
-                              "has filetype %d", dep->name,
-                              fileType);*/
-                            if (fileType == CM_SCACHETYPE_DIRECTORY)
-                              goto nextEntry;
-                        }
+            if (!(dsp->attribute & SMB_ATTR_DIRECTORY))  /* no directories */
+            {
+                /* We have already done the cm_TryBulkStat above */
+                fid.cell = scp->fid.cell;
+                fid.volume = scp->fid.volume;
+                fid.vnode = ntohl(dep->fid.vnode);
+                fid.unique = ntohl(dep->fid.unique);
+                fileType = cm_FindFileType(&fid);
+                /*osi_Log2(smb_logp, "smb_ReceiveTran2SearchDir: file %s "
+                 "has filetype %d", dep->name,
+                 fileType);*/
+                if (fileType == CM_SCACHETYPE_DIRECTORY)
+                    goto nextEntry;
+            }
 
                        /* finally check if this name will fit */
 
@@ -2276,13 +2282,13 @@ long smb_ReceiveTran2SearchDir(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t
                        if (infoLevel == 0x104)
                                ohbytes += 26;  /* Short name & length */
 
-                       if (searchFlags & 4) {
-                               ohbytes += 4;   /* if resume key required */
-                       }
+            if (searchFlags & 4) {
+                ohbytes += 4;  /* if resume key required */
+                       }   
 
-                        if (infoLevel != 1
-                           && infoLevel != 0x101
-                           && infoLevel != 0x103)
+            if (infoLevel != 1
+                 && infoLevel != 0x101
+                 && infoLevel != 0x103)
                                ohbytes += 4;   /* EASIZE */
 
                        /* add header to name & term. null */
@@ -2293,39 +2299,39 @@ long smb_ReceiveTran2SearchDir(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t
                         * even the aligned version (so we don't have to worry
                         * about an * overflow when we pad things out below).
                         * That's the reason for the alignment arithmetic below.
-                         */
+             */
                        if (infoLevel >= 0x101)
                                align = (4 - (orbytes & 3)) & 3;
                        else
                                align = 0;
                        if (orbytes + bytesInBuffer + align > maxReturnData)
-                                break;
+                break;
 
                        /* this is one of the entries to use: it is not deleted
                         * and it matches the star pattern we're looking for.
                         * Put out the name, preceded by its length.
-                         */
+             */
                        /* First zero everything else */
                        memset(origOp, 0, ohbytes);
 
                        if (infoLevel <= 0x101)
-                               *(origOp + ohbytes - 1) = (unsigned char) onbytes;
+                *(origOp + ohbytes - 1) = (unsigned char) onbytes;
                        else if (infoLevel == 0x103)
                                *((u_long *)(op + 8)) = onbytes;
                        else
                                *((u_long *)(op + 60)) = onbytes;
-                        strcpy(origOp+ohbytes, dep->name);
+            strcpy(origOp+ohbytes, dep->name);
 
                        /* Short name if requested and needed */
-                        if (infoLevel == 0x104) {
+            if (infoLevel == 0x104) {
                                if (NeedShortName) {
                                        strcpy(op + 70, shortName);
                                        *(op + 68) = shortNameEnd - shortName;
                                }
                        }
 
-                       /* now, adjust the # of entries copied */
-                       returnedNames++;
+            /* now, adjust the # of entries copied */
+            returnedNames++;
 
                        /* NextEntryOffset and FileIndex */
                        if (infoLevel >= 101) {
@@ -2334,23 +2340,23 @@ long smb_ReceiveTran2SearchDir(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t
                                *((u_long *)(op+4)) = nextEntryCookie;
                        }
 
-                        /* now we emit the attribute.  This is tricky, since
-                         * we need to really stat the file to find out what
+            /* now we emit the attribute.  This is tricky, since
+             * we need to really stat the file to find out what
                         * type of entry we've got.  Right now, we're copying
                         * out data from * a buffer, while holding the scp
                         * locked, so it isn't really convenient to stat
                         * something now.  We'll put in a place holder
-                         * now, and make a second pass before returning this
+             * now, and make a second pass before returning this
                         * to get the real attributes.  So, we just skip the
                         * data for now, and adjust it later.  We allocate a
                         * patch record to make it easy to find this point
                         * later.  The replay will happen at a time when it is
                         * safe to unlock the directory.
-                         */
+             */
                        if (infoLevel != 0x103) {
                                curPatchp = malloc(sizeof(*curPatchp));
-                               osi_QAdd((osi_queue_t **) &dirListPatchesp,
-                                        &curPatchp->q);
+                osi_QAdd((osi_queue_t **) &dirListPatchesp,
+                          &curPatchp->q);
                                curPatchp->dptr = op;
                                if (infoLevel >= 0x101)
                                        curPatchp->dptr += 8;
@@ -2366,9 +2372,9 @@ long smb_ReceiveTran2SearchDir(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t
                                curPatchp->fid.vnode = ntohl(dep->fid.vnode);
                                curPatchp->fid.unique = ntohl(dep->fid.unique);
 
-                                /* temp */
-                                curPatchp->dep = dep;
-                       }
+                /* temp */
+                curPatchp->dep = dep;
+                       }   
 
                        if (searchFlags & 4)
                                /* put out resume key */
@@ -2376,79 +2382,80 @@ long smb_ReceiveTran2SearchDir(smb_vc_t *vcp, smb_tran2Packet_t *p, smb_packet_t
 
                        /* Adjust byte ptr and count */
                        origOp += orbytes;      /* skip entire record */
-                        bytesInBuffer += orbytes;
+            bytesInBuffer += orbytes;
 
                        /* and pad the record out */
-                        while (--align >= 0) {
+            while (--align >= 0) {
                                *origOp++ = 0;
-                                bytesInBuffer++;
-                        }
-                        
+                bytesInBuffer++;
+            }
+
                }       /* if we're including this name */
                 
-nextEntry:
-                /* and adjust curOffset to be where the new cookie is */
+      nextEntry:
+        /* and adjust curOffset to be where the new cookie is */
                thyper.HighPart = 0;
-                thyper.LowPart = CM_DIR_CHUNKSIZE * numDirChunks;
-                curOffset = LargeIntegerAdd(thyper, curOffset);
-        }              /* while copying data for dir listing */
+        thyper.LowPart = CM_DIR_CHUNKSIZE * numDirChunks;
+        curOffset = LargeIntegerAdd(thyper, curOffset);
+    }          /* while copying data for dir listing */
 
        /* release the mutex */
        lock_ReleaseMutex(&scp->mx);
-        if (bufferp) buf_Release(bufferp);
+    if (bufferp) buf_Release(bufferp);
 
        /* apply and free last set of patches; if not doing a star match, this
         * will be empty, but better safe (and freeing everything) than sorry.
-         */
-        smb_ApplyV3DirListPatches(scp, &dirListPatchesp, infoLevel, userp,
-                                 &req);
+     */
+    smb_ApplyV3DirListPatches(scp, &dirListPatchesp, infoLevel, userp,
+                              &req);
         
-        /* now put out the final parameters */
+    /* now put out the final parameters */
        if (returnedNames == 0) eos = 1;
-        if (p->opcode == 1) {
+    if (p->opcode == 1) {
                /* find first */
-                outp->parmsp[0] = (unsigned short) dsp->cookie;
-                outp->parmsp[1] = returnedNames;
-                outp->parmsp[2] = eos;
-                outp->parmsp[3] = 0;           /* nothing wrong with EAS */
-                outp->parmsp[4] = 0;   /* don't need last name to continue
-                                        * search, cookie is enough.  Normally,
-                                        * this is the offset of the file name
-                                        * of the last entry returned.
-                                         */
-               outp->totalParms = 10;  /* in bytes */
-        }
-        else {
-               /* find next */
-                outp->parmsp[0] = returnedNames;
-                outp->parmsp[1] = eos;
-                outp->parmsp[2] = 0;   /* EAS error */
-                outp->parmsp[3] = 0;   /* last name, as above */
-                outp->totalParms = 8;  /* in bytes */
-        }
+        outp->parmsp[0] = (unsigned short) dsp->cookie;
+        outp->parmsp[1] = returnedNames;
+        outp->parmsp[2] = eos;
+        outp->parmsp[3] = 0;           /* nothing wrong with EAS */
+        outp->parmsp[4] = 0;   
+        /* don't need last name to continue
+         * search, cookie is enough.  Normally,
+         * this is the offset of the file name
+         * of the last entry returned.
+         */
+        outp->totalParms = 10; /* in bytes */
+    }
+    else {
+        /* find next */
+        outp->parmsp[0] = returnedNames;
+        outp->parmsp[1] = eos;
+        outp->parmsp[2] = 0;   /* EAS error */
+        outp->parmsp[3] = 0;   /* last name, as above */
+        outp->totalParms = 8;  /* in bytes */
+    }   
 
        /* return # of bytes in the buffer */
-        outp->totalData = bytesInBuffer;
+    outp->totalData = bytesInBuffer;
 
-       osi_Log2(afsd_logp, "T2 search dir done, %d names, code %d",
-               returnedNames, code);
+       osi_Log2(smb_logp, "T2 search dir done, %d names, code %d",
+              returnedNames, code);
 
        /* Return error code if unsuccessful on first request */
        if (code == 0 && p->opcode == 1 && returnedNames == 0)
                code = CM_ERROR_NOSUCHFILE;
 
        /* if we're supposed to close the search after this request, or if
-         * we're supposed to close the search if we're done, and we're done,
-         * or if something went wrong, close the search.
-         */
-        /* ((searchFlags & 1) || ((searchFlags & 2) && eos) */
-       if ((searchFlags & 1) || (returnedNames == 0) || ((searchFlags & 2) &&
-                                                         eos) || code != 0)
+     * we're supposed to close the search if we're done, and we're done,
+     * or if something went wrong, close the search.
+     */
+    /* ((searchFlags & 1) || ((searchFlags & 2) && eos) */
+       if ((searchFlags & 1) || (returnedNames == 0) || 
+         ((searchFlags & 2) && eos) || code != 0)
            smb_DeleteDirSearch(dsp);
        if (code)
-               smb_SendTran2Error(vcp, p, opx, code);
+        smb_SendTran2Error(vcp, p, opx, code);
        else {
-               smb_SendTran2Packet(vcp, outp, opx);
+        smb_SendTran2Packet(vcp, outp, opx);
        }
        smb_FreeTran2Packet(outp);
     smb_ReleaseDirSearch(dsp);
@@ -2464,7 +2471,7 @@ long smb_ReceiveV3FindClose(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp
 
     dirHandle = smb_GetSMBParm(inp, 0);
        
-    osi_Log1(afsd_logp, "SMB3 find close handle %d", dirHandle);
+    osi_Log1(smb_logp, "SMB3 find close handle %d", dirHandle);
 
     dsp = smb_FindDirSearch(dirHandle);
         
@@ -2490,7 +2497,7 @@ long smb_ReceiveV3FindNotifyClose(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t
 long smb_ReceiveV3OpenX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
 {
        char *pathp;
-    long code;
+    long code = 0;
        cm_space_t *spacep;
     int excl;
     cm_user_t *userp;
@@ -2539,7 +2546,7 @@ long smb_ReceiveV3OpenX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
          * (since IOCTL calls themselves aren't getting through).
          */
 #ifdef NOTSERVICE
-        osi_Log0(afsd_logp, "IOCTL Open");
+        osi_Log0(smb_logp, "IOCTL Open");
 #endif
 
         fidp = smb_FindFID(vcp, 0, SMB_FLAG_CREATE);
@@ -2654,8 +2661,8 @@ long smb_ReceiveV3OpenX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
     }
     else {
                osi_assert(dscp != NULL);
-               osi_Log1(afsd_logp, "smb_ReceiveV3OpenX creating file %s",
-                 osi_LogSaveString(afsd_logp, lastNamep));
+               osi_Log1(smb_logp, "smb_ReceiveV3OpenX creating file %s",
+                 osi_LogSaveString(smb_logp, lastNamep));
                openAction = 2; /* created file */
                setAttr.mask = CM_ATTRMASK_CLIENTMODTIME;
                smb_UnixTimeFromDosUTime(&setAttr.clientModTime, dosTime);
@@ -2745,7 +2752,7 @@ long smb_ReceiveV3OpenX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
        lock_ReleaseMutex(&scp->mx);
     smb_SetSMBDataLength(outp, 0);
 
-       osi_Log1(afsd_logp, "SMB OpenX opening fid %d", fidp->fid);
+       osi_Log1(smb_logp, "SMB OpenX opening fid %d", fidp->fid);
 
     cm_ReleaseUser(userp);
     /* leave scp held since we put it in fidp->scp */
@@ -2766,7 +2773,7 @@ long smb_ReceiveV3LockingX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
        LARGE_INTEGER LOffset, LLength;
        smb_waitingLock_t *waitingLock;
        void *lockp;
-       long code;
+       long code = 0;
        int i;
 
        cm_InitReq(&req);
@@ -2887,7 +2894,7 @@ long smb_ReceiveV3GetAttributes(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *
        unsigned short fid;
     smb_fid_t *fidp;
     cm_scache_t *scp;
-    long code;
+    long code = 0;
     long searchTime;
     cm_user_t *userp;
        cm_req_t req;
@@ -2937,7 +2944,7 @@ long smb_ReceiveV3GetAttributes(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *
     smb_SetSMBDataLength(outp, 0);
     code = 0;
 
-done:
+  done:
        lock_ReleaseMutex(&scp->mx);
        cm_ReleaseUser(userp);
        smb_ReleaseFID(fidp);
@@ -2949,7 +2956,7 @@ long smb_ReceiveV3SetAttributes(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *
        unsigned short fid;
     smb_fid_t *fidp;
     cm_scache_t *scp;
-    long code;
+    long code = 0;
        long searchTime;
     long unixTime;
     cm_user_t *userp;
@@ -2984,9 +2991,9 @@ long smb_ReceiveV3SetAttributes(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *
             attrs.clientModTime = unixTime;
             code = cm_SetAttr(scp, &attrs, userp, &req);
 
-            osi_Log1(afsd_logp, "SMB receive V3SetAttributes [fid=%ld]", fid);
+            osi_Log1(smb_logp, "SMB receive V3SetAttributes [fid=%ld]", fid);
         } else {
-            osi_Log1(afsd_logp, "**smb_UnixTimeFromSearchTime failed searchTime=%ld", searchTime);
+            osi_Log1(smb_logp, "**smb_UnixTimeFromSearchTime failed searchTime=%ld", searchTime);
         }
     }
     else code = 0;
@@ -3003,7 +3010,7 @@ long smb_ReceiveV3ReadX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
     long count, finalCount;
     unsigned short fd;
     smb_fid_t *fidp;
-    long code;
+    long code = 0;
     cm_user_t *userp;
     char *op;
         
@@ -3012,7 +3019,7 @@ long smb_ReceiveV3ReadX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
     offset.HighPart = 0;       /* too bad */
     offset.LowPart = smb_GetSMBParm(inp, 3) | (smb_GetSMBParm(inp, 4) << 16);
 
-    osi_Log3(afsd_logp, "smb_ReceiveV3Read fd %d, off 0x%x, size 0x%x",
+    osi_Log3(smb_logp, "smb_ReceiveV3Read fd %d, off 0x%x, size 0x%x",
              fd, offset.LowPart, count);
         
        fd = smb_ChainFID(fd, inp);
@@ -3084,7 +3091,7 @@ long smb_ReceiveV3ReadX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
 long smb_ReceiveNTCreateX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
 {
        char *pathp, *realPathp;
-       long code;
+       long code = 0;
        cm_space_t *spacep;
        cm_user_t *userp;
        cm_scache_t *dscp;              /* parent dir */
@@ -3172,8 +3179,8 @@ long smb_ReceiveNTCreateX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
        spacep = inp->spacep;
        smb_StripLastComponent(spacep->data, &lastNamep, realPathp);
 
-    osi_Log1(afsd_logp,"NTCreateX for [%s]",osi_LogSaveString(afsd_logp,realPathp));
-    osi_Log4(afsd_logp,"NTCreateX da=[%x] ea=[%x] cd=[%x] co=[%x]", desiredAccess, extAttributes, createDisp, createOptions);
+    osi_Log1(smb_logp,"NTCreateX for [%s]",osi_LogSaveString(smb_logp,realPathp));
+    osi_Log4(smb_logp,"NTCreateX da=[%x] ea=[%x] cd=[%x] co=[%x]", desiredAccess, extAttributes, createDisp, createOptions);
 
        if (lastNamep && strcmp(lastNamep, SMB_IOCTL_FILENAME) == 0) {
                /* special case magic file name for receiving IOCTL requests
@@ -3222,7 +3229,7 @@ long smb_ReceiveNTCreateX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
 #endif
     userp = smb_GetUser(vcp, inp);
     if (!userp) {
-       osi_Log1(afsd_logp, "NTCreateX Invalid user [%d]", ((smb_t *) inp)->uid);
+       osi_Log1(smb_logp, "NTCreateX Invalid user [%d]", ((smb_t *) inp)->uid);
        free(realPathp);
        return CM_ERROR_INVAL;
     }
@@ -3234,7 +3241,7 @@ long smb_ReceiveNTCreateX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
        else {
         baseFidp = smb_FindFID(vcp, baseFid, 0);
         if (!baseFidp) {
-               osi_Log1(afsd_logp, "NTCreateX Invalid base fid [%d]", baseFid);
+               osi_Log1(smb_logp, "NTCreateX Invalid base fid [%d]", baseFid);
                free(realPathp);
                cm_ReleaseUser(userp);
                return CM_ERROR_INVAL;
@@ -3243,7 +3250,7 @@ long smb_ReceiveNTCreateX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
                tidPathp = NULL;
        }
 
-    osi_Log1(afsd_logp, "NTCreateX tidPathp=[%s]", (tidPathp==NULL)?"null": osi_LogSaveString(afsd_logp,tidPathp));
+    osi_Log1(smb_logp, "NTCreateX tidPathp=[%s]", (tidPathp==NULL)?"null": osi_LogSaveString(smb_logp,tidPathp));
        
     /* compute open mode */
        fidflags = 0;
@@ -3296,7 +3303,7 @@ long smb_ReceiveNTCreateX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
         if (baseFid != 0) smb_ReleaseFID(baseFidp);
 
         if (code) {
-            osi_Log0(afsd_logp,"NTCreateX parent not found");
+            osi_Log0(smb_logp,"NTCreateX parent not found");
             cm_ReleaseUser(userp);
             free(realPathp);
             return code;
@@ -3380,8 +3387,8 @@ long smb_ReceiveNTCreateX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
        }
        else if (realDirFlag == 0 || realDirFlag == -1) {
                osi_assert(dscp != NULL);
-               osi_Log1(afsd_logp, "smb_ReceiveNTCreateX creating file %s",
-                               osi_LogSaveString(afsd_logp, lastNamep));
+               osi_Log1(smb_logp, "smb_ReceiveNTCreateX creating file %s",
+                               osi_LogSaveString(smb_logp, lastNamep));
                openAction = 2;         /* created file */
                setAttr.mask = CM_ATTRMASK_CLIENTMODTIME;
                setAttr.clientModTime = time(NULL);
@@ -3421,8 +3428,8 @@ long smb_ReceiveNTCreateX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
         /* create directory */
                if ( !treeCreate ) treeStartp = lastNamep;
         osi_assert(dscp != NULL);
-        osi_Log1(afsd_logp, "smb_ReceiveNTCreateX creating directory [%s]",
-                               osi_LogSaveString(afsd_logp, treeStartp));
+        osi_Log1(smb_logp, "smb_ReceiveNTCreateX creating directory [%s]",
+                               osi_LogSaveString(smb_logp, treeStartp));
                openAction = 2;         /* created directory */
 
                setAttr.mask = CM_ATTRMASK_CLIENTMODTIME;
@@ -3553,8 +3560,8 @@ long smb_ReceiveNTCreateX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
        lock_ReleaseMutex(&scp->mx);
        smb_SetSMBDataLength(outp, 0);
 
-       osi_Log2(afsd_logp, "SMB NT CreateX opening fid %d path %s", fidp->fid,
-                osi_LogSaveString(afsd_logp, realPathp));
+       osi_Log2(smb_logp, "SMB NT CreateX opening fid %d path %s", fidp->fid,
+                osi_LogSaveString(smb_logp, realPathp));
 
        smb_ReleaseFID(fidp);
 
@@ -3573,7 +3580,7 @@ long smb_ReceiveNTCreateX(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
 long smb_ReceiveNTTranCreate(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
 {
        char *pathp, *realPathp;
-       long code;
+       long code = 0;
        cm_space_t *spacep;
        cm_user_t *userp;
        cm_scache_t *dscp;              /* parent dir */
@@ -3654,9 +3661,9 @@ long smb_ReceiveNTTranCreate(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *out
        nameLength = lparmp[11];
 
 #ifdef DEBUG_VERBOSE
-       osi_Log4(afsd_logp,"NTTransCreate with da[%x],ea[%x],sa[%x],cd[%x]",desiredAccess,extAttributes,shareAccess,createDisp);
-       osi_Log2(afsd_logp,"... co[%x],sdl[%x],as[%x]",createOptions,sdLen,allocSize);
-       osi_Log1(afsd_logp,"... flags[%x]",flags);
+       osi_Log4(smb_logp,"NTTransCreate with da[%x],ea[%x],sa[%x],cd[%x]",desiredAccess,extAttributes,shareAccess,createDisp);
+       osi_Log2(smb_logp,"... co[%x],sdl[%x],as[%x]",createOptions,sdLen,allocSize);
+       osi_Log1(smb_logp,"... flags[%x]",flags);
 #endif
 
        /* mustBeDir is never set; createOptions directory bit seems to be
@@ -3702,7 +3709,7 @@ long smb_ReceiveNTTranCreate(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *out
 
        userp = smb_GetUser(vcp, inp);
     if(!userp) {
-       osi_Log1(afsd_logp, "NTTranCreate invalid user [%d]", ((smb_t *) inp)->uid);
+       osi_Log1(smb_logp, "NTTranCreate invalid user [%d]", ((smb_t *) inp)->uid);
        free(realPathp);
        return CM_ERROR_INVAL;
     }
@@ -3714,7 +3721,7 @@ long smb_ReceiveNTTranCreate(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *out
        else {
         baseFidp = smb_FindFID(vcp, baseFid, 0);
         if(!baseFidp) {
-               osi_Log1(afsd_logp, "NTTranCreate Invalid fid [%d]", baseFid);
+               osi_Log1(smb_logp, "NTTranCreate Invalid fid [%d]", baseFid);
                free(realPathp);
                cm_ReleaseUser(userp);
                return CM_ERROR_INVAL;
@@ -3826,8 +3833,8 @@ long smb_ReceiveNTTranCreate(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *out
        }
        else if (realDirFlag == 0 || realDirFlag == -1) {
                osi_assert(dscp != NULL);
-               osi_Log1(afsd_logp, "smb_ReceiveNTTranCreate creating file %s",
-                 osi_LogSaveString(afsd_logp, lastNamep));
+               osi_Log1(smb_logp, "smb_ReceiveNTTranCreate creating file %s",
+                 osi_LogSaveString(smb_logp, lastNamep));
                openAction = 2;         /* created file */
                setAttr.mask = CM_ATTRMASK_CLIENTMODTIME;
                setAttr.clientModTime = time(NULL);
@@ -3860,9 +3867,9 @@ long smb_ReceiveNTTranCreate(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *out
        else {
                /* create directory */
                osi_assert(dscp != NULL);
-               osi_Log1(afsd_logp,
+               osi_Log1(smb_logp,
                                "smb_ReceiveNTTranCreate creating directory %s",
-                               osi_LogSaveString(afsd_logp, lastNamep));
+                               osi_LogSaveString(smb_logp, lastNamep));
                openAction = 2;         /* created directory */
                setAttr.mask = CM_ATTRMASK_CLIENTMODTIME;
                setAttr.clientModTime = time(NULL);
@@ -4034,7 +4041,7 @@ long smb_ReceiveNTTranCreate(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *out
         lock_ReleaseMutex(&scp->mx);
     }
 
-       osi_Log1(afsd_logp, "SMB NTTranCreate opening fid %d", fidp->fid);
+       osi_Log1(smb_logp, "SMB NTTranCreate opening fid %d", fidp->fid);
 
        smb_ReleaseFID(fidp);
 
@@ -4060,7 +4067,7 @@ long smb_ReceiveNTTranNotifyChange(smb_vc_t *vcp, smb_packet_t *inp,
 
     fidp = smb_FindFID(vcp, fid, 0);
     if (!fidp) {
-        osi_Log1(afsd_logp, "ERROR: NotifyChange given invalid fid [%d]", fid);
+        osi_Log1(smb_logp, "ERROR: NotifyChange given invalid fid [%d]", fid);
         return CM_ERROR_BADFD;
     }
 
@@ -4071,8 +4078,8 @@ long smb_ReceiveNTTranNotifyChange(smb_vc_t *vcp, smb_packet_t *inp,
        smb_Directory_Watches = savedPacketp;
        lock_ReleaseMutex(&smb_Dir_Watch_Lock);
 
-    osi_Log4(afsd_logp, "Request for NotifyChange filter 0x%x fid %d wtree %d file %s",
-             filter, fid, watchtree, osi_LogSaveString(afsd_logp, fidp->NTopen_wholepathp));
+    osi_Log4(smb_logp, "Request for NotifyChange filter 0x%x fid %d wtree %d file %s",
+             filter, fid, watchtree, osi_LogSaveString(smb_logp, fidp->NTopen_wholepathp));
 
     scp = fidp->scp;
     lock_ObtainMutex(&scp->mx);
@@ -4176,7 +4183,7 @@ long smb_ReceiveNTTransact(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
 
        function = smb_GetSMBParm(inp, 18);
 
-       osi_Log1(afsd_logp, "SMB NT Transact function %d", function);
+       osi_Log1(smb_logp, "SMB NT Transact function %d", function);
 
        /* We can handle long names */
        if (vcp->flags & SMB_VCFLAG_USENT)
@@ -4257,9 +4264,9 @@ void smb_NotifyChange(DWORD action, DWORD notifyFilter,
                }
                smb_ReleaseFID(fidp);
 
-               osi_Log4(afsd_logp,
+               osi_Log4(smb_logp,
                         "Sending Change Notification for fid %d filter 0x%x wtree %d file %s",
-                        fid, filter, wtree, osi_LogSaveString(afsd_logp, filename));
+                        fid, filter, wtree, osi_LogSaveString(smb_logp, filename));
 
                nextWatch = watch->nextp;
                if (watch == smb_Directory_Watches)
@@ -4376,7 +4383,7 @@ long smb_ReceiveNTCancel(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
        smb_fid_t *fidp;
        cm_scache_t *scp;
 
-       osi_Log0(afsd_logp, "SMB3 receive NT cancel");
+       osi_Log0(smb_logp, "SMB3 receive NT cancel");
 
        lock_ObtainMutex(&smb_Dir_Watch_Lock);
        watch = smb_Directory_Watches;
@@ -4397,9 +4404,9 @@ long smb_ReceiveNTCancel(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
 
                        fidp = smb_FindFID(vcp, fid, 0);
             if (fidp) {
-                osi_Log3(afsd_logp, "Cancelling change notification for fid %d wtree %d file %s", 
+                osi_Log3(smb_logp, "Cancelling change notification for fid %d wtree %d file %s", 
                          fid, watchtree,
-                         osi_LogSaveString(afsd_logp, (fidp)?fidp->NTopen_wholepathp:""));
+                         osi_LogSaveString(smb_logp, (fidp)?fidp->NTopen_wholepathp:""));
 
                 scp = fidp->scp;
                 lock_ObtainMutex(&scp->mx);
@@ -4410,7 +4417,7 @@ long smb_ReceiveNTCancel(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp)
                 lock_ReleaseMutex(&scp->mx);
                 smb_ReleaseFID(fidp);
             } else {
-                osi_Log2(afsd_logp,"NTCancel unable to resolve fid [%d] in vcp[%x]", fid,vcp);
+                osi_Log2(smb_logp,"NTCancel unable to resolve fid [%d] in vcp[%x]", fid,vcp);
             }
 
                        /* assume STATUS32; return 0xC0000120 (CANCELED) */