(!strncmp
(AFSDIR_USR_DIRPATH, AFSDIR_SERVER_BIN_DIRPATH,
strlen(AFSDIR_USR_DIRPATH)))) {
- MakeDir(AFSDIR_USR_DIRPATH);
+ if (MakeDir(AFSDIR_USR_DIRPATH))
+ return errno;
}
if (!strncmp
(AFSDIR_SERVER_AFS_DIRPATH, AFSDIR_SERVER_BIN_DIRPATH,
strlen(AFSDIR_SERVER_AFS_DIRPATH))) {
- MakeDir(AFSDIR_SERVER_AFS_DIRPATH);
+ if (MakeDir(AFSDIR_SERVER_AFS_DIRPATH))
+ return errno;
}
- MakeDir(AFSDIR_SERVER_BIN_DIRPATH);
- MakeDir(AFSDIR_SERVER_ETC_DIRPATH);
- MakeDir(AFSDIR_SERVER_LOCAL_DIRPATH);
- MakeDir(AFSDIR_SERVER_DB_DIRPATH);
- MakeDir(AFSDIR_SERVER_LOGS_DIRPATH);
+ if (MakeDir(AFSDIR_SERVER_BIN_DIRPATH))
+ return errno;
+ if (MakeDir(AFSDIR_SERVER_ETC_DIRPATH))
+ return errno;
+ if (MakeDir(AFSDIR_SERVER_LOCAL_DIRPATH))
+ return errno;
+ if (MakeDir(AFSDIR_SERVER_DB_DIRPATH))
+ return errno;
+ if (MakeDir(AFSDIR_SERVER_LOGS_DIRPATH))
+ return errno;
#ifndef AFS_NT40_ENV
if (!strncmp
(AFSDIR_CLIENT_VICE_DIRPATH, AFSDIR_CLIENT_ETC_DIRPATH,
strlen(AFSDIR_CLIENT_VICE_DIRPATH))) {
- MakeDir(AFSDIR_CLIENT_VICE_DIRPATH);
+ if (MakeDir(AFSDIR_CLIENT_VICE_DIRPATH))
+ return errno;
}
- MakeDir(AFSDIR_CLIENT_ETC_DIRPATH);
+ if (MakeDir(AFSDIR_CLIENT_ETC_DIRPATH))
+ return errno;
- symlink(AFSDIR_SERVER_THISCELL_FILEPATH, AFSDIR_CLIENT_THISCELL_FILEPATH);
- symlink(AFSDIR_SERVER_CELLSERVDB_FILEPATH,
- AFSDIR_CLIENT_CELLSERVDB_FILEPATH);
+ if (symlink(AFSDIR_SERVER_THISCELL_FILEPATH,
+ AFSDIR_CLIENT_THISCELL_FILEPATH)) {
+ if (errno != EEXIST) {
+ return errno;
+ }
+ }
+ if (symlink(AFSDIR_SERVER_CELLSERVDB_FILEPATH,
+ AFSDIR_CLIENT_CELLSERVDB_FILEPATH)) {
+ if (errno != EEXIST) {
+ return errno;
+ }
+ }
#endif /* AFS_NT40_ENV */
- if (coredir)
- MakeDir(coredir);
+ if (coredir) {
+ if (MakeDir(coredir))
+ return errno;
+ }
return 0;
}
WriteBozoFile(char *aname)
{
FILE *tfile;
- char tbuffer[AFSDIR_PATH_MAX];
+ char *tbuffer = NULL;
afs_int32 code;
struct bztemp btemp;
+ int ret = 0;
if (!aname)
aname = (char *)bozo_fileName;
- strcpy(tbuffer, aname);
- strcat(tbuffer, ".NBZ");
- tfile = fopen(tbuffer, "w");
- if (!tfile)
+ if (asprintf(&tbuffer, "%s.NBZ", aname) < 0)
return -1;
+
+ tfile = fopen(tbuffer, "w");
+ if (!tfile) {
+ ret = -1;
+ goto out;
+ }
btemp.file = tfile;
fprintf(tfile, "restrictmode %d\n", bozo_isrestricted);
if (code || (code = ferror(tfile))) { /* something went wrong */
fclose(tfile);
unlink(tbuffer);
- return code;
+ ret = code;
+ goto out;
}
/* close the file, check for errors and snap new file into place */
if (fclose(tfile) == EOF) {
unlink(tbuffer);
- return -1;
+ ret = -1;
+ goto out;
}
code = rk_rename(tbuffer, aname);
if (code) {
unlink(tbuffer);
- return -1;
+ ret = -1;
+ goto out;
}
- return 0;
+ ret = 0;
+out:
+ free(tbuffer);
+ return ret;
}
static int
make_pid_filename(char *ainst, char *aname)
{
char *buffer = NULL;
+ int r;
if (aname && *aname) {
- asprintf(&buffer, "%s/%s.%s.pid", DoPidFiles, ainst, aname);
- if (buffer == NULL)
+ r = asprintf(&buffer, "%s/%s.%s.pid", DoPidFiles, ainst, aname);
+ if (r < 0 || buffer == NULL)
bozo_Log("Failed to alloc pid filename buffer for %s.%s.\n",
ainst, aname);
} else {
- asprintf(&buffer, "%s/%s.pid", DoPidFiles, ainst);
- if (buffer == NULL)
+ r = asprintf(&buffer, "%s/%s.pid", DoPidFiles, ainst);
+ if (r < 0 || buffer == NULL)
bozo_Log("Failed to alloc pid filename buffer for %s.\n", ainst);
}
struct afsconf_dir *tdir;
int noAuth = 0;
int i;
- char namebuf[AFSDIR_PATH_MAX];
+ char *oldlog;
int rxMaxMTU = -1;
afs_uint32 host = htonl(INADDR_ANY);
char *auditFileName = NULL;
printf("Usage: bosserver [-noauth] [-log] "
"[-auditlog <log path>] "
"[-audit-interface <file|sysvmq> (default is file)] "
- "[-rxmaxmtu <bytes>] [-rxbind] [-allow-dotted-principals]"
+ "[-rxmaxmtu <bytes>] [-rxbind] [-allow-dotted-principals] "
"[-syslog[=FACILITY]] "
"[-restricted] "
"[-enable_peer_stats] [-enable_process_stats] "
printf("Usage: bosserver [-noauth] [-log] "
"[-auditlog <log path>] "
"[-audit-interface <file|sysvmq> (default is file)] "
- "[-rxmaxmtu <bytes>] [-rxbind] [-allow-dotted-principals]"
+ "[-rxmaxmtu <bytes>] [-rxbind] [-allow-dotted-principals] "
"[-restricted] "
"[-enable_peer_stats] [-enable_process_stats] "
"[-cores=<none|path>] \n"
!(S_ISFIFO(sb.st_mode)))
#endif
) {
- strcpy(namebuf, AFSDIR_BOZLOG_FILE);
- strcat(namebuf, ".old");
- rk_rename(AFSDIR_BOZLOG_FILE, namebuf); /* try rename first */
+ if (asprintf(&oldlog, "%s.old", AFSDIR_BOZLOG_FILE) < 0) {
+ printf("bosserver: out of memory\n");
+ exit(1);
+ }
+ rk_rename(AFSDIR_BOZLOG_FILE, oldlog); /* try rename first */
+ free(oldlog);
bozo_logFile = fopen(AFSDIR_BOZLOG_FILE, "a");
if (!bozo_logFile) {
printf("bosserver: can't initialize log file (%s).\n",
*/
#ifndef AFS_NT40_ENV
- if (!nofork)
- daemon(1, 0);
+ if (!nofork) {
+ if (daemon(1, 0))
+ printf("bosserver: warning - daemon() returned code %d\n", errno);
+ }
#endif /* ! AFS_NT40_ENV */
/* create useful dirs */
- CreateDirs(DoCore);
+ i = CreateDirs(DoCore);
+ if (i) {
+ printf("bosserver: could not set up directories, code %d\n", i);
+ exit(1);
+ }
/* Write current state of directory permissions to log file */
DirAccessOK();
/* chdir to AFS log directory */
if (DoCore)
- chdir(DoCore);
+ i = chdir(DoCore);
else
- chdir(AFSDIR_SERVER_LOGS_DIRPATH);
+ i = chdir(AFSDIR_SERVER_LOGS_DIRPATH);
+ if (i) {
+ printf("bosserver: could not change to %s, code %d\n",
+ DoCore ? DoCore : AFSDIR_SERVER_LOGS_DIRPATH, errno);
+ exit(1);
+ }
/* try to read the key from the config file */
tdir = afsconf_Open(AFSDIR_SERVER_ETC_DIRPATH);
}
void
-bozo_Log(char *format, ...)
+bozo_Log(const char *format, ...)
{
char tdate[27];
time_t myTime;