/*
* Copyright 2000, International Business Machines Corporation and others.
* All Rights Reserved.
- *
+ *
* This software has been released under the terms of the IBM Public
* License. For details, see the LICENSE file in the top-level source
* directory or online at http://www.openafs.org/dl/license10.html
*/
+#include <afsconfig.h>
+#include <afs/param.h>
+
+#include <roken.h>
+
+#ifdef AFS_NT40_ENV
+#include <WINNT/afsevent.h>
+#endif
+
+#include <ubik.h>
+#include <afs/afsutil.h>
+#include <afs/cmd.h>
+
+#include "vlserver.h"
+#include "vldbint.h"
+
/* Read a VLDB file and verify it for correctness */
#define VL 0x001 /* good volume entry */
#define REFBK 0x4000 /* linked from something (BK) */
#define REFN 0x8000 /* linked from something (name) */
-#define vldbread(x,y,z) vldbio(x,y,z,0)
-#define vldbwrite(x,y,z) vldbio(x,y,z,1)
+#define MULTRW 0x10000 /* multiply-chained (RW) */
+#define MULTRO 0x20000 /* multiply-chained (RO) */
+#define MULTBK 0x40000 /* multiply-chained (BK) */
+#define MULTN 0x80000 /* multiply-chained (name) */
-#include <afsconfig.h>
-#include <afs/param.h>
-
-RCSID
- ("$Header$");
+#define MISRWH 0x100000 /* mischained (RW) */
+#define MISROH 0x200000 /* mischained (RO) */
+#define MISBKH 0x400000 /* mischained (BK) */
+#define MISNH 0x800000 /* mischained (name) */
-#include <sys/types.h>
-#include <sys/stat.h>
-#include <fcntl.h>
-#include <errno.h>
-#include <string.h>
-#ifdef AFS_NT40_ENV
-#include <winsock2.h>
-#include <WINNT/afsevent.h>
-#include <io.h>
-#else
-#include <sys/socket.h>
-#include <netdb.h>
-#include <netinet/in.h>
-#endif
-
-#include "vlserver.h"
-#include "vldbint.h"
-#include <ubik.h>
-#include <afs/afsutil.h>
-#include <afs/cmd.h>
+#define VLDB_CHECK_NO_VLDB_CHECK_ERROR 0
+#define VLDB_CHECK_WARNING 1
+#define VLDB_CHECK_ERROR 2
+#define VLDB_CHECK_FATAL 4
+#define vldbread(x,y,z) vldbio(x,y,z,0)
+#define vldbwrite(x,y,z) vldbio(x,y,z,1)
#define ADDR(x) (x/sizeof(struct nvlentry))
int fd;
-int listentries, listservers, listheader, listuheader, verbose;
+int listentries, listservers, listheader, listuheader, verbose, quiet;
int fix = 0;
+int passes = 0;
+/* if quiet, don't send anything to stdout */
+int quiet = 0;
+/* error level. 0 = no error, 1 = warning, 2 = error, 4 = fatal */
+int error_level = 0;
struct er {
long addr;
int type;
} *record;
+afs_int32 maxentries;
int serveraddrs[MAXSERVERID + 2];
+/* Used to control what goes to stdout based on quiet flag */
+void
+quiet_println(const char *fmt,...) {
+ va_list args;
+ if (!quiet) {
+ va_start(args, fmt);
+ vfprintf(stdout, fmt, args);
+ va_end(args);
+ }
+}
+
+/* Used to set the error level and ship messages to stderr */
+void
+log_error(int eval, const char *fmt, ...)
+{
+ va_list args;
+ if (error_level < eval) error_level = eval ; /* bump up the severity */
+ va_start(args, fmt);
+ vfprintf(stderr, fmt, args);
+ va_end(args);
+
+ if (error_level == VLDB_CHECK_FATAL) exit(VLDB_CHECK_FATAL);
+}
+
+
#if 0
int
writeUbikHeader()
#define HDRSIZE 64
int
-readUbikHeader()
+readUbikHeader(void)
{
int offset, r;
struct ubik_hdr uheader;
offset = lseek(fd, 0, 0);
if (offset != 0) {
- printf("error: lseek to 0 failed: %d %d\n", offset, errno);
- return (-1);
+ log_error(VLDB_CHECK_FATAL,"error: lseek to 0 failed: %d %d\n", offset, errno);
+ return (VLDB_CHECK_FATAL);
}
/* now read the info */
r = read(fd, &uheader, sizeof(uheader));
if (r != sizeof(uheader)) {
- printf("error: read of %d bytes failed: %d %d\n", sizeof(uheader), r,
+ log_error(VLDB_CHECK_FATAL,"error: read of %lu bytes failed: %d %d\n", sizeof(uheader), r,
errno);
- return (-1);
+ return (VLDB_CHECK_FATAL);
}
uheader.magic = ntohl(uheader.magic);
- uheader.size = ntohl(uheader.size);
+ uheader.size = ntohs(uheader.size);
uheader.version.epoch = ntohl(uheader.version.epoch);
uheader.version.counter = ntohl(uheader.version.counter);
if (listuheader) {
- printf("Ubik Header\n");
- printf(" Magic = 0x%x\n", uheader.magic);
- printf(" Size = %u\n", uheader.size);
- printf(" Version.epoch = %u\n", uheader.version.epoch);
- printf(" Version.counter = %u\n", uheader.version.counter);
+ quiet_println("Ubik Header\n");
+ quiet_println(" Magic = 0x%x\n", uheader.magic);
+ quiet_println(" Size = %u\n", uheader.size);
+ quiet_println(" Version.epoch = %u\n", uheader.version.epoch);
+ quiet_println(" Version.counter = %u\n", uheader.version.counter);
}
if (uheader.size != HDRSIZE)
- printf("Ubik header size is %u (should be %u)\n", uheader.size,
+ log_error(VLDB_CHECK_WARNING,"VLDB_CHECK_WARNING: Ubik header size is %u (should be %u)\n", uheader.size,
HDRSIZE);
if (uheader.magic != UBIK_MAGIC)
- printf("Ubik header magic is 0x%x (should be 0x%x)\n", uheader.magic,
+ log_error(VLDB_CHECK_ERROR,"Ubik header magic is 0x%x (should be 0x%x)\n", uheader.magic,
UBIK_MAGIC);
return (0);
}
int
-vldbio(int position, char *buffer, int size, int rdwr)
+vldbio(int position, void *buffer, int size, int rdwr)
{
int offset, r, p;
p = position + HDRSIZE;
offset = lseek(fd, p, 0);
if (offset != p) {
- printf("error: lseek to %d failed: %d %d\n", p, offset, errno);
+ log_error(VLDB_CHECK_FATAL,"error: lseek to %d failed: %d %d\n", p, offset, errno);
return (-1);
}
- if (rdwr == 1)
+ if (rdwr == 1)
r = write(fd, buffer, size);
- else
+ else
r = read(fd, buffer, size);
if (r != size) {
- printf("error: %s of %d bytes failed: %d %d\n", rdwr==1?"write":"read",
+ log_error(VLDB_CHECK_FATAL,"error: %s of %d bytes failed: %d %d\n", rdwr==1?"write":"read",
size, r, errno);
return (-1);
}
}
afs_int32
-IdHash(afs_int32 volid)
+IdHash(afs_uint32 volid)
{
return ((abs(volid)) % HASHSIZE);
}
return (slen != strspn(volname, map));
}
+int
+validVolumeAddr(afs_uint32 fileOffset)
+{
+ if (ADDR(fileOffset) >= maxentries) {
+ /* Are we in range */
+ return 0;
+ }
+ /*
+ * We cannot test whether the offset is aligned
+ * since the vl entries are not in a regular array
+ */
+ return 1;
+}
+
void
readheader(struct vlheader *headerp)
{
int i, j;
- vldbread(0, headerp, sizeof(*headerp));
+ vldbread(0, (char *)headerp, sizeof(*headerp));
headerp->vital_header.vldbversion =
ntohl(headerp->vital_header.vldbversion);
headerp->VolidHash[i][j] = ntohl(headerp->VolidHash[i][j]);
if (listheader) {
- printf("vldb header\n");
- printf(" vldbversion = %u\n",
+ quiet_println("vldb header\n");
+ quiet_println(" vldbversion = %u\n",
headerp->vital_header.vldbversion);
- printf(" headersize = %u [actual=%u]\n",
+ quiet_println(" headersize = %u [actual=%lu]\n",
headerp->vital_header.headersize, sizeof(*headerp));
- printf(" freePtr = 0x%x\n", headerp->vital_header.freePtr);
- printf(" eofPtr = %u\n", headerp->vital_header.eofPtr);
- printf(" allocblock calls = %10u\n", headerp->vital_header.allocs);
- printf(" freeblock calls = %10u\n", headerp->vital_header.frees);
- printf(" MaxVolumeId = %u\n",
+ quiet_println(" freePtr = 0x%x\n", headerp->vital_header.freePtr);
+ quiet_println(" eofPtr = %u\n", headerp->vital_header.eofPtr);
+ quiet_println(" allocblock calls = %10u\n", headerp->vital_header.allocs);
+ quiet_println(" freeblock calls = %10u\n", headerp->vital_header.frees);
+ quiet_println(" MaxVolumeId = %u\n",
headerp->vital_header.MaxVolumeId);
- printf(" rw vol entries = %u\n",
+ quiet_println(" rw vol entries = %u\n",
headerp->vital_header.totalEntries[0]);
- printf(" ro vol entries = %u\n",
+ quiet_println(" ro vol entries = %u\n",
headerp->vital_header.totalEntries[1]);
- printf(" bk vol entries = %u\n",
+ quiet_println(" bk vol entries = %u\n",
headerp->vital_header.totalEntries[2]);
- printf(" multihome info = 0x%x (%u)\n", headerp->SIT,
+ quiet_println(" multihome info = 0x%x (%u)\n", headerp->SIT,
headerp->SIT);
- printf(" server ip addr table: size = %d entries\n",
+ quiet_println(" server ip addr table: size = %d entries\n",
MAXSERVERID + 1);
- printf(" volume name hash table: size = %d buckets\n", HASHSIZE);
- printf(" volume id hash table: %d tables with %d buckets each\n",
+ quiet_println(" volume name hash table: size = %d buckets\n", HASHSIZE);
+ quiet_println(" volume id hash table: %d tables with %d buckets each\n",
MAXTYPES, HASHSIZE);
}
/* Check the header size */
if (headerp->vital_header.headersize != sizeof(*headerp))
- printf("Header reports its size as %d (should be %d)\n",
+ log_error(VLDB_CHECK_WARNING,"Header reports its size as %d (should be %lu)\n",
headerp->vital_header.headersize, sizeof(*headerp));
+ return;
}
void
for (j = 0; j < HASHSIZE; j++)
headerp->VolidHash[i][j] = htonl(headerp->VolidHash[i][j]);
- vldbwrite(0, headerp, sizeof(*headerp));
+ vldbwrite(0, (char *)headerp, sizeof(*headerp));
}
void
int i, j;
struct extentaddr *e;
- vldbread(addr, mhblockP, VL_ADDREXTBLK_SIZE);
+ vldbread(addr, (char *)mhblockP, VL_ADDREXTBLK_SIZE);
mhblockP->ex_count = ntohl(mhblockP->ex_count);
mhblockP->ex_flags = ntohl(mhblockP->ex_flags);
for (j = 0; j < VL_MAXIPADDRS_PERMH; j++)
e->ex_addrs[j] = ntohl(e->ex_addrs[j]);
}
+ return;
}
void
{
int i;
- vldbread(addr, vlentryp, sizeof(*vlentryp));
+ vldbread(addr, (char *)vlentryp, sizeof(*vlentryp));
for (i = 0; i < MAXTYPES; i++)
vlentryp->volumeId[i] = ntohl(vlentryp->volumeId[i]);
vlentryp->nextIdHash[i] = ntohl(vlentryp->nextIdHash[i]);
vlentryp->nextNameHash = ntohl(vlentryp->nextNameHash);
for (i = 0; i < NMAXNSERVERS; i++) {
- vlentryp->serverNumber[i] = ntohl(vlentryp->serverNumber[i]);
- vlentryp->serverPartition[i] = ntohl(vlentryp->serverPartition[i]);
- vlentryp->serverFlags[i] = ntohl(vlentryp->serverFlags[i]);
+ /* make sure not to ntohl these, as they're chars, not ints */
+ vlentryp->serverNumber[i] = vlentryp->serverNumber[i];
+ vlentryp->serverPartition[i] = vlentryp->serverPartition[i];
+ vlentryp->serverFlags[i] = vlentryp->serverFlags[i];
}
if (vlentryp->flags == VLCONTBLOCK) {
}
if (listentries) {
- printf("address %u: ", addr);
+ quiet_println("address %u: ", addr);
if (vlentryp->flags == VLCONTBLOCK) {
- printf("mh extension block\n");
+ quiet_println("mh extension block\n");
} else if (vlentryp->flags == VLFREE) {
- printf("free vlentry\n");
+ quiet_println("free vlentry\n");
} else {
- printf("vlentry %s\n", vlentryp->name);
- printf(" rw id = %u ; ro id = %u ; bk id = %u\n",
+ quiet_println("vlentry %s\n", vlentryp->name);
+ quiet_println(" rw id = %u ; ro id = %u ; bk id = %u\n",
vlentryp->volumeId[0], vlentryp->volumeId[1],
vlentryp->volumeId[2]);
- printf(" flags =");
+ quiet_println(" flags =");
if (vlentryp->flags & VLF_RWEXISTS)
- printf(" rw");
+ quiet_println(" rw");
if (vlentryp->flags & VLF_ROEXISTS)
- printf(" ro");
+ quiet_println(" ro");
if (vlentryp->flags & VLF_BACKEXISTS)
- printf(" bk");
- if (vlentryp->flags & 0xffff8fff)
- printf(" errorflag(0x%x)", vlentryp->flags);
- printf("\n");
- printf(" LockAfsId = %d\n", vlentryp->LockAfsId);
- printf(" LockTimestamp = %d\n", vlentryp->LockTimestamp);
- printf(" cloneId = %u\n", vlentryp->cloneId);
- printf
+ quiet_println(" bk");
+ if (vlentryp->flags & VLOP_MOVE)
+ quiet_println(" lock_move");
+ if (vlentryp->flags & VLOP_RELEASE)
+ quiet_println(" lock_release");
+ if (vlentryp->flags & VLOP_BACKUP)
+ quiet_println(" lock_backup");
+ if (vlentryp->flags & VLOP_DELETE)
+ quiet_println(" lock_delete");
+ if (vlentryp->flags & VLOP_DUMP)
+ quiet_println(" lock_dump");
+
+ /* all bits not covered by VLF_* and VLOP_* constants */
+ if (vlentryp->flags & 0xffff8e0f)
+ quiet_println(" errorflag(0x%x)", vlentryp->flags);
+ quiet_println("\n");
+ quiet_println(" LockAfsId = %d\n", vlentryp->LockAfsId);
+ quiet_println(" LockTimestamp = %d\n", vlentryp->LockTimestamp);
+ quiet_println(" cloneId = %u\n", vlentryp->cloneId);
+ quiet_println
(" next hash for rw = %u ; ro = %u ; bk = %u ; name = %u\n",
vlentryp->nextIdHash[0], vlentryp->nextIdHash[1],
vlentryp->nextIdHash[2], vlentryp->nextNameHash);
for (i = 0; i < NMAXNSERVERS; i++) {
if (vlentryp->serverNumber[i] != 255) {
- printf(" server %d ; partition %d ; flags =",
+ quiet_println(" server %d ; partition %d ; flags =",
vlentryp->serverNumber[i],
vlentryp->serverPartition[i]);
if (vlentryp->serverFlags[i] & VLSF_RWVOL)
- printf(" rw");
+ quiet_println(" rw");
if (vlentryp->serverFlags[i] & VLSF_ROVOL)
- printf(" ro");
+ quiet_println(" ro");
if (vlentryp->serverFlags[i] & VLSF_BACKVOL)
- printf(" bk");
+ quiet_println(" bk");
if (vlentryp->serverFlags[i] & VLSF_NEWREPSITE)
- printf(" newro");
- printf("\n");
+ quiet_println(" newro");
+ quiet_println("\n");
}
}
}
}
+ return;
}
void
{
int i;
- if (verbose)
- printf("Writing back entry at addr %u\n", addr);
-
+ if (verbose) quiet_println("Writing back entry at addr %u\n", addr);
for (i = 0; i < MAXTYPES; i++)
vlentryp->volumeId[i] = htonl(vlentryp->volumeId[i]);
vlentryp->flags = htonl(vlentryp->flags);
vlentryp->nextIdHash[i] = htonl(vlentryp->nextIdHash[i]);
vlentryp->nextNameHash = htonl(vlentryp->nextNameHash);
for (i = 0; i < NMAXNSERVERS; i++) {
- vlentryp->serverNumber[i] = htonl(vlentryp->serverNumber[i]);
- vlentryp->serverPartition[i] = htonl(vlentryp->serverPartition[i]);
- vlentryp->serverFlags[i] = htonl(vlentryp->serverFlags[i]);
+ /* make sure not to htonl these, as they're chars, not ints */
+ vlentryp->serverNumber[i] = vlentryp->serverNumber[i] ;
+ vlentryp->serverPartition[i] = vlentryp->serverPartition[i] ;
+ vlentryp->serverFlags[i] = vlentryp->serverFlags[i] ;
}
- vldbwrite(addr, vlentryp, sizeof(*vlentryp));
+ vldbwrite(addr, (char *)vlentryp, sizeof(*vlentryp));
}
void
vldbread(addr, sitbuf, VL_ADDREXTBLK_SIZE);
extent = (struct extentaddr *)sitbuf;
- printf("multihome info block: base %d\n", base);
+ quiet_println("multihome info block: base %d\n", base);
if (base == 0) {
- printf(" count = %u\n", ntohl(extent->ex_count));
- printf(" flags = %u\n", ntohl(extent->ex_flags));
+ quiet_println(" count = %u\n", ntohl(extent->ex_count));
+ quiet_println(" flags = %u\n", ntohl(extent->ex_flags));
for (i = 0; i < VL_MAX_ADDREXTBLKS; i++) {
- printf(" contaddrs[%d] = %u\n", i,
+ quiet_println(" contaddrs[%d] = %u\n", i,
ntohl(extent->ex_contaddrs[i]));
}
}
if (j >= VL_MAX_ADDREXTBLKS)
continue;
- printf(" base %d index %d:\n", base, i);
+ quiet_println(" base %d index %d:\n", base, i);
- printf(" afsuuid = (%x %x %x /%d/%d/ /%x/%x/%x/%x/%x/%x/)\n",
+ quiet_println(" afsuuid = (%x %x %x /%d/%d/ /%x/%x/%x/%x/%x/%x/)\n",
ntohl(extent[i].ex_hostuuid.time_low),
ntohl(extent[i].ex_hostuuid.time_mid),
ntohl(extent[i].ex_hostuuid.time_hi_and_version),
ntohl(extent[i].ex_hostuuid.node[3]),
ntohl(extent[i].ex_hostuuid.node[4]),
ntohl(extent[i].ex_hostuuid.node[5]));
- printf(" uniquifier = %u\n", ntohl(extent[i].ex_uniquifier));
+ quiet_println(" uniquifier = %u\n", ntohl(extent[i].ex_uniquifier));
for (j = 0; j < VL_MAXIPADDRS_PERMH; j++) {
a = ntohl(extent[i].ex_addrs[j]);
if (a) {
- printf(" %d.%d.%d.%d\n", (a >> 24) & 0xff,
+ quiet_println(" %d.%d.%d.%d\n", (a >> 24) & 0xff,
(a >> 16) & 0xff, (a >> 8) & 0xff, (a) & 0xff);
}
}
int freecount = 0, mhcount = 0, vlcount = 0;
int rwcount = 0, rocount = 0, bkcount = 0;
struct nvlentry vlentry;
- afs_uint32 addr, entrysize, maxvolid = 0;
+ afs_uint32 addr;
+ afs_uint32 entrysize = 0;
+ afs_uint32 maxvolid = 0;
- if (verbose)
- printf("Read each entry in the database\n");
+ if (verbose) quiet_println("Read each entry in the database\n");
for (addr = header->vital_header.headersize;
addr < header->vital_header.eofPtr; addr += entrysize) {
readentry(addr, &vlentry, &type);
if (type == VL) {
if (!(vlentry.flags & VLF_RWEXISTS))
- printf("WARNING: VLDB entry '%s' has no RW volume\n",
+ log_error(VLDB_CHECK_WARNING,"VLDB_CHECK_WARNING: VLDB entry '%s' has no RW volume\n",
vlentry.name);
for (i = 0; i < MAXTYPES; i++)
continue;
}
if (e) {
- printf
- ("VLDB entry '%s' contains an unknown RW/RO index serverFlag\n",
+ log_error
+ (VLDB_CHECK_ERROR,"VLDB entry '%s' contains an unknown RW/RO index serverFlag\n",
vlentry.name);
e = 0;
}
- printf
+ quiet_println
(" index %d : serverNumber %d : serverPartition %d : serverFlag %d\n",
j, vlentry.serverNumber[j], vlentry.serverPartition[j],
vlentry.serverFlags[j]);
rindex = addr / sizeof(vlentry);
if (record[rindex].type) {
- printf("INTERNAL ERROR: record holder %d already in use\n",
+ log_error(VLDB_CHECK_ERROR,"INTERNAL VLDB_CHECK_ERROR: record holder %d already in use\n",
rindex);
return;
}
entrysize = VL_ADDREXTBLK_SIZE;
mhcount++;
} else {
- printf("Unknown entry at %u\n", addr);
+ log_error(VLDB_CHECK_ERROR, "Unknown entry at %u. Aborting\n", addr);
+ break;
}
}
if (verbose) {
- printf("Found %d entries, %d free entries, %d multihomed blocks\n",
+ quiet_println("Found %d entries, %d free entries, %d multihomed blocks\n",
vlcount, freecount, mhcount);
- printf("Found %d RW volumes, %d BK volumes, %d RO volumes\n", rwcount,
+ quiet_println("Found %d RW volumes, %d BK volumes, %d RO volumes\n", rwcount,
bkcount, rocount);
}
/* Check the maxmimum volume id in the header */
if (maxvolid != header->vital_header.MaxVolumeId - 1)
- printf
+ quiet_println
("Header's maximum volume id is %u and largest id found in VLDB is %u\n",
header->vital_header.MaxVolumeId, maxvolid);
}
-
-void
-SetHashEnd(long addr, int type, long new)
-{
- struct nvlentry vlentry;
- afs_int32 i, rindex, type2, next = -1;
-
- for (; addr; addr = next) {
- readentry(addr, &vlentry, &type2);
- switch(type & 0xf0) {
- case RWH:
- next = vlentry.nextIdHash[0];
- break;
- case ROH:
- next = vlentry.nextIdHash[1];
- break;
- case BKH:
- next = vlentry.nextIdHash[2];
- break;
- case NH:
- next = vlentry.nextNameHash;
- break;
- default:
- next = -1;
- }
-
- if (next < 1) {
- switch(type & 0xf0) {
- case RWH:
- if (vlentry.nextIdHash[0] != 0) {printf("bwoop\n");}
- vlentry.nextIdHash[0] = new;
- break;
- case ROH:
- if (vlentry.nextIdHash[1] != 0) {printf("bwoop\n");}
- vlentry.nextIdHash[1] = new;
- break;
- case BKH:
- if (vlentry.nextIdHash[2] != 0) {printf("bwoop\n");}
- vlentry.nextIdHash[2] = new;
- break;
- case NH:
- if (vlentry.nextNameHash != 0) {printf("bwoop\n");}
- vlentry.nextNameHash = new;
- break;
- }
- writeentry(addr, &vlentry);
- return;
- }
- }
-}
-
/*
* Follow each Name hash bucket marking it as read in the record array.
* Record we found it in the name hash within the record array.
afs_int32 i, type, rindex;
/* Now follow the Name Hash Table */
- if (verbose)
- printf("Check Volume Name Hash\n");
+ if (verbose) quiet_println("Check Volume Name Hash\n");
for (i = 0; i < HASHSIZE; i++) {
chainlength = 0;
+
+ if (!validVolumeAddr(header->VolnameHash[i])) {
+ log_error(VLDB_CHECK_ERROR,"Name Hash %d: Bad entry %u is out of range\n",
+ i, header->VolnameHash[i]);
+ continue;
+ }
+
for (addr = header->VolnameHash[i]; addr; addr = vlentry.nextNameHash) {
readentry(addr, &vlentry, &type);
if (type != VL) {
- printf("Name Hash %d: Bad entry at %u: Not a valid vlentry\n",
+ log_error(VLDB_CHECK_ERROR,"Name Hash %d: Bad entry at %u: Not a valid vlentry\n",
i, addr);
continue;
}
- rindex = addr / sizeof(vlentry);
+ rindex = ADDR(addr);
+ /*
+ * we know that the address is valid because we
+ * checked it either above or below
+ */
if (record[rindex].addr != addr && record[rindex].addr) {
- printf
- ("INTERNAL ERROR: addresses %u and %u use same record slot %d\n",
+ log_error
+ (VLDB_CHECK_ERROR,"INTERNAL VLDB_CHECK_ERROR: addresses %ld and %u use same record slot %d\n",
record[rindex].addr, addr, rindex);
}
if (record[rindex].type & NH) {
- printf
- ("Name Hash %d: Bad entry '%s': Already in the name hash\n",
+ log_error
+ (VLDB_CHECK_ERROR,"Name Hash %d: Bad entry '%s': Already in the name hash\n",
i, vlentry.name);
+ record[rindex].type |= MULTN;
break;
}
- record[rindex].type |= NH;
+ if (!validVolumeAddr(vlentry.nextNameHash)) {
+ log_error(VLDB_CHECK_ERROR,"Name Hash forward link of '%s' is out of range\n",
+ vlentry.name);
+ record[rindex].type |= MULTN;
+ break;
+ }
+
+ record[rindex].type |= NH;
record[rindex].type |= REFN;
chainlength++;
/* Hash the name and check if in correct hash table */
if (NameHash(vlentry.name) != i) {
- printf
- ("Name Hash %d: Bad entry '%s': Incorrect name hash chain (should be in %d)\n",
+ log_error
+ (VLDB_CHECK_ERROR,"Name Hash %d: Bad entry '%s': Incorrect name hash chain (should be in %d)\n",
i, vlentry.name, NameHash(vlentry.name));
+ record[rindex].type |= MULTN;
}
}
if (chainlength > longest)
shortest = chainlength;
}
if (verbose) {
- printf
+ quiet_println
("%d entries in name hash, longest is %d, shortest is %d, average length is %f\n",
count, longest, shortest, ((float)count / (float)HASHSIZE));
}
+ return;
}
/*
int count = 0, longest = 0, shortest = -1, chainlength;
struct nvlentry vlentry;
afs_uint32 addr;
- afs_int32 i, j, hash, type, rindex, ref;
+ afs_int32 i, j, hash, type, rindex, ref, badref, badhash;
/* Now follow the RW, RO, and BK Hash Tables */
- if (verbose)
- printf("Check RW, RO, and BK id Hashes\n");
+ if (verbose) quiet_println("Check RW, RO, and BK id Hashes\n");
for (i = 0; i < MAXTYPES; i++) {
hash = ((i == 0) ? RWH : ((i == 1) ? ROH : BKH));
ref = ((i == 0) ? REFRW : ((i == 1) ? REFRO : REFBK));
+ badref = ((i == 0) ? MULTRW : ((i == 1) ? MULTRO : MULTBK));
+ badhash = ((i == 0) ? MULTRW : ((i == 1) ? MULTRO : MULTBK));
count = longest = 0;
shortest = -1;
for (j = 0; j < HASHSIZE; j++) {
chainlength = 0;
+ if (!validVolumeAddr(header->VolidHash[i][j])) {
+ log_error(VLDB_CHECK_ERROR,"%s Hash %d: Bad entry %u is out of range\n",
+ vtype(i), j, header->VolidHash[i][j]);
+ continue;
+ }
+
for (addr = header->VolidHash[i][j]; addr;
addr = vlentry.nextIdHash[i]) {
readentry(addr, &vlentry, &type);
if (type != VL) {
- printf
- ("%s Id Hash %d: Bad entry at %u: Not a valid vlentry\n",
+ log_error
+ (VLDB_CHECK_ERROR,"%s Id Hash %d: Bad entry at %u: Not a valid vlentry\n",
vtype(i), j, addr);
continue;
}
- rindex = addr / sizeof(vlentry);
+ rindex = ADDR(addr);
if (record[rindex].addr != addr && record[rindex].addr) {
- printf
- ("INTERNAL ERROR: addresses %u and %u use same record slot %d\n",
+ log_error
+ (VLDB_CHECK_ERROR,"INTERNAL VLDB_CHECK_ERROR: addresses %ld and %u use same record slot %d\n",
record[rindex].addr, addr, rindex);
}
if (record[rindex].type & hash) {
- printf
- ("%s Id Hash %d: Bad entry '%s': Already in the the hash table\n",
+ log_error
+ (VLDB_CHECK_ERROR,"%s Id Hash %d: Bad entry '%s': Already in the hash table\n",
vtype(i), j, vlentry.name);
+ record[rindex].type |= badref;
+ break;
+ }
+
+ if (!validVolumeAddr(vlentry.nextIdHash[i])) {
+ log_error(VLDB_CHECK_ERROR,"%s Id Hash forward link of '%s' is out of range\n",
+ vtype(i), vlentry.name);
+ record[rindex].type |= badref;
break;
}
+
record[rindex].type |= hash;
record[rindex].type |= ref;
/* Hash the id and check if in correct hash table */
if (IdHash(vlentry.volumeId[i]) != j) {
- printf
- ("%s Id Hash %d: Bad entry '%s': Incorrect Id hash chain (should be in %d)\n",
+ log_error
+ (VLDB_CHECK_ERROR,"%s Id Hash %d: Bad entry '%s': Incorrect Id hash chain (should be in %d)\n",
vtype(i), j, vlentry.name,
IdHash(vlentry.volumeId[i]));
+ record[rindex].type |= badhash;
}
}
shortest = chainlength;
}
if (verbose) {
- printf
+ quiet_println
("%d entries in %s hash, longest is %d, shortest is %d, average length is %f\n",
- count, vtype(i), longest, shortest,
- ((float)count / (float)HASHSIZE));
+ count, vtype(i), longest, shortest,((float)count / (float)HASHSIZE));
}
}
+ return;
}
/*
afs_int32 type, rindex;
/* Now follow the Free Chain */
- if (verbose)
- printf("Check Volume Free Chain\n");
+ if (verbose) quiet_println("Check Volume Free Chain\n");
for (addr = header->vital_header.freePtr; addr;
addr = vlentry.nextIdHash[0]) {
readentry(addr, &vlentry, &type);
if (type != FR) {
- printf
- ("Free Chain %d: Bad entry at %u: Not a valid free vlentry (0x%x)\n",
+ log_error
+ (VLDB_CHECK_ERROR,"Free Chain %d: Bad entry at %u: Not a valid free vlentry (0x%x)\n",
count, addr, type);
continue;
}
rindex = addr / sizeof(vlentry);
if (record[rindex].addr != addr && record[rindex].addr) {
- printf
- ("INTERNAL ERROR: addresses %u and %u use same record slot %d\n",
+ log_error
+ (VLDB_CHECK_ERROR,"INTERNAL VLDB_CHECK_ERROR: addresses %u and %ld use same record slot %d\n",
record[rindex].addr, addr, rindex);
}
if (record[rindex].type & FRC) {
- printf("Free Chain: Bad entry at %u: Already in the free chain\n",
+ log_error(VLDB_CHECK_ERROR,"Free Chain: Bad entry at %u: Already in the free chain\n",
addr);
break;
}
count++;
}
if (verbose)
- printf("%d entries on free chain\n", count);
+ quiet_println("%d entries on free chain\n", count);
+ return;
}
/*
* Read each multihomed block and mark it as found in the record.
* Read each entry in each multihomed block and mark the serveraddrs
* array with the number of ip addresses found for this entry.
- *
+ *
* Then read the IpMappedAddr array in the header.
* Verify that multihomed entries base and index are valid and points to
* a good multhomed entry.
* Mark the serveraddrs array with 1 ip address for regular entries.
- *
- * By the end, the severaddrs array will have a 0 if the entry has no
+ *
+ * By the end, the severaddrs array will have a 0 if the entry has no
* IP addresses in it or the count of the number of IP addresses.
*
- * The code does not verify if there are duplicate IP addresses in the
+ * The code does not verify if there are duplicate IP addresses in the
* list. The vlserver does this when a fileserver registeres itself.
*/
void
int mhblocks = 0;
afs_int32 i, j, m, rindex;
afs_int32 mhentries, regentries;
- afs_int32 caddrs[VL_MAX_ADDREXTBLKS];
+ afs_uint32 caddrs[VL_MAX_ADDREXTBLKS];
char mhblock[VL_ADDREXTBLK_SIZE];
struct extentaddr *MHblock = (struct extentaddr *)mhblock;
struct extentaddr *e;
memset(&nulluuid, 0, sizeof(nulluuid));
if (verbose)
- printf("Check Multihomed blocks\n");
+ quiet_println("Check Multihomed blocks\n");
if (header->SIT) {
- /* Read the first MH block and from it, gather the
+ /* Read the first MH block and from it, gather the
* addresses of all the mh blocks.
*/
readMH(header->SIT, MHblock);
if (MHblock->ex_flags != VLCONTBLOCK) {
- printf
- ("Multihomed Block 0: Bad entry at %u: Not a valid multihomed block\n",
+ log_error
+ (VLDB_CHECK_ERROR,"Multihomed Block 0: Bad entry at %u: Not a valid multihomed block\n",
header->SIT);
}
}
if (header->SIT != caddrs[0]) {
- printf
- ("MH block does not point to self %u in header, %u in block\n",
+ log_error
+ (VLDB_CHECK_ERROR,"MH block does not point to self %u in header, %u in block\n",
header->SIT, caddrs[0]);
}
readMH(caddrs[i], MHblock);
if (MHblock->ex_flags != VLCONTBLOCK) {
- printf
- ("Multihomed Block 0: Bad entry at %u: Not a valid multihomed block\n",
+ log_error
+ (VLDB_CHECK_ERROR,"Multihomed Block 0: Bad entry at %u: Not a valid multihomed block\n",
header->SIT);
}
rindex = caddrs[i] / sizeof(vlentry);
if (record[rindex].addr != caddrs[i] && record[rindex].addr) {
- printf
- ("INTERNAL ERROR: addresses %u and %u use same record slot %d\n",
+ log_error
+ (VLDB_CHECK_ERROR,"INTERNAL VLDB_CHECK_ERROR: addresses %u and %u use same record slot %d\n",
record[rindex].addr, caddrs[i], rindex);
}
if (record[rindex].type & FRC) {
- printf
- ("MH Blocks Chain %d: Bad entry at %u: Already a MH block\n",
+ log_error
+ (VLDB_CHECK_ERROR,"MH Blocks Chain %d: Bad entry at %ld: Already a MH block\n",
i, record[rindex].addr);
break;
}
mhblocks++;
- /* Read each entry in a multihomed block.
+ /* Read each entry in a multihomed block.
* Find the pointer to the entry in the IpMappedAddr array and
* verify that the entry is good (has IP addresses in it).
*/
if (memcmp(&e->ex_hostuuid, &nulluuid, sizeof(afsUUID)) == 0) {
if (ipindex != -1) {
- printf
- ("Server Addrs index %d references null MH block %d, index %d\n",
+ log_error
+ (VLDB_CHECK_ERROR,"Server Addrs index %d references null MH block %d, index %d\n",
ipindex, i, j);
serveraddrs[ipindex] = 0; /* avoids printing 2nd error below */
}
if (ipaddrs) {
mhentries++;
if (ipindex == -1) {
- printf
- ("MH block %d, index %d: Not referenced by server addrs\n",
+ log_error
+ (VLDB_CHECK_ERROR,"MH block %d, index %d: Not referenced by server addrs\n",
i, j);
} else {
serveraddrs[ipindex] = ipaddrs; /* It is good */
}
if (listservers && ipaddrs) {
- printf("MH block %d, index %d:", i, j);
+ quiet_println("MH block %d, index %d:", i, j);
for (m = 0; m < VL_MAXIPADDRS_PERMH; m++) {
if (!e->ex_addrs[m])
continue;
- printf(" %d.%d.%d.%d",
+ quiet_println(" %d.%d.%d.%d",
(e->ex_addrs[m] & 0xff000000) >> 24,
(e->ex_addrs[m] & 0x00ff0000) >> 16,
(e->ex_addrs[m] & 0x0000ff00) >> 8,
(e->ex_addrs[m] & 0x000000ff));
}
- printf("\n");
+ quiet_println("\n");
}
}
/*
* if (mhentries != MHblock->ex_count) {
- * printf("MH blocks says it has %d entries (found %d)\n",
+ * quiet_println("MH blocks says it has %d entries (found %d)\n",
* MHblock->ex_count, mhentries);
* }
*/
}
}
if (verbose)
- printf("%d multihomed blocks\n", mhblocks);
+ quiet_println("%d multihomed blocks\n", mhblocks);
/* Check the server addresses */
if (verbose)
- printf("Check server addresses\n");
+ quiet_println("Check server addresses\n");
mhentries = regentries = 0;
for (i = 0; i <= MAXSERVERID; i++) {
if (header->IpMappedAddr[i]) {
mhentries++;
if (((header->IpMappedAddr[i] & 0x00ff0000) >> 16) >
VL_MAX_ADDREXTBLKS)
- printf
- ("IP Addr for entry %d: Multihome block is bad (%d)\n",
+ log_error
+ (VLDB_CHECK_ERROR,"IP Addr for entry %d: Multihome block is bad (%d)\n",
i, ((header->IpMappedAddr[i] & 0x00ff0000) >> 16));
if (((header->IpMappedAddr[i] & 0x0000ffff) > VL_MHSRV_PERBLK)
|| ((header->IpMappedAddr[i] & 0x0000ffff) < 1))
- printf
- ("IP Addr for entry %d: Multihome index is bad (%d)\n",
+ log_error
+ (VLDB_CHECK_ERROR,"IP Addr for entry %d: Multihome index is bad (%d)\n",
i, (header->IpMappedAddr[i] & 0x0000ffff));
if (serveraddrs[i] == -1) {
- printf
- ("warning: IP Addr for entry %d: Multihome entry has no ip addresses\n",
+ log_error
+ (VLDB_CHECK_WARNING,"warning: IP Addr for entry %d: Multihome entry has no ip addresses\n",
i);
serveraddrs[i] = 0;
}
if (listservers) {
- printf(" Server ip addr %d = MH block %d, index %d\n",
+ quiet_println(" Server ip addr %d = MH block %d, index %d\n",
i, (header->IpMappedAddr[i] & 0x00ff0000) >> 16,
(header->IpMappedAddr[i] & 0x0000ffff));
}
regentries++;
serveraddrs[i] = 1; /* It is good */
if (listservers) {
- printf(" Server ip addr %d = %d.%d.%d.%d\n", i,
+ quiet_println(" Server ip addr %d = %d.%d.%d.%d\n", i,
(header->IpMappedAddr[i] & 0xff000000) >> 24,
(header->IpMappedAddr[i] & 0x00ff0000) >> 16,
(header->IpMappedAddr[i] & 0x0000ff00) >> 8,
}
}
if (verbose) {
- printf("%d simple entries, %d multihomed entries, Total = %d\n",
+ quiet_println("%d simple entries, %d multihomed entries, Total = %d\n",
regentries, mhentries, mhentries + regentries);
}
+ return;
+}
+char *
+nameForAddr(afs_uint32 addr, int hashtype, afs_uint32 *hash, char *buffer)
+{
+ /*
+ * We need to simplify the reporting, while retaining
+ * legible messages. This is a helper function. The return address
+ * is either a fixed char or the provided buffer - so don't use the
+ * name after the valid lifetime of the buffer.
+ */
+ afs_int32 type;
+ struct nvlentry entry;
+ if (!addr) {
+ /* Distinguished, invalid, hash */
+ *hash = 0xFFFFFFFF;
+ return "empty";
+ } else if (!validVolumeAddr(addr)) {
+ /* Different, invalid, hash */
+ *hash = 0XFFFFFFFE;
+ return "invalid";
+ }
+ readentry(addr, &entry, &type);
+ if (VL != type) {
+ *hash = 0XFFFFFFFE;
+ return "invalid";
+ }
+ if (hashtype >= MAXTYPES) {
+ *hash = NameHash(entry.name);
+ } else {
+ *hash = IdHash(entry.volumeId[hashtype]);
+ }
+ sprintf(buffer, "for '%s'", entry.name);
+ return buffer;
}
-void
-FixBad(afs_uint32 idx, afs_uint32 addr, afs_uint32 type, afs_uint32 tmp,
- struct nvlentry *vlentry) {
- SetHashEnd(addr, type, tmp);
- printf("linked unlinked chain %u (index %d) to end of chain\n",
- tmp, ADDR(tmp));
+void
+reportHashChanges(struct vlheader *header, afs_uint32 oldnamehash[HASHSIZE], afs_uint32 oldidhash[MAXTYPES][HASHSIZE])
+{
+ int i, j;
+ afs_uint32 oldhash, newhash;
+ char oldNameBuffer[10 + VL_MAXNAMELEN];
+ char newNameBuffer[10 + VL_MAXNAMELEN];
+ char *oldname, *newname;
+ /*
+ * report hash changes
+ */
+
+ for (i = 0; i < HASHSIZE; i++) {
+ if (oldnamehash[i] != header->VolnameHash[i]) {
+
+ oldname = nameForAddr(oldnamehash[i], MAXTYPES, &oldhash, oldNameBuffer);
+ newname = nameForAddr(header->VolnameHash[i], MAXTYPES, &newhash, newNameBuffer);
+ if (verbose || (oldhash != newhash)) {
+ quiet_println("FIX: Name hash header at %d was %s, is now %s\n", i, oldname, newname);
+ }
+ }
+ for (j = 0; j < MAXTYPES; j++) {
+ if (oldidhash[j][i] != header->VolidHash[j][i]) {
+
+ oldname = nameForAddr(oldidhash[j][i], j, &oldhash, oldNameBuffer);
+ newname = nameForAddr(header->VolidHash[j][i], j, &newhash, newNameBuffer);
+ if (verbose || (oldhash != newhash)) {
+ quiet_println("FIX: %s hash header at %d was %s, is now %s\n", vtype(j), i, oldname, newname);
+ }
+ }
+ }
+ }
}
int
WorkerBee(struct cmd_syndesc *as, void *arock)
{
char *dbfile;
- afs_int32 maxentries, type, tmp;
+ afs_int32 type;
struct vlheader header;
- struct nvlentry vlentry;
- int i, j, help = 0;
+ struct nvlentry vlentry, vlentry2;
+ int i, j;
+ afs_uint32 oldnamehash[HASHSIZE];
+ afs_uint32 oldidhash[MAXTYPES][HASHSIZE];
+ error_level = 0; /* start clean with no error status */
dbfile = as->parms[0].items->data; /* -database */
listuheader = (as->parms[1].items ? 1 : 0); /* -uheader */
listheader = (as->parms[2].items ? 1 : 0); /* -vheader */
listservers = (as->parms[3].items ? 1 : 0); /* -servers */
listentries = (as->parms[4].items ? 1 : 0); /* -entries */
verbose = (as->parms[5].items ? 1 : 0); /* -verbose */
- fix = (as->parms[6].items ? 1 : 0); /* -fix */
+ quiet = (as->parms[6].items ? 1 : 0); /* -quiet */
+ fix = (as->parms[7].items ? 1 : 0); /* -fix */
+
+ /* sanity check */
+ if (quiet && (verbose || listuheader || listheader ||listservers \
+ || listentries)) {
+ log_error(VLDB_CHECK_FATAL," -quiet cannot be used other display flags\n");
+ return VLDB_CHECK_FATAL;
+ }
+
/* open the vldb database file */
fd = open(dbfile, (fix > 0)?O_RDWR:O_RDONLY, 0);
if (fd < 0) {
- printf("can't open file '%s'. error = %d\n", dbfile, errno);
+ log_error(VLDB_CHECK_FATAL,"can't open file '%s'. error = %d\n", dbfile, errno);
return 0;
}
readUbikHeader();
readheader(&header);
if (header.vital_header.vldbversion < 3) {
- printf("does not support vldb with version less than 3\n");
- return 0;
+ log_error(VLDB_CHECK_FATAL,"does not support vldb with version less than 3\n");
+ return VLDB_CHECK_FATAL;
}
maxentries = (header.vital_header.eofPtr / sizeof(vlentry)) + 1;
record = (struct er *)malloc(maxentries * sizeof(struct er));
- memset((char *)record, 0, (maxentries * sizeof(struct er)));
- memset((char *)serveraddrs, 0, sizeof(serveraddrs));
+ memset(record, 0, (maxentries * sizeof(struct er)));
+ memset(serveraddrs, 0, sizeof(serveraddrs));
/* Will fill in the record array of entries it found */
ReadAllEntries(&header);
/* Follow the chain of free entries */
FollowFreeChain(&header);
- /* Now check the record we have been keeping for inconsistancies
- * For valid vlentries, also check that the server we point to is
+ /* Now check the record we have been keeping for inconsistencies
+ * For valid vlentries, also check that the server we point to is
* valid (the serveraddrs array).
*/
if (verbose)
- printf("Verify each volume entry\n");
+ quiet_println("Verify each volume entry\n");
for (i = 0; i < maxentries; i++) {
- int nextp;
- int reft;
- int hash;
- int *nextpp;
- char *which;
+ int hash = 0;
+ int nexthash = 0;
+ char *which = NULL;
if (record[i].type == 0)
continue;
*/
if (record[i].type & VL) {
int foundbad = 0;
+ int foundbroken = 0;
char volidbuf[256];
readentry(record[i].addr, &vlentry, &type);
if (InvalidVolname(vlentry.name))
- printf("Volume '%s' at addr %u has an invalid name\n",
+ log_error(VLDB_CHECK_ERROR,"Volume '%s' at addr %ld has an invalid name\n",
vlentry.name, record[i].addr);
if (!(record[i].type & NH)) {
- nextp = ADDR(vlentry.nextNameHash);
- reft = REFN;
hash = NameHash(vlentry.name);
- nextpp = &vlentry.nextNameHash;
which = "name";
- sprintf(volidbuf, "");
+ volidbuf[0]='\0';
foundbad = 1;
}
if (vlentry.volumeId[0] && !(record[i].type & RWH)) {
- nextp = ADDR(vlentry.nextIdHash[0]);
- reft = REFRW;
hash = IdHash(vlentry.volumeId[0]);
- nextpp = &(vlentry.nextIdHash[0]);
which = "RW";
sprintf(volidbuf, "id %u ", vlentry.volumeId[0]);
foundbad = 1;
}
if (vlentry.volumeId[1] && !(record[i].type & ROH)) {
- nextp = ADDR(vlentry.nextIdHash[1]);
- reft = REFRO;
hash = IdHash(vlentry.volumeId[1]);
- nextpp = &(vlentry.nextIdHash[1]);
which = "RO";
sprintf(volidbuf, "id %u ", vlentry.volumeId[1]);
foundbad = 1;
}
if (vlentry.volumeId[2] && !(record[i].type & BKH)) {
- nextp = ADDR(vlentry.nextIdHash[2]);
- reft = REFBK;
hash = IdHash(vlentry.volumeId[2]);
- nextpp = &(vlentry.nextIdHash[2]);
which = "BK";
sprintf(volidbuf, "id %u ", vlentry.volumeId[2]);
foundbad = 1;
}
- if (foundbad) {
- printf("%d: Volume '%s' %snot found in %s hash %d", i,
- vlentry.name, volidbuf, which, hash);
- if (nextp) {
- printf(" (next %d", nextp);
- if (!(record[nextp].type & reft)) {
- printf(" not in chain ");
- record[nextp].type |= reft;
- } else if (nextp != 0) {
- printf(" next in chain");
- if (fix) {
- printf(", unchaining");
- *nextpp = 0;
- writeentry(record[i].addr, &vlentry);
- }
- }
- printf(")");
+ if (!validVolumeAddr(vlentry.nextNameHash) ||
+ record[ADDR(vlentry.nextNameHash)].type & MULTN) {
+ hash = NameHash(vlentry.name);
+ which = "name";
+ volidbuf[0]='\0';
+ if (validVolumeAddr(vlentry.nextNameHash)) {
+ readentry(vlentry.nextNameHash, &vlentry2, &type);
+ nexthash = NameHash(vlentry2.name);
+ } else {
+ nexthash = 0xFFFFFFFF;
+ }
+ if (hash != nexthash)
+ foundbroken = 1;
+ }
+
+ if (!validVolumeAddr(vlentry.nextIdHash[0]) ||
+ record[ADDR(vlentry.nextIdHash[0])].type & MULTRW) {
+ hash = IdHash(vlentry.volumeId[0]);
+ which = "RW";
+ sprintf(volidbuf, "id %u ", vlentry.volumeId[0]);
+ if (validVolumeAddr(vlentry.nextIdHash[0])) {
+ readentry(vlentry.nextIdHash[0], &vlentry2, &type);
+ nexthash = IdHash(vlentry2.volumeId[0]);
+ } else {
+ nexthash = 0xFFFFFFFF;
+ }
+ if (hash != nexthash)
+ foundbroken = 1;
+ }
+
+ if (!validVolumeAddr(vlentry.nextIdHash[1]) ||
+ record[ADDR(vlentry.nextIdHash[1])].type & MULTRO) {
+ hash = IdHash(vlentry.volumeId[1]);
+ which = "RO";
+ sprintf(volidbuf, "id %u ", vlentry.volumeId[1]);
+ if (validVolumeAddr(vlentry.nextIdHash[1])) {
+ readentry(vlentry.nextIdHash[1], &vlentry2, &type);
+ nexthash = IdHash(vlentry2.volumeId[1]);
+ } else {
+ nexthash = 0xFFFFFFFF;
}
- printf("\n");
+ if (hash != nexthash)
+ foundbroken = 1;
}
-
+
+ if (!validVolumeAddr(vlentry.nextIdHash[2]) ||
+ record[ADDR(vlentry.nextIdHash[2])].type & MULTBK) {
+ hash = IdHash(vlentry.volumeId[2]);
+ which = "BK";
+ sprintf(volidbuf, "id %u ", vlentry.volumeId[2]);
+ if (validVolumeAddr(vlentry.nextIdHash[2])) {
+ readentry(vlentry.nextIdHash[2], &vlentry2, &type);
+ nexthash = IdHash(vlentry2.volumeId[2]);
+ } else {
+ nexthash = 0xFFFFFFFF;
+ }
+ if (hash != nexthash)
+ foundbroken = 1;
+ }
+
+ if (foundbroken) {
+ log_error(VLDB_CHECK_ERROR, "%d: Volume '%s' %s forward link in %s hash chain is broken (hash %d != %d)\n", i,
+ vlentry.name, volidbuf, which, hash, nexthash);
+ } else if (foundbad) {
+ log_error(VLDB_CHECK_ERROR, "%d: Volume '%s' %snot found in %s hash %d\n", i,
+ vlentry.name, volidbuf, which, hash);
+ }
+
for (j = 0; j < NMAXNSERVERS; j++) {
if ((vlentry.serverNumber[j] != 255)
&& (serveraddrs[vlentry.serverNumber[j]] == 0)) {
- printf
- ("Volume '%s', index %d points to empty server entry %d\n",
+ log_error
+ (VLDB_CHECK_ERROR,"Volume '%s', index %d points to empty server entry %d\n",
vlentry.name, j, vlentry.serverNumber[j]);
}
}
-
+
if (record[i].type & 0xffff0f00)
- printf
- ("Volume '%s' id %u also found on other chains (0x%x)\n",
+ log_error
+ (VLDB_CHECK_ERROR,"Volume '%s' id %u also found on other chains (0x%x)\n",
vlentry.name, vlentry.volumeId[0], record[i].type);
-
+
/* A free entry */
} else if (record[i].type & FR) {
if (!(record[i].type & FRC))
- printf("Free vlentry at %u not on free chain\n",
+ log_error(VLDB_CHECK_ERROR,"Free vlentry at %ld not on free chain\n",
record[i].addr);
-
+
if (record[i].type & 0xfffffdf0)
- printf
- ("Free vlentry at %u also found on other chains (0x%x)\n",
+ log_error
+ (VLDB_CHECK_ERROR,"Free vlentry at %ld also found on other chains (0x%x)\n",
record[i].addr, record[i].type);
-
+
/* A multihomed entry */
} else if (record[i].type & MH) {
if (!(record[i].type & MHC))
- printf("Multihomed block at %u is orphaned\n",
+ log_error(VLDB_CHECK_ERROR,"Multihomed block at %ld is orphaned\n",
record[i].addr);
-
+
if (record[i].type & 0xfffffef0)
- printf
- ("Multihomed block at %u also found on other chains (0x%x)\n",
+ log_error
+ (VLDB_CHECK_ERROR,"Multihomed block at %ld also found on other chains (0x%x)\n",
record[i].addr, record[i].type);
-
+
} else {
- printf("Unknown entry type at %u (0x%x)\n", record[i].addr,
+ log_error(VLDB_CHECK_ERROR,"Unknown entry type at %u (0x%x)\n", record[i].addr,
record[i].type);
}
}
- /* By the time we get here, unchained entries are really unchained */
- printf("Scanning %u entries for possible repairs\n", maxentries);
+ if (fix) {
+ /*
+ * If we are fixing we will rebuild all the hash lists from the ground up
+ */
+ memcpy(oldnamehash, header.VolnameHash, sizeof(oldnamehash));
+ memset(header.VolnameHash, 0, sizeof(header.VolnameHash));
+
+ memcpy(oldidhash, header.VolidHash, sizeof(oldidhash));
+ memset(header.VolidHash, 0, sizeof(header.VolidHash));
+ quiet_println("Rebuilding %u entries\n", maxentries);
+ } else {
+ quiet_println("Scanning %u entries for possible repairs\n", maxentries);
+ }
for (i = 0; i < maxentries; i++) {
+ afs_uint32 hash;
if (record[i].type & VL) {
readentry(record[i].addr, &vlentry, &type);
- if (!(record[i].type & REFN) && (strlen(vlentry.name)>0)) {
- printf("%d: Record %u (type 0x%x) not in a name chain\n", i,
+ if (!(record[i].type & REFN)) {
+ log_error(VLDB_CHECK_ERROR,"%d: Record %ld (type 0x%x) not in a name chain\n", i,
record[i].addr, record[i].type);
- if (fix) {
- if (header.VolnameHash[NameHash(vlentry.name)] == 0)
- header.VolnameHash[NameHash(vlentry.name)] = record[i].addr;
- else
- FixBad(i, header.VolnameHash[NameHash(vlentry.name)], NH, record[i].addr, &vlentry);
- }
}
if (vlentry.volumeId[0] && !(record[i].type & REFRW)) {
- printf("%d: Record %u (type 0x%x) not in a RW chain\n", i,
+ log_error(VLDB_CHECK_ERROR,"%d: Record %ld (type 0x%x) not in a RW chain\n", i,
record[i].addr, record[i].type);
- if (fix) {
- if (header.VolidHash[0][IdHash(vlentry.volumeId[0])] == 0)
- header.VolidHash[0][IdHash(vlentry.volumeId[0])] = record[i].addr;
- else
- FixBad(i, header.VolidHash[0][IdHash(vlentry.volumeId[0])], RWH, record[i].addr, &vlentry);
- }
}
if (vlentry.volumeId[1] && !(record[i].type & REFRO)) {
- printf("%d: Record %u (type 0x%x) not in a RO chain\n", i,
+ log_error(VLDB_CHECK_ERROR,"%d: Record %ld (type 0x%x) not in a RO chain\n", i,
record[i].addr, record[i].type);
- if (fix) {
- if (header.VolidHash[1][IdHash(vlentry.volumeId[1])] == 0)
- header.VolidHash[1][IdHash(vlentry.volumeId[1])] = record[i].addr;
- else
- FixBad(i, header.VolidHash[1][IdHash(vlentry.volumeId[1])], ROH, record[i].addr, &vlentry);
- }
}
if (vlentry.volumeId[2] && !(record[i].type & REFBK)) {
- printf("%d: Record %u (type 0x%x) not in a BK chain\n", i,
+ log_error(VLDB_CHECK_ERROR,"%d: Record %ld (type 0x%x) not in a BK chain\n", i,
record[i].addr, record[i].type);
- if (fix) {
- if (header.VolidHash[2][IdHash(vlentry.volumeId[2])] == 0)
- header.VolidHash[2][IdHash(vlentry.volumeId[2])] = record[i].addr;
- else
- FixBad(i, header.VolidHash[2][IdHash(vlentry.volumeId[2])], BKH, record[i].addr, &vlentry);
+ }
+ if (fix) {
+ afs_uint32 oldhash, newhash;
+ char oldNameBuffer[10 + VL_MAXNAMELEN];
+ char newNameBuffer[10 + VL_MAXNAMELEN];
+ char *oldname, *newname;
+
+ /*
+ * Put the current hash table contexts into our 'next'
+ * and our address into the hash table.
+ */
+ hash = NameHash(vlentry.name);
+
+ if (vlentry.nextNameHash != header.VolnameHash[hash]) {
+ oldname = nameForAddr(vlentry.nextNameHash, MAXTYPES, &oldhash, oldNameBuffer);
+ newname = nameForAddr(header.VolnameHash[hash], MAXTYPES, &newhash, newNameBuffer);
+ if (verbose || ((oldhash != newhash) &&
+ (0 != vlentry.nextNameHash) &&
+ (0 != header.VolnameHash[hash]))) {
+ /*
+ * That is, only report if we are verbose
+ * or the hash is changing (and one side wasn't NULL
+ */
+ quiet_println("FIX: Name hash link for '%s' was %s, is now %s\n",
+ vlentry.name, oldname, newname);
+ }
}
+ vlentry.nextNameHash = header.VolnameHash[hash];
+ header.VolnameHash[hash] = record[i].addr;
+
+ for (j = 0; j < MAXTYPES; j++) {
+
+ if (0 == vlentry.volumeId[j]) {
+ /*
+ * No volume of that type. Continue
+ */
+ continue;
+ }
+ hash = IdHash(vlentry.volumeId[j]);
+
+ if (vlentry.nextIdHash[j] != header.VolidHash[j][hash]) {
+ oldname = nameForAddr(vlentry.nextIdHash[j], j, &oldhash, oldNameBuffer);
+ newname = nameForAddr(header.VolidHash[j][hash], j, &newhash, newNameBuffer);
+ if (verbose || ((oldhash != newhash) &&
+ (0 != vlentry.nextIdHash[j]) &&
+ (0 != header.VolidHash[j][hash]))) {
+ quiet_println("FIX: %s hash link for '%s' was %s, is now %s\n",
+ vtype(j), vlentry.name, oldname, newname);
+ }
+ }
+
+ vlentry.nextIdHash[j] = header.VolidHash[j][hash];
+ header.VolidHash[j][hash] = record[i].addr;
+ }
+ writeentry(record[i].addr, &vlentry);
}
}
}
- if (fix)
+ if (fix) {
+ reportHashChanges(&header, oldnamehash, oldidhash);
writeheader(&header);
+ }
+
+ close(fd);
- return 0;
+ return error_level;
}
int
"Display server list");
cmd_AddParm(ts, "-entries", CMD_FLAG, CMD_OPTIONAL, "Display entries");
cmd_AddParm(ts, "-verbose", CMD_FLAG, CMD_OPTIONAL, "verbose");
+ cmd_AddParm(ts, "-quiet", CMD_FLAG, CMD_OPTIONAL, "quiet");
cmd_AddParm(ts, "-fix", CMD_FLAG, CMD_OPTIONAL, "attempt to patch the database (potentially dangerous)");
return cmd_Dispatch(argc, argv);
git://git.openafs.org / openafs.git / blobdiff